Commit Graph

19452 Commits

Author SHA1 Message Date
Vinit Nayak a1d0d8269c Remove split instructions view on split launch success
* We weren't removing the instance of the view
that is created when split initiated from workspace
* Fewer bugs like this once RecentsView + workspace
instructions view are consolidated

Bug: 292590703
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Swiping to home after split apps launch
hides the view

Change-Id: I6b5037c024e6e0c456b687bc802076f691a955b2
2023-07-27 14:11:27 -07:00
Treehugger Robot 42b5cf6ee6 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-07-27 19:23:44 +00:00
Luca Zuccarini e2d31192a4 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-qpr-dev am: cf5703f614 am: 79fff57106
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24209925

Change-Id: I32abafb8a87a7f9e4cb56f7f6240a5bcf472f9c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-27 11:42:19 +00:00
Luca Zuccarini 79fff57106 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-qpr-dev am: cf5703f614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24209925

Change-Id: If01e1bae7860e2bc8764a95a77add08f349a5831
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-27 11:01:43 +00:00
Luca Zuccarini cf5703f614 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-qpr-dev 2023-07-27 09:58:26 +00:00
Andy Wickham be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Bill Yi ca00f219c2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I129f717c91f3f0cce914a9e6c0a0315ef3720cac
2023-07-26 13:41:04 -07:00
Liran Binyamin f172c0b3b5 Set the stash handle bounds deterministically
The bounds of the bubble stash handle is calculated based on the bounds of
the bubble bar. The problem is that the bubble bar could be invisible, which
results in incorrect bounds set for the handle.

This change sets the bounds for the handle based on the width of the screen.

Fixes: 290992144
Test: Manual
        - Remove bubbles
        - Restart Launcher
        - Open the bubble test app and double tap on a chat
        - Observe that the handle animates in
Change-Id: Ida260014d59b88387de010891c18057f3b091e93
2023-07-26 15:38:58 -04:00
Liran Binyamin 95d84f5e06 Don't animate in the bubble bar unless there are bubbles
Fixes: 290608658
Test: Manual:
      - Remove all bubbles
      - Lock and unlock device
      - Observe that bubble bar is not displayed

      - Remove all bubbles
      - Restart launcher process
      - Observe that bubble bar is not displayed

Change-Id: I850d307394230968f86abc23ba0b4e94f55e10f0
2023-07-26 15:38:47 -04:00
Treehugger Robot 29809a1aaf Merge changes I45b6f858,I28120248 into udc-qpr-dev am: 17988825f2 am: eebc14aef1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24180083

Change-Id: Iaa092606e44cec2550c631408ace321793202ba5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 19:21:04 +00:00
Ats Jenk 8057383830 Merge "Use hasBeenResumed() for checking if launcher is resumed" into udc-qpr-dev am: 38a7faf04e am: acec8ea55e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24182810

Change-Id: Ifa5663b45a1c5a110b7be7b75af63ca7342343f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 19:20:40 +00:00
Treehugger Robot 9ba1be46b9 Merge "Add jank monitor for CUJ_QUICK_SWITCH from home screen" into udc-qpr-dev am: 46c1b631d6 am: d71d9ee41e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24168094

Change-Id: I282136acd9971971abe2681680e2a553e736d23d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 19:15:23 +00:00
Treehugger Robot eebc14aef1 Merge changes I45b6f858,I28120248 into udc-qpr-dev am: 17988825f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24180083

Change-Id: Ic5141bb6234ff00db7b0a03e5f824500de7d9598
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 18:44:33 +00:00
Treehugger Robot 17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Ats Jenk acec8ea55e Merge "Use hasBeenResumed() for checking if launcher is resumed" into udc-qpr-dev am: 38a7faf04e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24182810

Change-Id: I5fc014e3c14ae836c49f6b7555aa739dfe7fda68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 18:20:44 +00:00
Ats Jenk 38a7faf04e Merge "Use hasBeenResumed() for checking if launcher is resumed" into udc-qpr-dev 2023-07-26 18:18:11 +00:00
Treehugger Robot d71d9ee41e Merge "Add jank monitor for CUJ_QUICK_SWITCH from home screen" into udc-qpr-dev am: 46c1b631d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24168094

Change-Id: If633bd1c47467be91fcf9134cdc9c1cfed471d92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 18:12:50 +00:00
Treehugger Robot 46c1b631d6 Merge "Add jank monitor for CUJ_QUICK_SWITCH from home screen" into udc-qpr-dev 2023-07-26 16:16:47 +00:00
Luca Zuccarini 627d67549f Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
2023-07-26 15:37:44 +00:00
randypfohl c59599dc19 Removing obsolete call to start home activity with shell transitions
- The second start activity was causing issues with 3p launchers which
  may not expect another new intent (ie. if it handles gestures at
  the bottom of the screen).  We can't completely remove this logic
  because for button navigation we don't want to fall through to the
  launch-next-task animation below, but we can can continue to
  finish the recents animation immediately.
- With shell transitions, leashes for opening apps are always hidden
  by default so when transitioning to a 3p launcher from
  RecentsActivity we also need to show the surface if we want to
  animate it in

Bug: 289609734
Test: Set 3p Launcher as default, in both gesture & button navigation
      - Go from 3p home -> overview, then overview -> 3p home
      - Go from app -> 3p home
      - Go from app -> overview, then overview -> 3p home
      - Quickswitch from app

Signed-off-by: Winson Chung <winsonc@google.com>
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2b3dc6f73007f8b7d97ae2972e37c5d055659c8b)
Merged-In: I6875083931de63a8097d23d180553885ed7cfb01
Change-Id: I6875083931de63a8097d23d180553885ed7cfb01
2023-07-26 00:57:07 +00:00
Tracy Zhou 2d74c470d1 Merge "Add quick switch to trackpad gesture tests" into udc-qpr-dev am: 2a8a40c4a8 am: f20eff274c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24034416

Change-Id: I67a093384a8f1ec28e2342e9ac8272358cf6680f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 21:54:24 +00:00
Ats Jenk cf25610a28 Flag stashing desktop when going home
Put logic to stash desktop apps behind a flag. Turn it off by default.

Bug: 292109910
Flag: persist.wm.debug.desktop_stashing
Test: turn off the flag, open an app on the desktop and go home
      observe that user is taken to home screen and subsequent launches
      are in full screen
      turn on the flag, open app on the desktop and go home
      observe that there is a toast shown for desktop and next app is
      launched to desktop
Change-Id: Ic6f9a3644bb09d4fb877f4694843a7c20969f925
2023-07-25 14:20:00 -07:00
Tracy Zhou f20eff274c Merge "Add quick switch to trackpad gesture tests" into udc-qpr-dev am: 2a8a40c4a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24034416

Change-Id: I07e7f841bbc2e2e7d5526ae9f88d217aa725ff0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 21:03:33 +00:00
randypfohl 100f56a01c Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: b947238a9e am: d2739609b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: I8be54057c53bff9f81de81d3f366ed28eac4781f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 21:00:10 +00:00
Tracy Zhou 2a8a40c4a8 Merge "Add quick switch to trackpad gesture tests" into udc-qpr-dev 2023-07-25 20:11:22 +00:00
randypfohl d1d18dcef1 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: 64d723f6a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: I6f1feee0483a73dca0f614c6b9a3a13e46e62252
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:05:39 +00:00
randypfohl d2739609b5 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: b947238a9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Iacb77a5aa57db4adeecbc96a477c441a9a88937a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:04:32 +00:00
Tony Wickham 2ea942b813 Add jank monitor for CUJ_QUICK_SWITCH from home screen
Flag: None
Test: adb logcat -b events | grep jank_cuj_events
  - Verified quick switch from home gets begin and end
  - Verified quick switch then swipe back or up to home
    gets begin and cancel
  - Verified quick switch then swipe up to overview
    gets begin and cancel
Fixes: 290323639
Change-Id: I4f1991251b111c0531b30c48ba610ce85dcafdd3
2023-07-25 19:18:20 +00:00
randypfohl 64d723f6a7 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: I4662a1133716fce5861e899859784848e5daec2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 19:12:09 +00:00
randypfohl b947238a9e Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Ife4db9cda8ecd85ee21e51575a7bc24c37882ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 19:07:48 +00:00
Schneider Victor-tulias 4fcc063c5d Merge "Fix broken gesture nav edu on tablets in portrait." into udc-qpr-dev am: d33fc05022 am: 7ab611e48b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24103298

Change-Id: I29c2c2383f7ff6cdd54c46490e04ed489a25cdb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:23:20 +00:00
Greg Kaiser 2a2e30ed88 Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev am: b095594afd am: d4ed91551d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24191951

Change-Id: Ie0d08c25f1c5db107df84204713ed390b7533d42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:23:06 +00:00
Ats Jenk f0be4fa573 Use hasBeenResumed() for checking if launcher is resumed
ag/23852178 introduced a clean up for launcher state when invoking
transient taskbar. It was checking launcher activity resumed state with
`isResumed()` method. This breaks transient taskbar for desktop mode as
we are marking the launcher activity to be paused using the launcher
flags. `hasBeenResumed()` method is the one we can used instead as it is
checking the launcher flags and not the resumed state of the activity
itself.

Bug: 292266259
Test: open transparent activity on top of launcher
      unstash taskbar
      go home
Test: move an app to desktop, unstash taskbar
Change-Id: I98d14dbfdde4b857f50e62206fc0f308e8f54231
2023-07-25 11:18:29 -07:00
Tracy Zhou bfef402e1e Add quick switch to trackpad gesture tests
Bug: 23895346
Test: presubmit
Change-Id: I85f3e010757595763f58ea81a13671fe49604b76
2023-07-25 10:55:40 -07:00
Schneider Victor-tulias 7ab611e48b Merge "Fix broken gesture nav edu on tablets in portrait." into udc-qpr-dev am: d33fc05022
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24103298

Change-Id: I2097c1f6e9ffef030be22505d6b242509d8adf63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 17:40:40 +00:00
Greg Kaiser d4ed91551d Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev am: b095594afd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24191951

Change-Id: I7deb680cbc3e6600e6cb3201628cfde98ede4f49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 17:40:23 +00:00
Schneider Victor-tulias d33fc05022 Merge "Fix broken gesture nav edu on tablets in portrait." into udc-qpr-dev 2023-07-25 17:01:37 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Jagrut Desai 83ebc96d6c Merge "Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet" into udc-qpr-dev am: 8997e5626a am: 5b2bb7bcc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23899920

Change-Id: Iad1a805ea375bd74ba271b4fbb3c81353a6e1e17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 05:36:40 +00:00
Jagrut Desai 5b2bb7bcc2 Merge "Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet" into udc-qpr-dev am: 8997e5626a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23899920

Change-Id: If6475c36d108b820b0a0ab0a9ad94654c89179c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 04:55:08 +00:00
Jagrut Desai 8997e5626a Merge "Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet" into udc-qpr-dev 2023-07-25 04:14:47 +00:00
Andy Wickham 2000264559 Merge "Change Overview Actions to round buttons." into udc-qpr-dev am: 03b5f8b1d1 am: 48445a5fb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783599

Change-Id: I5e5ffed6f3eee007dffb60a56f9a1cd4c0dfd8d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 21:05:43 +00:00
Stefan Andonian 784cce815c Add ViewCapture to Taskbar am: a540ce2046 am: dc20190b3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24149168

Change-Id: Ib54d456340da4820e5f88e03356d3519c0b98817
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 21:05:31 +00:00
Andy Wickham 48445a5fb2 Merge "Change Overview Actions to round buttons." into udc-qpr-dev am: 03b5f8b1d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783599

Change-Id: Idb64d2d1ca132ce80321af3a4714ff75c2b36b4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 20:20:02 +00:00
Stefan Andonian dc20190b3f Add ViewCapture to Taskbar am: a540ce2046
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24149168

Change-Id: I699a711547541691031fb5e52a7f35a062d5da10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 20:19:46 +00:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Vadim Tryshev 101ea3e4e5 Restoring starting capturing existing activity.
ag/24138143 made the rule to produce empty captures in many cases.

ag/24138143 aimed to fix a leak that was caused by a local var
alreadyOpenActivity still referring the activity when the leak check
executes.

Fixing that by moving the variable to a method startCapturingExistingActivity.

Bug: 291638593
Test: local, presubmit
Flag: N/A
Change-Id: I281202488c6c85e2e2c5b5b3300e26d808167104
2023-07-24 19:09:48 +00:00
Treehugger Robot 8ebc589a49 Merge "Remove debug logs" into udc-qpr-dev am: 979ae6b463 am: a1f448449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24176445

Change-Id: I4643347495a3441c074dfcf1cc02a5025182035f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 17:49:52 +00:00
Tracy Zhou 0a9992813b Merge "Add pressBack test to TaplTestsTrackpad" into udc-qpr-dev am: dc6d7e1e51 am: a27c4aa1e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24094533

Change-Id: Id713be33d172597001d6d4e1cfb61211700799c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 17:49:22 +00:00