PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
76,729 Commits 1 Branch 0 Tags
94de34ce2fa5144833f7801e31c01e617b9a3de1
Commit Graph
19452 Commits
Author SHA1 Message Date
Randy PfohlandAndroid (Google) Code Review f18305ac08 Merge changes I3394267d,Idf9ef20e into udc-qpr-dev 
* changes:
  Adding some logging to track test failure in post submit
  enable testWidgets for postsubmit for long term debugging
 2023-08-22 17:14:40 +00:00
Vinit NayakandAndroid (Google) Code Review 0989216160 Merge "Null out Activity in split controller" into udc-qpr-dev 2023-08-22 16:21:45 +00:00
Adrian Roos f45ebad9be Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR 
With ENABLE_HIDE_IME_CAPTION_BAR, we no longer need to update the navigation bar override. This was already applied for the navigation bar, but not the task bar. Mirrors the NavigationBar.java change in
I8793db69fb846046300d5a56b3b0060138ef4cd5.

Bug: 289748734
Change-Id: I86079cb6670a2ae3b6fa883694f8af81df212408
Test: presubmit
 2023-08-22 16:07:37 +00:00
Liran Binyamin 80f20a2183 Handle touches on the bubble bar in Overview 
If the bubble bar is visible and we're in Overview, set the touchable region
of the Taskbar to include the bubble bar bounds.

Fixes: 290197298
Test: Manual
      - Add multiple bubbles to the bubble bar
      - Go to Overview
      - Tap on the bubble bar
      -- Observe that the bubble bar expands
      - Tap on different bubbles
      -- Observe that the bubble bar updates correctly
      - Tap outside the bubble bar
      -- Observe that the bubble bar collapses
      - Tap outside of the bubble bar again
      -- Observe that the launcher state changed and we are in Home
Change-Id: I722778ee41b50ebca57431bb303da89104d25090
 2023-08-22 09:13:15 -04:00
Pat Manning c7087e8f9f Do not consume hover events not coming from cursor for a11y. 
Fix: 283041221
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e9ded6873173ea001c82d6319716a2d48b3bad
 2023-08-22 09:17:04 +00:00
Treehugger RobotandAndroid (Google) Code Review a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00
Tracy ZhouandAndroid (Google) Code Review b038bac666 Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev 2023-08-22 06:48:01 +00:00
Sunny Goyal 5442cbc300 Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag 
Bug: b/270397209
Test: Presubmit
Flag: RECEIVE_UNFOLD_EVENTS_FROM_SYSUI
Change-Id: I4f87777fd27b5489557742b58e25dc5488b7d32b
 2023-08-22 04:31:09 +00:00
Luca ZuccariniandAndroid Build Coastguard Worker b38e61a339 Animate depth from the right value on Taskbar All Apps launches. 
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

(cherry picked from commit 627d67549f)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3e91646d123abbe58ccc0544746145ce5024b923)
Merged-In: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
 2023-08-22 02:15:08 +00:00
Nick ChameyevandAndroid Build Coastguard Worker 14b4f9edcc [Unfold animation] Do not preemptively start the animation if it has run already 
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
(cherry picked from commit 6d756970e7)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e53f5ef97a02d25f508774e82985e24dc2f4d2d)
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
 2023-08-22 02:14:49 +00:00
Vinit Nayak b620af4612 Null out Activity in split controller 
Bug: 295225524
Change-Id: I59aaed3fca07d611088cec0a4bfafc658a151bb2
 2023-08-21 23:40:51 +00:00
Treehugger RobotandAndroid (Google) Code Review 0bf390490a Merge "Pass extras Bundle in onRecentsAnimationStart" into main 2023-08-21 23:25:16 +00:00
Treehugger RobotandAutomerger Merge Worker 15f1370c45 Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f am: 0dbd72188b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I1ebeef38e8001379a7d0b4b1c4a9ae8bc4cf9698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 22:53:41 +00:00
Tracy Zhou d9d17ce133 Init nav mode in TaskbarActivityContext between fold/unfold 
In RotationButtonController, we show the floating rotation button either when the bar is visible, or when the device is in gesture nav mode, even in an immersive app. The issue here is that mNavMode is not correctly initialized after the device is unfolded.

Fixes: 272164624
Test: Open townhall. Fold and then unfold. Tilt the device and make sure the floating rotation button shows.
Change-Id: I09025132fdca5c764e66d9ac21f29b853741d257
 2023-08-21 22:38:13 +00:00
Treehugger RobotandAutomerger Merge Worker 0dbd72188b Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I47fae5b187a2bb2a50e0ff78ce9672cdd50ba6b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 22:14:42 +00:00
Treehugger RobotandAndroid (Google) Code Review 2a1df8879f Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev 2023-08-21 21:50:54 +00:00
randypfohl ecffb20ba8 Adding some logging to track test failure in post submit 
Test: not needed

Bug: 295069071

Change-Id: I3394267dbbd808544e2759737c7d139c5ba4121f
 2023-08-21 14:49:25 -07:00
Vadim TryshevandAutomerger Merge Worker 3c880e2601 Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev am: 72731c4bda am: c4d207ea41 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486323

Change-Id: Id15e1266db1aa353a8bf18bdbd675973b21bddfe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 21:44:02 +00:00
Vinit Nayak b23cdf1f93 Pass extras Bundle in onRecentsAnimationStart 
* Bundle will contain SplitBounds if recents
animation contains splitscreen targets
* Key to use is SplitBounds#KEY_RECENTS_BUNDLE

Test: Swiping up with single + split tasks
Bug: 254378592
Change-Id: I51f4063aa62ae22a43ffb3712ae6a837156f32d8
 2023-08-21 21:32:54 +00:00
Vadim TryshevandAutomerger Merge Worker c4d207ea41 Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev am: 72731c4bda 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486323

Change-Id: I1cb596ba63312b9562d49b9e0b3b36131b1ea692
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 21:04:02 +00:00
Vadim TryshevandAndroid (Google) Code Review 72731c4bda Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev 2023-08-21 20:19:27 +00:00
Treehugger RobotandAndroid (Google) Code Review 4dc9893028 Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev 2023-08-21 19:41:19 +00:00
Treehugger RobotandAutomerger Merge Worker f59f95247d Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev am: e207075bdc am: 589bc3f092 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24472691

Change-Id: I76c0b825cc80a641d7d1ef387be9857014e493a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 19:29:08 +00:00
Pat ManningandAutomerger Merge Worker 6784e09204 Merge "Check taskbar stash state for hover only on hover events." into udc-qpr-dev am: bd4e77ccf7 am: 9180b92d8e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24420598

Change-Id: I528c980856b8dcb6c02593893da7bb7846eb503c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 19:25:31 +00:00
Treehugger RobotandAutomerger Merge Worker 589bc3f092 Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev am: e207075bdc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24472691

Change-Id: I9ab48540ad3684e6de0e0c96ba3aaaabde1b863e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 19:21:50 +00:00
Tony WickhamandAndroid (Google) Code Review 0c91338815 Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev-plus-aosp 2023-08-21 19:01:15 +00:00
Treehugger RobotandAndroid (Google) Code Review e207075bdc Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev 2023-08-21 18:56:40 +00:00
Pat ManningandAutomerger Merge Worker 9180b92d8e Merge "Check taskbar stash state for hover only on hover events." into udc-qpr-dev am: bd4e77ccf7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24420598

Change-Id: I42f9e17bd7123e116457b5758372f67d5f852316
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-21 18:47:22 +00:00
Tony Wickham 5841b168fb Add null check for mRecentsView when recents animation is canceled 
Flag: none
Test: TaplTestsPersistentTaskbar#testHideTaskbarPersistsOnRecreate
Fixes: 295796661
Change-Id: Idb454105cc86f1b9dbe720ba0ee28ad03436ec14
 2023-08-21 18:46:44 +00:00
Pat ManningandAndroid (Google) Code Review bd4e77ccf7 Merge "Check taskbar stash state for hover only on hover events." into udc-qpr-dev 2023-08-21 18:18:10 +00:00
Andreas AgvardandAutomerger Merge Worker a8a71f36f5 Merge "Prevent long press nav handle invocation when quick switching between apps." into udc-qpr-dev am: 31689cad69 am: 37ba5dd025 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24483110

Change-Id: Ibc3e75990f5a68d74572b8044ee4a5163396ddfe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-19 10:25:52 +00:00
Andreas AgvardandAutomerger Merge Worker 37ba5dd025 Merge "Prevent long press nav handle invocation when quick switching between apps." into udc-qpr-dev am: 31689cad69 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24483110

Change-Id: I0996c639d301f253fad780a6396e71d3c5bf1e73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-19 09:50:07 +00:00
Andreas AgvardandAndroid (Google) Code Review 31689cad69 Merge "Prevent long press nav handle invocation when quick switching between apps." into udc-qpr-dev 2023-08-19 09:16:13 +00:00
Mateusz CicheńskiandAutomerger Merge Worker 44abf2e7a7 Merge "Remove fling gesture related flags for PiP and Bubbles" into udc-qpr-dev am: cdb5f1036b am: 3744f3713c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24448712

Change-Id: I68ca5003f650855e1959bc44e2aa73ff6623a9f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-19 02:58:30 +00:00
Mateusz CicheńskiandAutomerger Merge Worker 3744f3713c Merge "Remove fling gesture related flags for PiP and Bubbles" into udc-qpr-dev am: cdb5f1036b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24448712

Change-Id: Ic9b709185d5b63fdf252f4f5edcb5d44a8327fdb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-19 02:25:05 +00:00
Mateusz CicheńskiandAndroid (Google) Code Review cdb5f1036b Merge "Remove fling gesture related flags for PiP and Bubbles" into udc-qpr-dev 2023-08-19 01:52:27 +00:00
Vadim Tryshev 49f492e28a Demoting testSplitAppFromHomeWithItself from presubmit 
It flakes in 100% of runs on certain targets

Bug: 295225524
Flag: N/A
Test: presubmit
Change-Id: I9d93db78154e834990ed82b95cadab359c2231ab
 2023-08-18 18:07:13 -07:00
Treehugger RobotandAutomerger Merge Worker 2c206acb8b Merge "Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated" into udc-qpr-dev am: fae0011590 am: cd5b6ee62e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486312

Change-Id: I1c94a2bc322854ec78e9dfea3a243199a08ea2ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-19 00:22:50 +00:00
Treehugger RobotandAutomerger Merge Worker cd5b6ee62e Merge "Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated" into udc-qpr-dev am: fae0011590 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486312

Change-Id: Id2091827cfa29e7f051609cc571fcb9c17a4d0d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-18 23:48:12 +00:00
Treehugger RobotandAndroid (Google) Code Review fae0011590 Merge "Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated" into udc-qpr-dev 2023-08-18 23:10:55 +00:00
Tony Wickham 7e9cfdf254 Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated 
Test: manually call finish() in onActivityInit(), no crash when
handler is subsequently invalidated (did crash before this change)
Flag: None
Fixes: 295796661

Change-Id: I2dac7ca87bcdb700da2387309d5ad1d2f4ef43d7
 2023-08-18 21:44:52 +00:00
Treehugger RobotandAutomerger Merge Worker d0029eda42 Merge "Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit"" into udc-qpr-dev am: 14223c8fb6 am: 56c3aee7da 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24484260

Change-Id: I52e856d82acf60e03674f1d4d3da57155439b5bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-18 20:13:59 +00:00
Andreas Agvard 96beb83bee Prevent long press nav handle invocation when quick switching between apps. 
Bug: 296616400
Test: Manual
Change-Id: Ic393014e0eb834e60414d6ce9fcdf3d91cb1667a
 2023-08-18 22:06:20 +02:00
Treehugger RobotandAutomerger Merge Worker 56c3aee7da Merge "Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit"" into udc-qpr-dev am: 14223c8fb6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24484260

Change-Id: I59831f0e9d68e0686b76c2d4916907e5c3b5a624
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-18 19:40:44 +00:00
Treehugger RobotandAndroid (Google) Code Review 14223c8fb6 Merge "Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit"" into udc-qpr-dev 2023-08-18 19:10:12 +00:00
Vadim TryshevandAndroid (Google) Code Review 8b5edb3c29 Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit" 
This reverts commit 120b5876da.

Reason for revert: The leak simply moved to the next test method. So, looks like the leak originated in the previous test.

Change-Id: Ia24e31338af7eb1902a945fa92e0aa19aaddcd83
 2023-08-18 17:36:17 +00:00
Jagrut Desai a26500b145 Remove Change Navigation Mode option for Taskbar Divider Popup Menu 
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Merged-In: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
 2023-08-18 16:57:08 +00:00
Pat Manning 3447016c66 Check taskbar stash state for hover only on hover events. 
Fix: 293419351
Test: TaplTestsTransientTaskbar.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I86d166d71dc5d41a7c4e450584e8948db96bf199
 2023-08-18 14:45:48 +00:00
Jagrut DesaiandAutomerger Merge Worker 15ab7a24e8 Merge "Correcting Taskbar Icon Layout bounds when Taskbar Divider is present" into udc-qpr-dev am: d34fe6d60c am: 14b1fdfba3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24449989

Change-Id: I18e197ed288d1e5835bb5aeb32c29fda433e0ca7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-18 05:05:49 +00:00
Jagrut DesaiandAutomerger Merge Worker e198d44e15 Merge "Refactor taskbar divider view to IconButtonView" into udc-qpr-dev am: 6341a7e31c am: 5150489fc0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24448722

Change-Id: I9f2651ebb0df4053c421f34cc49053a9fe5a8726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-18 05:05:12 +00:00