Commit Graph

19452 Commits

Author SHA1 Message Date
Andy Wickham 369c6e8be7 Reduces vertical padding of predicted apps in All Apps.
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).

Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing

Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot 7ef9220555 Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c am: 8563855387
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490

Change-Id: I47fd27284002803817d2bd3b549cac7a78ee23fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:31:37 +00:00
Vinit Nayak ebd04c4bc1 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce am: 1f97ccf5e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I11d27495a0aaa09ebcd376fd38ad96721562eb63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:29:41 +00:00
TreeHugger Robot 8563855387 Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490

Change-Id: Ia6a7f74c9a7ede2a41164fe68a271e94dcb7b724
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:16 +00:00
Vinit Nayak 1f97ccf5e2 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I40fbd2314fc02db46682e99057c365bae3973e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:58:44 +00:00
TreeHugger Robot 7d8ba14b3c Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev 2022-09-12 18:30:47 +00:00
Vinit Nayak f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00
Sunny Goyal cae104baaf Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171 am: 5145e474d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471

Change-Id: Ia297ef33280ec46a6222781f43ae6dc1b813bd4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 18:00:45 +00:00
Sunny Goyal 5145e474d6 Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471

Change-Id: I2958d9cd87323c5a3934904120d550fbb2d2f411
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 17:16:38 +00:00
Winson Chung 252ec11e4e Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Sunny Goyal 1eb1124d82 Removing back-button alpha animation code
Back button is only animation in 2-button UI which is not supported anymore

Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Vinit Nayak 2e4dcb16a7 Place TaskMenuView aligned with secondary split thumbnail
* Use consistent divider calculations in
different methods

Fixes: 245610772
Fixes: 218784487

Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.

Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Vinit Nayak bdcdcf9edd Merge "Disable split pair long press smart actions" into tm-qpr-dev am: 5aa6deff8d am: 822e9bbf88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890715

Change-Id: Iec125e205e4f399c440bdc2d9ce892feeea9931a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 20:19:17 +00:00
Vinit Nayak 822e9bbf88 Merge "Disable split pair long press smart actions" into tm-qpr-dev am: 5aa6deff8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890715

Change-Id: I0667bea3ba2d29a1af7b3013a6ed090bc15dd241
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 19:17:31 +00:00
Vinit Nayak 5aa6deff8d Merge "Disable split pair long press smart actions" into tm-qpr-dev 2022-09-08 18:51:05 +00:00
Schneider Victor-tulias b240a8d844 Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev am: 5f4e93d669 am: 155d8027a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890487

Change-Id: Ib861643b91434192071a34cbd04232bf0d02c68d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:49:11 +00:00
Schneider Victor-tulias b77eca42a4 Merge "Finish recents animation to the matching state." into tm-qpr-dev am: 0b828e291c am: 364021226d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697943

Change-Id: Idd543141eea90d0f64c646c34d1a8eaff6ec7bbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:49:03 +00:00
Schneider Victor-tulias 155d8027a5 Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev am: 5f4e93d669
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890487

Change-Id: I47668a9bd84a4a2550431e6fd12e370311cdadd2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:19:03 +00:00
Schneider Victor-tulias 364021226d Merge "Finish recents animation to the matching state." into tm-qpr-dev am: 0b828e291c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697943

Change-Id: I32529fa4410c61d7c967873ca5c118fa53e7369c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:18:54 +00:00
Schneider Victor-tulias 5f4e93d669 Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev 2022-09-08 18:14:20 +00:00
Schneider Victor-tulias 0b828e291c Merge "Finish recents animation to the matching state." into tm-qpr-dev 2022-09-08 18:11:43 +00:00
Ats Jenk c2475fa8ee Merge "Filter out active freeform tasks from recents" into tm-qpr-dev am: accde3a686 am: df6d7ffc46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19817526

Change-Id: I3c7b1cc360d984be60d1fd41eaeb526e543c1a35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 16:43:03 +00:00
Ats Jenk df6d7ffc46 Merge "Filter out active freeform tasks from recents" into tm-qpr-dev am: accde3a686
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19817526

Change-Id: I0363eefb1ff54f2d81ef28be947a1b9f4623bfae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 16:12:48 +00:00
Ats Jenk accde3a686 Merge "Filter out active freeform tasks from recents" into tm-qpr-dev 2022-09-08 16:07:19 +00:00
Jeremy Sim 1217f60247 Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev am: 8611800206 am: de313d7a44
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19833885

Change-Id: Ib96f948aabb5edb50d4032433833a5878dc20352
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 01:49:34 +00:00
Jeremy Sim de313d7a44 Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev am: 8611800206
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19833885

Change-Id: Ibd280401ecd22d6289144652658b79ebcd2bd403
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 01:16:34 +00:00
Jeremy Sim 8611800206 Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev 2022-09-08 00:45:41 +00:00
Vinit Nayak e6c1c0ebf6 Disable split pair long press smart actions
Fixes: 236891562
Test: Long press launches task on split pairs.
Fullscreen overview tasks unchanged.

Change-Id: I5ff5377ddbf2bad60b3158dfef7ed2a8073fa0c4
2022-09-07 16:29:17 -07:00
Schneider Victor-tulias 07211eaed4 Add STATE_LAUNCHER_DRAWN printing
Added loging to only print and/or track multistatecallback states

Bug: 227514916
Test: tried various gestures and printed logs
Change-Id: I487b09ca0660fb385c34b49523a2417f11fcde00
2022-09-07 15:46:49 -07:00
Vinit Nayak 42fd4441a3 Run animation for liveTile before trying to launch it
* If current TaskView is running live tiles, animate directly
when toggling recents button instead of trying to
launch the task

Fixes: 240231324
Test: Launching a single GroupedTaskView from overview
launches as expected in 3 button.
Tested adjacent launches as well.

Change-Id: I6c060d918d3ae08bee9da1ad9507bb25cf445b96
2022-09-07 15:33:35 -07:00
Ats Jenk 461c3b3bd0 Filter out active freeform tasks from recents
Freeform tasks will show up as a separate, single tile in recents.
Filtering them out right now.

Bug: 244348395
Test: atest RecentTasksControllerTest RecentTasksListTest
Change-Id: Ifb197031076a8d8934cea78c6b68cb059477a81a
2022-09-07 15:32:02 -07:00
Schneider Victor-tulias a602a0a895 Add error detection for aborting the recents scrolling during transition to home
Bug: 227514916
Test: swiped to overview, to home and quick switch and checked the logs
Change-Id: Ie02d3933e2fb05eedd9c264a381329bc04feac2d
2022-09-07 14:16:08 -07:00
Jeremy Sim 7af10ad02c Prevent Overview Actions from appearing during split from home
Overview Actions will no longer erroneously appear when initiating a split from home.

The bug occurred because split from home causes an irregular state where the user is in split select, yet there is still a focused (main) task in Overview. Overview Actions did not anticipate this state and had no case to handle it.

Fixed by adding a check to Overview Actions so that they will never show when split selection is active.

Fixes: 244499708
Test: Manual
Change-Id: Idf1762c306dceb5048cefec8fa68ac9ca5468379
2022-09-07 12:13:47 -07:00
Alex Chau 17b18bbd8c Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev am: 0f1001c7b1 am: 2cda6fee53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19717456

Change-Id: I640a82ccc8be13a2ff1779f915aa946c841bea6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 15:07:29 +00:00
Alex Chau 2cda6fee53 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev am: 0f1001c7b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19717456

Change-Id: I8b6e68788cde685ee9ed66786714d836b4ffaa13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 14:25:43 +00:00
Alex Chau 0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal 3fccc4ab9f Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev am: 7a6c610626 am: fad9fc1c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19746954

Change-Id: Iaa5ec82d7e74a8e0b33e12c7a43f4eb78941a441
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 05:43:03 +00:00
Sunny Goyal fad9fc1c6a Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev am: 7a6c610626
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19746954

Change-Id: I725789d75f5596ae9b2efb6c48264f54360d81c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 05:12:54 +00:00
Sunny Goyal 7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
Schneider Victor-tulias bc5815d89d Merge "Expand on gesture navigation error detection." into tm-qpr-dev am: 2ae4420a12 am: 38fb33bfca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19671572

Change-Id: I34a81001da26c18a810aaf6b02e202b506791cc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:35:47 +00:00
Schneider Victor-tulias 38fb33bfca Merge "Expand on gesture navigation error detection." into tm-qpr-dev am: 2ae4420a12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19671572

Change-Id: I13e9d67e843c657263578943efa35769ed7b7300
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:05:47 +00:00
TreeHugger Robot 45a39e360b Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev am: db32818a4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19818711

Change-Id: Iff335f7db89bec9675d0028953fb47d3359d103e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:05:39 +00:00
Schneider Victor-tulias 2ae4420a12 Merge "Expand on gesture navigation error detection." into tm-qpr-dev 2022-09-06 17:32:02 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Mateusz Cicheński fc2f0a835f Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev am: 77593150da am: e1b2d018ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19836119

Change-Id: Ic9c1cd8a0139cf4461eb73de58a77958dfdc40d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 17:24:12 +00:00
Mateusz Cicheński e1b2d018ed Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev am: 77593150da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19836119

Change-Id: I13ba5ac31bcffe42270b4042a22ce212ec7482d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 16:54:58 +00:00
Mateusz Cicheński 77593150da Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev 2022-09-06 16:36:48 +00:00
Alex Chau 5e4d93b9dc Merge "Enable adjacent task animation for grid" into tm-qpr-dev am: cec6e2c914 am: c47cb0463c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19619264

Change-Id: I129f15c6bde07d6baa5155a4fb10d69eb03d676d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 16:02:46 +00:00