Commit Graph

15373 Commits

Author SHA1 Message Date
Sunny Goyal 92e392d55b Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I9e77f805e0b3e198ef44a075f6176b9fcc8f6cd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:27:54 +00:00
Sunny Goyal d2a34a2d54 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev 2023-03-20 20:01:52 +00:00
Jon Miranda d0c8aa31bd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: I7c5c1c5f39906eb5e4f5caff4ec4a8c828e5300c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 16:45:42 +00:00
Jon Miranda ad94440c5f Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev 2023-03-20 16:14:43 +00:00
Jon Miranda f23e2d1e16 Keep foreground drawable centered during app open/close animation.
For apps that use AdaptiveIcon, we used to animate the foreground
drawable independently from the background. This is sometimes
perceived as jank so we remove the animation since it is very subtle
in the best case scenario.

Bug: 268026344
Test: open/close apps/folders that use AdaptiveIcons
Change-Id: I500bf56e04823757d511d909a93d3b30703249a1
2023-03-20 16:13:02 +00:00
Thales Lima 7eee74b3f8 Scale folder if it doesn't fit the screen
Scale folder attrs if a full folder doesn't fit the screen width. This will make icons and text smaller than the workspace.

As a follow-up, another bug will be created to only scale full folders instead of all folders.

Bug: 271554689
Test: manually create a full folder, change the display size to large+
Change-Id: I47dc4bd4fe0c9eae989095fc1d179b81d350ef77
2023-03-17 14:13:04 -03:00
Mike Schneider ea674e208c Merge "Add optional debug logging to on flag changes" into tm-qpr-dev am: 8daf6d804e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21868395

Change-Id: I8a871b40687dffb7feb45fb7da9b27727e36ba97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 08:28:05 +00:00
Mike Schneider 8daf6d804e Merge "Add optional debug logging to on flag changes" into tm-qpr-dev 2023-03-17 07:54:33 +00:00
Charlie Anderson cd6fd73639 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev am: d4eed6ec90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21992972

Change-Id: Ic4c29770d9b485252bc8e12e7666f8ab0598cdec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 00:45:25 +00:00
Charlie Anderson d4eed6ec90 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev 2023-03-17 00:15:54 +00:00
Brandon Dayauon d8ae733516 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev am: 26958a0961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079203

Change-Id: Ic18cf7d1cd4e0605202461dc0c1cb1f39cb3f25e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 23:11:49 +00:00
Brandon Dayauon 26958a0961 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev 2023-03-16 22:52:47 +00:00
Charlie Anderson 3a2a69ab3d Fixes tests and issues when toggling new app shortcut popup flag.
Bug: 247880037
Test: manually tested app popup. Also ran Launcher tests locally with U flag on/off.
Change-Id: I93c04f9715d583376c36d823c23353619afd26b6
2023-03-16 12:37:14 -04:00
Helen Cheuk 9a452ebb57 Merge "Resize text in drop target button if the text displayed is truncated vertically" into tm-qpr-dev am: f70036a136
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21701323

Change-Id: I80f12a51fd252b37248c71f88822e13601f41c03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 00:45:27 +00:00
Helen Cheuk f70036a136 Merge "Resize text in drop target button if the text displayed is truncated vertically" into tm-qpr-dev 2023-03-16 00:08:32 +00:00
Charlie Anderson d52925f9c4 Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev am: da4e07812a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21791366

Change-Id: I83ac6a587bf29869708958a86064b55b2f4f756f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 21:38:47 +00:00
Charlie Anderson da4e07812a Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev 2023-03-15 21:18:53 +00:00
Helen Cheuk 1a55cde8c3 Resize text in drop target button if the text displayed is truncated vertically
“Don’t suggest app” text is cut off at the bottom in tablet when it is set to have largest font and display size before this fix. This change is to check if the text is displayed completely with available height. If not, decrease the text size until it does

Fix: 264732627
Test: manual
Change-Id: I8331a40f2cd767a7b2807c15d9772566baf9f355
2023-03-15 14:03:45 +00:00
Mike Schneider a79d460736 Add optional debug logging to on flag changes
FlagDebugUtils.formatFlagChange() utility to always write the set of
updated flags, with a list of actual changes applied. Examples:

[allow_gesture|device_dozing] +[device_dozing]
[] -[state_started]

Additionally, moved the appendFlag utility to the new FlagDebugUtils

Test: manually verifed the output in logcat
Bug: 261418621
Change-Id: Ie4f2cfcd4b34f0a816db7845e1df4331babed07a
2023-03-15 13:36:18 +01:00
Vinit Nayak e1a0fab43d Merge "Add debug logs for WorkTabExists test" into tm-qpr-dev am: 51a864893b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21550343

Change-Id: I9c370088fc04039b7a6af7b9d2781a9eca0b3449
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-14 23:37:36 +00:00
Vinit Nayak 51a864893b Merge "Add debug logs for WorkTabExists test" into tm-qpr-dev 2023-03-14 22:46:07 +00:00
Brandon Dayauon e6b8134769 Merge "Shortcut/people icon horizontal layout polish" into tm-qpr-dev am: 50eef33f20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21980491

Change-Id: I8d04b7e94c912252bd49fcd262630d73f33ce16c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-14 21:25:37 +00:00
Brandon Dayauon b1957cd6fb Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT
This is so it matches closely to all apps icons but the difference is that the icon size is 48dp.

bug: 261047689
test: manual - https://screenshot.googleplex.com/83YwnfwSfR6CJRB and https://screenshot.googleplex.com/68Yqz9hk5NHETKK
Change-Id: I381d9415d2a80a9d36291828a1a31d0c83fc395e
2023-03-14 13:27:30 -07:00
Brandon Dayauon 50eef33f20 Merge "Shortcut/people icon horizontal layout polish" into tm-qpr-dev 2023-03-14 20:18:54 +00:00
Brandon Dayauon 2b3343018e Shortcut/people icon horizontal layout polish
- allow two line for SearchResultShortcutIcons (also be used in search_result_icon_container)

bug: 261047689
test: manual - https://screenshot.googleplex.com/9wwjxp3nqf4iyJr
Change-Id: Ie8d1415ea94f843f32abb9e4416064c1b674be6d
2023-03-14 11:03:18 -07:00
Brian Isganitis c9905fed66 Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev am: 201a8f5ea3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778876

Change-Id: I4c0f86fb4e29f90468e9f74da5d7ffe3045fb2b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-14 17:45:09 +00:00
Brian Isganitis 201a8f5ea3 Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev 2023-03-14 17:16:43 +00:00
Charlie Anderson 63be5b53db polish for the app shortcut popup, fixing padding on several elements.
Bug: 269343928
Test: manually verify against spec
Change-Id: Ib8dd7ab2778644e2220622d43f9774c1de6357e9
2023-03-14 11:33:38 -04:00
Vinit Nayak 7a68378fe4 Add debug logs for WorkTabExists test
Bug: 243688989
Change-Id: Iafec4cae86f1527acac9a25fceb501609ca308f6
2023-03-13 14:27:55 -07:00
Stefan Andonian 0714e68ce7 Merge "Allow Binding the First Workspace Page before the Rest." into tm-qpr-dev am: df57fd822c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21546153

Change-Id: If21d0703c86ec92233bdb25f26cbdbebb41faf77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-13 21:27:34 +00:00
Stefan Andonian df57fd822c Merge "Allow Binding the First Workspace Page before the Rest." into tm-qpr-dev 2023-03-13 20:54:03 +00:00
Thales Lima 4b38b550f5 Merge "Fix TaskView cropping for transient taskbar" into tm-qpr-dev am: 887c0ae68b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537813

Change-Id: I18020f02403cd7eb42cac16758e85799248322f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-13 13:31:14 +00:00
Thales Lima 887c0ae68b Merge "Fix TaskView cropping for transient taskbar" into tm-qpr-dev 2023-03-13 13:27:37 +00:00
Charlie Anderson f09e93f046 Merge "Prevents an extra Widget shortcut from showing when popup receives update." into tm-qpr-dev am: b8827be992
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21956947

Change-Id: I422b55875afe590abe536d7593cc979f17f8dfa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 23:30:34 +00:00
Fengjiang Li d14b11ad3c Merge "[Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled" into tm-qpr-dev am: 47c03be9fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21911161

Change-Id: I1b74b3a49c48936039c501ca07ca4d7aa0ceeb3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 23:26:29 +00:00
Charlie Anderson b8827be992 Merge "Prevents an extra Widget shortcut from showing when popup receives update." into tm-qpr-dev 2023-03-10 23:23:04 +00:00
Fengjiang Li 47c03be9fc Merge "[Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled" into tm-qpr-dev 2023-03-10 21:27:40 +00:00
Sebastián Franco b8614e298c Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I274f6eae4cda80ea45ee48328b6d2a5abfb1e648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:47:55 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Fengjiang Li b167a803fb Merge "[Predictive Back] Fix small bottom gap in widget to home animation" into tm-qpr-dev am: 20a343e740
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21934197

Change-Id: I142754b178563b7ec325bba16eb806737354b1ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:59:03 +00:00
Brandon Dayauon e0bddb5b42 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: Ibf5cb36dc8e5ec0def0012b17b14e848a33d9d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:58:48 +00:00
Fengjiang Li 20a343e740 Merge "[Predictive Back] Fix small bottom gap in widget to home animation" into tm-qpr-dev 2023-03-10 17:34:24 +00:00
Brandon Dayauon 5ddc6ab4da Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev 2023-03-10 17:21:37 +00:00
Fengjiang Li 37305d49fa [Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled
TaskbarAllAppsSlideInView.onBackInvoked() can be triggered by ViewGroup.dispatchKeyEvent(event) with KEYCODE_BACK, in that case we should skip scale animation

Test: manual
Fix: b/272317866
Change-Id: I19468cfe4765de5276c479b0f7fa88ec0690bbfd
2023-03-10 08:54:55 -08:00
Charlie Anderson 5cb9961c28 Prevents an extra Widget shortcut from showing when popup receives update.
Bug: 247880037
Test: Tested manually on phone
Change-Id: I8e9827ac0bfac6161f8b81629a697d053970195b
2023-03-10 11:26:01 -05:00
Federico Baron aac9a588e2 Merge "Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install" into tm-qpr-dev am: 0c77edb8cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21943710

Change-Id: Ie3d3ff6a2cc834b80e8d909d4753f8c0d1af9c75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 06:37:30 +00:00
Federico Baron 0c77edb8cc Merge "Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install" into tm-qpr-dev 2023-03-10 06:21:17 +00:00
Sihua Ma 7560a917d9 Merge "Use app widget host instead of holder to get rid of deleteHost" into tm-qpr-dev am: 713931ec38
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21408002

Change-Id: I9a4ca72e07649daed35f4c4d4ca8b02caabe07bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 23:29:19 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sihua Ma 713931ec38 Merge "Use app widget host instead of holder to get rid of deleteHost" into tm-qpr-dev 2023-03-09 23:06:55 +00:00