There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.
Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.
Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
This reverts commit 4dfcbec512.
Reason for revert: Fix the margin issue by handling the bottom
insets ourselves.
Change-Id: Ic01cadbbe847e419af8bb444ad57764e719152c3
3 Button overview orientation wasn't
getting set, but working because of the sensor.
Now we set orientation when entering overview,
and reset to rotation 0 when exiting overview.
Also fix related bug in RecentsOriented state
where we weren't updating the current sensor
rotation with foreground app orientation.
Fixes: 157069195
Change-Id: Ide1b7dbeb68aeaf6a3c45f7260595f69f4813d94
This reverts commit 160ca4b8a2.
Reason for revert: Got issues like b/158318606 when switch nav modes, also the margin seems not set properly. And this doesn't work for 3 button mode too. Would switch to just use task menu for all.
Change-Id: I645f2a2a9032ae99799c75bcc6c983c1bbfd8df8
1. When home screen rotation is allowed, we still have action buttons for landscape, but remove bottom margin to shrink the UI.
2. When home screen rotation is not allowed, we do in-place rotation for overview, where we won't show action buttons.
Test: see demo video: https://drive.google.com/file/d/1G6ihv_DOykx1MLpFAQf3VJHq3D1HotnX/view?usp=sharing
Bug: 153736749
Change-Id: Ia1c7ef8c245ac13bf50adf32ee5114f23e491e75
Extracts fake task view animation logic to
SwipeUpGestureTutorialController, which
Home and Overview controllers extend.
Fixes: 157945497
Change-Id: Ibd1c129c57e9bee8db62baae455ca1bd9df114c7
mLastRectRotation's value is used after
swipe gestures are complete to reset the
layout for overview (after swiping to home
animation is complete), so we need to set
it to a valid value instead of -1.
OverviewActions visibility depends on
it being rotation 0 for it to be visible,
otherwise it won't show up.
Bug: 155844780
Test: Swipe up to home from an app,
Swipe up to overview, observe overview
actions show in portrait.
Swipe up and back down from landscape app,
hit back. Open portrait app, ensure back
gesture still works.
Change-Id: Ia923a54e68af567b4470841783328528fffebe6a
This consumer is used when Bubbles is expanded, and causes swipes up to hide bubbles via closeSystemDialogs rather than going all the way home.
Test: install launcher and swipe up (after including the other CL in this topic)
Fixes: 156390484
Change-Id: I36b71dd95dc45a5a547eddfe0faddf61630b6f25
Overview comes in and workspace goes out at overshoot(1.2), so
the wallpaper depth/blur should match that speed.
Test: go to overview from home in 3 button or 0 button mode,
ensure wallpaper scales down at the same rate as other elements
Bug: 154637581
Change-Id: I03254fa3fdf19f468852bed8aab7ba21203c429a
Previously we would enter a quickswitch session state
whenever user tapped on navbar and sent flags to
sysui to only enable edge gesture for the current rotation.
Now we only do that on a new task resulting from the gesture
or when going into recents to show nav bar in the
orientation user would expect it (only if they never
quickswitched).
Fixes: 155844780
Test: Tested swiping back from quickswitching
into apps of different orientations.
Note that back is still broken when you
quickswitch and then rotate the foreground app.
Change-Id: I935e7c66489d46e59156414d64653c846ae4c5d8
Reset overview when user does a swipe to home
gesture. Preivously we only rest when user
first when to over, and then swiped to home.
Fixes: 156053957
Change-Id: I5a157f9e2229aba4b36851bd46d704a39d647110
Vinit Nayak
Hyunyoung Song
Jon Miranda
TreeHugger Robot
Becky Qiu
Zak Cohen
Winson Chung
thiruram
Andy Wickham
vadimt
Sunny Goyal
Joshua Tsuji
Tony Wickham