Commit Graph

4540 Commits

Author SHA1 Message Date
Alex Chau 0423e3b412 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev am: fe69980f90 am: 5354bce2e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15992132

Change-Id: I3901bbb4414a9cec2006ad7bb48d971358be04b8
2021-10-07 15:18:40 +00:00
Vinit Nayak 52025a6a52 Merge "Show split options when overview actions hidden for grid" into sc-v2-dev am: 7c2b52e5cf am: 34035ace74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15971858

Change-Id: I24e03b74abb4f64d8f94a3d114c82d68447a59a6
2021-10-07 15:18:29 +00:00
Vinit Nayak 38abfe1ea5 Merge "Move back to end of screen on keyguard" into sc-v2-dev am: c5ae15b481 am: 08b57cd012
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15986998

Change-Id: Idb49286c7bdc5e27fbe09ab064020964e22face2
2021-10-07 15:18:15 +00:00
Alex Chau fe69980f90 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev 2021-10-07 14:52:05 +00:00
Vinit Nayak 7c2b52e5cf Merge "Show split options when overview actions hidden for grid" into sc-v2-dev 2021-10-07 14:51:44 +00:00
Vinit Nayak c5ae15b481 Merge "Move back to end of screen on keyguard" into sc-v2-dev 2021-10-07 14:49:47 +00:00
Vinit Nayak a08e806e25 Move back to end of screen on keyguard
* Animate it back into position after user unlocks
* Re-create taskbar on layout direction change so
PropertyHolders are recreated to take into account
new values

Fixes: 199852418
Test: Tested w/ password + pin for gesture + 3 button
Change-Id: Ie7f16f737a8fc12328c05d7628d0e3ae09fc08ca
2021-10-06 18:09:15 -07:00
Tony Wickham c310a6f930 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev am: f9d2082cf3 am: cdb2df88bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15988588

Change-Id: I761d29cd74d833e259da29f422dd0bc9e144ff0c
2021-10-06 17:59:03 +00:00
Tony Wickham f9d2082cf3 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev 2021-10-06 17:36:45 +00:00
TreeHugger Robot 0e60eddf61 Merge "Remove workaround for unrotated gesture monitor (3/3)" 2021-10-06 17:18:05 +00:00
Alex Chau aea42dc43e Only adjust min/max scroll for split screen in landscape
- Portrait's split placeholder is at top/bottom and does not affect scroll

Bug: 200537659
Test: Split left and split right in portrait / landscape, check if min/max scroll is correct
Change-Id: Ib7eb09d3cc44c8e0d962920ad094c73abc5f0dbd
2021-10-06 12:31:10 +01:00
Vinit Nayak a85e762a62 Merge "Reset state after split launch animation finishes" into sc-v2-dev am: 6ab0d1e7be am: c8b7fef784
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15986152

Change-Id: I8e71fbbb5344205209065a5c94a215db4020ba2a
2021-10-06 01:24:27 +00:00
Tony Wickham 66ed0ff23e Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
2021-10-05 18:14:51 -07:00
Vinit Nayak 6ab0d1e7be Merge "Reset state after split launch animation finishes" into sc-v2-dev 2021-10-06 00:56:48 +00:00
TreeHugger Robot 565c5ed6e2 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev am: 1bf753f7a6 am: e77cae7f0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15947750

Change-Id: I9c7cac5e73845ed4f08d2d518e661891188a0ce6
2021-10-06 00:45:44 +00:00
TreeHugger Robot 1bf753f7a6 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev 2021-10-06 00:14:46 +00:00
Vinit Nayak 0516737146 Reset state after split launch animation finishes
Previously we were clearing SplitSelectStateController
state too soon for fake landscape case where
as soon as the tasks launch the device does a rotation
animation since the new split tasks are in landscape.
Move restting state after animation finishes.

Fixes: 201980666

Change-Id: I23efd59fad444c47ae6c2048888a8570f22610fd
2021-10-05 15:29:24 -07:00
Vinit Nayak 1772a30c70 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev am: 0ff2ad6ff4 am: 9b79688147
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15956593

Change-Id: Ifb3b2498f5db96beadbb6edfe768d7b6762ab023
2021-10-05 22:03:37 +00:00
Vinit Nayak 0ff2ad6ff4 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev 2021-10-05 21:44:34 +00:00
Vinit Nayak 95ee358269 Show split options when overview actions hidden for grid
* We hide split option in task menu for focused task
if the user hasn't scrolled at all in overview
* We show option when user has scrolled because then
the split option from overview actions will be hidden
* Mostly uses the same logic as
RecentsView#updateActionsViewFocusedScroll()

Bug: 201380373
Test: Manual
Change-Id: Ia8769a67cfbb2e4414cd4d8e816e62245fc4bd2c
2021-10-05 14:28:07 -07:00
Alex Chau b78753a73f Adjust min/max scroll according to mSplitPlaceholderSize am: 516584e648 am: 60818c3de0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15982847

Change-Id: I8cbf7c400b06c19b5dd37a1fff66007d414e9d61
2021-10-05 18:27:44 +00:00
Pat Manning a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak 01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00
Alex Chau 516584e648 Adjust min/max scroll according to mSplitPlaceholderSize
- RTL is not handled yet due to split select broken

Bug: 200537659
Test: Split left and split right, check if min/max scroll is correct
Change-Id: I734d890bb955601da52cd806074014ed2e7eba55
2021-10-05 17:22:05 +01:00
Jerry Chang 93250cf918 Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev am: b001ce602f am: 6d6c9de783
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15903128

Change-Id: I82bbca3b2d5bbecdaff5ba6627c87d30f69b227d
2021-10-05 01:19:23 +00:00
Jerry Chang b001ce602f Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev 2021-10-05 00:46:36 +00:00
Prabir Pradhan 85f0cec3dc Remove workaround for unrotated gesture monitor (3/3)
There is currently a conflation between per-window-input-rotation and
unrotated gesture monitors. We would like to enable
per-widnow-input-rotation first without affecting gesture monitors so
that the old behavior is maintained for gesture monitors.

We can then add unrotated gesture monitors as a new feature later on.

Bug: 201982032
Bug: 179274888
Test: manual
Change-Id: I935165446e1a347129e9eb3cc816c62b24d4fc47
2021-10-04 06:06:18 -07:00
Jerry Chang d41c032afd Update side stage outline visibility with swipe gesture
Bug: 200850654
Test: enabled side stage outline, observed the outline updates its
      visibility with swipe gesture properly.
Change-Id: I59fcb1fdbb07f5ad5327036972ebbe20ebeb11b7
2021-10-02 10:04:32 +08:00
TreeHugger Robot 889dfd07cd Merge "Don't snap to task when tapping task icon in overview grid" into sc-v2-dev am: f5942afeb5 am: a5a22a2970
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15960194

Change-Id: I3b1826f21c6f643f87ddfa5022385e36005f9558
2021-10-01 19:46:43 +00:00
Alex Chau d4864e5cbc Don't snap to task when tapping task icon in overview grid
- Open task menu directly instead of snapping to task, as there are spaces to do so unlike small screen

Fix: 201428316
Test: Tap task icon with clear all button shown in overview grid, no snapping
Test: Tap task icon with clear all button shown in non-grid overview, snapped to last task
Change-Id: Ief79f7c758c4109e5c7722b2f35647db98a9f05c
2021-10-01 18:23:25 +01:00
TreeHugger Robot 2e00cb8fee Merge "Overview - Remove Chips code" into sc-v2-dev am: d1ad84c6df am: 5587d7a493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15942463

Change-Id: I40a106e7ff4060c6c0459142defa418fad1d42b5
2021-09-30 22:43:30 +00:00
TreeHugger Robot d1ad84c6df Merge "Overview - Remove Chips code" into sc-v2-dev 2021-09-30 22:14:41 +00:00
Alex Chau 9ec321cbe9 Switch to rest state when display changes am: 90d24f4b9b am: f017e1bfcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15951262

Change-Id: If23c8dcd8a52c3293775a49b1e8e6b8efd336bc6
2021-09-30 19:40:29 +00:00
Alex Chau 90d24f4b9b Switch to rest state when display changes
Fix: 199463580
Test: Unfold device from overview (both from app and from home), overview should close
Change-Id: I7786f3ec46857075e123fa2a093c7b55ca616fc1
2021-09-30 17:26:05 +01:00
TreeHugger Robot 2e4a003f71 Merge "Remove the Share button option from Overview." into sc-v2-dev am: 70cc9ffe7c am: 8775a79741
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15935390

Change-Id: I27bfb9c63fb618abb0faaa116e44b9e95aa84b45
2021-09-30 04:38:22 +00:00
TreeHugger Robot 70cc9ffe7c Merge "Remove the Share button option from Overview." into sc-v2-dev 2021-09-30 04:11:47 +00:00
Tony Wickham ec7030a5e9 Merge "Aniamte stashed handle color changes" into sc-v2-dev am: 6db0cf1e22 am: 631a02507d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943405

Change-Id: I541418eadc98644d9b6f99a7a5a30dea519b1386
2021-09-30 02:39:20 +00:00
Tony Wickham f6af104676 Merge "Update stashed handle region to only include the handle" into sc-v2-dev am: ad3de8eab8 am: b3ade306da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943399

Change-Id: I06b1964118f83bc74678c8ea7a00341c24cf17dd
2021-09-30 02:39:10 +00:00
Tony Wickham 6db0cf1e22 Merge "Aniamte stashed handle color changes" into sc-v2-dev 2021-09-30 02:17:18 +00:00
Tony Wickham ad3de8eab8 Merge "Update stashed handle region to only include the handle" into sc-v2-dev 2021-09-30 02:17:03 +00:00
Tony Wickham 0ede0fa405 Aniamte stashed handle color changes
Test: Swipe from light background to dark background, ensure handle animates the color change
Bug: 193938970
Change-Id: I815c3a364019935bdf3d69309e695ac34b119c5e
2021-09-29 16:19:49 -07:00
Tony Wickham a93e158352 Update stashed handle region to only include the handle
Before it included the whole width/height of the view, rather than just the outline where the handle is drawn.

Test: Swipe up from a light app on dark wallpaper, ensure handle changes color as soon as the white app background is past halfway through the handle
Bug: 193938970
Change-Id: Ic8b83f60976f05b8ff56590422bd9b2fa6140e76
2021-09-29 15:47:58 -07:00
Samuel Fufa 7444c5185f Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev am: abb827b376 am: aab3edf950
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882894

Change-Id: I3f8df26bbc49772faf8b166750fa8cc5ddbc16b5
2021-09-29 22:32:01 +00:00
Samuel Fufa abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
Zak Cohen 71c527126b Overview - Remove Chips code
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.

Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
2021-09-29 14:43:27 -07:00
Zak Cohen 283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Pat Manning 05c2873979 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev am: 429b8df180 am: 148b8bd2eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15804385

Change-Id: I25bb02bde3dc3eeceb6a22d220a64da53b91ac96
2021-09-29 21:30:58 +00:00
Pat Manning 429b8df180 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev 2021-09-29 21:03:46 +00:00
Zak Cohen 018a761e17 Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev am: ba4b8e145d am: a3553ac013
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15936271

Change-Id: Ic3658840206e8a1ff6f8f9868209a219a82b47e2
2021-09-29 20:43:45 +00:00
Zak Cohen ba4b8e145d Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev 2021-09-29 20:15:14 +00:00