Commit Graph

13440 Commits

Author SHA1 Message Date
TreeHugger Robot 906e96a68e Merge "Allow icons to take up full width in all cases where width > height." into tm-dev 2022-03-08 19:08:59 +00:00
Schneider Victor-tulias ed8f41b5e2 Merge "Add method to pause expensive view updates during the app launch aimation" into tm-dev 2022-03-08 18:41:04 +00:00
Jon Miranda f4f6be6080 Merge "Let BubbleTextHolder extend IconLabelDotView" into tm-dev 2022-03-08 15:58:21 +00:00
Alex Chau d8a37c2e12 Merge "Use less icons in hotseat when in 3 button nav for tablet" into tm-dev 2022-03-08 11:58:55 +00:00
Becky Qiu 50c49447cc [OneSearch] Add packageId as an int for latency logging.
Enum defined in NexusLauncher.

Bug: 210790418
Test: manual, see log result in the NL cl.
Change-Id: I03a2a9831fc4cf34f3160f098739a7afd2900ec2
2022-03-07 20:51:22 -08:00
Jon Miranda 39334f4013 Allow icons to take up full width in all cases where width > height.
Previously we only let the icons take up the max width if the
device was in vertical bar layout. For tablets this meant
that the icons would be smaller than the actual window crop.

We want the full width in any cases where the profile width
is greater than the height, so created a new method to check for that.

Bug: 203157974
Test: phone/tablet in portrait/landscape
Change-Id: I467f142bac87ec7c3b369c01f8d9c96ddf74fc76
2022-03-07 18:17:50 -08:00
Jon Miranda a0fb57dc43 Let BubbleTextHolder extend IconLabelDotView
This properly hides just the icon/dot and leaves the
text for All Apps views  during the app launch/exit animation.

Bug: 213306709
Test: open/close apps on workspace, open/swipe back apps in all apps
Change-Id: I327ce3e41298e50e34b8809491fc6d97a89f9f96
2022-03-07 14:45:13 -08:00
Hyunyoung Song 3c8277d161 Merge "ENABLE_QUICK_SEARCH" into tm-dev 2022-03-07 19:16:20 +00:00
Alex Chau 6ed408f59f Use less icons in hotseat when in 3 button nav for tablet
- We have less space on tablets when 3 button nav is enabled because QSB is now inline with the icons. This creates a new attribute to define how many icons should be shown when in that mode. This could be used for other grids in the future as well.
- InvariantDeviceProfile now listens for nav mode changes

Fixes 214882090, 221420204
Test: manual

Change-Id: I012432a1a322c4e5505e46a1198c841ab124aaa6
2022-03-07 18:38:05 +00:00
Alex Chau 86cbea3dc4 Merge "Moving NavigationMode to display controller" into tm-dev 2022-03-07 12:29:53 +00:00
Hyunyoung Song 915a435f13 ENABLE_QUICK_SEARCH
Bug: 213954097
Test: video attached to the bug

Change-Id: Id46ee329df569cccaeda27574c94dbbb6d9fd41f
2022-03-05 23:29:25 -08:00
Sunny Goyal 4403d078a6 Moving NavigationMode to display controller
Navigation mode affects display properties like bounds and
most listeners already had a similar display listener. This
will remove race conditions when managing the two events.

Bug: 221961069
Test: Presubmit
Change-Id: If7a22e006e6b969ecddf075001066809aa72995c
2022-03-04 18:11:33 -08:00
Schneider Victor-tulias 789a6a95cc Add method to pause expensive view updates during the app launch aimation
Fixes: 220922269
Test: Manual
Change-Id: I39066f575c0ddfc4868ab9e27149e2bd9492b39c
2022-03-04 13:59:33 -08:00
Thiru Ramasamy d7af3cc784 Add support for logging multiple attributes per item.
This change will make use of new attributes field in LauncherAtoms to log multiple item attributes by converting them int array and then writes proto bytes into statsd.

Test: wwdebug && wwlogcat http://gpaste/5985977337118720
Change-Id: Iabda0b14100558f5625d01ba829d3ad96a6419fc
2022-03-04 08:40:44 -08:00
Thiru Ramasamy b097f24610 Adds StatsLatencyLogger library.
Test: build NexusLauncherDebug; wwdebug && wwlogcat
Change-Id: Ib1f1aeb78d1cb930ca680439341de6be5e5be2dd
2022-03-03 17:33:24 -08:00
Sunny Goyal ed6d3a47c0 Merge "Separating refresh rate tracking to a separate class" into tm-dev 2022-03-03 23:00:29 +00:00
Brian Isganitis 221b2d7d5e [conflict] Merge changes from topic "presubmit-am-4c8411152aef49f099eee419e063b01e" into sc-v2-dev-plus-aosp am: 087e879b25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16943984

Change-Id: I46336888da6b90649c6def8fbc10c8032f4f2821
2022-03-03 18:21:46 +00:00
Becky Qiu 2ad875afa4 Merge "[OneSearch] Arm2 - Add feature flags." into tm-dev 2022-03-02 21:57:44 +00:00
Becky Qiu 1684d7a739 [OneSearch] Arm2 - Add feature flags.
Added 2 flags to control web suggestion position and whether use fallback app results.

Bug: 213953197
Test: no test needed
Change-Id: Ia11c8bc9493fa4d61ced6982e7cac538201f1be2
2022-03-01 23:35:31 +00:00
Alex Chau 031a77022b Intercept workspace touch when Launcher is in AllApps bottom sheet
Fix: 217571715
Test: Can't scroll workspace when AllApps bottomsheet is up
Test: Can still scroll AllApps bottomsheet down
Change-Id: I116f082ec6a6892cf5c7d0e1388a5771e6fdc4a6
2022-03-01 20:00:36 +00:00
Luca Zuccarini 76263c2d35 Merge "Ensure that the Hotseat respects the margins of the QSB." into tm-dev 2022-03-01 10:21:36 +00:00
TreeHugger Robot 8dfc9872b4 Merge "Add flag for One Search support in Taskbar All Apps." into tm-dev 2022-03-01 03:34:18 +00:00
Sunny Goyal 6bc4257d86 Separating refresh rate tracking to a separate class
Bug: 221961069
Test: Presubmit
Change-Id: I04091ebc9f3d88d2dbbde1bf0d5390c815e026d1
2022-02-28 17:13:00 -08:00
Brian Isganitis 407403315d Add flag for One Search support in Taskbar All Apps.
Test: No
Bug: 216683257
Change-Id: I7a705827f165f60c444bb27c55cdfb6b635215d2
2022-02-28 14:33:47 -08:00
TreeHugger Robot 094a4bdd48 Merge "Removing some unnecessary layout calls in TaskView" into tm-dev 2022-02-28 22:16:30 +00:00
Luca Zuccarini 5c65febbb6 Ensure that the Hotseat respects the margins of the QSB.
Before this change they were ignored by onMeasure(), so that the QSB
couldn't rely on margins for its positioning.

Bug: 217477426
Test: manual
Change-Id: Ifecd3d40ea584273b7857d19b25a90dbafe1c656
(cherry picked from commit 410c75a442)
2022-02-25 17:00:07 +00:00
Adam Cohen f2f302bcf6 Fix DnD logic for determining current drag screen / panel
=> we want to use the extremum of finger location and object
   center for snapping to a new screen (max when snapping to right,
   min when snapping to left)
=> when selecting a panel within the current screen, we want to
   rely strictly on the object center to determine selection; there
   is plenty of space to be consistent here, and extremum logic
   could cause thrashing back and forth with no page movement.

Test: Manual. See videos in b/221104663. On two-panel and one-panel
      test dragging a widget between different screens with
      different starting positions of where the widget goes down.

Bug 221104663

Change-Id: I8f0f13f07b753752087a90c4bacb76cfbf7aa5bf
2022-02-24 16:13:12 -08:00
Alex Chau 1c01af74c6 Merge "Fix incorrect accessibility announcement on two panel home" into tm-dev 2022-02-24 11:51:59 +00:00
TreeHugger Robot 582ab494dc Merge "Use color tokens for all apps entry buttons." into tm-dev 2022-02-24 00:07:47 +00:00
Andras Kloczl 2dacbee028 Fix incorrect accessibility announcement on two panel home
- Divide total pages by panelCount if two panel is active
- Increment target column when moving an item to right panel

Test: manual
Bug: 200009004
Change-Id: Ia8d2d760dc5e8b413e5b1150c049f7fa3ec26513
2022-02-23 22:35:12 +00:00
Sunny Goyal d4c4ad9212 Removing some unnecessary layout calls in TaskView
Bug: 221095750
Test: Presubmit
Change-Id: I277c1350109ce3bd0b29502c588482c737ab1e3d
2022-02-23 13:06:46 -08:00
TreeHugger Robot c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Jon Miranda 48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Alex Chau d8f81e9bf4 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev
* changes:
  Tune AllApps bottom sheet VisD and motion
  Put taskbar all apps in separate overlay window and stash taskbar.
2022-02-23 19:11:51 +00:00
Vinit Nayak 58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
Thales Lima bfb275bf21 Merge "Create new logic for grid migration" into tm-dev 2022-02-23 18:07:06 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Thales Lima 0a7ff8780f Create new logic for grid migration
Fixes 217564863
Test: manual, changing grids from Wallpaper & Style and checking against spec

Change-Id: I94cf77111b37810282527f1a212b6e4126d3eba1
2022-02-23 15:20:50 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Schneider Victor-tulias 2763365eb6 Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Fixes: 220345439
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
(cherry picked from commit 5597e4825d)
2022-02-22 18:38:07 +00:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
kholoud mohamed 9b38947b32 Fix crash when loading string cache
Crash was caused by a null context in ModelDelegate

Fixes: 218305827
Test: manual
Change-Id: I1b046e24427dbdc6752ac100f488c428838ac31f
2022-02-21 11:29:24 +00:00
Presubmit Automerger Backend 2a4f1111e6 [automerge] Remove popup container drag listener on close complete. 2p: 8aa4b05d22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16943984

Bug: 217162588
Change-Id: Ifecc5533324e4669d7742a0ee75c4d57d5b868ca
Merged-In: I16515518c6d488b74450456306abbfff646ac11b
2022-02-18 21:18:44 +00:00
Brian Isganitis 8aa4b05d22 Remove popup container drag listener on close complete.
Bug: 217162588
Test: Verified removal once drag is finished. Verified working on secondary display launcher.
Change-Id: I16515518c6d488b74450456306abbfff646ac11b
Merged-In: I16515518c6d488b74450456306abbfff646ac11b
2022-02-18 21:18:33 +00:00
TreeHugger Robot 49141ccf2e Merge "Revert "Clear all DragView in onSaveInstanceState"" 2022-02-17 20:45:46 +00:00
Tracy Zhou a2215455da Merge "Correct order of split action buttons" 2022-02-17 19:13:26 +00:00
Thales Lima 73087f4b2c Merge "Stop using bottom inset in preview" 2022-02-17 15:28:09 +00:00
Thales Lima 83b345338b Stop using bottom inset in preview
We are not using the bottom inset (navbar) in Launcher anymore, so we should not use it in preview as well.

Fixes 205284107
Test: manual

Change-Id: Iefd71b3cbe8e738c4559716af8c85015ba7c3c41
2022-02-17 13:35:41 +00:00
Tracy Zhou 0551313a9b Correct order of split action buttons
Fixes: 219988163
Fixes: 217965089
Test: https://screenshot.googleplex.com/8LNMBeEQhMVnDSm
Change-Id: I760c0b8085069181d9a1cdc582ac7d58a08f4724
2022-02-17 00:14:50 -08:00
Presubmit Automerger Backend 233f9fc731 [automerge] Init FloatingIconView properties before fetching drawable. 2p: 35d294387c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16908749

Bug: 207389002
Change-Id: I3815ebc0a26f61950d03b63a011dce9e42adb036
Merged-In: Ifdbf3e733e27918c57a5e9b23e5a11b65f8f338c
2022-02-16 23:23:54 +00:00