Commit Graph

1576 Commits

Author SHA1 Message Date
Yogisha Dixit c0425b05c6 Merge "Log widgets source." into sc-dev am: f9acf1d5d4 am: 0f8e5a8a3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: If1ec9ea5acee39e6b83b5beb51a3cb109aaf219b
2021-07-01 13:43:21 +00:00
Yogisha Dixit 658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Yogisha Dixit 326ad0617f Merge "Show resize frame when widget is added." into sc-dev am: 419ee4599e am: 41ce5a6a2a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13956205

Change-Id: I0ec365e612a88fb8639941226c9d8d6451ece8aa
2021-06-29 21:35:53 +00:00
Yogisha Dixit 037a5362d8 Show resize frame when widget is added.
I referenced the code in Workspace.java that updates the widget view's
layout params before showing the resize frame.

Test: manual, AddWidgetTest and AddConfigWidgetTest tapl tests
Bug: 183437963
Change-Id: I6655917878fa22d6084b4bf39fc0661e7278d6f9
2021-06-29 18:25:38 +01:00
Steven Ng dbc7e42f3f Merge "Refine widgets removal logging" into sc-dev am: 57072af106 am: 5a0f9901b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15106953

Change-Id: I4280f8851753cb29b5b8fb3fc54b8465b79beec6
2021-06-26 22:56:20 +00:00
Steven Ng acd9d79932 Refine widgets removal logging
Test: N/A
Bug: 190565858
Change-Id: I7fb20eaf727db19787fa9b1fb36eeb5d1392e50c
2021-06-25 11:51:44 +01:00
Pinyao Ting bbb9a9c033 Extra logging related to widget removal upon restore
As observed in b/187799223, widgets are removed after restore. We cannot
identify the root cause from the bugreport. This CL includes more
logging in the hope of identifying the root cause.

Bug: 18779922
Bug: 190565858
Test: manual
Change-Id: Ibdc9876716028592d17beac4542e1d8c498f9e4c
(cherry picked from commit 655ac082c2)
2021-06-25 09:22:33 +00:00
Samuel Fufa 512f54d57c Merge "Polish work for work profile" into sc-dev am: 1e70c235cf am: 770b6a182a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031833

Change-Id: I4d641524d85183379c3db51a248170af5a9707dc
2021-06-23 19:26:41 +00:00
Samuel Fufa ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Sunny Goyal 4b2528307c Merge "Simplifying Launcher binding callbacks" into sc-v2-dev am: 49537a8942 am: 5ba498a832
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019037

Change-Id: I0ed0925e8d81ca801ab5807f574b277d9191e9b0
2021-06-22 04:29:25 +00:00
Sunny Goyal 4a48a988c8 Simplifying Launcher binding callbacks
> Making all methods as default
> Removing obsolete logic around synchronous binding
> Removing some UI dependencies from bind callbacks

Bug: 187353581
Test: Manual
Change-Id: I0d2bbb060af2cab7c64541d7695055629dfaf0b8
2021-06-17 15:21:01 -07:00
Winson Chung 5f295024eb Merge "Don't rely on intent to call back from activity tracker" into sc-dev am: 1b369c4763 am: cb4a74617b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14909197

Change-Id: I1e175c69167f34f53ca4dd2c1f190068c916244b
2021-06-15 18:30:33 +00:00
Winson Chung 0c36935be9 Merge "Don't rely on intent to call back from activity tracker" into sc-dev am: 1b369c4763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14909197

Change-Id: Ic05028f7cbd58bd4312b04c32f60f31ec33a1721
2021-06-15 18:16:19 +00:00
Winson Chung 1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
Santhosh Thangaraj 44d0b56dab Merge "Fix the page number based Seen impression." into sc-dev am: 4d61c56200 am: 9d3097935f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14905388

Change-Id: I8219e2de7666167d33f1557f5002aa2578b0c468
2021-06-15 15:42:33 +00:00
Santhosh Thangaraj 8134028a3a Merge "Fix the page number based Seen impression." into sc-dev am: 4d61c56200
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14905388

Change-Id: I0d3e74f112da86eedc7d50bbe2bd9fa799473902
2021-06-15 15:22:29 +00:00
Winson Chung 1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
András Klöczl 2a60d99494 Merge "Add left widget panel to Launcher home when unfolded" into sc-v2-dev am: 71954b7ec5 am: efe9f10684
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14745702

Change-Id: Idad5ddbdd61d540c2d85fc107cc36439dcd6205b
2021-06-14 15:39:01 +00:00
Andras Kloczl dbf577af46 Add left widget panel to Launcher home when unfolded
Test: manual
Bug: 175939730
Change-Id: I9831e7fa95084db12953ec7cb2eb725e7549e01d
2021-06-14 12:22:05 +02:00
Santhosh Thangaraj 192924459b Fix the page number based Seen impression.
Test: On device.
Bug: 183117427
Change-Id: Ic1b11fb7630f60f11387951749420653aa3f0c8a
2021-06-10 20:44:09 +00:00
TreeHugger Robot a8b3870603 Merge "[AA+] Reset search manager when exiting all apps." into sc-dev am: e57006fe63 am: 285c50740a am: 7b4e042824
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14804874

Change-Id: I25a8601efaf46d279b6f4b0cb8f7ae743ec7b5b4
2021-06-09 01:26:29 +00:00
TreeHugger Robot 285c50740a Merge "[AA+] Reset search manager when exiting all apps." into sc-dev am: e57006fe63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14804874

Change-Id: I074e33f790758400825ee4aa34f9628207d71f96
2021-06-09 00:52:10 +00:00
thiruram ea56f849c2 [AA+] Reset search manager when exiting all apps.
This is required to log search session exits properly, especially when exiting AllApps without clearing search query.

Bug: 178562918
Test: Manual
Change-Id: Id4c1007b051e9efd9ae5929c274a70cf3ae3cbf1
2021-06-07 17:14:24 -07:00
Sunny Goyal 9d9930e2fc Merge "Taskbar layout update" into sc-v2-dev am: a72e9e20bf am: f703600a8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14722697

Change-Id: Idc4f8932d94a215231076269b2d6fb18611a8188
2021-06-04 18:35:22 +00:00
Sunny Goyal a72e9e20bf Merge "Taskbar layout update" into sc-v2-dev 2021-06-04 18:08:58 +00:00
Yogisha Dixit 80abb18d53 Add new log events for widgets. am: 4ff5ee3a8f am: f8ef794774 am: 45491961d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14425539

Change-Id: I519c29d4a047fc01e43f4642fa2f4345db39d387
2021-06-04 17:05:40 +00:00
Yogisha Dixit f8ef794774 Add new log events for widgets. am: 4ff5ee3a8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14425539

Change-Id: Icfd93b918332a391602c788aa84f27d421c7ef14
2021-06-04 16:37:07 +00:00
Yogisha Dixit 4ff5ee3a8f Add new log events for widgets.
Design doc: go/widgets-logging

Bug: 185778648
Test: manual
Change-Id: Ia3c6edb87766a33e77865e9461e7101a1df864c1
2021-06-04 14:52:37 +01:00
Bill Lin 1cf3039c1e Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2 am: ae054d8584 am: b61a3850b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: Ib18d6c070199ec49afb96a69c5dac299f030e20f
2021-06-04 02:14:12 +00:00
Bill Lin b61a3850b2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2 am: ae054d8584
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: I775c0edcfe403c854a7c87104fa9aba78761f18d
2021-06-04 00:49:48 +00:00
Bill Lin 657a6da6fb Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: I717b55f90426b21c05370a0aeb731b960fb64bee
2021-06-04 00:33:43 +00:00
Sunny Goyal 57b2279dcb Taskbar layout update
> Calculating the hotseat padding statically
> Animating taskbar views individually when animating to home
  instead of a layout animation
> Moving all navbar buttons to a separate layout/controller and independent
  of Launcher
> Fixing RTL layout for taskbar and nav bar

Bug: 187353581
Test: Manual
Change-Id: If21696f38beee328f553e467394776a8e8ed4c3e
2021-06-03 16:10:02 -07:00
Bill Lin a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Tony Wickham 1321851bfb Merge changes I6bf48141,I77b7a2e4 into sc-v2-dev am: f262591ab0 am: 9a9a93f551
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14706973

Change-Id: I6b222c6875a8916d7d198c85f4e998dc31fb8873
2021-05-28 16:07:12 +00:00
Tony Wickham c7cbf254f3 Let DragView use ActivityContext instead of Launcher
- Make DragView abstract and extended by LauncherDragView for the explicitly Launcher-specific parts.
- Some other methods like Utilities.getFullDrawable() now accept (Activity)Context rather than Launcher.

Test: Compiles and runs, manual drag and drop
Bug: 182981908
Change-Id: I77b7a2e48ce864dd711c3232217fdba4d60c546f
2021-05-25 15:35:55 -07:00
András Klöczl c295503361 Merge "Add two panel home support for page binding logic" into sc-v2-dev am: adbe369451 am: 614a98fdea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14589972

Change-Id: Id17504effb8304c401d61d4efe29d6581bdb5c0e
2021-05-25 13:28:06 +00:00
Andras Kloczl 55edfe55f7 Add two panel home support for page binding logic
There's a logic which prioritizes the binding for the
current page and defers the other pages' binding.
If two panel home is enabled, we want to bind both pages
together. LauncherPageRestoreHelper has been created to
contain the logic for persisting restoring and calculating
which pages to load immediately.

Test: manual + run LauncherPageRestoreHelperTest robo test
Bug: 174464691
Change-Id: I57ac3f7150303b95b272e922f44bda26f9d5ce2a
2021-05-24 23:22:06 +02:00
Sunny Goyal b9945f51cb Merge changes from topic "revert-14664190-JGHJCCJYPM" into sc-dev am: 67914aff50 am: 8d996187ea am: 00a0efca95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14669170

Change-Id: I05b89930d87f76c66db03eb47dda1008a659da64
2021-05-21 16:37:17 +00:00
Sunny Goyal d5500548dc Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
430465a3d5
Bug: 187353581
Change-Id: I7b2280d16adfafd3e85ffc1d22e32d0c00d12b67
2021-05-21 07:05:02 +00:00
Kholoud Mohamed ba5e40107a Merge changes I46501369,Icd1ddd43 into sc-dev am: 2c2163329b am: 89384618ca am: ef38ca7c1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14664190

Change-Id: I037f43deac0b7cc7c2fa4aa4cffca306af5ec4a0
2021-05-20 16:25:31 +00:00
Kholoud Mohamed 430465a3d5 Revert "Moving taskbar lifecycle to TouchInteractionService"
This reverts commit e215fb730b.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/tests/view?invocationId=I13700009003387451&testResultId=TR89423459137251402, bug https://buganizer.corp.google.com/issues/188755902

Bug: 188755902
Change-Id: I4650136975b60f311499ee6ff5b27ab9a32d23d6
2021-05-20 13:32:05 +01:00
Sunny Goyal 1a2cbe8dab Merge "Moving taskbar lifecycle to TouchInteractionService" into sc-dev am: 5bb515b6cc am: 3cb1237308
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14445701

Change-Id: Ic448fef7308f15e5eb919438f9cd463e143a9b9d
2021-05-20 04:39:40 +00:00
TreeHugger Robot 55c9481cad Merge "Revert to overview coming from the side instead of bottom" into sc-dev am: 6facaad569 am: 504fbe1764
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14554677

Change-Id: I01a560126f963131e10dabd006a6a924d40a4e05
2021-05-20 04:37:24 +00:00
Yogisha Dixit 95c7c14d08 Merge "Log widget features." into sc-dev am: 07449132fb am: f51b28150c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14487017

Change-Id: I802edc6d02b0d7ba72c323c0a5e0b7b2a332a60e
2021-05-20 04:36:40 +00:00
Sunny Goyal e215fb730b Moving taskbar lifecycle to TouchInteractionService
> Inflating taskbar views with a non-launcher window context
> Removing separate taskbar view in Launcher
> Handling taskbar icon clicks directly instead of going via launcher
> Fixing some relayouts during show/hide animation

Bug: 187353581
Test: Manual
Change-Id: Ia7d44acbb770bf0345922234b3daa5cc040a5843
2021-05-17 21:47:08 -07:00
TreeHugger Robot 6facaad569 Merge "Revert to overview coming from the side instead of bottom" into sc-dev 2021-05-17 17:04:43 +00:00
Yogisha Dixit 07449132fb Merge "Log widget features." into sc-dev 2021-05-15 15:07:40 +00:00
Yogisha Dixit 0b15c7ee07 Log widget features.
Design doc: go/widgets-logging
Note that this doesn't log dynamic colors yet. I'll work on that in a
follow-up CL.

Bug: 185778648
Test: manual
Change-Id: I04249ef267907b4112c220fb206e077d1bee783a
2021-05-15 00:26:41 +01:00
Tony Wickham 82d5a0681d Revert to overview coming from the side instead of bottom
Test: Visually checking all of these. As appropriate, repeat in 0, 2, 3
button modes, landscape/portrait/fake landscape, and 3P launcher
- Quick switch from home
- Home to overview
- Overview to home (swipe up)
- Overview to home (tap outside)
- Overview to home (back invocation)
- Quick switch from app
- Swipe up and hold from app
- Dismiss an app
- Empty recents
- Split select state to home
- Modal state to home
Fixes: 185411781

Change-Id: If00a22fee35c832a259bfc62808efbac5990ce2e
2021-05-14 16:06:44 -07:00
TreeHugger Robot 28928e6e20 Merge "Extra logging related to widget removal upon restore" 2021-05-12 01:45:58 +00:00