Commit Graph

11169 Commits

Author SHA1 Message Date
Alex Chau 8ddacf2185 Merge "Add more logs tracking gesture and recents animation in RecentsView" into main 2024-04-09 20:32:19 +00:00
Alex Chau 55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Holly Jiuyu Sun 887a88f149 Merge "[omni] Read and use touch slop multiplier for LPNH." into main 2024-04-09 20:17:51 +00:00
Treehugger Robot cb8ad6edde Merge "Add debug log for TaskView.onClick" into main 2024-04-09 19:54:11 +00:00
Treehugger Robot 58d913d996 Merge "Fix BinderTests#testSwitchToOverview" into main 2024-04-09 19:41:29 +00:00
Schneider Victor-tulias 2dee591601 Fix BinderTests#testSwitchToOverview
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.

Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
2024-04-09 14:04:34 -04:00
Holly Sun 9b11c40b01 [omni] Read and use touch slop multiplier for LPNH.
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.

Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
2024-04-09 10:10:10 -07:00
Alex Chau 34bfc7a80b Add debug log for TaskView.onClick
Bug: 310064698
Test: manual
Flag: None
Change-Id: Ib772dd8995442d3b1af84aec0668b11828ab62e6
2024-04-09 17:45:30 +01:00
Helen Cheuk a0dc66c206 Merge "Add focus outline to overview clear all button" into main 2024-04-09 16:27:27 +00:00
Brian Isganitis 093b432985 Merge "Reset allAppsVisible if folding to phone upon recreateTaskbar." into main 2024-04-09 16:22:16 +00:00
Brian Isganitis 4ba8346a34 Merge "Use translation shift setter when showing AllApps without animation." into main 2024-04-09 16:21:54 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Liran Binyamin 60d4e8d3b8 Merge "Fix NPE when setting bubble bar bounds" into main 2024-04-09 14:04:19 +00:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Jeremy Sim fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Brian Isganitis 6d63e7796d Reset allAppsVisible if folding to phone upon recreateTaskbar.
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.

Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
2024-04-08 15:36:31 -07:00
Brian Isganitis 514f866f5c Use translation shift setter when showing AllApps without animation.
The no-animation case used to be handled immediately upon inflating the
view, so we got away with reassigning the field to
TRANSLATION_SHIFT_OPENED directly. Since this happens in post of a
handler, we need to instead use the setter so that a relayout happens.

Test: Manual
Fix: 324268840
Flag: N/A
Change-Id: I089f15a8d64e0d22885ae387679214a540790ad0
2024-04-08 15:15:41 -07:00
Liran Binyamin 4d257139ad Fix NPE when setting bubble bar bounds
The bubble bar bounds change listener is sometimes invoked before the IBubbles service has been initialized.
This change adds a null check before calling the service.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 332423960
Test: manual
Change-Id: Iaa048c62a60c90c5e416da05ba53467a5034d86c
2024-04-08 21:05:00 +00:00
Federico Baron 9462c3b604 Merge "Fix null pointer in FloatingWidgetView" into main 2024-04-08 18:52:43 +00:00
Treehugger Robot 8687018b09 Merge "Disable app chip menu height limit for bottom row" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot 18694cc977 Merge "Add max height logic and avoidance of taskbar into task menu" into main 2024-04-08 18:22:08 +00:00
Liran Binyamin 9a9ef494ae Merge changes I74b09220,Id7e2db5f into main
* changes:
  Don't animate bubbles in the initial state update
  Suppress animation for bubbles that auto expand
2024-04-08 16:30:30 +00:00
Uwais Ashraf d9de4b0558 Add max height logic and avoidance of taskbar into task menu
Fix: 329842207
Test: Manually tested, see video in bug
Flag: NA
Change-Id: I08079f14cee63fe7973ba751529109ca66423bb6
2024-04-08 16:23:59 +00:00
Alex Chau 293d2cb867 Disable app chip menu height limit for bottom row
Bug: 326952853
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: manual
Change-Id: I104296979803eb8967b07793f4f2590e592f9df7
2024-04-08 16:24:45 +01:00
Alex Chau 7714b2cd32 Add more logs tracking gesture and recents animation in RecentsView
Bug: 332635097
Test: manual
Flag: None
Change-Id: I6f83806f783344c07f7f59fe87c37b7cc377fff2
2024-04-08 13:12:06 +01:00
Saumya Prakash 83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash 5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Liran Binyamin 0701ab166d Don't animate bubbles in the initial state update
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
2024-04-05 20:15:52 -04:00
Sunny Goyal 8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Tony Wickham a6dcb11094 Merge "Apply insets to top-level providers, not just paramsForRotation" into main 2024-04-05 22:01:29 +00:00
Jeremy Sim 24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Sunny Goyal 9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Anushree Ganjam 16a0f61078 Merge "Add dump for PredictionRowView." into main 2024-04-05 19:41:31 +00:00
Tony Wickham f95a6b73e5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:40:06 +00:00
Liran Binyamin c21852a186 Suppress animation for bubbles that auto expand
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
       - create bubble that auto expands
       - observe that the bubble does not animate
       - note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
2024-04-05 14:09:32 -04:00
Anushree Ganjam 1115b416bb Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
2024-04-05 10:57:44 -07:00
Schneider Victor-tulias 09268637b4 Merge "Add debug logs to TaskView" into main 2024-04-05 16:46:55 +00:00
Tony Wickham fefe8a441b Merge "Unstash taskbar due to IME immediately when system gesture starts" into main 2024-04-05 15:49:36 +00:00
Schneider Victor-tulias 148cbffdbf Add debug logs to TaskView
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: I633a1a67cadc8f1f85fbdeb3a0913623ae817bf1
2024-04-05 10:31:21 -04:00
Treehugger Robot 6539e29882 Merge "Launch AppPair live tile when not visible" into main 2024-04-05 02:08:17 +00:00
Liran Binyamin 98bbc2b46d Merge "Animate the stash handle for new bubbles" into main 2024-04-05 00:49:39 +00:00
Vinit Nayak 8c14bef1f2 Merge "Explicitly set animation and timings for split cancel button" into main 2024-04-05 00:07:13 +00:00
Vinit Nayak 637274ebc9 Launch AppPair live tile when not visible
* End the recents animation and then relaunch as if
from scratch
* We explicitly ignore the anim for end of recents animation
since that will cause the taskbar to quickly show and stash
again, and we know in this case that we'll quickly be launching
right back into an app

Test: Tested w/ live tile + non live,
fullscreen + app pairs
Bug: 316485863

Change-Id: I6ae8cccc01401935bf96fba8a154216e6b1ad701
2024-04-04 15:58:17 -07:00
Tony Wickham a6b29968a4 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
2024-04-04 22:07:43 +00:00
Vinit Nayak aeb9595b37 Explicitly set animation and timings for split cancel button
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation

Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps

Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
2024-04-04 14:20:18 -07:00
Jagrut Desai e6f349b3dd Adjusting Taskbar Icons for larger display size
Bug: 323948193
Test: Manual
Flag: NONE

Change-Id: I0bdfcaebf3de050ac850fe42c061c82ffebdb7c2
2024-04-04 14:01:57 -07:00
Ats Jenk 9f0042b2c8 Merge "Update spring stiffness for bubble bar drag animation" into main 2024-04-04 18:56:27 +00:00
Ats Jenk d961c3d31d Merge "Update bubble bar bounds in shell" into main 2024-04-04 18:55:36 +00:00
Liran Binyamin 597ced3033 Animate the stash handle for new bubbles
The stash handle now animates out before the new bubble animates in, and animates back in after the new bubble is hidden.
There's still some additional polish needed :)

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/z30Ob1rcDUkNEphLAQsgV

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I03449286b01ec96de9834e24a707652ddbe49fb0
2024-04-04 14:26:08 -04:00