Commit Graph

15021 Commits

Author SHA1 Message Date
Mike Schneider 8daf6d804e Merge "Add optional debug logging to on flag changes" into tm-qpr-dev 2023-03-17 07:54:33 +00:00
Charlie Anderson d4eed6ec90 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev 2023-03-17 00:15:54 +00:00
Brandon Dayauon 26958a0961 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev 2023-03-16 22:52:47 +00:00
Charlie Anderson 3a2a69ab3d Fixes tests and issues when toggling new app shortcut popup flag.
Bug: 247880037
Test: manually tested app popup. Also ran Launcher tests locally with U flag on/off.
Change-Id: I93c04f9715d583376c36d823c23353619afd26b6
2023-03-16 12:37:14 -04:00
Helen Cheuk f70036a136 Merge "Resize text in drop target button if the text displayed is truncated vertically" into tm-qpr-dev 2023-03-16 00:08:32 +00:00
Charlie Anderson da4e07812a Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev 2023-03-15 21:18:53 +00:00
Helen Cheuk 1a55cde8c3 Resize text in drop target button if the text displayed is truncated vertically
“Don’t suggest app” text is cut off at the bottom in tablet when it is set to have largest font and display size before this fix. This change is to check if the text is displayed completely with available height. If not, decrease the text size until it does

Fix: 264732627
Test: manual
Change-Id: I8331a40f2cd767a7b2807c15d9772566baf9f355
2023-03-15 14:03:45 +00:00
Mike Schneider a79d460736 Add optional debug logging to on flag changes
FlagDebugUtils.formatFlagChange() utility to always write the set of
updated flags, with a list of actual changes applied. Examples:

[allow_gesture|device_dozing] +[device_dozing]
[] -[state_started]

Additionally, moved the appendFlag utility to the new FlagDebugUtils

Test: manually verifed the output in logcat
Bug: 261418621
Change-Id: Ie4f2cfcd4b34f0a816db7845e1df4331babed07a
2023-03-15 13:36:18 +01:00
Vinit Nayak 51a864893b Merge "Add debug logs for WorkTabExists test" into tm-qpr-dev 2023-03-14 22:46:07 +00:00
Brandon Dayauon b1957cd6fb Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT
This is so it matches closely to all apps icons but the difference is that the icon size is 48dp.

bug: 261047689
test: manual - https://screenshot.googleplex.com/83YwnfwSfR6CJRB and https://screenshot.googleplex.com/68Yqz9hk5NHETKK
Change-Id: I381d9415d2a80a9d36291828a1a31d0c83fc395e
2023-03-14 13:27:30 -07:00
Brandon Dayauon 50eef33f20 Merge "Shortcut/people icon horizontal layout polish" into tm-qpr-dev 2023-03-14 20:18:54 +00:00
Brandon Dayauon 2b3343018e Shortcut/people icon horizontal layout polish
- allow two line for SearchResultShortcutIcons (also be used in search_result_icon_container)

bug: 261047689
test: manual - https://screenshot.googleplex.com/9wwjxp3nqf4iyJr
Change-Id: Ie8d1415ea94f843f32abb9e4416064c1b674be6d
2023-03-14 11:03:18 -07:00
Brian Isganitis 201a8f5ea3 Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev 2023-03-14 17:16:43 +00:00
Charlie Anderson 63be5b53db polish for the app shortcut popup, fixing padding on several elements.
Bug: 269343928
Test: manually verify against spec
Change-Id: Ib8dd7ab2778644e2220622d43f9774c1de6357e9
2023-03-14 11:33:38 -04:00
Vinit Nayak 7a68378fe4 Add debug logs for WorkTabExists test
Bug: 243688989
Change-Id: Iafec4cae86f1527acac9a25fceb501609ca308f6
2023-03-13 14:27:55 -07:00
Stefan Andonian df57fd822c Merge "Allow Binding the First Workspace Page before the Rest." into tm-qpr-dev 2023-03-13 20:54:03 +00:00
Thales Lima 887c0ae68b Merge "Fix TaskView cropping for transient taskbar" into tm-qpr-dev 2023-03-13 13:27:37 +00:00
Charlie Anderson b8827be992 Merge "Prevents an extra Widget shortcut from showing when popup receives update." into tm-qpr-dev 2023-03-10 23:23:04 +00:00
Fengjiang Li 47c03be9fc Merge "[Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled" into tm-qpr-dev 2023-03-10 21:27:40 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Fengjiang Li 20a343e740 Merge "[Predictive Back] Fix small bottom gap in widget to home animation" into tm-qpr-dev 2023-03-10 17:34:24 +00:00
Brandon Dayauon 5ddc6ab4da Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev 2023-03-10 17:21:37 +00:00
Fengjiang Li 37305d49fa [Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled
TaskbarAllAppsSlideInView.onBackInvoked() can be triggered by ViewGroup.dispatchKeyEvent(event) with KEYCODE_BACK, in that case we should skip scale animation

Test: manual
Fix: b/272317866
Change-Id: I19468cfe4765de5276c479b0f7fa88ec0690bbfd
2023-03-10 08:54:55 -08:00
Charlie Anderson 5cb9961c28 Prevents an extra Widget shortcut from showing when popup receives update.
Bug: 247880037
Test: Tested manually on phone
Change-Id: I8e9827ac0bfac6161f8b81629a697d053970195b
2023-03-10 11:26:01 -05:00
Federico Baron 0c77edb8cc Merge "Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install" into tm-qpr-dev 2023-03-10 06:21:17 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sihua Ma 713931ec38 Merge "Use app widget host instead of holder to get rid of deleteHost" into tm-qpr-dev 2023-03-09 23:06:55 +00:00
Sebastian Franco 239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
Federico Baron db599b2d8e Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install
Fix: 269702659
Test: Download an app that has a lighning next to the install text and verify that the animation plays smoothly and that it doesn't animate until we finish downloading completely.
Change-Id: I11147444a85db01c75d63b5cdd09d1d911a28c75
2023-03-09 14:44:41 -08:00
Fengjiang Li 1898d16ee0 [Predictive Back] Fix small bottom gap in widget to home animation
The bug was caused by a math problem. The extrat bottom offset should be

 offset = (H / 0.9 - H) / 2

Fix: b/269393854
Test: manual
Change-Id: Ia4d6b3f2ecb53b82d6779cd385ce4d7ca3c16113
2023-03-09 14:38:06 -08:00
Jon Miranda 0fe7e089ca Merge "Align taskbar to the left/right in 3 button nav for certain devices." into tm-qpr-dev 2023-03-09 22:33:28 +00:00
Jon Miranda e17a949950 Align taskbar to the left/right in 3 button nav for certain devices.
Otherwise we position the taskbar in the center.

Bug: 259712417
Fixes: 267997547
Test: transient taskbar unaffected
      persistent taskbar
      - test on small tablet
      - test on large tablet
      - test LTR and RTL

Change-Id: Ieb0a304d9963ebf583bc4ef2deaab747019e8d6d
2023-03-09 22:33:18 +00:00
Vinit Nayak 4b0a5ed8fa Merge "Add initial split from GroupedTaskView animation" into tm-qpr-dev 2023-03-09 21:17:07 +00:00
Sihua Ma cdb3c0af1a Use app widget host instead of holder to get rid of deleteHost
Also putting the calls to destroy() in try-finally blocks.

Test: N/A
Fix: 272535886
Change-Id: I57ecd90e412b3b8b59b4ed755a5d4191b05fd9b3
2023-03-09 11:19:18 -08:00
Thales Lima 9fde4781ea Fix TaskView cropping for transient taskbar
TaskView clipping is not necessary anymore because task in Overview will always be the same aspect ratio as the app when in fullscreen.

Fix: 268211636
Test: manual trigger of Overview (landscape, portrait, split screen)
Change-Id: Ib4faeda6f0cccef3b23fcbacb89c6d2832c0df59
Merged-In: Ib4faeda6f0cccef3b23fcbacb89c6d2832c0df59
2023-03-09 18:43:05 +00:00
Brandon Dayauon c1e12fc150 Merge "Play original haptic when feature flag is off. Rename feature flag" into tm-qpr-dev 2023-03-09 16:44:07 +00:00
Eddie Lan cbdd6493f1 Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev 2023-03-09 09:06:11 +00:00
Eddie Lan 293688a9a0 Revert "Hide the splash icon when launching with no view and no ..."
Revert submission 21447384-no-splash

Reason for revert: build break
Bug: 272383391

Reverted changes: /q/submissionid:21447384-no-splash

Change-Id: I73565b1f4e5dd969237980b2b5dbeee7b563abcb
2023-03-09 09:00:29 +00:00
Jon Miranda 4c368373cb Merge "Polish taskbar un/stash animation." into tm-qpr-dev 2023-03-09 03:33:39 +00:00
Jon Miranda 1671b704b3 Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev 2023-03-09 00:33:27 +00:00
Brandon Dayauon dee687c33a Play original haptic when feature flag is off. Rename feature flag
- Remove the Utilities.atLeast check since it's no longer relevant as there is no new haptics being played
in the original haptic..

When FeatureFlag is off, the haptic for all apps and qsb is played in one place. So when
FeatureFlag is on, we need to isolate where the haptic call gets played so we disable calling it from two places
and play the haptics at the respective areas.
flag: ENABLE_PREMIUM_HAPTICS_ALL_APPS=false


bug: 270634265
test: Manual
Change-Id: I7b92c427e880b196130270ed9709cf1ea0e19e0a
2023-03-09 00:14:14 +00:00
Jon Miranda 67d4b0ed6b Polish taskbar un/stash animation.
- When QSB is inline, we add it to the reveal animation
  so that it moves in coordination with the rest of the
  taskbar icons
- Hide All Apps button when transitioning from Home -> App
  to match spec
- Shorten duration icons move in x duration so that they
  stay within the taskbar background bounds.

Bug: 267806083
Bug: 246635237
Bug: 246660243
Test: transient taskbar
      with isQsbInline = true and false

Change-Id: Ie6b866311cc2ceba88cdf01652b30fee457d0359
Merged-In: Ie6b866311cc2ceba88cdf01652b30fee457d0359
2023-03-08 23:47:29 +00:00
Jagrut Desai d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
Vinit Nayak aa7bf8b394 Add initial split from GroupedTaskView animation
* Created SplitAnimationController to prevent more
RecentsView bloat
* Extract SplitSelectSource attributes into separate class
* http://recall/-/cMb5xTTxhmZtFt04eYnmQj/eACJq1un8Ef91LgmQblpAw

Bug: 267370106
Change-Id: I5d430c091ac84bbbc30319e7b78711b610a21252
2023-03-08 15:17:57 -08:00
Andreas Miko 121bbf6a3f Merge "Add unlock animation for foldables" into tm-qpr-dev 2023-03-08 22:40:22 +00:00
Jon Miranda acdf07e0b7 Hide taskbar view for app open/close animation.
Bug: 246635237
Test: open app in hotseat
      close app in hotseat
      the 'matching' view in taskbar should be hidden
      tested icon, predicted icon, folders in taskbar/hotseat
Change-Id: I74382480826afafe6ae58e78faf26fe10812e29b
2023-03-08 10:37:25 -08:00
Jagrut Desai 1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Charlie Anderson e3b583277c Merge "Fix bug by allowing popup notifications to be dismissed via swipe" into tm-qpr-dev 2023-03-08 16:48:26 +00:00
Andreas Miko 8e4192fa4f Add unlock animation for foldables
Test: Unit tests added
Test: Manual tests on foldable device going through unlock on outer and inner screens
Bug: b/261584499

Change-Id: I9cdb717400c82e7a0bb4d58d6d25d8b794200af3
2023-03-08 15:58:25 +01:00
Charlie Anderson 3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00