Commit Graph

2001 Commits

Author SHA1 Message Date
Sunny Goyal 679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
2022-11-04 14:41:14 -07:00
TreeHugger Robot 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
Sebastián Franco 58502d0236 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev 2022-11-03 18:55:50 +00:00
TreeHugger Robot 9e1f6002e5 Merge "Add delay after installing dummy app" into tm-qpr-dev 2022-11-03 17:17:09 +00:00
Sam Dubey 52a3bcd4bb Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev 2022-11-03 11:40:24 +00:00
Sam Dubey a3577293b6 Revert "Support multi users scenarios in Tapl"
Revert "Reduce multi users tests runtime"

Revert "Add PlatformTesting to dependency."

Revert "Move platform testing util to separate gradle module"

Revert submission 20311444-user-switch-nosleep

Reason for revert: Part of DM+Platinum montiro as a likely culprit for b/257210412. Won't be submitted if proven otherwise.
Reverted Changes:
I90b1069de:Support multi users scenarios in Tapl
I706da86a3:Add PlatformTesting to dependency.
I605cd76c4:Move platform testing util to separate gradle modu...
I64b571dc4:Reduce multi users tests runtime

Change-Id: I6310efa59fe1755feb29bef28d890e684b7164c6
2022-11-03 10:08:13 +00:00
Benno Lin 8f669d20d7 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev 2022-11-03 06:42:19 +00:00
Winson Chung 38779f75da Add delay after installing dummy app
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
2022-11-03 03:47:01 +00:00
Sunny Goyal 39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Saumya Prakash ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00
Tony Wickham 6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Saumya Prakash 12731af30d Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I64c91c682009808690d696032ffadefc86dfbac9
2022-11-01 21:49:19 +00:00
Benno Lin 2e35f5152d Support multi users scenarios in Tapl
Tapl uses ContentProvider to get information from Launcher.
By default, it uses system user, who usually spwans the process
of instrumented tests, to send requests. Therefore, it can't get
the information of secondary user's Launcher process.

To solve the problem, the CL proposes to allow tests providing
UserInfo to Tapl, so that Tapl can use the right user's context
to get the test information. For more details, please refer to
go/multi-users-waiting-dd.

Test: https://android-build.googleplex.com/builds/abtd/run/L62400000957107134
Bug: 254402688
Change-Id: I90b1069de31e979138683049586bd87a7e7d813a
2022-11-01 14:36:24 +00:00
Sunny Goyal c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal d6e9c601d8 Adding screenrecord for debug failing test
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
2022-10-31 13:25:17 -07:00
Sebastian Franco 285b749bcf Wait in ReorderWidgets test for the workapce to load after changing it.
Fix: 252860608
Test: atest ReorderWidgets
Change-Id: Idf99188837a475d0327174e264ab1d23d646d75d
2022-10-27 14:42:19 -07:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Saumya Prakash 5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash 19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00
Saumya Prakash f1a4121784 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-10-26 20:31:44 +00:00
Sihua Ma 0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
2022-10-26 10:57:13 -07:00
Saumya Prakash 96cad794d7 Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I17628f1fa3869b575ec404a2a630a6927e3c1d14
2022-10-24 22:47:24 +00:00
Sunny Goyal d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
Hui Kang 4b87b9e521 Fix AddWidgetTest flake
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
2022-10-24 18:09:15 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
TreeHugger Robot 7c9144328a Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" into tm-qpr-dev 2022-10-17 22:58:51 +00:00
Hui Kang 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation"
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
2022-10-17 20:37:49 +00:00
vadimt 9853497f6c Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
Merged-In: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:48:46 +00:00
TreeHugger Robot 126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau 6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
Ling Wo 5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Sebastián Franco 9eeeeacf30 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev 2022-10-07 20:33:41 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets.
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
2022-09-29 11:12:31 +01:00
Sebastian Franco a44d255c8f Fix ReorderWidgets by removing faulty 4x4 cases
Fix: 242323136
Test: atest ReorderWidgets (the device has to be cf_x86_64_phone-userdebug)
Change-Id: Ic545409ecc20420be6c7377513c704822dbaf75e
2022-09-27 09:37:54 -05:00
Vadim Tryshev af91a58659 Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev 2022-09-22 16:25:06 +00:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
2022-09-21 10:56:04 -07:00
TreeHugger Robot 4298b36ef4 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev 2022-09-21 03:50:08 +00:00
vadimt f132bd7d3f Adding a comment for goHome()
Bug: 187761685
Test: presubmit
Change-Id: I2917daa90f22cc0da0169c287b02cc4cf37a8f4b
2022-09-19 19:08:43 -07:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Nicolo' Mazzucato d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Alex Chau 7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00