Commit Graph

3509 Commits

Author SHA1 Message Date
TreeHugger Robot 6c71f688b2 Merge "End recents animation when entering split select" into sc-v2-dev 2021-07-21 18:55:54 +00:00
Evan Rosky 2102a89ef6 Merge "Part of fixing Splashcreen cts tests" into sc-v2-dev 2021-07-21 18:01:09 +00:00
Alex Chau 2450adf56f Always use INSIDE_TO_OUTSIDE scope when swiping to home in tablets
- In tablets user is either in home screen or there is a taskbar on screen, so swipe to home will always touches the launcher

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: Id1b05708324302eb4b4c2d623ca9fe27090188fc
2021-07-21 14:52:01 +01:00
Lucas Dupin f82c463672 Merge "Revert "Apply depth even when surface is null"" into sc-dev am: 8d43e46261
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15341690

Change-Id: I9faebe44fd95ed907376e93a3729bbdc3634b5ec
2021-07-21 00:36:24 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Alex Chau 17e9b51e38 Merge "Wait for taskbar to become visible after closing launcher in tests" into sc-v2-dev 2021-07-20 22:59:31 +00:00
Evan Rosky 8fb6c2156b Part of fixing Splashcreen cts tests
This passes the launcher component name into the transition filter
so that it only matches if the launcher is the current home activity

Bug: 194112093
Test: atest SplashscreenTests
Change-Id: Ie2185545a5bef8b317e104b6ac878f6cde0d7350
2021-07-20 14:23:55 -07:00
Lucas Dupin ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Alex Chau cd791c5c9d Wait for taskbar to become visible after closing launcher in tests
- Taskbar takes some time to appear after closing launcher and launching test app

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: I714e35ee855660ac28bb214386f48ddbea0e834c
2021-07-20 21:11:08 +01:00
Alex Chau de6819a453 Check if running task is null in onPrepareGestureEndAnimation
- The crash happen when swiping to overview from home without any task in recents
- A simple null check fixes the issue

Fix: 194166137
Test: FallbackRecentsTest#goToOverviewFromHome
Change-Id: I9344a96a4a78fcfc88d2ad53e44ecd43b23114d5
2021-07-20 11:07:50 +01:00
Sunny Goyal be0b070019 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev am: c3f56d7628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331678

Change-Id: Icd63f65f52646e638c35229c6069455e9b9cd08e
2021-07-20 07:17:28 +00:00
Sunny Goyal c3f56d7628 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev 2021-07-20 07:03:51 +00:00
Tony Wickham 5eb1045cee Merge "Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash" into sc-v2-dev 2021-07-20 02:44:28 +00:00
TreeHugger Robot 0cc7f23e91 Merge "Continue loading visible task data when scrolling recents during anim to home" into sc-v2-dev 2021-07-20 00:17:47 +00:00
Sunny Goyal a1bed5428d Fixing quickswitch window not properly aligned in split-screen
Bug: 193992000
Test: Manual
Change-Id: Ic37cbc561a0299be1a1c05dfb17bd826c173100e
2021-07-19 17:10:12 -07:00
Tony Wickham 8a2c1cbc5a Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash
Also fix unstashing not working in 3P launchers by moving the unstash call from LauncherTaskbarUIController to TaskbarActivityContext

Test: long press taskbar background and stashed handle, watch it hint towards the new stashed/unstashed state respectively and then complete the animation when the long press is triggered
Fixes: 193926311
Fixes: 192926350
Change-Id: I0e538be9129bf5c600d07f360b8106d7077862ad
2021-07-19 14:09:33 -10:00
Tony Wickham a9f728e57b Continue loading visible task data when scrolling recents during anim to home
When we go from overview to home, we scroll to page 0 so that all tasks end up offscreen. However, since we are already in NORMAL state, we previously ignored loadVisibleTaskData() for the tasks as they scrolled by. Instead, we now continue loading task data while the scroller is unfinished.

Test: swipe to last recent task, swipe up to home, ensure thumbnails are still loaded as they scroll offscreen
Bug: 192522519
Change-Id: Iba770200fc5dbdfc91dccda9a6b9c891ab6c5e3d
2021-07-19 11:34:07 -10:00
TreeHugger Robot b0ef69e886 Merge "Wait for dismiss animation to finish before checking task count" into sc-v2-dev 2021-07-19 18:39:18 +00:00
Jonathan Miranda 70e8c0b022 Merge "Fix notification dot not always being up to date." into sc-dev am: 8e095ccb05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302020

Change-Id: I73d52b726f120029edc345a4154e36e734a6ea32
2021-07-19 18:00:49 +00:00
Jonathan Miranda 8e095ccb05 Merge "Fix notification dot not always being up to date." into sc-dev 2021-07-19 17:45:26 +00:00
Alex Chau 97cba26a20 Wait for dismiss animation to finish before checking task count
- See http://b/193440212#comment5, TaskView takes time after swipe gesture to finish dismiss animation, so wait for the animation to finish before checking task count

Bug: 193440212
Test: TaplTestsQuickstep#testOverview
Change-Id: I21397e68f384e956a7c9f2ee8a8161ac784b4d2e
2021-07-19 17:34:57 +01:00
Alex Chau 0841e93a34 Merge "Don't allow stashing in tests for now" into sc-v2-dev 2021-07-19 12:15:43 +00:00
Vinit Nayak f40262a617 End recents animation when entering split select
Allow starting split selection from live tile task.
Animation is still funky, but that's in a separate
CL altogether.

Fixes: 193212975
Test: Repro steps in bug no longer happen
Change-Id: I507628d3ef474936694dfbabfef5e0acf9f55b5d
2021-07-17 17:28:41 -07:00
Jon Miranda f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
Tony Wickham 9c84d7f3c3 Don't allow stashing in tests for now
Test: TaplTestsQuickstep#testOverviewActions (arbirarily)
Bug: 193521974
Change-Id: Ic2c5c5f9f37ed3f035ec932b4c96fb51598cf899
2021-07-16 12:27:40 -10:00
Thales Lima 2e15dde6b7 Merge "launcher: enable swipe down to open focused app" into sc-v2-dev 2021-07-16 13:23:32 +00:00
TreeHugger Robot c0fe7b1cc4 Merge "Revert "Move focused task to front when attaching RecentsView"" into sc-v2-dev 2021-07-16 12:54:51 +00:00
Alex Chau a6451fc640 Revert "Move focused task to front when attaching RecentsView"
This reverts commit 86ac825061.

Reason for revert: Causes crash in fallback recents

Bug: 192471181
Change-Id: I41d2b5c87259568f21e6417be3a6dea5dd1a0864
2021-07-16 12:54:34 +00:00
Thales Lima fb5ba04c6a launcher: enable swipe down to open focused app
Fixes 192437421
Test: manual testing

Change-Id: Ife8e53cf4d7542525736e7b93ac92f9a2ddcd068
2021-07-16 10:55:38 +00:00
TreeHugger Robot 935ca32b3c Merge "Fixing regression from animation not starting while in overview" into sc-dev am: f054bf5681
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15305446

Change-Id: I4c4162c0734b9a3feaaf25eadca47f11e1887b8a
2021-07-16 02:04:42 +00:00
Cyrus Boadway d7573be527 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev am: 66f1b57815
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15284080

Change-Id: I065ddc6049008b0a2db9767ab4d1e49e1537efac
2021-07-16 02:04:30 +00:00
TreeHugger Robot f054bf5681 Merge "Fixing regression from animation not starting while in overview" into sc-dev 2021-07-16 01:27:02 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Winson Chung 558b18eb12 Fixing regression from animation not starting while in overview
Bug: 193830420
Test: Open an app in overview, tap on a notification
Change-Id: Ifd9797dc40d9fffbf9603bca98fcb4a4119e0444
2021-07-15 16:17:51 -07:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Cyrus Boadway 66f1b57815 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev 2021-07-15 18:28:29 +00:00
Pat Manning d642b65137 Merge "Scale task rounded corners proportional to TaskView size." into sc-v2-dev 2021-07-15 17:39:31 +00:00
Pat Manning 8a6179bb7d Scale task rounded corners proportional to TaskView size.
Test: manual
Fix: 183936745
Change-Id: I2e2dd806826cba135d5a1e6ab9a5e80b8994d64d
2021-07-15 15:25:24 +00:00
Alex Chau 86ac825061 Move focused task to front when attaching RecentsView
- Only move focused task it's the first time attaching RecentsView
- Simpily remove and re-add focused task to move it to front

Bug: 192471181
Test: manual
Change-Id: I95b29c39328911beec7fd3d254f7a22be5e10cc1
2021-07-15 15:24:00 +01:00
Alex Chau 031373daa3 Reland "Snap to relative position to snappd task when dismissing"
This reland commit ba61b98fca accidentally reverted by http://ag/15162411

Bug: 188793333
Test: manual
Change-Id: Iae07a67d528aa80e8f87d37758244d0c46b61cf7
2021-07-15 15:12:34 +01:00
TreeHugger Robot 3df9de7cd0 Merge "Don't create gap between last task and clear all button" into sc-v2-dev 2021-07-15 10:54:47 +00:00
Hongwei Wang a35d7ec90e Merge "Use display cutout info in auto-enter-pip transition" into sc-dev 2021-07-14 23:52:42 +00:00
Hongwei Wang 3c4f60900d Merge "Use display cutout info in auto-enter-pip transition" into sc-v2-dev 2021-07-14 21:00:47 +00:00
Cyrus Boadway 1cf5527ae8 Keep transparent drawable for clipping outline during launch animation
During the widget-activity transition, the widget foreground loses its
clipping radius, if the clipping is determined by a drawable. We remove
the drawable through the animation.

For widgets where there is content being clipped by the background's
corener radius, this results in the widget window appearing square
through the entire animation, then snapping in rounded corners on
animation-complete.

To solve this, we leave a transparent clone of the drawable in the
original drawable's place, for the balance of the animation, providing
the outline for clipping.

Manual testing against 20 Google widgets showed no regression in
behaviour in other cases.

Bug: 193665108
Test: manual

Change-Id: I3db31e4634c8dd6b22a513a976386d396445ebc2
2021-07-14 19:21:16 +00:00
TreeHugger Robot 6224eaea29 Merge "Notify System UI about taskbar state" into sc-v2-dev 2021-07-14 10:59:26 +00:00
Thales Lima 03f0c67420 Merge "launcher: check if task still exists before leaving it in focus" into sc-v2-dev 2021-07-14 09:54:10 +00:00
Schneider Victor-tulias 38a6d462a2 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: Icb5e7cdca02fab3c6c165ab3c612ee943d97d947
2021-07-13 23:41:14 +00:00
Schneider Victor-tulias ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00