Commit Graph

12822 Commits

Author SHA1 Message Date
Jagrut Desai 8a9e7a1dfd Merge "Fix 3-button Navigation Switch Access Long press" into main 2024-11-15 00:05:08 +00:00
Treehugger Robot 90c4e9e62b Merge "Fix hotseat layout on device rotation." into main 2024-11-14 22:10:32 +00:00
Schneider Victor-tulias a8dd1a90df Merge "Update RecentsWindowSwipeHandler to animate home->overview properly" into main 2024-11-14 19:44:13 +00:00
Jagrut Desai 48793e1fcd Fix 3-button Navigation Switch Access Long press
This cl includes
 - Make long press of back navigation button of 3 button navigation mode behave just like short press.

Test: Manual
Bug: 315723734
Flag: EXEMPT bugfix
Change-Id: Id897c84dcb33f73174ea907c5ab5655d2ac5ba10
2024-11-14 11:27:14 -08:00
Treehugger Robot 1297e9eb98 Merge "Change fallback closing animators for Desktop Mode." into main 2024-11-14 18:23:01 +00:00
Liana Kazanova (xWF) 94f4f1bcf3 Merge "Revert "Listen to LauncherUserInfo config changes and hide/unhid..."" into main 2024-11-14 17:27:31 +00:00
Gustav Sennton 8e4cae1258 Change fallback closing animators for Desktop Mode.
The main changes are:
1. the amount to move the window horizontally (much less for Desktop
Mode), and
2. the timing for when the alpha animation is applied - we remove the
   25ms delay for freeform windows.

Bug: 378675987
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_exit_transitions
Change-Id: Ieeb6b827eee2e6314ea9c79213cdf401f48d3c85
2024-11-14 16:26:07 +00:00
Treehugger Robot 55c2aca78e Merge "Updates layout when overflow button and alt-tab are both triggered." into main 2024-11-14 16:13:54 +00:00
Pechetty Sravani (xWF) 41743bd0c7 Revert "Listen to LauncherUserInfo config changes and hide/unhid..."
Revert submission 29352757-update-usericoninfo

Reason for revert: <DroidMonitor created revert due to b/379000263. Will be verified through ABTD for standard investigation.>

Reverted changes: /q/submissionid:29352757-update-usericoninfo

Change-Id: I751536274ec9dcc4047bf9c76b3a5cab258da6e4
2024-11-14 06:11:15 +00:00
mpodolian b563271ff5 Fix hotseat layout on device rotation.
When rotating the device, a few issues were causing improper hotseat
layout:

- BubbleBarController receives an initial configuration before the UI
controller is set.
- The updated device profile, including the correct `isQsbInline` value,
arrives after all controllers are recreated, and the UI controller is
not informed of the device profile update.

Added logic to carry over the bubble bar bubble visibility state to the
new UI controller. Included a call to notify the UI controller of the
device profile update.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Have a Tangor device in landscape orientation with the
bubble bar. Rotate the device - observe hotseat and QSB are reduced in
width. Dismiss the bubble bar - observe hotseat and QSB extends to the
full width.
video: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e8e1ZFRQlbHQtUlCXVJbFJ

Change-Id: If180b01c8cdb329cd45d084af63a986c08cf65a1
2024-11-13 17:41:17 -08:00
Olivier Nshimiye 0b2cb4961c Merge "Listen to LauncherUserInfo config changes and hide/unhide private space entrypoint accordingly" into main 2024-11-14 00:03:34 +00:00
Treehugger Robot 85f34826f1 Merge "4b/ Migrate TopTaskTracker to use visible running tasks from Shell" into main 2024-11-13 23:47:27 +00:00
Olivier Nshimiye 39dee43e12 Listen to LauncherUserInfo config changes and hide/unhide private space
entrypoint accordingly

Flag: android.multiuser.add_launcher_user_config

Bug: 346553745
Test: Manual - verified on device
Test: atest LauncherAppsTests

Change-Id: I202c4c76af4f96d5b3226daffcfebc2f9b9703b1
2024-11-13 21:35:05 +00:00
Brandon Dayauon 1d9b09c2e8 Merge "Update height of predictionRow + 4dp to be aligned with NL app suggestions height." into main 2024-11-13 21:00:45 +00:00
Wen-Chien Wang ca95004403 Updates layout when overflow button and alt-tab are both triggered.
Before this cl, the KQS view is closed and reopened when the
overflow button and alt-tab key are triggered one after the other.
This cl changes the behavior so that instead of reopening, the
list of task is updated and the KQS container layout is toggled
between "wrap content" and "match parent".

Bug: 368119679
Test: open KQS via taskbar and observe the layout change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I05ea4c66727daa206ff1d7906500dc8f9cc81982
2024-11-13 20:48:07 +00:00
Artsiom Mitrokhin f0b80dadb2 Merge "Implement app icons <-> leave behind animation" into main 2024-11-13 19:42:54 +00:00
Treehugger Robot a8440279bf Merge "Account for bubble bar bounds for taskbar overflow" into main 2024-11-13 19:23:22 +00:00
Schneider Victor-Tulias 8451f0fb1e Update RecentsWindowSwipeHandler to animate home->overview properly
Update RecentsWindowSwipeHandler to animate home alpha properly

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366022874
Test: Attempted gesture from home and launched app

Change-Id: Idf4ed071a843a129f1d39caa59e468f6c88e9e38
2024-11-13 13:12:09 -05:00
Liran Binyamin 12d34f8e2a Merge "Make the flyout color animation smooth" into main 2024-11-13 16:14:07 +00:00
Treehugger Robot be17fb8a63 Merge "Revert "Fix jank resulting from TaskView resizing"" into main 2024-11-13 12:25:45 +00:00
Vinay Joglekar d23234576d Merge "Fix NPE when user goes into maps navigation mode and tries to split app." into main 2024-11-13 12:05:46 +00:00
Alex Chau 17d81a3611 Revert "Fix jank resulting from TaskView resizing"
This reverts commit 5a01f588be.

Reason for revert: We don't want this behavior anymore

Bug: 343882478
Fix: 373319262
Change-Id: I7b16a229cbe303191591ff695f78a2acb831a3e8
2024-11-13 10:43:15 +00:00
Winson Chung dde53a10e3 4b/ Migrate TopTaskTracker to use visible running tasks from Shell
- When enable_shell_top_task_tracking is enabled, use the shell
  provided signals to keep an up-to-date running (visible) task list
  on the Launcher side, instead of managing the list via to-front
  signals from Core via TaskStackListener.  In doing so, we also
  update CachedTaskInfo to use this visible task list in preparation
  for future refactoring to use the GroupedTaskInfos directly instead.

Bug: 346588978
Flag: EXEMPT adding new flag enable_shell_top_task_tracking
Test: Build SystemUI & Launcher
Test: atest WMShellUnitTests
Change-Id: I16d515243760a17258a727e2502e35387da87589
2024-11-13 07:05:43 +00:00
Mykola Podolian 40cb4bf335 Merge "Fixed bubble bar size for the 3 buttons navigation mode." into main 2024-11-13 00:25:36 +00:00
vinayjoglekar 4c3471ff44 Fix NPE when user goes into maps navigation mode and tries to split app.
OnDestroy is called in this scenario and mContainer is set to null. When I added this code I assumed this will be non null always.

Test: Manual : open maps->start navigation-> overview->split
Fix: 376409147
Flag: EXEMPT bugfix
Change-Id: I96a47b24beb5b3d343aae0e715c0b3efabdebe08
2024-11-12 20:06:29 +00:00
Artsiom Mitrokhin d370b4d5f4 Implement app icons <-> leave behind animation
Bug: 376281549
Flag: com.android.launcher3.taskbar_overflow
Test: manual, press the overflow button, dismiss KQS
Change-Id: Ifae1455785d028f58072068f25e52a5e58ed1c72
2024-11-12 14:56:21 -05:00
Brandon Dayauon 1c7122ff9a Update height of predictionRow + 4dp to be aligned with NL app suggestions height.
spec: https://screenshot.googleplex.com/9VsQXxmsuZvoj7Y
Add 4dp to the existing height when using two lines. Need to do this for prediction row as well so that
animation is smooth and doesn't show jumpiness.

bug: 378472318
Test: photos:
before: https://screenshot.googleplex.com/7F8FNdnrngpuSUe
after: https://screenshot.googleplex.com/63vttsfptSqwE7c
Flag: NONE increasing height
Change-Id: I2076160efe3596cc8673d32b5066ec2103f71eb0
2024-11-12 11:30:01 -08:00
Toni Barzic 28ebd1bacd Account for bubble bar bounds for taskbar overflow
When caculating number of icons to show in taskbar, account for bubble
bar size (the max size when in collapsed state) when bubble bar has
bubbles (even if the bubble bar is stashed). Note that the bubble bar
visibility may change, so max number of icons in the taskbar may change
during the taskbar view lieftime. TaskbarViewController already had a
method called when the bubble bar visibility changed - adapt it to also
reclaculate max number of icons to show in the taskbar, and update the
list of icons shown in the UI if necessary (if the change in the bubble
bar visibility would also cause a change in number of icons shown in the
taskbar).

Bug: 368119679
Test: Launch enough apps for taskbar to enter overflow, open an app that
supports bubbles, and trigger 2 or more bubbles so bubble bar shows up.
Verify that the buble bar does not overlap with taskbar bounds, both
in transient and persistent taskbar. Remove bubbles, and verify the
taskbar bounds expand, allowing more icons to be shown.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: Ifed4e5e5dd64df5256090f5ba55f24203c09e839
2024-11-12 18:40:40 +00:00
Ats Jenk d3a4f9f721 Merge "Fix bubble bar position on recreate" into main 2024-11-12 18:11:39 +00:00
Liran Binyamin 09403e7d9a Make the flyout color animation smooth
This change updates the flyout animation interpolator to an
emphasized curve and updates the color animation so that it completes
within a shorter period of time. Speeding up the color animation
makes the color transformation smooth.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 378077265
Test: atest BubbleBarViewAnimatorTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Idd38fc71543f629aeb568d72386a9b9def51c307
2024-11-12 10:49:09 -05:00
Alex Chau 6734784b72 Merge "Fix split animation with small number of tasks only" into main 2024-11-12 15:30:06 +00:00
Treehugger Robot 9b44959f68 Merge "Move logic onto default dispatcher. Clearing main - stop performance bug" into main 2024-11-12 14:24:21 +00:00
Treehugger Robot 48770752e2 Merge "Register transitions for Desktop app launch + minimize animations" into main 2024-11-12 13:55:29 +00:00
Treehugger Robot cdbc828af6 Merge "Create new TTVData onAttachedToWindow for new TTVModel." into main 2024-11-12 13:17:20 +00:00
Gustav Sennton 39c006e792 Register transitions for Desktop app launch + minimize animations
In other CLs we pass specific RemoteTransitions to Shell for app
launches and unminimize actions. Those CLs cover Launcher actions like
the keyboard alt-tab shortcut, or launching an app from Taskbar.
This CL covers launches that don't originate from Launcher, e.g.
launches through intents.

Test: DesktopAppLaunchTransitionManagerTest
Bug: 369966416
Flag: com.android.window.flags.enable_desktop_app_launch_transitions
Change-Id: I82fd72f870c1e38efe5a8ce533a60f282c10203c
2024-11-12 09:16:34 +00:00
Ats Jenk 5ad93d97fa Fix bubble bar position on recreate
When device is rotated, taskbar goes through recreate flow.
LauncherTaskbarUIController restores the state for taskbar in-app
display multiprop.
Ensure that bubble bar is positioned within the taskbar bounds.

The multiprop values in LauncherTaskbarUIController for taskbar in-app
display progress can be restored from shared state when the device
rotates. But this means when we receive updates to various indexes, the
progress for that index may not match what is the actual value of the
multiprop. As it relies on the max function.
Make sure we pass along the actual value for in-app display progress
when updating bubble bar and not the value for the index that got
updated.
Also make sure bubble bar translation always updates when updates are
received as this is the only path for bubble bar to receive updates.

Make sure that when we do override bubble bar translation using in-app
display progress, any existing animation for bubble bar translation y is
cancelled. Otherwise the unlock animation was animating the bubble bar
to the incorrect position after unlock.

Bug: 377621110
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest PersistentBubbleStashControllerTest
Test: manual, have bubble bar with 3 button nav, swipe to -1 and rotate
  the device, observe that bubble bar is in the correct position
Test: manual, repeat same test with all apps open, observe that bubble
  bar has correct position after rotation
Test: manual, with gesture navigation, observe that bubble bar has
  correct position on home screen, -1 and all apps after rotation
Change-Id: I66138e003c4b371299e40558fdadc142fbdbbcd5
2024-11-11 23:21:30 -08:00
mpodolian 5f7785a4d4 Fixed bubble bar size for the 3 buttons navigation mode.
Change logic to updated bubble properties even we do not have any
bubbles.

Fixes: 376141825
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3 button navigation mode, rotate the device.
Change-Id: Ide6df73b3b24c628a0f9e6db6582d4e2ddadfc04
2024-11-11 18:05:48 -08:00
Liran Binyamin 4785a5e24e Merge "Animate the bubble notification in overview" into main 2024-11-11 23:08:03 +00:00
Treehugger Robot d89f2f14f7 Merge "Fix some tests in TaskbarScrimViewController for bubble bar" into main 2024-11-11 21:03:49 +00:00
Mady Mellor 1d1e50d33b Fix some tests in TaskbarScrimViewController for bubble bar
When taskbar is in pinned mode with bubble bar expanded, in some
scenarios, we hide taskbar contents (i.e. when bubbles overlaps with
taskbar) and the scrim still shows.

One of the existing tests in TaskbarScrimViewController checks that
the scrim would be 0 when taskbar is not visible, however, in the
bubble bar case this isn't always true... I think there probably are
cases where taskbar isn't visible for other reasons (e.g. shade is
pulled down, but there are other tests specific to that). I'm
setting this test to only run when bubble bar isn't running, because
in that case bubbles never impacts taskbar visibility.

I added a test case to ensure scrim is hidden when pinned BUT bubble
bar is on home -- in this case we shouldn't show the scrim.

When adding the enableFlag/disableFlag I saw some NPEs in onDestroy
methods of some controllers so I protect against those as well.

Flag: EXEMPT test change
Test: atest NexusLauncherTest:TaskbarScrimViewControllerTest
      atest NexusLauncherRoboTest:TaskbarScrimViewControllerTest
Bug: 377764181
Change-Id: I71001222aa8a4393b341dd2b43a4b2e46e617a70
2024-11-11 11:03:58 -08:00
Ats Jenk e3e3bc1f4e Merge "Send bubble bar location update source to shell" into main 2024-11-11 17:04:40 +00:00
Alex Chau 2c7004164d Fix split animation with small number of tasks only
- Extract newClearAllShortTotalWidthTranslation out from the last grid task visible case, to use it to predict new clearAllShortTotalWidthTranslation after focus task is staged, then use newClearAllShortTotalWidthTranslation to compensate getScrollForPage of grid tasks not on top-right corner for tasks close to clearAllButton
- Applied ag/28945919's fix to dismiss animation as well
- Fixed next focused task translation using wrong sign in RTL

Fix: 378403770
Test: With LTR/RTL, test focused task staging / dismiss with 1-6 tasks, dismiss grid end tasks with 1-6 tasks
Flag: EXEMPT BUG_FIX
Change-Id: Ie5b597c4318c5de84377fde50090491e78581af9
2024-11-11 15:12:28 +00:00
Uwais Ashraf 36e0c2521a Move logic onto default dispatcher. Clearing main - stop performance bug
Bug: 377437341
Fix: 374061907
Fix: 357542211
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking slowed down videos of performance
Change-Id: Idab5bd0728395413159a7aafbba8faec62e520a3
2024-11-11 13:39:46 +00:00
Treehugger Robot 6cd51b8344 Merge "Only add accessibility actions in Overview if not in select mode" into main 2024-11-11 11:34:16 +00:00
samcackett 3a8a36f8fa Only add accessibility actions in Overview if not in select mode
When modalness is >0, the user is in select mode and the icon menu is
hidden, therefore Talkback shouldn't pick it up.

Fix: 320203664
Flag: NONE bugfix
Test: Manual. Turn Talkback on, navigate to Overview, enter select mode,
 select the whole TaskView, Talkback shouldn't have any accessibility
 actions to execute.
Change-Id: I83dffce60f42cc32d83c499dfb08ddf97888f527
2024-11-11 09:55:41 +00:00
Johannes Gallmann f47df1f60a Merge "Use FlingOnBackAnimationCallback for predictive back" into main 2024-11-11 08:29:47 +00:00
Uwais Ashraf 881b97b3b5 Create new TTVData onAttachedToWindow for new TTVModel.
Fix: 378295588
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking instance ids, splash fucntionality
Change-Id: If02c3c152aad651cb2497730310715e0812e587f
2024-11-10 07:43:22 +00:00
vinayjoglekar 0cceb24288 Animation issue when splitting task from taskbar which is in DW
When app is in DesktopTask being split, we need to bring tasks after last desktop task to correct position during split animation. Solution is to add additional primary translation from current desktopview to first non desktopview.

Refactored how primary translation is being calculated.

Test: Manual, split app from taskbar which is in desktop window
Fix: 377230397
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ic76b0e7d9a627158e5d521ed40f17279130a974a
2024-11-09 10:55:46 +00:00
Sihua Ma 73487c1475 Merge "Resetting workspace alpha when the animation is cancelled" into main 2024-11-09 01:50:27 +00:00
Sihua Ma 424b8dee5e Resetting workspace alpha when the animation is cancelled
Bug: 364465567
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I0dcc62a10ca96670c5ed794001c58fd319e36854
2024-11-08 22:51:29 +00:00