Commit Graph

8003 Commits

Author SHA1 Message Date
Tony 89126653cd Don't intercept above shelf progress if still animating
When you swipe up to overview from home, we should allow touches on
recents even if the overshoot animation isn't finished. If the
touch is below the all apps progress, we continue to intercept to
allow for double swipe up.

Bug: 80093992
Change-Id: Ifdca61e7cfc1f7a713c067596cc0c1bd3154b44e
2018-06-07 20:48:04 -07:00
Android Build Merger (Role) 34838cf551 [automerger] Overshoot when flinging up from an app am: b45444b250
Change-Id: I25d7621d3b60b307d4eb7c466eafc893e78b7ea0
2018-06-06 23:20:59 +00:00
Tony Wickham b45444b250 Overshoot when flinging up from an app
- Use OvershootInterpolator based on velocity (consistent with swiping up
  from home)
- Scale down recents as well, to be consistent with adjacent pages scaling
  up when you launch a task

Bug: 109709720
Change-Id: Ie47309058ccf673a4b86c40c843c415beb2d8dc7
2018-06-06 23:20:58 +00:00
TreeHugger Robot 108801840b Merge "Revert "Set mState = mCurrentStableState in onAnimationCancel"" into ub-launcher3-edmonton 2018-06-06 18:51:46 +00:00
Android Build Merger (Role) 69652337ef [automerger] Revert "Set mState = mCurrentStableState in onAnimationCancel" am: d6692cedff
Change-Id: Ic38e6db9bb62e04d017db93e906be2be02a33294
2018-06-06 18:48:00 +00:00
Sunny Goyal d6692cedff Revert "Set mState = mCurrentStableState in onAnimationCancel"
This reverts commit 8935d9515c.

Reason for revert:
Bug: 109814458
Bug: 79935289

Change-Id: I33e4933a68060b6055ad7af8e45cffceec14880d
2018-06-06 18:47:59 +00:00
Winson Chung 0abc19ae0d Merge "Hides the keyboard when qsb loses focus in All apps" into ub-launcher3-edmonton-polish 2018-06-06 00:17:41 +00:00
TreeHugger Robot af19ffff62 Merge "Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions" into ub-launcher3-edmonton 2018-06-05 23:57:08 +00:00
TreeHugger Robot eb424209ff Merge changes from topic "am-6756c3c9-4e27-48e1-8ae4-b6d5cdd77952" into ub-launcher3-edmonton-polish
* changes:
  [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a
  Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions
2018-06-05 23:57:08 +00:00
TreeHugger Robot 25c7e81ee5 Merge "Fix wrong labeling of app launch session type (HOME vs OVERVIEW)" into ub-launcher3-edmonton-polish 2018-06-05 23:55:46 +00:00
Android Build Merger (Role) 7ef92daaf5 [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a
Change-Id: Ic88f7803c9a938f20f002f7d8eaf8df33e0f578f
2018-06-05 23:48:01 +00:00
Sunny Goyal 1c63c72c1a Adding a pending invisibility flag, which is used to indicate that the launcher
is not really invisible, but consider it invisible for window transitions

When a recents animation is cancelled, the callback can be received before or after the
wallpaper animation. To ensure that wallpaper animaiton runs properly, we keep the launcher
forceInvisible=true, only for that particular animaiton and false everywhere

Bug: 109735443
Change-Id: I5b22cc3327c8cd53a836d10e09fc88ae103becfc
2018-06-05 16:47:54 -07:00
Hyunyoung Song 4bd472550c Fix wrong labeling of app launch session type (HOME vs OVERVIEW)
Context: onResetOverview callback should be called the moment launcher state
exits from OVERVIEW.
More context: When user drag and drop from overview, and happens to launch
an app immediately after dropping the icon before animation finishes,
that app launch is labeled as OVERVIEW and not HOME.

Bug: 109747805
Change-Id: I24dc8681d6c51dfd2043fe71a1a81d6e96027ef4
2018-06-05 16:45:27 -07:00
Mehdi Alizadeh 25b4dfee29 Hides the keyboard when qsb loses focus in All apps
Bug: 80190879
Change-Id: I88da6ef7a88b9dd4fce06e4f2b4592ee6ce39195
2018-06-05 16:22:35 -07:00
Android Build Merger (Role) b72f69d073 [automerger] Fixing controller state is not properly cleared when the animaiton is cancelled. am: 87a6ad18cd
Change-Id: If50ce87da192ed0339d5b9faa1983bfc4174b647
2018-06-05 23:07:41 +00:00
Sunny Goyal 87a6ad18cd Fixing controller state is not properly cleared when the animaiton is cancelled.
This was leading to a pending animation running while the state had changes,
leaving user in an inconsistent state.

Various atomic animation fixes
> Ensuring that there is only one success listener on atomic animation, so that atomic
  controller is created only once and to the final mToState
> If atomic controller is already running, skip animating the atomic conmonenets as
  part of main animaiton
> Cancel atomic controller if it is going to a different state

Bug: 80549582
Bug: 109583168
Change-Id: Ie7a032e0fa73b1f1c2ef53055c08d16444f0385e
2018-06-05 16:07:29 -07:00
Android Build Merger (Role) 7c8ffd1d3b [automerger] Do not change state in the middle of quickstep gesture am: d936f6a5e9
Change-Id: I6297797bb034ad8bd2600c8abb5a959ee0e6aa32
2018-06-05 17:12:30 +00:00
Sunny Goyal d936f6a5e9 Do not change state in the middle of quickstep gesture
Changing states causing quickscrub to get cancelled and recentsView to
get reset to page 0, causing an abrupt jump.

Bug: 80537625
Bug: 80497058
Change-Id: I19cfe4380bbff15734b9d90dc31596904da27483
2018-06-05 10:12:23 -07:00
TreeHugger Robot 6e680f9bf6 Merge "Deleting invalid icons when an app is restored" into ub-launcher3-edmonton-polish 2018-06-04 23:54:10 +00:00
Sunny Goyal f46779fe01 Do not run StateHandler code while holding the lock
Deadlock:
Main thread:
  InternalStateHandler.run() =>
  	 LauncherFrameDrawn =>
  	 Switch MotionEventQueue to Main thread =>
  	 Try to acquire MotionEventQueue lock while holding InternalStateHandler lock

Remote UI thread
  Recents Animation cancel on MotionEventQueue =>
     Cancel SwipeHandler =>
     Clear previously registered InternalStateHandler =>
     Try to acquire InternalStateHandler lock while holding MotionEventQueue lock

Bug: 80536505
Change-Id: I75e522edea2a76f8bc90e8abc2a174583cc709c4
2018-05-31 14:12:52 -07:00
TreeHugger Robot f4392dbf5a Merge "Some launcher3 fixes so that it compiles with different configurations" into ub-launcher3-edmonton 2018-05-31 16:42:56 +00:00
Sunny Goyal d0f43ceba7 Some launcher3 fixes so that it compiles with different configurations
Bug: 79996542
Change-Id: I4267aeb8f5b0714415970c63453049ff41466644
2018-05-30 18:15:21 -07:00
Sunny Goyal 337fcb7983 Theme updates for dark text:
> Using white scrim on adjescent tiles in overview
> Using a ligher scrim in dark-theme+dark-text

Bug: 80253867
Change-Id: I3f257d3addaca8bc5970a61722f5ae0e7af89382
2018-05-30 15:53:10 -07:00
Sunny Goyal e48fe1095d Deleting invalid icons when an app is restored
When a app is restored, it may not be in exactly the same state as it was when backed up.
Some components might be missing, and some shortcuts may be disabled or unavailable

Bug: 63525806
Change-Id: I09e6c0e9a9d2c1e8ccd73430f94bd065bdf2718e
2018-05-30 15:23:09 -07:00
Tony 67f9cad75a Fix animation not playing when going home while another animation is playing
When going to a new state, we cancel any currently playing animation. When
canceling the animation, we reset mState = mCurrentStableState. Thus, when
determining the duration of the new animation, we have both state == NORMAL
and mState == NORMAL, leading to a duration of 0 and therefore no animation.
Storing the fromState before canceling/resetting fixes the issue.

Change-Id: I92332deae8058c4dd41212fe7f749955ede28b1c
2018-05-29 17:33:16 -07:00
Tony Wickham 0512a6de57 Merge "Unhide badge when popup closes without animation" into ub-launcher3-edmonton 2018-05-29 22:44:09 +00:00
Tony Wickham 8935d9515c Set mState = mCurrentStableState in onAnimationCancel
mState is set when the transition starts toward that state even if it is
never reached. If the animation is canceled, therefore, we should reset
mState = mCurrentStableState since that is the state we came from.

For instance, when swiping up from overview, mState = ALL_APPS, but when
swiping back down we cancel that animation and create the task launch
animation. When creating the task launch animation, we reapplyState(),
which, before this change, was still ALL_APPS instead of OVERVIEW.

Bug: 79935289
Change-Id: I59c5799e92350747e4ef1d99a80ba678a2ce7b98
2018-05-29 21:58:52 +00:00
Tony bb9378aead Unhide badge when popup closes without animation
Bug: 80379412
Change-Id: I7d6c1b67a07747078b43b17612d8c67a46c8cc0e
2018-05-29 14:44:41 -07:00
Sunny Goyal 9bb8ffb5e3 Various quickscrub fixes
> Fixing PagedView resetting the currentPage, if scrollToPage was called before first layout
  This causes quickscrub to jump back to the current task if launcher activity was dead.
> Fixing missing callbacks in DeferredTouchConsumer causing missed quick scrub flings
> Sending the resents animation callbacks on the motion queue thread, to avoid synchronization
  issues with sysui callbacks.
> Waiting until the recents animation is received before starting the scale down animation
> Calculating the offset for quickscrub statically incase launcher activity was dead

Bug: 80214390
Change-Id: I1b7d00b7b266655a92fcd6239f25ba191655150f
2018-05-29 12:17:20 -07:00
TreeHugger Robot 03aaced252 Merge "Fix clipping of adaptive icons Bug:62372639" into ub-launcher3-edmonton 2018-05-29 17:38:28 +00:00
Hyunyoung Song 49df554dc2 Fix clipping of adaptive icons
Bug:62372639

Context: only noticeable on large form factor AND Large display setting
Ceiling operation is needed to calculate offset of the drawing.

Change-Id: I7c77fa53f0811990b8cfdc3a12e2b43eb4d2d73e
2018-05-25 16:30:23 -07:00
Vadim Tryshev 5c17a390d2 Merge "Reporting range of visible tasks" into ub-launcher3-edmonton 2018-05-25 19:55:39 +00:00
Vadim Tryshev 528b9e0615 Reporting range of visible tasks
Also fixes task position being incorrectly reported specifically for
swipe events due to using stale getCurrentPage().

Bug: 72222505
Test: Manual
Change-Id: Ic79b67f8a6ffbfabc397b411b14afc309405197e
2018-05-25 12:24:40 -07:00
Sunny Goyal 4308bd232e Merge "Fixing launcher going to a different state when dragging an icon from different activity" into ub-launcher3-edmonton 2018-05-25 19:17:28 +00:00
Sunny Goyal 4dcda06542 Fixing launcher going to a different state when dragging an icon from different activity
Bug: 80191074
Change-Id: I45ea646dc2bd21627e8b724dac9c9fc23c18797d
2018-05-25 11:56:53 -07:00
Sunny Goyal db9f86a472 Accounting for view translation when calculating the focus location
Bug: 80160107
Change-Id: Ibb0cb82c33c141bb3abf9b7576be4253630cb8c5
2018-05-25 17:52:49 +00:00
Jon Miranda 012d39a0e9 Fix crash caused by removing update listener in update listener.
Bug: 80236772
Test: Fling all apps open, and catch it before it reaches the top
Change-Id: I082a26b97afb7dbc162758ff9654e4a3707f9d7e
2018-05-25 10:41:16 -07:00
Jon Miranda 31942e788b Fix bug where icon 'jumps' on long press.
Bug: 76155869
Change-Id: I739b00564b0ebe00b3aff326b3c1d62deea9d1d3
2018-05-25 01:49:37 +00:00
TreeHugger Robot 159d6949a1 Merge "Fix prediction tip shows when user attempts but does not swipe up all the way to All Apps when quickstep is disabled." into ub-launcher3-edmonton 2018-05-25 00:49:23 +00:00
Tracy Zhou 5d89e1be98 Fix prediction tip shows when user attempts but does not swipe up all the way to All Apps when quickstep is disabled.
Bug: 80268964
Test: Manual test
Change-Id: I9b0620d57ccd466392c1db4c4899da3368a854db
2018-05-24 17:24:23 -07:00
TreeHugger Robot a252a07562 Merge "Adding support for dark text on dark theme" into ub-launcher3-edmonton 2018-05-24 21:09:16 +00:00
Sunny Goyal a6afdffbbd Adding support for dark text on dark theme
Bug: 80253867
Change-Id: Ib81a2fe884f68cd2dd4af1e573bd8c836f374f16
2018-05-24 13:50:27 -07:00
Vadim Tryshev 1b0c5032d1 Fixing keyboard navigation when Overview list is empty
Bug: 80155387
Change-Id: Ife86fe4b718ef01291a04b21020155110d75fa7b
Testing: Manual
2018-05-24 13:06:18 -07:00
TreeHugger Robot 1ab656460b Merge "Removing discovery bouncer from accessibility" into ub-launcher3-edmonton 2018-05-24 00:03:17 +00:00
Vadim Tryshev 17839d5f62 Removing discovery bouncer from accessibility
It was obstructing views under it.

Solves both Talkback and Switch Access issues.

Bug: 80192025
Test: Manual
Change-Id: Ia7fad91e1fcb857afbf68f879550c670279cee68
2018-05-23 16:51:41 -07:00
Sunny Goyal 7f28fd55ff Increasing the overview size while in QuickScrub mode
Bug: 80139193
Change-Id: I19ea05d3cc083628364651e9d9f581fe1aaaeaaa
2018-05-23 15:55:51 -07:00
Sunny Goyal d5377ca4b3 Merge "Remove custom focus logic" into ub-launcher3-edmonton 2018-05-23 21:29:41 +00:00
Tony Wickham 65e8311222 Merge "Only log swipe interaction on swipe end" into ub-launcher3-edmonton 2018-05-23 20:51:40 +00:00
Tony Wickham 422e1f9c69 Only log swipe interaction on swipe end
Previously we were logging new states as we swipe past them; now we just
log the start and end states when lifting your finger.

Bug: 80102083
Change-Id: Icec6c3dab1441023a3cdcadb7b56ecef8313cb8c
2018-05-23 13:20:10 -07:00
TreeHugger Robot 4e057b5f97 Merge "Log the parent of the PREDICTION container type (ALLAPPS OR TASKSWITCHER) Bug: 79423536" into ub-launcher3-edmonton 2018-05-23 20:16:15 +00:00