Commit Graph

14330 Commits

Author SHA1 Message Date
Treehugger Robot 8899e43c8a Merge "Turn on debug logging for RemoteActionShortcut / Pause App Shortcut" into main 2025-04-07 09:05:49 -07:00
Alex Chau b9b817f3c7 Merge "Taskbar nav per-display" into main 2025-04-07 08:31:13 -07:00
Alex Chau 68439fefa4 Merge "Filter tasks by display id" into main 2025-04-07 05:09:49 -07:00
Alex Chau 7dce980f9a Merge "Refactor RotationTouchHelper to be per-display" into main 2025-04-07 04:27:26 -07:00
Treehugger Robot 5dbac00441 Merge "Clear overlay ref to thumbnail on reset" into main 2025-04-07 02:56:13 -07:00
Uwais Ashraf ffb1c80a7c Clear overlay ref to thumbnail on reset
Bug: 402703010
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking heap dumps
Test: Presubmit tests
Test: ABTD runs - see comments
Change-Id: Ia42513a9773ae9000cf5aee702bb84dadeae816f
2025-04-05 12:41:04 +00:00
Treehugger Robot 53aff62dbf Merge "[Memory Leak] Fix leak of KeyboardQuickSwitchView and TaskbarOverlayDragLayer by SlideInRemoteTransition" into main 2025-04-04 18:02:08 -07:00
Treehugger Robot ab1cfa9740 Merge "Change Taskbar and Folder radius based on selected shape" into main 2025-04-04 17:10:32 -07:00
Charlie Anderson abd133c04a Turn on debug logging for RemoteActionShortcut / Pause App Shortcut
Bug: 407836418
Test: presubmit
Flag: EXEMPT just logging
Change-Id: I90973f34faf66cffe000645089a79de5f9e6b73c
2025-04-04 16:02:39 -07:00
Eghosa Ewansiha-Vlachavas 6665030709 Merge "[2/n] Isolate desktop entry point disabling from window exemptions" into main 2025-04-04 15:45:16 -07:00
Charlie Anderson 95ad50be6e Change Taskbar and Folder radius based on selected shape
Bug: 387543368
Bug: 408059321
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: stashing / unstashing taskbar
Change-Id: Ic5483a9dc0ecea47615a9add4b24772ceb97d982
2025-04-04 14:39:39 -07:00
Fengjiang Li 535ecc525e [Memory Leak] Fix leak of KeyboardQuickSwitchView and TaskbarOverlayDragLayer by SlideInRemoteTransition
By the time SlideInRemoteTransition is started, KeyboardQuickSwitchView is already detached from window, causing
1. Rejection from InteractionJankMonitor to mointor jank
2. Leak of KeyboardQuickSwitchView and its parent view TaskbarOverlayDragLayer

We should simply remove jank-monitoring of CUJ_LAUNCHER_KEYBOARD_QUICK_SWITCH_APP_LAUNCH as it's doing no-op and causing leak

Fix: 407032864
Test: manual - verify leak fixed locally
Flag: NONE - released code
Change-Id: I8562d8da1c4f0ec1b88e7ffa8bbb8da75ee57548
2025-04-04 11:56:38 -07:00
Sukesh Ram 0afdd7781c [CD Taskbar] Fix rendering taskbar on CD after reboot
- Use mWindowContexts instead of mTaskbars to recreate taskbars as
  taskbars are not always created - example when user is locked,
  taskbars are not created until after user unlocks.
- Create device profiles for connected displays when user unlocks in
  case those weren't created when display was added.

Bug: 405327859
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: I8d63a7f2b3d8ab95b246010c2fc6295cae22a343
2025-04-04 11:30:02 -07:00
Sukesh Ram 3351985052 Merge "[CD Taskbar] Cache displayId & Consolidate DisplayController methods" into main 2025-04-04 10:57:29 -07:00
Treehugger Robot 1d8172f685 Merge "Remove haptics on dismiss animation end." into main 2025-04-04 09:52:12 -07:00
Pat Manning b3098b122b Remove haptics on dismiss animation end.
Add fling haptic when passing dismiss threshold. Currently exists only when dragging.

Fix: 406788127
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I3db0a3a4849f12407911d53702e63a197504a98f
2025-04-04 15:24:37 +01:00
Will Osborn d8be141eed Filter tasks by display id
Test: tested locally on tablet
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402363691
Change-Id: I5148f2ef09dde4a07d4b34f1752f12249bba69b6
2025-04-04 14:08:20 +00:00
Will Osborn d515f1a3ed Refactor RotationTouchHelper to be per-display
Bug: 398195845
Test: locally tested + ran unit tests
Flag: EXEMPT refactor
Change-Id: I2a5ae4171fd211650624291574f84f8bff8b8825
2025-04-04 12:59:34 +00:00
Will Osborn 90ac376da8 Taskbar nav per-display
Test: local + unit
Bug: 402364626
Flag: com.android.launcher3.enable_overview_on_connected_displays

Change-Id: I9643367e19b107a2811e93db4e3dd32e9355da71
2025-04-04 10:32:46 +00:00
Alex Chau b24e17db10 Add OverviewReleaseFlags to control combination of Overview flags
- This avoids flags from being enabled in Trunkfood partrial unless the dependency is also enabled

Bug: 408178115
Test: build and smoke test
Flag: EXEMPT flag only

Change-Id: Iccf9a9368383ab14a9abf7a1198c8a0c372b103f
2025-04-04 10:38:32 +01:00
Sukesh Ram 5da5e1c9e1 [CD Taskbar] Cache displayId & Consolidate DisplayController methods
TaskbarActivityContext should store displayId and return a cached value to avoid unnessary binder calls.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 406019031
Test: m
Change-Id: I808352e7098ee731abc7362b2f8f1b7a675457f9
2025-04-03 23:40:45 -07:00
Toni Barzic fd39b428f9 Avoid some unnecessary taskbar recreations
Skips recreate taskbar calls for desktop taskbar on freeform display
feature. When the feature is enabled, the taskbar will be consistent on
freeform displays across different UI states. This means that changes in
launcher visibility, and desktop mode will not expected to change the
flavour of taskbar used on the display, making taskbar recreation
unnecessary in those cases.

Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device. verify correct taskbar is shown
      on home screen, in overview, in desktop mode, with fullscreen
      app shown. Verify opening/launching apps from taskbar works
      as expected.

Change-Id: Ib679aa27afc1087226f05d0e914bfe6ff67bd24b
2025-04-04 05:53:07 +00:00
Treehugger Robot 21c065ae3d Merge "[Memory Leak] Fix leak of Launcher activity from recent view's input consumer" into main 2025-04-03 15:57:40 -07:00
Brian Isganitis 88707d3da3 Merge "Disable LayoutTransitions for transient taskbar." into main 2025-04-03 14:03:10 -07:00
Jordan Silva 434e4931a3 Merge "Update Overview buttons styles and layout" into main 2025-04-03 13:48:07 -07:00
Fengjiang Li 222fb581bd [Memory Leak] Fix leak of Launcher activity from recent view's input consumer
Ensure we always clear the consumer, which has strong ref to RecentsView and launcher activity, once gesture is ended

Fix: 407823225
Test: presubmit
Flag: NONE - released code
Change-Id: I90f2212247965697a4077890404bb577943efa37
2025-04-03 13:47:29 -07:00
Treehugger Robot 9d5dcc8682 Merge "Recreate taskbar for combined desktop mode / pinning state change" into main 2025-04-03 13:16:21 -07:00
Treehugger Robot ff60bad47c Merge "Do not add a stub TaskView unless there is no running TaskView" into main 2025-04-03 12:36:13 -07:00
Treehugger Robot cb30e70576 Merge "Fix app pair crash" into main 2025-04-03 12:24:17 -07:00
Ajinkya Chalke d411c2511c Merge "Fix Alt+Tab KQS for projected mode" into main 2025-04-03 12:19:06 -07:00
Will Osborn 07f417eabb Merge "Fix for getting Display from ApplicationContext in RotationTouchHelper" into main 2025-04-03 09:38:50 -07:00
minch 38b14021a9 Do not add a stub TaskView unless there is no running TaskView
Do not add a stub TaskView unless there is no running TaskView.
And add the TaskView type checking while getting the running TaskView
from the given [GroupedTaskInfo].

Bug: 407120863
Test: 1. Change to a 3P launcher (e.g., Nova Launcher), clear recents
         task, then swipe up from home screen, verified that
         "No recent items" is shown without having a transparent
         home TaskView.
      2. Drag a window inside the desk to be a fullscreen one,
        then swipe up, verified that it works correctly.
      3. Swiping up from fullscreen or desk tasks works correctly.
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I73f8b3310b4c66fdd3dd9cc5cd95418196279893
2025-04-03 09:37:46 -07:00
Treehugger Robot e1ab1c6214 Merge "pin-shortcut: Move flag to lse" into main 2025-04-03 09:29:51 -07:00
Randy Pfohl 0c4afa7542 Merge "Fixing crash when showing blocked by policy message without an activity" into main 2025-04-03 09:13:17 -07:00
Will Osborn 6329ae849b Fix for getting Display from ApplicationContext in RotationTouchHelper
Bug: b/407878199
Test: local on Tangor + presubmit
Flag: EXEMPT bugfix
Change-Id: Id25b2c179398ff25d2607872d17f494621bfea2e
2025-04-03 13:55:20 +00:00
Ajinkya Chalke daf6fd534a Fix Alt+Tab KQS for projected mode
- Update to show Alt+Tab KQS for phones but only on CD.
- When user triggers Alt+Tab while phone display is in focus, overview
  is triggered - existing behaviour.
- Added back querying taskbar from TaskbarManager when Overview in
  window is disabled.

Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Bug: 407508421
Fix: 407508421
Test: manually ran CUJ
Change-Id: If601055b4dd16b12683c2a80065acf3aaaedd211
2025-04-03 11:26:34 +00:00
Alex Chau 191dda179e Merge "Avoid removing ClearAllButton in split select animation" into main 2025-04-03 02:32:14 -07:00
Vinit Nayak 59904c788e Fix app pair crash
* With the change made in ag/31615582, we assumed
that top level + stage level split roots would always be
included in the transition, that isn't the case when an app pair
is already showing and then we switch to another app pair (stage
roots aren't included since they aren't modified in that scenario)
* Now shell sends the entire tree. Also modified SplitScreenUtils
to consider TRANSIT_CHANGE changes as well for the scenario where
one app of an app pair is already full screen and then we launch an
app pair which has that same app, the stage root there undergoes a change
and not a open/close transition.
* One KI is that the animation doesn't fully work when launching a second
app pair from taskbar when split is already showing (though it is an
improvement from current behavior/animation). This is because when the second
app pair launches, the tasks' snapshot windows/leashes are passed back as
leafs, however these snapshots have not been parented to be under the stage roots.
So both snapshots are positioned at 0, 0 causing overlap. Will fix that in
a followup

Bug: 399037701
Test: Open app pairs from desktop windowing + normal taskbar
Flag: EXEMPT bugfix

Change-Id: I83adffd16fea98b8e877dfbe1ba1ef4a3d08fcb9
2025-04-03 01:00:56 -04:00
Treehugger Robot 343333ce8a Merge "Prefer launching desktop tasks on freeform display" into main 2025-04-02 16:54:41 -07:00
Treehugger Robot 243e95fd5f Merge "Don't report INSETS_ROUNDED_CORNER on phones" into main 2025-04-02 14:03:28 -07:00
Brian Isganitis c0af778af1 Disable LayoutTransitions for transient taskbar.
Taskbar stashes once an app is launched from taskbar, or remains stashed if you launch something from All Apps. The layout transitions therefore are unlikely to be seen by the user. Disabling them means when the user unstashes, they will see the end result of the transition immediately. The problem with them being enabled for transient taskbar is we set icon alpha to 0 if Taskbar is stashed, which conflicts with the alpha layout transition animation.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 406809935
Test: Manual
Change-Id: Ibcfc04e5c9af104725a69c8cceccef49544d7bd3
2025-04-02 13:21:54 -07:00
Treehugger Robot 8310d2d219 Merge "Dispatch KeyEvents received by the RecentsWindowManager to the LauncherRootView" into main 2025-04-02 12:40:28 -07:00
Jordan Silva f99a50c2e4 Update Overview buttons styles and layout
This CL update the style of Overview Buttons to support Wallpaper Blur feature.
- Overview action button background, padding and spacing updated.
- Clear all button style updated to match action buttons.
- Select button drawable updated.

Bug: 404479758
Fix: 407665072
Flag: com.android.launcher3.enable_overview_desktop_tile_wallpaper_background
Test: OverviewImageTest
Change-Id: I89b781928c4b49155df9dfb5af5e81775ab5b87b
2025-04-02 11:59:25 -07:00
Tony Wickham fdd34cb24a Don't report INSETS_ROUNDED_CORNER on phones
Flag: EXEMPT bugfix
Fixes: 406689798
Test: none (we can add one once we add TaskbarInsetsControllerTest)
Change-Id: I0bba8f39104b7b6d6dbbc4029981fea2988dae50
2025-04-02 18:54:47 +00:00
Randy Pfohl 2638755462 Fixing crash when showing blocked by policy message without an activity
Flag: com.android.launcher3.enable_launcher_overview_in_window

Test: Built locally, no crash

Bug: None/Exempt found and fixed

Change-Id: Ia712c298ae498f34b8bf243d2e754db8339648f1
2025-04-02 17:39:52 +00:00
Jagrut Desai 1621848c58 Merge "Fix Taskbar offset in launcher" into main 2025-04-02 08:59:01 -07:00
Treehugger Robot 94469d7934 Merge "Change AppChip to work without TTV refactor flag" into main 2025-04-02 08:24:08 -07:00
Treehugger Robot 22a61d32ca Merge "Translate grid end for tasks after dismiss." into main 2025-04-02 06:08:07 -07:00
Jordan Silva c7006fe3a4 Change AppChip to work without TTV refactor flag
Update the flag condition to load the app chip when the TTV flag is off via `onIconLoaded`. It uses the `TaskViewModel` when TTV flag is on.

Fix: 407947426
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Disable com.android.launcher3.enable_refactor_task_thumbnail.
Change-Id: Ia240f614d1c18f2c32227ee06e82a3fb6b1e080d
2025-04-02 13:57:54 +01:00
Pat Manning 394ad82cf9 Translate grid end for tasks after dismiss.
Fix: 389084739
Test: TaplTestsQuickstep#testDismissLastGridRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I5f7785328d0b4b69d6f43cd8bfa68c1504f6ae21
2025-04-02 03:50:49 -07:00