Commit Graph

15569 Commits

Author SHA1 Message Date
Jeremy Sim 86cf2ea3c8 Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840

Change-Id: I490a99f184fdb3d6432b93ea36ac79c0e8a51c66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 22:15:20 +00:00
Jeremy Sim 3137f65dcc Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev 2023-07-05 21:22:12 +00:00
Liran Binyamin 3c81efd136 Ensure overflow isn't selected when bar is collapsed am: 16b05e251b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933

Change-Id: I19c19e06e387ce56a78d10b8251edf8449ceb989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 19:15:12 +00:00
Liran Binyamin 16b05e251b Ensure overflow isn't selected when bar is collapsed
After the bubble bar collapsing animation completes, and reordering
is finished, if the bubble overflow is selected, update the selected
bubble to be the first bubble. This ensures that the overflow
is not selected the next time the bubble bar is expanded.

This is done through a callback from the BubbleBarView to the
BubbleBarController with the key of the first bubble. Ideally the view
would just notify that the selected bubble needs to be updated, but
the controller doesn't hold ordering info.

Fixes: 289280431
Test: manual
       - Add 2 bubbles to the bubble bar
       - Expand the bubble bar. The first bubble A should be selected
       - Select the second bubble B
       - Select the overflow
       - Tap on the overflow again to collapse the bubble bar
       - Tap on the bubble bar to expand it
       - Observe that bubble B is first and selected
Change-Id: I0f9c2d628cfaf3a80da55ff634284687425e949a
2023-07-05 12:20:46 -04:00
Tracy Zhou b3f8477b94 Add initial trackpad tapl tests am: 323958007d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485

Change-Id: I76bf5d89ac5b141aad398ff62b3483535a0d6fc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 20:28:39 +00:00
Tracy Zhou 323958007d Add initial trackpad tapl tests
- go home

Bug: 281732733
Test: presubmit
Change-Id: I538d63bde2bf427a02c2bc355eab71546d667bf9
2023-07-03 10:50:54 -07:00
Jagrut Desai 9f3a115ab0 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 62dd220b69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I616ad6bb87381eca5b452ddadd460d35f4b71414
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:29:18 +00:00
Jagrut Desai 491b0f9028 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I9d438b3edda25a7407d30d702013b385b3fd9195
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:37 +00:00
Jagrut Desai 62dd220b69 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:45:46 +00:00
Jagrut Desai fa2a81844f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev 2023-06-30 22:29:20 +00:00
Treehugger Robot dd262b4617 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 120c78d24f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I852fc4d1f95af8ef5be6fa02dd1d1d404b8cd92a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:28:58 +00:00
Treehugger Robot 957d46ae52 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: Idbb6ded338cf1fe3db8142ba75d54844a9bf1382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:05:32 +00:00
Treehugger Robot 120c78d24f Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I1302f2aeaeb17fa95a1a64cb2e095febadcacba1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:03:05 +00:00
Holly Jiuyu Sun d91ee8f9af Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395

Change-Id: I677a0e430b79b13a85f955a85421d78c5a166969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 18:27:19 +00:00
Holly Jiuyu Sun 18e0e1e50a Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev 2023-06-30 17:56:16 +00:00
Treehugger Robot 2c3c1e46c0 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev 2023-06-30 17:45:50 +00:00
Holly Sun 35b9960b63 [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Treehugger Robot 5a56f8f111 Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679

Change-Id: I02604078e3f4dcfc6413916a8c47f7c6cce934bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 00:11:09 +00:00
Treehugger Robot 1b565681fe Merge "Disable all apps from overview in some cases." into udc-qpr-dev 2023-06-29 23:52:09 +00:00
Brandon Dayauon 69be4ccd17 Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838

Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:38:46 +00:00
Brandon Dayauon aa9332af88 Merge "Fix prediction row title consistency" into udc-qpr-dev 2023-06-29 21:45:40 +00:00
Hongwei Wang e359184522 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 263aceeeea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I55f4709943f4373b71a7dff8fbcd7c1f660a9a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:23:48 +00:00
Hongwei Wang 49b9fbd188 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I0a6ef4eee4dfc6244b5ee4a7716c1e625923d4b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:58:16 +00:00
Hongwei Wang 263aceeeea Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:56:29 +00:00
Hongwei Wang ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Jon Miranda 3bad3ebaad Cleans up bad state when transient taskbar shows on home.
Bug: 279514548
Test: open transparent activity on top of launcher
      unstash taskbar
      go home

Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
2023-06-29 02:51:38 +00:00
Tracy Zhou afd4eec779 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev am: 96fc36f614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835676

Change-Id: Ia4b95d8ace26619a0993eddbdb4139f872035cc1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 02:29:46 +00:00
Tracy Zhou 96fc36f614 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev 2023-06-29 01:34:00 +00:00
Jeremy Sim ef603e6ddd Add logcat logs for splitscreen launch failures
This patch makes it so that splitscreen launch failures (when app doesn't support splitscreen, or multi-instance, or if app crashes) are logged in logcat.

Fixes: 280494204
Test: Manual
Change-Id: If12a0c71e88b7b783be505e8a4caabeecc241dd9
2023-06-28 23:36:54 +00:00
Jagrut Desai 53d953ccd2 Taskbar All Apps Shortcut Menu Acccessibility Focus
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-28 14:48:54 -07:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
TreeHugger Robot 1a23d2986a Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev am: c84ecc0f67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836068

Change-Id: Ibd0f3c7fdbfd3913e4abe7c78b6013ed1888ee92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:36 +00:00
Schneider Victor-tulias 99e779ad03 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev am: e2e1b79b06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835673

Change-Id: I1112987cc848ecaf2c30c383f04843afd6371576
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:24 +00:00
Schneider Victor-tulias 4864de5700 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev am: 3ce99d1d96
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835670

Change-Id: Ib71e83fe6fb810383595e03fb3c40a4839d12d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:13 +00:00
TreeHugger Robot c84ecc0f67 Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev 2023-06-28 20:08:23 +00:00
Schneider Victor-tulias e2e1b79b06 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev 2023-06-28 19:59:33 +00:00
Schneider Victor-tulias 3ce99d1d96 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev 2023-06-28 19:59:19 +00:00
Schneider Victor-tulias ad2279a26e Handle onFlingFinished onRecentsAnimationStart
If the onRecentsAnimationStart callback runs after the user lifts their finger and onFlingFinished runs, then onFlingFinished never has another chance to run, leaving the user trapped in a state where the launcher is not started and the AllSetActivity is still present but invisible. Reverted to allow onFlingFinished to run onRecentsAnimationStart to handle this edge case.

Flag: not needed
Fixes: 285194839
Test: Ran AllSetActivty with a delay in onRecentsAnimationStart
Change-Id: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
2023-06-28 17:43:03 +00:00
Schneider Victor-tulias ae62216f15 Inset the contents of AllSetActivity
Insetting the contents of AllSetActivity to prevent overlapping with the gesture nav handle

Flag: not needed
Fixes: 275018092
Test: launched AllSetActivity in landscape with largest font and display size
Change-Id: Ia82a007e8a69c637a30c56e079d9c77d73885d9f
2023-06-28 10:02:05 -07:00
Winson Chung 470b3e771e Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b am: b019f371fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: Ic034129a9d522c2871f7ea2452007a83a9e61691
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 08:56:48 +00:00
Winson Chung 551cbc4969 Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: I2a7ebbac3c510d32b70ee57dd8323123800ff09a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:52:58 +00:00
Winson Chung b019f371fd Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: Ib095560a1ba305ec4150037852caa2d0d58f9121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:48:03 +00:00
Winson Chung 0da5208bb3 Merge "Workaround for handling the restart of an already visible task" into udc-dev 2023-06-28 05:51:59 +00:00
Winson Chung 57c2a79e47 Workaround for handling the restart of an already visible task
- If a task is already visible, then startActivity is a no-op and the
  remote transition that launcher expects to run is not started. As a
  workaround (until restarts are an actual transition), listen for
  the case where a task is restarted and invoke the end callbacks

Fixes: 286016555
Test: Repro steps on the bug
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-28 05:51:54 +00:00
Jerry Chang 3651051182 Polish home-key from split to pip transition
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.

Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-28 02:10:34 +00:00
Tracy Zhou 0b767c91b5 Use DisplayController.Info to determine if it's a tablet
Fixes: 286942201
Test: N/A
Change-Id: Iabcceaee45f885f1dd188d3ab9039ffd3a036a0e
2023-06-28 00:20:12 +00:00
TreeHugger Robot 7cccf75c64 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev am: d5b3a0a099
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783071

Change-Id: Id58dbf1f9cd64148cac79bb464ad2752f6ea3de3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 22:34:54 +00:00
TreeHugger Robot d5b3a0a099 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev 2023-06-27 22:34:40 +00:00
Vadim Tryshev 2ba42ef94d Removing ViewCaptureAnalysisRule
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I0123ed3892bbfd6d0e880141ace878b6204dbd81
2023-06-27 22:12:45 +00:00
Andy Wickham 5555ce326d Disable all apps from overview in some cases.
Specifically, whenever floating search bar would not show in
Overview, we also disable this all apps gesture. This covers
cases such as:
 - Landscape on phones
 - Tablets where taskbar shows in Overview

Note this does not depend on ENABLE_FLOATING_SEARCH flag state.
Just reuses the same LauncherState logic used for that.

Bug: 275132633
Test: Manual on tablet, phone, foldable
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: I6d6cc404a7dfef7c78b45ac830878032027156d8
2023-06-27 14:53:19 -07:00