Commit Graph

9144 Commits

Author SHA1 Message Date
Jordan Silva 8554f90ea6 Fix TaskView bind and orientation state called multiple times
DWB toast initialization is being called 3 times for every TaskView. Twice during the TaskView bind (setOrientationState and bind), and for every TaskView loaded in applyLoadPlan the bind and the setOrientationState are invoked. This CL removes the excessive calls in the TaskView bind and applyLoadPlan.
The DWB for the focused task view is still being called twice due to orientation update for the focused task.

Bug: 281980412
Flag: N/A
Test: atest DigitalWellBeingToastTest
Change-Id: Id301b53b9cb0dfc23a81debec67a6de9a35485b9
2023-05-24 16:29:54 +00:00
Jon Miranda d88ce20005 Merge "Fix SUW unstash animation." into udc-dev am: 9e0eee3729 am: bdb4531729
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23352149

Change-Id: I38e1d23e36c9e67d5bdd3cd273b6e6573d145945
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 21:00:10 +00:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
Vinit Nayak c83f94cde3 Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev am: 258019fe8e am: 1f27273c06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23320818

Change-Id: I11104b119109468f3b0984fb670b6196c418b97d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 18:43:42 +00:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Hongwei Wang ba46fe8f94 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev am: 0c66b151e3 am: 2ef78aa7d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23321279

Change-Id: I65f500cbd7280ec09b7feeef096c74b7372c7454
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 01:03:33 +00:00
Saumya Prakash ae2aab9217 Merge changes If2c82082,I03532b80 into udc-dev am: 66e7ec721b am: 1b12262d07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159151

Change-Id: I31b599f7b1e3cd4a3ed6dc659ba9b3f5b258334b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:13:58 +00:00
Hongwei Wang 0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Ats Jenk 7377639653 Merge "Show a persistent toast when selecting desktop apps on home screen" into udc-qpr-dev 2023-05-18 22:24:26 +00:00
Saumya Prakash 66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00
Treehugger Robot 1967be3a1f Merge "Fix widget clipping in widget back animation" into udc-dev am: 80e9a3b64e am: 43f6b63317
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267682

Change-Id: I234f78049ce344eb46c72cc978504a1395918eb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 21:12:50 +00:00
Hongwei Wang 45b8d39ab8 Notify WMShell on aborting auto-enter-pip
Note that this change does not fix the bug listed here. This is to
callback WMShell when the transition is aborted and WMShell can choose
how to handle this.

Bug: 283177443
Test: adb shell dumpsys activity service SystemUIService WMShell
Test: go/winscope and check the SF/WM dump
Change-Id: I8abfc2db47d1f0bfc3d400066936bed354743420
2023-05-18 13:15:57 -07:00
Jagrut Desai 8c78798b26 Merge "Fixing spacing between folder icon and folder itself" into udc-dev am: b9a88db27c am: 59802b88ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23269297

Change-Id: I37848a59e92af89b9c1732c28f6e2966523a9531
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 20:02:16 +00:00
Treehugger Robot 80e9a3b64e Merge "Fix widget clipping in widget back animation" into udc-dev 2023-05-18 19:59:21 +00:00
Saumya Prakash 0a6fb2c9e1 Update Lottie animations for gesture navigation tutorial to enable custom colors
This change introduces tokens for all the lottie animations in the
gesture navigation tutorial so that the colors can be changed to match
with the current design spec at http://shortn/_aig7n8W7rF

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Bug: 281764891
Test: Tried changing colors and verified that lottie animations changed
appropriately.

Change-Id: If2c820826603fb1cf424f5f0c97d83b195d26606
2023-05-18 10:47:44 -07:00
Schneider Victor-tulias 474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Vinit Nayak 6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00
Jagrut Desai b9a88db27c Merge "Fixing spacing between folder icon and folder itself" into udc-dev 2023-05-18 17:21:33 +00:00
Ats Jenk 9f11519936 Show a persistent toast when selecting desktop apps on home screen
When desktop stashed state changes, show a persistent popup on home
screen to select an app that will be launched on desktop.

Flag: persist.wm.debug.desktop_mode_2
Bug: 261234402
Test: launch an app on desktop, swipe home, observe the popup, launch an
  app, observe app is launched on desktop and popup is hidden
Test: stash desktop apps by going home while on desktop, press on the
  "exit desktop" button in the popup, observe popup is hidden, launch an
  app, observe it is launched in fullscreen

Change-Id: I66fe0ab977fa7b2059f149d7d0ab0cf92192c967
2023-05-18 09:31:27 -07:00
Tracy Zhou d7c00cb8b4 Disallow two finger gesture nav behaviors when the cursor is in the zones
- This change addresses swipe up and quick switch from the nav bar area using two fingers
- Separate changes will be implemented in SysUI to disable two finger swipe down from the status bar area and two finger swipe edge swipe for back

Bug: 283112069
Test: manual
Change-Id: I67c7ba31e759d5693d89112fd8f37f3d2a9eaa41
2023-05-18 00:33:04 +00:00
Sihua Ma f8acb23e1f Fix widget clipping in widget back animation
Test: Manual
Fix: 280261814
Change-Id: I4db24ca624d50b1d860df428fdab9d591f35ac5e
2023-05-17 13:32:20 -07:00
TreeHugger Robot e607fdb2a2 Merge "Removing support for lagacy shortcuts" into udc-qpr-dev 2023-05-17 19:25:45 +00:00
Saumya Prakash 7d7a07590a Merge "Display app icons in quick switch task view when there are no updates." into udc-dev am: e212779ffd am: 289de879b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23270250

Change-Id: I1aec6d672a6d2a9e967796256dd99b7b4dff0854
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 19:02:27 +00:00
Saumya Prakash e212779ffd Merge "Display app icons in quick switch task view when there are no updates." into udc-dev 2023-05-17 17:11:49 +00:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Alex Chau 7af659da9e DisplayController should deep compare mPerDisplayBounds
- In CHANGE_SUPPORTED_BOUNDS check, it uses Map.equals, but as the value is a primitive array WindowBounds[], equals check does not deep compare the arrays and may result in false negative
- One example is when fontScale changes, DisplayController re-create bounds from WindowManagerProxy, result in new WindowBounds[] created, and the shallow compare results in unexpected CHANGE_SUPPORTED_BOUNDS

Fix: 282736623
Test: DisplayControllerTest
Change-Id: I3897595c58559192b951ecfee7c9f62a07dafe1f
2023-05-17 09:40:46 +00:00
Winson Chung fb51c85cae Merge "Only set drag shadow params if they are valid" into udc-dev am: 2e1ce4c72f am: 1275b898ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23249924

Change-Id: Ice6a5f215f5fbe64b27fa4308b7c3e3e5f0d6968
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 06:49:25 +00:00
Winson Chung 2e1ce4c72f Merge "Only set drag shadow params if they are valid" into udc-dev 2023-05-17 03:44:42 +00:00
Ats Jenk c6cbcbcd74 Merge "Stash desktop apps on home gesture or taskbar home button press" into udc-qpr-dev 2023-05-17 00:16:04 +00:00
Saumya Prakash 033412a892 Display app icons in quick switch task view when there are no updates.
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fix: 275629107
Test: Launched keyboard quick switch view and changed focus back and forth

Change-Id: I6ce39e7842bb04c80d49d871002ef957708a8e59
2023-05-16 23:00:46 +00:00
Jagrut Desai 172266fb4e Fixing spacing between folder icon and folder itself
Test: Manual
Bug: 282990506
Flag: not needed
Change-Id: I4a873495ffdf6210b496a4d7d18546dc7483e66e
2023-05-16 14:04:14 -07:00
Ats Jenk 7cd5a681f7 Stash desktop apps on home gesture or taskbar home button press
When we detect the home gesture or tap on home button in taskbar,
check if desktop apps are visible. If they are, signal WMShell
to stash the desktop apps.

Flag: persist.wm.debug.desktop_mode_2
Bug: 261234402
Test: have gesture nav enabled, put an app on desktop and swipe up to
  home, verify toast is shown, and next app launches to desktop
Test: have 3-button nav enabled, put an app on desktop and press home,
  verify toast is shown, and next app launches to desktop
Change-Id: I824e640bfafa20cb3451cbd8f035fe9dca18094f
2023-05-16 11:57:50 -07:00
Charlie Anderson afb447ee0d Merge "Adding a new Edit Mode LauncherState" into udc-dev 2023-05-16 18:42:34 +00:00
TreeHugger Robot b9f04842b5 Merge "Add a no recent tasks message to the keyboard quick switch view" into udc-dev 2023-05-16 06:49:52 +00:00
Schneider Victor-tulias 4ee471fecf Merge "Update keyboard quick switch view ordering and add icons" into udc-dev 2023-05-16 05:12:47 +00:00
Treehugger Robot 56f539538f Merge "Don't treat Recents as transient for all apps from overview." into udc-dev 2023-05-16 01:28:49 +00:00
Schneider Victor-tulias b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Schneider Victor-tulias f0233c53d3 Merge "Code cleanup: recycle typed arrays when they are no longer needed" into udc-dev 2023-05-15 23:48:11 +00:00
TreeHugger Robot f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
TreeHugger Robot 15bc0d388a Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev 2023-05-15 22:20:32 +00:00
Winson Chung 583de1621d Only set drag shadow params if they are valid
- Invalid params trigger an exception to be thrown when starting a
  system drag

Bug: 269016702
Test: Presubmit
Change-Id: I4b1953afd72ab1c6d41f3b5b536f9578ef40d792
2023-05-15 22:10:16 +00:00
Tony Wickham 4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Tracy Zhou 3711aa64ac Merge "[Reland] Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-05-15 19:45:46 +00:00
Schneider Victor-tulias b6407699ae Update keyboard quick switch view ordering and add icons
- Updated the keyboard quick switch view ordering to left-to-right (vice versa in RTL)
- Added app icons to keyboard quick switch taskviews

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 275629107
Test: launched keyboard quick switch view and changed focus back and forth
Change-Id: Ie2f0a1c08c7065c53075f6fa015000a2d6184491
2023-05-15 12:06:19 -07:00
Schneider Victor-tulias eb8dce01ce Add handling for toggling keyboard stashing from the keyboard
Flag: ENABLE_KEYBOARD_TASKBAR_TOGGLE
Bug: 281726846
Fixes: 246660615
Test: toggled the transient taskbar with the meta+t input
Change-Id: I315f83850b11d24d8b55061d7111300effb43936
2023-05-15 18:41:25 +00:00
Schneider Victor-tulias 581fd3eede Code cleanup: recycle typed arrays when they are no longer needed
The border animator does not need the typed array anymore after initialization. recycling the object.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 282202504
Test: changed focus in quick switch view and overview
Change-Id: Iea9077e49e754894008899dfc9b90e3876b53051
2023-05-15 11:38:17 -07:00
Treehugger Robot 11939898f3 Merge "Update app ring color and alpha" into udc-dev 2023-05-15 17:33:23 +00:00
Sunny Goyal 4fdc9181dd Adding support for listening to end callbacks when launching an intent from Launcher
Also moving various state handling to these end callbacks enstead of relying on resume

Bug: 265134143
Test: Verified that the end callback is received
Change-Id: I326a99c80154d244c0e49f678717c476602b6240
2023-05-15 10:31:06 -07:00
Treehugger Robot ba4fcb0171 Merge "Fix bug where unstash animation plays twice." into udc-dev 2023-05-13 01:47:20 +00:00