Commit Graph

2354 Commits

Author SHA1 Message Date
Becky Qiu 84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Jon Miranda 783717c0c6 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21
am: f20a7d252c

Change-Id: I3fcfe4dc137756d5b4a049468632d111ca7fa4f6
2019-08-01 15:19:01 -07:00
Tony 13bdbffe29 Don't end launcher components anim early even if it does nothing am: 03c548901f
am: 1d7e474c69

Change-Id: I1f1f70c2791755535d1318b636e37a745e97d057
2019-08-01 15:18:36 -07:00
Jon Miranda f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony 1d7e474c69 Don't end launcher components anim early even if it does nothing
am: 03c548901f

Change-Id: Ifb228b935659e971facfd8d6bb4c56ab54424e68
2019-08-01 15:04:36 -07:00
TreeHugger Robot 9da9a2bd21 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev 2019-08-01 21:47:47 +00:00
Tony 03c548901f Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
2019-08-01 13:28:43 -07:00
Tony Wickham 70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham 1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham 35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
Vinit Nayak 45c12ff1b5 Set recents view to be visible from alt+tab
Recents was being initialized but was not
marked as attached to app window. This
was causing it's animator to never make it
View.VISIBLE.

Test: Open any app
On physical keyboard press alt+tab
Observe that overview shows up

fixes: 138396234
Change-Id: I9e6c001242f4552027e79b162fb812f476823a37
2019-07-31 20:10:55 +00:00
Jon Miranda f462b251e1 Tune window/icon alpha for swipe up to home animation.
Bug: 136591785
Change-Id: Ib781bc77cfd49b6f4529a609d7025f510e219575
2019-07-31 10:05:16 -07:00
Sunny Goyal c302baced0 Notifying the geature guide app when back gesture is performed
so that user onboarding can the updated accordingly

Bug: 138403212
Change-Id: Ib4e1cde0b2c746f955d5a58251c8ab653dadbc67
2019-07-29 11:55:11 -07:00
Winson Chung fa652a8a4f Updating to use deferred cancel api
- Also updating the sysui flag to home's flags when passing some
  threshold
- Also ensure we don't allow swipe up when QS is open

Bug: 137196872
Bug: 135969043
Change-Id: I476eee7f02ae86aa795fceabb304bcaa7416ef9c
2019-07-27 10:08:52 -07:00
Winson Chung 1d3d19f2e1 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev 2019-07-26 16:46:35 +00:00
Winson Chung 0ef10a458d Skip tests for overlays that don't exist on device
Bug: 138401738
Bug: 138227387
Change-Id: If661fd342e1382915485bccdf6ae2c9e77a92bc4
2019-07-26 00:09:43 +00:00
vadimt f88d0b5a8a More diags in TouchInteractionService
Bug: 138251824
Change-Id: I0909a2c85b1b2bdd8b67da59c978d6a3bbb58ee5
2019-07-25 16:38:39 -07:00
TreeHugger Robot 3bbb20262b Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev 2019-07-25 23:17:21 +00:00
Winson Chung 5089140cda Fix NPE in service dump
Bug: 138144992
Change-Id: I608ea209b04fce13a63190ec424849dc909a6a9a
2019-07-25 15:22:47 -07:00
TreeHugger Robot 2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary 93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
Vadim Tryshev 2870df0776 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev 2019-07-25 19:47:42 +00:00
Tony Wickham 2b365ae7f0 Fix incorrect task index bounds
Should have been using min, not max. Added lower bound for good measure.

Bug: 138025252
Change-Id: Icd8c7d62dca7605fe63e83602e4c9fceb91f68a6
2019-07-25 12:27:29 -07:00
vadimt 7593dc995b NavigationModeSwitchRule: log exception before 'finally'
Change-Id: I158105da467e2759fec6fa5d8acd582b2e95f7c5
2019-07-25 12:16:31 -07:00
James O'Leary 74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Tony Wickham cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Winson Chung 0727d59576 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev 2019-07-24 00:12:28 +00:00
TreeHugger Robot 8578309f1b Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev 2019-07-24 00:01:25 +00:00
Tony Wickham fbd77c48cc Distinguish mDragHandleProgress from mMidProgress
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.

Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
2019-07-23 16:58:45 -07:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Winson Chung 48ba8c864c Fix regression in assistant window handling
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
  swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task

Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
2019-07-23 16:25:46 -07:00
Zak Cohen 87477f5996 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev 2019-07-23 22:51:28 +00:00
Jon Miranda 9566a04400 Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-23 22:24:35 +00:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham 3fca6aaec2 Finish recents animation when touching during animation to recents
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().

Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
2019-07-19 16:53:00 -07:00
Zak Cohen bc4d213535 TaskView - add a getter for the bitmap data.
This allows other components to get it directly from the view, rather
than retaining their own copy.

Bug: 137129923
Tested: Manual

Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
2019-07-19 15:14:53 -07:00
vadimt c8d496fe00 Fix waiting for launcher initialization
Bug: 137836033

Change-Id: Ifc8ce867abd85eaeacd09a2b39636ecc4109c046
2019-07-18 18:31:49 -07:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
Jon Miranda 11b5535556 Skip TouchInteractionService preload if restore task is pending.
Otherwise the preload may cause launcher to restore too early, resulting
in data loss.

Bug: 131315856
Change-Id: I4412c8f691286ba142e9c748a908a3ed42713a82
2019-07-17 21:24:07 -07:00
TreeHugger Robot aaf6c7ce56 Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev 2019-07-17 23:02:50 +00:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Sunny Goyal e88d8acd85 Adding spring animation when swiping up to home in 3P Launcher
Bug: 137197916
Change-Id: Ic9808a30e8cd4e0b2a221c4b03bc29489038e092
2019-07-17 11:39:25 -07:00
Vinit Nayak 10d278f3d5 Merge "Reload task list when task is removed" into ub-launcher3-qt-r1-dev 2019-07-17 00:49:52 +00:00
TreeHugger Robot 401583f9b6 Merge "Getting starting point of swipe from overview to all apps via protocol" into ub-launcher3-qt-r1-dev 2019-07-17 00:24:55 +00:00
vadimt 6a75e52f85 Getting starting point of swipe from overview to all apps via protocol
Change-Id: Idf04579b67011dac45b081a81367cde2d1274117
2019-07-16 16:46:53 -07:00