This ensures that the background of the widget will not disappear after cancelling opening the widget activity.
Normally, when opening and closing the widget activity, the following procedures are executed:
tap on widget
-> opening animation initialized -> opening animation finished
-> close the activity
-> closing animation initialized -> closing animation finished
The steps above would work fine. However, a different set of procedures is followed if we try to cancel opening the widget activity:
tap on widget
-> opening animation initialized
-> opening animation started
-> swipe back before opening animation is completed
-> closing animation initialized
-> opening animation finished
-> closing animation started
-> closing animation finished
During the animation initialization process, FloatingWidgetBackgroundView would be initialized. It will then cache the original background and replace with a temporary drawable with alpha set to 0. The background is only restored at the end of the animation.
If two FloatingWidgetBackgroundView is initialized on the same app widget view before one of them is finished, the second floating view will treat the temporary drawable as the original background. At the end of the closing animation, the temporary drawable with an alpha value of 0 will be set for the app widget view, causing the background of the widget view to disappear.
This CL stores the original drawables into the background view so they could be retrieved during the initialization process of the floating background view.
Test: Manual
Fix: 259526083
Change-Id: Iefa29b22b690076a4fc3fc77fe6eea4b6316f852
Prior to this change, we used absoulte screen values.
With this change, the nav threshold is aligned with all other taskbar
thresholds.
Fixes: 269167210
Bug: 267646355
Test: swipe up to show taskbar
Change-Id: Ie2017577fd640b4173fd5ba10122d6906e74f90a
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.
Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.
Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
This could happen when the QuickstepWidgetHolder is not initialized on the main thread, or destroy() is not called on the main thread, while a random widget is removed at the same time which iterates the widget holder list and calls the callbacks.
Also fixing an issue with memory leak that is caused by the strong reference in WeakHashMap
Test: Presubmit
Fix: 271362384
Change-Id: I621ffb29c167cef9842758c5fdefd6bb66dd487e
Fixes: 270669636
Test: Couldn't repro, but visually we have checks for
recentsView != null && OTHER_CONDITION, but in the else
case we don't check if recentsView being null is the reason
the if-block didn't get triggered
Change-Id: I72e7480bac56c7e7b7edb73edac4309e9923d302
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.
testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.
Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
NavbarButtonsViewController has been massaged to make sure the buttons
contrast well with the color of the Taskbar background that they are on,
if applicable.
Test: Manual
Fix: 268052229
Change-Id: I917a1a1be013c304910b0f674ae8a13abb8e47a1
Merged-In: I917a1a1be013c304910b0f674ae8a13abb8e47a1
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.
Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions
Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
Bug: 269660657
Test: open overview, click on split screen action, observe desktop tile
is hidden
Test: on home screen, long press on app icon and choose split screen,
observe overview opens with desktop tile hidden
Change-Id: I60c06a8e2ef8fc13e741f8845254d22e9e430bb6
On large fonts and display sizes, the TutorialStepIndicator can overlap the skip and/or done buttons. Adding some additional translation to account for this.
Fixes: 269588989
Test: tried the tutorial on the largest and default font and display sizes on a phone
Change-Id: I45a276bba3e9cb10336c6f3aa363b7a5c7a73543
This is achieved by instead creating an empty item info that only
specifies the splash type to be solid color.
Bug: 269343536
Test: manual
Change-Id: Ibf5c8f1c949e26af207b8c6e382f71677b9acc2d
Based on UX specs, desktop tile should be using the large size and be
pinned ot the right in overview.
Updates to ensure the desktop tile is using the focused tile size when
grid only overview is enabled.
Test: enable grid only overview, have some fullscreen tasks in overview
and some desktop tasks, open overview from home, observe desktop tile
peeks from right
Test: same setup as before, open a fullscreen app, open overview,
observe desktop tile peeks in from right
Test: same setup as before, go to desktop, open overview, observe
desktop tile is focused
Test: turn off grid only overview, repeat the same test case
Bug: 271131878
Change-Id: Ic804428dca415f08a26c47e1d6b9b3a94fcfbfdf
During setup, default home progresses setup -> null -> launcher, which
can lead us to unintentionally preload the fallback overview.
Fix: 258022658
Test: Manual
Change-Id: I952b7923b06f2d4b058f42834d1f840719c73fd0
Sunny Goyal
Brian Isganitis
Sihua Ma
Charlie Anderson
Schneider Victor-tulias
Jon Miranda
Tony Wickham
TreeHugger Robot
Johannes Gallmann
Hyunyoung Song
Pat Manning
Hongwei Wang
Jeremy Sim
Vinit Nayak
Ats Jenk
Nick Chameyev
Luca Zuccarini
Stefan Andonian