Commit Graph

3717 Commits

Author SHA1 Message Date
Ming-Shin Lu 1eedfc33c5 Fix weird split-screen secondary task animation
As CL[1] corrects the screenBounds of remote animation target,
and we are now using RemoteAnimationTarget#localBounds to offect the
position.

Remove the offset logics in AppWindowAnimationHelper#updateSourceStack,
and TaskViewSimulator#setPreview, then refine computeSurfaceParams
with offseting the position of HOME task by localBounds.

[1]: I793f01fb290fe65af1bbf8e29e429fbca63ac255

Fix: 153581126
Test: manual as below steps:
     1) Launch a app, swipe up to overview screen.
     2) Tap app icon and pressing "Split screen" item.
     3) After entered split-screen mode, taps the task view.
     4) Make sure the secondary task animation the movement is
        correct and smoothly.

Change-Id: I0e4ed1465e80f48336908813ac694fb3aaa3c347
2020-05-19 20:02:44 +08:00
Winson Chung 6e0d05fc41 Merging from ub-launcher3-rvc-dev @ build 6492476
Bug: 150504032
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6492476.html
Change-Id: I96b36965f7b471eb77aa78a8b923ed9298e8a02f
2020-05-13 23:22:18 +00:00
Vinit Nayak bdd6522661 Merge "Update recents child views RTL handling" into ub-launcher3-rvc-dev 2020-05-13 21:41:09 +00:00
Sunny Goyal f190fd2d4e Build fix. Unifying task size calculation code.
Change-Id: Iaed3a28a9e74c39da8d01aa42b30c96bdb69a661
2020-05-13 14:06:07 -07:00
TreeHugger Robot 650da4bbd1 Merge "Keep Predicted icon same size when dragging" into ub-launcher3-rvc-dev 2020-05-13 19:18:28 +00:00
TreeHugger Robot e0fef877e4 Merge "Changing RecentsView layout based on the split screen task size" into ub-launcher3-rvc-dev 2020-05-13 18:35:05 +00:00
TreeHugger Robot d893a478a3 Merge "Adds Settings button back to Back gesture tutorial." into ub-launcher3-rvc-dev 2020-05-13 18:34:37 +00:00
Becky Qiu dc48fc4f84 [Overview Actions] Adjust the select mode taskview UI.
It will have a 30dp horizontal paddings and vertically in the middle of the screen.

Test: local
Bug: 155444014

Change-Id: I4f3d627008b2c114cc4921bf683919c6044926e4
2020-05-13 18:23:28 +00:00
Samuel Fufa 167210a323 Keep Predicted icon same size when dragging
-> In addition, this also prevents the drawing of ring effect for predicted icon when view is about to be copied to drag bitmap. Icon will scale to full size (without ring) when dropped.

Video attached to bug report

Bug: 152325754
Test: Manual
Change-Id: Ibd1a5dbf76c41bdc30ae851ad914a4d0e32703c8
2020-05-13 11:22:27 -07:00
Andy Wickham ee1203e436 Adds Settings button back to Back gesture tutorial.
Uses a simpler Intent which actually works :)

Fixes: 149348244
Bug: 148542211
Change-Id: I5e28c63d1eec93b4642e398c7532e7ec4809d6e2
2020-05-13 10:48:38 -07:00
Andy Wickham 65381300f2 Minor cleanup in RecentTasksList.java
Change-Id: I8a496300c936e4d3f2bcd6b0c6c482e5bbb0452d
2020-05-13 09:34:49 -07:00
Vinit Nayak 08a8327b1d Update recents child views RTL handling
Fixes: 154928106
Test: AppIcon and clear all button
shows up as expected in LTR and RTL
configuration.

Change-Id: Idcf367b8aff53002e63a03b64b96e3602127707e
2020-05-12 22:24:26 -07:00
TreeHugger Robot 75dcd82a67 Merge "Don't handle task appeared during second quick switch transition" into ub-launcher3-rvc-dev 2020-05-13 03:35:23 +00:00
TreeHugger Robot 7c604edf92 Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev 2020-05-12 23:01:25 +00:00
Tony Wickham f6be443eb4 Don't handle task appeared during second quick switch transition
Instead of using shared gesture state, use the swipe handler's
internal state. This ensures that only the handler that started
the new task can finish the controller for it (i.e. starting a
new gesture, which creates a new handler, will ignore the
onTaskAppeared() that the previous handler initiated).

Test: Quick switch to delayed task A, then quick switch to B right
before onTaskAppeared() such that we get onTaskAppeared() during
the transition (easier to repro if you increase animation durations
with springs off). Before this change, A appeared on top.

Bug: 156412706
Change-Id: Ic7d3cd43399005095b2e7c7382218edffefdc27b
2020-05-12 17:46:02 -05:00
Becky Qiu 073cbca370 [Overview Actions] Put the taskview in the middle of the screen.
Using horizontal padding 48dp to adjust the scale of the taskview and put it in the middle of the vertical space.

Test: local
Bug: 155444014
Change-Id: Iee6096baf18ae1106c24c83b4675abd4d3ff4d4f
2020-05-12 15:00:54 -07:00
Sunny Goyal b78ea4b4fc Changing RecentsView layout based on the split screen task size
Bug: 155816922
Change-Id: I33f69d72f8a27e3621d029c6ee4045c3664f3ac9
2020-05-12 14:04:19 -07:00
Sunny Goyal 3f948e3f42 Adding state manager to fallback recents activity
Bug: 156398988
Change-Id: Id0a106ef888ade5223940ac8243108c39b4d6b98
2020-05-12 13:31:48 -07:00
TreeHugger Robot 7dcd4d6ed6 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev 2020-05-12 18:42:22 +00:00
TreeHugger Robot 2830c99bee Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-12 17:35:42 +00:00
vadimt 60bc43d0cc Even more additional logging for pause non-detection
Bug: 156044202
Change-Id: I7c1a8a9ef4149bd64597908c0b6797cfe33fd4b6
2020-05-12 09:51:24 -07:00
Sunny Goyal 4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot b8759f9b26 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev 2020-05-12 03:06:29 +00:00
TreeHugger Robot 3d3c41a3a6 Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev 2020-05-12 01:07:21 +00:00
TreeHugger Robot eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
Sunny Goyal 35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Tony Wickham a57000c33d Restart running task if another task was started but not appeared
If we just finish the controller to resume the running task like
we normally would, the delayed task will appear on top when it's
ready. Instead, we need to start the original task in this case.

- Move mLastStartedTaskId to GestureState, shared between swipe
  handlers when continuing the gesture.
- Update logic to change LAST_TASK to NEW_TASK if a task was
  started (but not appeared) during the same gesture; likewise,
  only change NEW_TASK to LAST_TASK if no task was started.
- Finish the controller when successfully starting the task
  that already appeared, since we won't get onTaskAppeared().

Bug: 156132424
Change-Id: I1e9af297840745ab3d5e90214425f10a2616d90a
2020-05-11 18:26:06 -05:00
TreeHugger Robot ed31f24dbf Merge "Fixing current task not overshooting on swipe-up in overview" into ub-launcher3-rvc-dev 2020-05-11 22:55:45 +00:00
Sunny Goyal 84376f305b Fixing current task not overshooting on swipe-up in overview
> also fixing flicker during swipe-up when scroll is applied before recents
has been initialized

Bug: 154761552
Change-Id: I45c2b6801b8b87097c2816e26a234bab41b72ed4
2020-05-11 14:39:32 -07:00
TreeHugger Robot 6459397e3d Merge "Temporarily removes Settings button from Back tutorial." into ub-launcher3-rvc-dev 2020-05-11 21:10:46 +00:00
Sunny Goyal ef44cf8f45 Fixing pullback factor not initialized after launcher process death
Instead of storing it on first swipe-up, computing it when required

Change-Id: I4b37002a016328e3b2d1c8535198ec8a6b56faf3
2020-05-11 13:28:53 -07:00
Andy Wickham 168aaf9682 Temporarily removes Settings button from Back tutorial.
Currently it just crashes, so it shouldn't be there. If
and when we decide to add it back, we will need to get
our package whitelisted to send the necessary Intent.

Bug: 149348244
Change-Id: I5ab292d04ebc5679e34e5a92141df3d86ef6e551
2020-05-11 13:24:06 -07:00
TreeHugger Robot ae5afa74cd Merge "Using TaskViewSimulator for both Launcher and fallback recents" into ub-launcher3-rvc-dev 2020-05-11 19:32:26 +00:00
Vinit Nayak 115e70ddcf Merge "Infer launcher rotation when initializing RecentsOrientedState" into ub-launcher3-rvc-dev 2020-05-11 19:07:54 +00:00
TreeHugger Robot 17d3fe81c4 Merge "[Overview Actions] Change actions view UI based on different nav modes." into ub-launcher3-rvc-dev 2020-05-11 18:52:13 +00:00
Zak Cohen 02a25be89d Merge "Overview Actions - shows a message if action is blocked by policy." into ub-launcher3-rvc-dev 2020-05-11 18:43:55 +00:00
Vinit Nayak b9522d334a Infer launcher rotation when initializing RecentsOrientedState
fixes: 154776599
Change-Id: I9b95f7f96836a974be0fd1236547efb4b405fda5
2020-05-11 11:23:49 -07:00
Hyunyoung Song e745f50128 Merge "Hookup statsd for workspace layout logging" into ub-launcher3-rvc-dev 2020-05-11 18:18:57 +00:00
Becky Qiu 7d12134240 [Overview Actions] Change actions view UI based on different nav modes.
1. Change the overview actions container to 66dp height.
2. For 3 button mode, container will have 8dp bottom margin.
3. For gesture mode, container will have 16dp bottom margin.
4. Action buttons and close button will always be in the center vertically.

Spec: https://docs.google.com/presentation/d/1gXWNdCRXvXuEhgDmE0TX2KYqCxIQBXVtWKdl4pKrno8/edit#slide=id.g840c32b190_3_6

Demo:
- 3 button: https://screenshot.googleplex.com/2Y3uMaJMi9E
- gesture: https://screenshot.googleplex.com/XzaKHpp5ke9
Test: tested for both modes and when switch between.
Bug: 155444592

Change-Id: If66d369df0218b7ee2abab8a3f345488bf223b16
2020-05-11 10:46:21 -07:00
vadimt 7b7e62e5eb Additional logging for pause non-detection
Bug: 156044202
Change-Id: I6d7dcdcf73722e66fcbd180c9e309c518766b9b8
2020-05-11 10:10:53 -07:00
Bill Yi 91e0db3905 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2f2cda2793113a012d86b0d18cccf3e6fabb7e69
2020-05-10 20:53:08 +00:00
Hyunyoung Song 7f7894e3b7 Hookup statsd for workspace layout logging
Bug: 144953948

Change-Id: I81bd42929b2d65a63c610e95e5e01179a3971493
2020-05-10 01:37:42 -07:00
Zak Cohen 4ebd859bc4 Overview Actions - shows a message if action is blocked by policy.
Device policy or app secure surface policy mean that snapshot based
actions shouldn't work.
This is encoded in whether the snapshot is "real", the fake snapshot is
generated when policy doesn't allow captures.

Test: tested with Test DPC fake device policy app
Change-Id: Ib34e5a90ab58fb401d4516c531866d1c13569256
2020-05-08 17:16:15 -07:00
vadimt ad87034d1f More logging for pause non-detection
Bug: 156044202
Change-Id: I1c995b6c28f7108b96ff74aa8c3c71f70f8b3fb6
2020-05-08 15:09:37 -07:00
Sunny Goyal 86a2f91101 Using TaskViewSimulator for both Launcher and fallback recents
Fixing fling to home animation in landscape and multi-window orientation

Bug: 155896573
Bug: 155816922
Change-Id: I5fdff8694eced415978345b026858f5167c2a198
2020-05-08 14:48:42 -07:00
Vinit Nayak 77762fdf4f Merge "Revert "Disabling flaky test until fix is found"" into rvc-dev 2020-05-08 20:41:16 +00:00
Vinit Nayak 1be8a17986 Revert "Disabling flaky test until fix is found"
This reverts commit fdaa12d028.

Reason for revert: Should be fixed with ag/11252279

Bug: 150958400
Change-Id: Ia61462239ad5d8aba502bc8513d685046c1a1361
2020-05-08 20:41:01 +00:00
Sunny Goyal 9d85f52386 Merge "Fixing swipe-up form app in landspace, rotates the surface" into ub-launcher3-rvc-dev 2020-05-08 20:11:56 +00:00
TreeHugger Robot 4d1203efab Merge "Fixing Fallback recents crashes when going to modal state" into ub-launcher3-rvc-dev 2020-05-08 19:46:35 +00:00
TreeHugger Robot 16fb9fac22 Merge "Adding tracing for switching to overview instead of all apps" into ub-launcher3-rvc-dev 2020-05-08 18:39:39 +00:00