Commit Graph

5784 Commits

Author SHA1 Message Date
Sunny Goyal 81300a9f75 Merge "Using add/replace instead of update when updating an entry." into ub-launcher3-calgary-polish 2016-10-07 18:04:16 +00:00
Sunny Goyal caa52918f1 Using add/replace instead of update when updating an entry.
Update operation was not including version and updateTime columns
leading to a update operation getting called wheneven launcher loads.

Bug: 32004297
Change-Id: I5f1793633ce3bb72d5641a82502b3ba8b9cdff7d
2016-10-07 10:00:56 -07:00
Hyunyoung Song d8fcffb8fe Add user event logging for tap on search
b/31772967

Change-Id: I71ececb8195d46405623a8ae2a99d001088d9181
2016-10-03 14:01:25 -07:00
Hyunyoung Song 70a421e224 Merge "Consume ACTION_UP when fling is detected on top of icon" into ub-launcher3-calgary-polish 2016-09-30 23:21:05 +00:00
Hyunyoung Song 035a516e18 Consume ACTION_UP when fling is detected on top of icon
Bug: Adam found out that when you swipe down fast on an icon, you can
launch search AND launch an app. Only one should trigger and not both.

Change-Id: I66b9df26d8bb355f011d057dafd45f90f59b82ae
2016-09-30 16:13:55 -07:00
Hyunyoung Song 37ecabc88e Merge "Agressively change the color of the the all apps background during pull up b/30502942" into ub-launcher3-calgary-polish 2016-09-30 20:53:21 +00:00
Hyunyoung Song 81a56f9acc Agressively change the color of the the all apps background during pull up
b/30502942

Change-Id: Iea072d95ed4f62907b164b2c4ee75ad737eccb7a
2016-09-30 12:57:16 -07:00
Tony Wickham f0fc3c4674 Merge "Some minor fixes for extracted status bar." into ub-launcher3-calgary-polish 2016-09-29 01:27:07 +00:00
Tony Wickham 345bff3ce6 Some minor fixes for extracted status bar.
- setLightStatusBar() is now updateStatusBar(), with a forceLight
  parameter. We set the status bar to be light if forceLight or
  shouldBeLightStatusBar() (based on wallpaper).
- Force status bar to be light if all apps is open.
- Default to dark status bar, not light (light == dark icons)

Bug: 29452834
Change-Id: I7b102ceff2f1ef2ab8defd4a46c698df4feaf2a5
2016-09-28 16:53:17 -07:00
Sunny Goyal 7bb7ead9f7 Merge "Fixing the newIntent logic to check the state before it has been reset." into ub-launcher3-calgary-polish 2016-09-28 22:57:56 +00:00
Tony Wickham 9311387a22 Enable light status bar when top of wallpaper is light.
(Light status bar = dark icons)

Bug: 29452834
Change-Id: I9f61a05d80158827761c8b62ab40fc50971e27a6
2016-09-28 14:16:11 -07:00
Sunny Goyal 85313735fa Fixing the newIntent logic to check the state before it has been reset.
When home button is pressed, we reset all active state (close all-apps,
folder, shortcuts menu). But we do not go to the default screen if the
active state was non-zero (any of the containers were open).

Change-Id: Ia9a06729d65767124471c5b793323a55d822210a
2016-09-28 12:42:55 -07:00
Hyunyoung Song ffad962092 Add user event logging for action on search box
b/31772967

Change-Id: Ide652ddfad931e392b21f5a2bbdf9f07729d0383
2016-09-27 18:07:00 -07:00
Sunny Goyal 1b7e9bc063 Merge "Removing reflection from AlphabeticIndexCompat" into ub-launcher3-calgary-polish 2016-09-27 17:03:34 +00:00
Sunny Goyal 70fea7877d Removing reflection from AlphabeticIndexCompat
Bug: 31596662
Change-Id: I23da4a9747daa3cee6cec961fc590d18bf05791a
2016-09-27 09:50:22 -07:00
Tony 1cf412ca91 Don't attempt to add item back to folder when deferring drag.
Since the item hasn't yet been removed until the deferred drag
starts, adding it again will throw an exception (the view
already has a parent).

Bug: 30769920
Change-Id: Icb95aaa64e6e3c5dc105bbf3e54460b529d02033
2016-09-23 18:58:37 -07:00
Tony Wickham 6e74e899d3 Refactor shortcuts drag and drop.
- Instead of creating our own drag view within the container, and
  handling logic to determine when to start a real drag, we start
  the drag immediately and just defer onDragStart().
- To determine when the deferred drag should start, we add a
  DeferDragCondition to DragOptions. The default DeferDragCondition
  never defers a drag, but is overridden for apps with shortcuts
  to defer until the icon is dragged a given distance.
- Because the drag is handled in DragController, including checking
  when to start the deferred drag, DeepShortcutsContainer no longer
  needs to handle touch events and ShortcutsContainerListener has
  been removed.

This change has several immediate benefits:
- The code is much cleaner, because it allows touch handling to be
  done by the DragController through the normal drag flow, without
  recreating logic in ShortcutsContainerListener/DeepShortcutContainer.
- The janky second haptic feedback has been removed (now it vibrates
  when you long press, like everywhere else, but not again when the
  shortcuts close after dragging a distance).
- Drops are animated, instead of just popping the icon back into place.

Bug: 30769920
Bug: 30465972
Bug: 31533078
Change-Id: I679b412b72fbf6c3895d76963311eb5010c8e8db
2016-09-23 18:44:47 -07:00
Tony Wickham c980735560 Merge "Stop jumping to workspace from hotseat on quick drop." into ub-launcher3-calgary-polish 2016-09-23 00:34:53 +00:00
Tony Wickham 39ce3d119b Merge "Remove shortcuts that no longer exist or are no longer pinned." into ub-launcher3-calgary-polish 2016-09-23 00:32:22 +00:00
Tony Wickham 7695e603bf Remove shortcuts that no longer exist or are no longer pinned.
(This change is in the onShortcutsChanged() callback.)

- Remove all workspace icons that correspond to shortcuts that
  are now unpinned
- Remove all workspace icons that have the same package and
  user handle as passed in onShortcutsChanged(), if they aren't
  included in the list of shortcuts that is also passed.

These cases will happen for static and dynamic shortcuts,
respectively, when an app's data is cleared.

Bug: 30316501
Change-Id: I50db6567cb318d087012ab5d8208e765b81c6f99
2016-09-22 16:54:57 -07:00
Tony Wickham e5a00c6172 Move shortcut fade interpolator outside of loop.
Change-Id: I64806897afcd1062dfbaefd6dca07f024f7346af
2016-09-22 13:01:46 -07:00
Tony Wickham 4d917a9793 Merge "Fade deep shorcuts in and out." into ub-launcher3-calgary-polish 2016-09-22 19:55:52 +00:00
Tony Wickham b318c0e396 Fade deep shorcuts in and out.
Animate open:
- Stagger-fade shortcuts as they open
- Become fully opaque before fully open, at which point the
  arrow animates in (scale). This way there is no overlap of
  a translucent shortcut over an opaque arrow.

Animate close:
- Stagger-fade shortcuts as they close
- Delay fade until arrow animation is finished, to ensure
  there is no overlapping of translucent and opaque.

This is much less visually jarring when quickly dragging
and dropping apps with shortcuts.

Bug: 31533078
Change-Id: I8673ee64e92414c718233ea89b70362187e53696
2016-09-22 12:50:58 -07:00
Hyunyoung Song ea045e7532 Fixing two critical bugs in all apps transition controller
am: 0a9c092c89

Change-Id: I115b7bc6d165dc9d5e73e1878b96d194bfc62da7
2016-09-22 18:17:25 +00:00
Hyunyoung Song 1c8c3c1f05 Merge "Make IME less sticky when launching a new app b/31382106" into ub-launcher3-calgary-polish 2016-09-22 00:10:56 +00:00
Hyunyoung Song 7e83ab90ae Make IME less sticky when launching a new app
b/31382106

Change-Id: Iee60a2f7e6a70858623e80d4b8b68154d1941210
2016-09-21 17:03:56 -07:00
Hyunyoung Song 0a9c092c89 Fixing two critical bugs in all apps transition controller
bug#1: if long press from page indicator region, you can pull up all apps
even though the workspace is in overview state.

bug#2: all apps should not intercept touch not only in overview mode
but also in any modal state.

Change-Id: I91c0a181f037f6c2465a983825da3a2da7e2920f
2016-09-20 22:50:06 -07:00
Tony Wickham dbf08b4aee Stop jumping to workspace from hotseat on quick drop.
Regression occurred in ag/1315317.

In that change, Launcher#enterSpringLoadedDragMode() was moved from
the end of startDrag() to the end of onDragStart(). This changed the
sequence of events from:

beginDragShared() --> DragController#startDrag() --> onDragStart -->
dropTarget.onDragOver() --> Launcher#enterSpringLoadedDragMode()

to:

beginDragShared() --> DragController#startDrag() --> onDragStart -->
Launcher#enterSpringLoadedDragMode() --> onDragOver()

Basically, the key difference is that onDragOver() is called after
enterSpringLoadedDragMode(). This matters, because onDragOver()
returns early if Workspace#transitionStateShouldAllowDrop() returns
false, which it does during the spring loaded transition. This meant
that onDragOver() didn't update the layout to be Hotseat, and thus
the current workspace page was used as default, since that is what
was set in onDragEnter(). To fix it, I've copied the logic in
onDragOver() that checks to see if the drag is over the hotseat first
to a new method that onDragEnter() now calls as well.

Bug: 31245181
Change-Id: Ie758921b25fc96516a09c32bdc9706da941522df
2016-09-20 16:48:42 -07:00
Hyunyoung Song 13c14c8f8c Merge "Fix ExtendedEditText not handling touch correctly b/31555902" into ub-launcher3-calgary-polish 2016-09-20 21:10:35 +00:00
Tony Wickham 4125386687 Merge "When shortcuts close, only set text visible if not in hotseat." into ub-launcher3-calgary-polish 2016-09-20 20:49:37 +00:00
Hyunyoung Song 3f9d647de6 Fix ExtendedEditText not handling touch correctly
b/31555902

Change-Id: Ife23cf6af29ac47315aee4abc0ffe2dbcde352f9
2016-09-20 12:37:41 -07:00
Jonathan Miranda 6a7ca92f72 Merge "Only reset search field when back key is hit if there is no query." into ub-launcher3-calgary-polish 2016-09-19 23:08:42 +00:00
Jonathan Miranda 41be5cdea5 Merge "Add context to widget dimensions for accessibility." into ub-launcher3-calgary-polish 2016-09-19 23:04:11 +00:00
Jon Miranda 48542731c5 Uses a TransformingTouchDelegate to extend touch target for widgets list.
am: 0ef81fdc22

Change-Id: I33962020ff1cf75e46254c24687a53fd5b2088fa
2016-09-19 21:43:54 +00:00
Jon Miranda 0ef81fdc22 Uses a TransformingTouchDelegate to extend touch target for widgets list.
The widget row contents were being clipped, which made it seem like
the horizontal scroll was broken.

Bug: 30023607
Change-Id: I00b0c334bbb0faf166d4cd168392cc494ed732e0
2016-09-19 13:08:43 -07:00
Jon Miranda 6c61323998 Add context to widget dimensions for accessibility.
Bug: 19085860
Change-Id: Ia28c2c14b93945d796226eea3de040e971fd42f0
2016-09-19 11:25:39 -07:00
Sunny Goyal d1e5b5ceaa Merge "Updating the paddings in folder cell" into ub-launcher3-calgary-polish 2016-09-19 16:33:40 +00:00
Jon Miranda bb918b3532 Only reset search field when back key is hit if there is no query.
Bug: 31432372
Change-Id: I93c7ee661597f934402f464c4f0182a8fad38d39
2016-09-19 09:31:56 -07:00
Hyunyoung Song 80e6aa4b01 Merge "Fixing issue where overview->normal workspace mode cannot be done by tapping b/31458165" into ub-launcher3-calgary-polish 2016-09-16 19:34:40 +00:00
Sunny Goyal baec6ffae2 Updating the paddings in folder cell
> Updating overall padding for the cell and adding drawable padding
> Ensuring that the folder cell is always rendered properly based
  on available vertical space

Bug: 30605958
Change-Id: I8ceb9fea5a25052b0d7461f52edca0e6a33fa085
2016-09-16 12:05:02 -07:00
Hyunyoung Song f99370c2a9 Fixing issue where overview->normal workspace mode cannot be done by tapping
b/31458165

Because workspaceInModalState makes the VerticalFlingDetector
to consume the touch input, click is not detected in Overview mode.

Placed pulldown to search behind a feature flag.

Change-Id: I31ab69f57944a18e6b264c4f2ed2d0c1175cd940
2016-09-16 12:03:27 -07:00
Tony Wickham f595f3de0f Merge "Don't close all apps when touching deep shortcuts container." into ub-launcher3-calgary-polish 2016-09-16 18:47:48 +00:00
Hyunyoung Song c1c6126745 Merge "Set contentDescription on caret" into ub-launcher3-calgary-polish 2016-09-15 23:31:37 +00:00
Hyunyoung Song c5afad6eb9 Set contentDescription on caret
Change-Id: I1f66b96b3f94649d85857b0107144bb4070ef448
2016-09-15 16:19:14 -07:00
Jon Miranda 488d8adeb8 Use ContextCompat.getColor to support API levels below 23.
Found while debugging on Lollipop.

Change-Id: Ibe97fd30c4ee8cd0c1735a41802b859345f9e931
2016-09-15 15:05:12 -07:00
Sunny Goyal 9784572c47 Adding support for extending the touch target in the touchDelegate
am: 1cc48e1d0c

Change-Id: I29ce4b52a2b687f73b2db4ddb633210e905aad69
2016-09-15 21:33:10 +00:00
Sunny Goyal 1cc48e1d0c Adding support for extending the touch target in the touchDelegate
Bug: 31458312
Change-Id: Ic819bdede2776ff63ec17053cc1326415edc1ca0
2016-09-15 13:37:13 -07:00
Jon Miranda 3f9d6278e3 Fix bug where page indicator animation repeats itself.
Bug: 31501865
Change-Id: I0df77859b82b60fd0e50023e0f5690961850cf6c
2016-09-15 12:40:18 -07:00
Hyunyoung Song 46133612b4 Pull down should start search.
b/31458165

Change-Id: If4821e3d89a05a00551af6a5209ebc1693a1389b
2016-09-15 10:48:25 -07:00
Sunny Goyal 6f28e71e94 Simplifying the startSearch call in launcher callbacks
Change-Id: I722e110903cced237f05667c4d711468d7cd3daa
2016-09-13 14:22:31 -07:00