Commit Graph
948 Commits
Author SHA1 Message Date
Treehugger RobotandAndroid (Google) Code Review 1d235fca54 Merge "Adding CannedAnimationCoordinator to enable running a predefined animation in Launcher" into udc-qpr-dev 2023-08-23 20:28:04 +00:00
Stefan AndonianandAndroid (Google) Code Review 0487d8ee9b Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev 2023-08-21 21:47:58 +00:00
Stefan Andonian 24a963b268 Move WallpaperColorHints RPC calls to a background thread.
Bug: 251502424
Test: Theme behavior still works fine. Compilation worked well.
Change-Id: I18d0b2094f3ba841846ff98567acc7327a7bd220
2023-08-21 20:10:41 +00:00
Sunny Goyal 0ee66478c6 Adding CannedAnimationCoordinator to enable running a predefined animation in Launcher
> The coordinator takes care of recreating animations on layout changes and
   linking it with state animation
> This also ensures that there is only one animation playing at a time

Bug: 293464892
Test: Verified that calling with multiple animations cancels previos call
Flag: None
Change-Id: Iab161720c94843b5834734da78167344c17539c8
2023-08-21 12:55:42 -07:00
Brandon DayauonandAndroid (Google) Code Review 7aaee510db Merge "Remove unused onboardingPrefs" into udc-qpr-dev 2023-08-16 17:49:26 +00:00
Fengjiang Li 98c91a65cf Revert "Revert "Make AllAppsRecyclerViewContainer GONE when hidden""
This reverts commit a163646c7a.

Reason for revert: Re-submit with ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY turned off in child CL (submit together)

Test: Tested in ag/24107285
Change-Id: Ia85c1e8447c45ff44814ad4bfe0f178a72d0e7d3
2023-08-04 10:28:36 -07:00
Inseob KimandAndroid (Google) Code Review a163646c7a Revert "Make AllAppsRecyclerViewContainer GONE when hidden"
This reverts commit df59c2e535.

Reason for revert: b/293944420

Change-Id: I0ae830e1a5ba8affb6815c9e96ffee1b20c6e8d0
2023-08-04 02:18:44 +00:00
Fengjiang Li df59c2e535 Make AllAppsRecyclerViewContainer GONE when hidden
Test: N/A
Flags: ALL_APPS_GONE_VISIBILITY
Bug: 264341825
Change-Id: I28933c08e80b95bcd5031da9869b37f34f6408b2
2023-07-31 10:41:58 -07:00
Brandon Dayauon 8bd8819796 Remove unused onboardingPrefs
bug: 285890538
Flag: false- ENABLE_SHOW_IME_SNACKBAR_AGAIN
test: manual
Change-Id: Ib84133d47d9cbadeb65f3b28a9e4a1558bca8258
2023-07-28 12:15:44 -07:00
Fengjiang Li da718e9749 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-07-20 11:08:14 -07:00
Vinit Nayak 15a9feb67f Add support for taskbar phone 3 button seascape
* Ignore orientation check from ag/22709055 for now,
that will be reverted. This causes recreateTaskbar() to
not run when folding the device

Bug: 274517647
Test: Tested 3 button nav in portrait/landscape/seascape
Flag: persist.wm.debug.hide_navbar_window
Change-Id: Ied02ead677d496b465c748257e32b7db5eb9580c
2023-07-06 13:58:30 -07:00
Fengjiang Li 1519c168da Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
This CL ensures no inflation of BubbleTextView happens while binding applications, and reduces jank on slow device.

1. Let active/inactive all apps RVs share the same AllAppsRecyclerViewPool
2. Use worker thread to pre-inflate BubbleTextViews and add them to shared view pool on main thread

Bug: 287523421
Test: See before/after screenshot/video/trace attached in bug
Change-Id: I00213407be2c7c2d329997552785d0aa56c4d057
2023-07-05 13:07:26 -07:00
Holly Sun 35b9960b63 [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Thales Lima 2759aa345b Decrease icon size by steps
When the icon can't fit the cell size, decrease it by steps defined by UX until it fits or reach a minimum size.

Fix: 283929701
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: IconSizeStepsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I2875b669c0a24ecd1c4d785a33e2cffb78c9fe76
2023-06-20 20:37:38 +01:00
Anushree GanjamandAndroid (Google) Code Review 66b03a42e0 Merge "Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED." into udc-qpr-dev 2023-06-09 13:50:31 +00:00
Andreas Agvard edd9c96e70 Added utility function to VibratorWrapper for generating Assist hapic
Test: Manual

Change-Id: I14c1c4e5a5c1aef54de12524282d21f16c4021c0
2023-06-08 21:40:17 +00:00
Anushree Ganjam caf2c0ffb0 Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED.
Launcher Search related educards is being sent from AiAi now and we
don't need to hold the count in launcher.

Flag: NA
Bug: 265476821
Test: Manual

Change-Id: I5374e7cab6551d44fc995adb3b3a46173169ab6c
2023-06-06 18:59:06 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Santiago Aboy SolanesandAndroid (Google) Code Review 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy SolanesandAndroid (Google) Code Review ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Vinit NayakandAutomerger Merge Worker c2545b82cc Merge "Add logs for launcher user cache" into udc-dev am: 43c79d23b3 am: d7037d07e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23523872

Change-Id: I5a512981f5776174f079dca8b81fc3e3fe069a83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 04:24:56 +00:00
Vinit NayakandAndroid (Google) Code Review 43c79d23b3 Merge "Add logs for launcher user cache" into udc-dev 2023-06-02 02:57:40 +00:00
Vinit Nayak 134e429189 Add logs for launcher user cache
Bug: 243688989
Flag: None
Change-Id: I6f6ea3f3326c1814c2a50863e9bfbcb7e4323ae8
2023-06-01 17:11:42 -07:00
Sunny GoyalandAndroid (Google) Code Review 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Vadim TryshevandAutomerger Merge Worker 01a4b4990a Merge "Fixing a flake when workspace loading never finishes." into udc-dev am: 5fe61d4ff7 am: 88ad0211ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493702

Change-Id: Ia6a4ac682df6d374029823333faa9746ab75d991
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 02:04:01 +00:00
Vadim TryshevandAndroid (Google) Code Review 5fe61d4ff7 Merge "Fixing a flake when workspace loading never finishes." into udc-dev 2023-06-01 00:50:25 +00:00
vadimt 9c102e5634 Fixing a flake when workspace loading never finishes.
The flake was caused by the fact that addOnDrawListener(), the redraw is not guaranteed. This ultimately results to the workspace loading never finishing.
Forcing the redraw.

Bug: 267200150
Test: atest Launcher3Tests:com.android.launcher3.celllayout.ReorderWidgets#simpleReorder --rerun-until-failure
Flag: N/A
Change-Id: I47683425150a07ab2632e2bebdeca4d304e30d1b
2023-05-31 10:59:25 -07:00
Kateryna IvanovaandAndroid (Google) Code Review 72fbdc7976 Merge "Migrate Interpolators from Launcher3 to the public animation library" into udc-qpr-dev 2023-05-31 15:25:40 +00:00
TreeHugger RobotandAutomerger Merge Worker 76a7def698 Merge "Possibly fix the widget restoration bug" into udc-dev am: 7dabd57f2d am: 8fbd56b2c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23481736

Change-Id: Iade89cc8961c46bacfd3ceeec189cb5f03df635b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 03:20:09 +00:00
Sihua Ma 48465319f6 Possibly fix the widget restoration bug
The update will always be considered as failed because we always return 0 for all the commits.

Test: N/A
Bug: 234700507
Change-Id: I33ee8af996cef62dbc14349f9a7dd3cb72836ab6
2023-05-30 15:12:00 -07:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Stefan Andonian cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00
Alex Chau ff2a8382fc Add additional logs when DisplayController detects unexpected bounds
Bug: 283944974
Test: manual
Change-Id: I8f50c79e00be0a4be812634678e9e05a80343a07
Merged-In: I8f50c79e00be0a4be812634678e9e05a80343a07
2023-05-24 15:24:03 +00:00
Alex Chau 5fa9a2f49b Add additional logs when DisplayController detects unexpected bounds
Bug: 283944974
Test: manual
Change-Id: I8f50c79e00be0a4be812634678e9e05a80343a07
2023-05-24 15:23:39 +00:00
Anushree GanjamandAutomerger Merge Worker b6bf68a1c8 Merge "Add AGA_SESSION_SUMMARY_LOG for session summary log debugging." into udc-dev am: a2de64b8e7 am: 640b85c976
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23355101

Change-Id: I2c9f8b368abd181e96dde7b0a2bf79da6d559d63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:25:33 +00:00
Anushree Ganjam 0f54a897bb Add AGA_SESSION_SUMMARY_LOG for session summary log debugging.
adb shell setprop log.tag.AGASessionSummaryLog V

Bug: 283829335
Test: Manual
Flag: NA
Change-Id: I90da76f1db1a103e49171bbc7499cd79606d3fcf
2023-05-22 19:48:43 +00:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Alex Chau 7af659da9e DisplayController should deep compare mPerDisplayBounds
- In CHANGE_SUPPORTED_BOUNDS check, it uses Map.equals, but as the value is a primitive array WindowBounds[], equals check does not deep compare the arrays and may result in false negative
- One example is when fontScale changes, DisplayController re-create bounds from WindowManagerProxy, result in new WindowBounds[] created, and the shallow compare results in unexpected CHANGE_SUPPORTED_BOUNDS

Fix: 282736623
Test: DisplayControllerTest
Change-Id: I3897595c58559192b951ecfee7c9f62a07dafe1f
2023-05-17 09:40:46 +00:00
Vinit NayakandAndroid (Google) Code Review a6e7a4b574 Merge "Don't throw exception for SafeCloseable objects" into udc-dev 2023-05-16 17:52:54 +00:00
Vinit Nayak fa5a61c8db Don't throw exception for SafeCloseable objects
* SafeCloseable objects will have their close() method
called when SandboxContext is destroyed, so we can leave
them out of the allowList.
* Long term we may want to remove the allowList altogether
and just rely on safeCloseable

Test: Locally passes
Flag: not needed
Bug: 280463854
Change-Id: I317a9d6639b25a522fe9dbcf2655b55ec68fded6
2023-05-15 18:56:55 -07:00
Sunny Goyal 7bc6cdee56 Revert "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""""
This reverts commit 09905cfa90.

Reason for revert: Fixed the crashing issue

Change-Id: Ibcfc28a89356d262e67e8842d6bae37e230a70f5
2023-05-13 01:59:19 -07:00
Vinit Nayak 88a91bbd16 Add logs to check which userId is used for workProfile matcher
Flag: none
Test: compiles
Bug: 243688989
Change-Id: I0a579203cc0c51f7707180b323ed4828f1dea297
2023-05-11 14:55:00 -07:00
Sunny GoyalandAndroid (Google) Code Review 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Holly Jiuyu SunandAndroid (Google) Code Review ae1c56e34d Merge "[play] Add debug config flag to GMS Play." into udc-dev 2023-05-05 06:55:43 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
Fengjiang Li 5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Schneider Victor-tuliasandAndroid (Google) Code Review 8c1bffb24f Merge "Remove unused debug logs" into udc-dev 2023-04-27 17:44:42 +00:00