Commit Graph

5899 Commits

Author SHA1 Message Date
Wei Sheng Shih 4cd75a1aae Merge "Cancel the recents animation for locked gesture[2/2]" into tm-qpr-dev 2022-05-30 01:48:07 +00:00
TreeHugger Robot db9a5bb80b Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118 am: a947c74b11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I9246c6ca0df462853195bf11d29dc210bcc9fa55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-28 00:05:16 +00:00
Alex Chau 4eebbac3b7 Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion

Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak 1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Jeremy Sim a930633884 Merge "Fix Overview screenshot bug in fake landscape" into tm-qpr-dev 2022-05-26 01:02:20 +00:00
Sunny Goyal 6d6defb472 Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc am: f6df7d76ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002

Change-Id: I833d70f3d0fa24020ef6eed3394f3c84e6afb5c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 23:11:01 +00:00
Jeremy Sim aba72f50b9 Fix Overview screenshot bug in fake landscape
Fixes an issue where the user would not be able to take a screenshot through the Overview menu when:
1) the task thumbnail was in LiveTile mode and
2) the phone was in fake landscape.

The issue arose because all Overview menu items, upon selection, were forcing LiveTile to end immediately, even before running the onClick method of each menu item. In the case of screenshots, this resulted in the onClick method being unable to take a screenshot because LiveTile was already ended.

This fix prevents Overview menu items from always forcing LiveTile to end, instead allowing each onClick method to determine its own order of operations and end LiveTile when appropriate. The functionality of all other current menu items (Select, Split, etc) should not be affected by this change.

Fixes: 231047451
Test: Manual
Change-Id: Ibfc79a114718fc4674dc434a907044184c7f5dd0
2022-05-25 15:48:59 -07:00
Sunny Goyal 279911fafc Merge "Creating the transaction on the UI thread" into tm-dev 2022-05-25 22:24:04 +00:00
Brian Isganitis 0bc68242ee Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-qpr-dev 2022-05-25 20:27:21 +00:00
TreeHugger Robot 6687578d1e Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59 am: 60273b856b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686

Change-Id: I8a842caecf2b929ddadf765137bf0d36465032c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:42:31 +00:00
TreeHugger Robot 9557b10c59 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev 2022-05-25 18:48:17 +00:00
TreeHugger Robot 8398c12649 Merge "Update vibrations in the All set page to match the SUW welcome page." into tm-qpr-dev 2022-05-25 18:30:06 +00:00
Brian Isganitis a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00
Vinit Nayak ac8c6f817b Merge "Hide taskviews when animating to split" into tm-qpr-dev 2022-05-25 17:19:03 +00:00
Schneider Victor-tulias 3efef1ce5a Attempt to preload the Launcher activity when the user reaches the All Set Page.
Preloading the Launcher activity once the user reaches the SUW All Set app allows for a smoother first reveal transition. Refactored TIS and TISBinder to make this possible.

Fixes: 226726244
Test: factory reset and flashed a build onto a pixel 6 pro
Change-Id: I1be3383bafdde17b951329de4c7d6b87affd210c
2022-05-25 10:02:20 -07:00
Alex Chau e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
wilsonshih 2b06fa518b Cancel the recents animation for locked gesture[2/2]
When device is locked and going to finish the recents animation,
instead of start home activity, calling
finishRunningRecentsAnimation directly so core and shell does not need
to handle another transition.

Bug: 230582311
Test: enable shell transition. Start showWhenLocked activity while
keyguard showing. Scroll up to dismiss the activity and verify the
activity and home shall be stopped and only keyguard remains on the
screen.
Also verify entering recents works fine when device is unlocked.

Change-Id: Ic76f81efcaa8ed00d5af1475259ec16659f6b568
2022-05-25 12:57:32 +08:00
Sunny Goyal cdc111a158 Creating the transaction on the UI thread
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error

Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Sunny Goyal 51cbd323e2 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316 am: 57a956911c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212

Change-Id: I63c8780cd914488282f1159037e3d6e31bbd87da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 22:15:02 +00:00
Vinit Nayak 7608cfd628 Hide taskviews when animating to split
* Move FloatingTaskView to drag layer to
keep it from showing up on top of the
TaskMenuView that is animating to a close

Bug: 232804154
Change-Id: Ifaa3286c48509d1f60a559bb4d318988a1d30679
2022-05-24 18:41:42 +00:00
Schneider Victor-tulias 2edbe23513 Update vibrations in the All set page to match the SUW welcome page.
Fixes: 211844049
Test: opened the all set page on different devices, tested with different supported vibration effects
Change-Id: I0b86dae3bec28ff56a3a23f9bb65dcbdb1b27325
2022-05-24 18:30:11 +00:00
Sunny Goyal 4a35dd4f0d Do not launch home disambiguation screen when home is not known
Bug: 233071361
Test: Verified on device
Change-Id: I54e71e19363920b0778c328dc391575d0921f304
2022-05-23 23:30:58 +00:00
Jeremy Sim b0cce86385 Implement non-disappearing View for split staging instructions
The instructions for how to perform a splitscreen operation, previously conveyed through a disappearing Toast, are now conveyed through a custom View object.

Fixes: 219987907
Test: Manual
Change-Id: Iff2bb6e334e0325e8a091d76a5f9b8767071365f
2022-05-23 21:23:22 +00:00
Sunny Goyal 617f9fae3d Avoiding updating task via scroll if RectF spring animation is running
Bug: 231333965
Test: Verified no update at the end of home transition
Change-Id: I2a106f4d7661f9d409425ce2ed755e74e1abe14b
2022-05-23 10:13:10 -07:00
Alex Chau 51da219869 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-23 14:33:34 +01:00
Winson Chung c6df6edabe Merge "Ensure that we're animating the current live tasks when going back" into tm-dev am: 3e6cd99990 am: 1b7350f27c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18461390

Change-Id: Iee286ed20fe9529aa1efb19004a4448192980370
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-19 08:24:30 +00:00
Luca Zuccarini a3719625f2 Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev am: 175fc66aa8 am: 22bb04bb77
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18375247

Change-Id: Icac6fe62259ac76d7527c8ab4cea91b11b21ac55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:40:24 +00:00
TreeHugger Robot 5a5434cbdc Merge "Fix crash if AM returns empty task list" into tm-dev am: aca91898a8 am: 634e5ac012
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18379858

Change-Id: I5d0c414b24d27f69d464baee6d7ad206c42fbe96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:29:00 +00:00
Luca Zuccarini 30a46a02fa Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev am: 3eb149b055 am: b742969fb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18185506

Change-Id: I3b2437ea0ddca4a4b61ce0c93e24f4f45ffa2246
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:16:49 +00:00
Vinit Nayak 8c20d2a4e4 Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev am: cfdb076d12 am: 24b9ebfd07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18286602

Change-Id: I81107a37b37a91652ad4a671c2032ad8759e836a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:16:38 +00:00
TreeHugger Robot 40a5591250 Merge "Revert "Snap to last task if swiping down at a greater Y than X velocity."" into tm-dev am: a3ce2fc552 am: 3b23f648fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420831

Change-Id: Idcd6b99af6e293cdff277629b59f93b568fc2589
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:16:33 +00:00
Sunny Goyal 05d17176b1 Merge "Fixing transaction applier holding on to the release check if no frame update was scheduled" into tm-dev am: 6956b5cc7c am: 0cf8a8f3d0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18360436

Change-Id: Ibb52b44f1692d7ee74e13d3a349a4385fb2902bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:06:37 +00:00
TreeHugger Robot 9d7f0308d9 Merge "Clear recents animation controllers and recents animation snapshots synchronously." into tm-dev am: 6ac4f9e882 am: c3d101b0f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18243102

Change-Id: Ib44c817baea867445cd536801e485f76285cab35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:03:13 +00:00
Winson Chung b6fa2ce486 Ensure that we're animating the current live tasks when going back
- The other call to launch tasks animated doesn't work for the current
  task you swiped from when in split.

http://recall/-/g6hkB0pXjyQSvfA8STqRAT/bKHWGjhf2yQVpmRkvn3aeD

Bug: 223750399
Test: Enter overview, swipe back
Test: Enter overview from split, swipe back
Change-Id: Icbe2944df2bb382e072c2890001d7eae505a7b04
2022-05-18 18:46:54 +00:00
Luca Zuccarini 175fc66aa8 Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev 2022-05-18 14:21:27 +00:00
TreeHugger Robot aca91898a8 Merge "Fix crash if AM returns empty task list" into tm-dev 2022-05-17 23:26:17 +00:00
Sunny Goyal 8b5be54b47 Fix crash if AM returns empty task list
Bug: 231630259
Test: Verified on device
Change-Id: I15a48def7f7a7715adbbff94e29e889da100551e
2022-05-17 11:11:45 -07:00
Luca Zuccarini 3eb149b055 Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev 2022-05-17 16:06:27 +00:00
Vinit Nayak cfdb076d12 Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev 2022-05-17 13:56:51 +00:00
TreeHugger Robot a3ce2fc552 Merge "Revert "Snap to last task if swiping down at a greater Y than X velocity."" into tm-dev 2022-05-17 07:24:00 +00:00
Vinit Nayak 2cb5cb5d00 Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar
Bug: 205493938
Change-Id: I196bc52c1bec75b5442f3546f466799ba9c3831b
2022-05-16 21:38:28 -07:00
Brian Isganitis 1f60acd68d Revert "Snap to last task if swiping down at a greater Y than X velocity."
This reverts commit e10ab8cdcd.

Reason for revert: Possibly introduced regressions. There was a followup to this CL that was also reverted. Would prefer to revert this one too and then roll forward with a CL that addresses all problems.

Change-Id: Ic32ad10945e4ace2f985475d24adb6a80b19067f
2022-05-17 00:16:56 +00:00