Winson Chung
a87e251a6b
Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09 am: 9b3c0a7ae8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339
Change-Id: I7e23e46f1f88650cf274be66dd3dc189e930996a
2021-07-03 03:59:16 +00:00
Winson Chung
9b3c0a7ae8
Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339
Change-Id: I0934d3e3125f0da439eb97461572bbf23c6b5298
2021-07-03 03:41:59 +00:00
Winson Chung
a82403ab09
Merge "Fix crash when handling recents animation canceled" into sc-dev
2021-07-03 03:26:26 +00:00
Winson Chung
553d978012
Fix crash when handling recents animation canceled
...
- If Launcher finishes the animation, that also cleans up the screenshot
on the server side, so we can skip calling it
Fixes: 192684578
Test: N/a, adding a null check
Change-Id: Ia6b99b4262e72f925e7d622ea8833d3c88252633
2021-07-03 03:26:16 +00:00
Tracy Zhou
f203bb6839
[DO NOT MERGE] Make the cutout slightly smaller am: 26f47c711a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081309
Change-Id: I577deccb5a0e5211127ce6a84764ce53a2b7a89a
2021-07-02 21:54:18 +00:00
Tracy Zhou
ee5dc1149e
Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev
2021-07-02 21:41:28 +00:00
Tracy Zhou
26f47c711a
[DO NOT MERGE] Make the cutout slightly smaller
...
Temporary fix for S. Leaving the bug open for a proper fix in T.
Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Sunny Goyal
b7477c97e5
Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734 am: e6704c17f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733
Change-Id: Ie31b8673cadabf99149665f9a7b1a9fb95d953a3
2021-07-02 18:57:51 +00:00
Tracy Zhou
ed5b2b3bab
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05 am: f3e9774ca6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810
Change-Id: I32da1bf258c69d9c694465428e37ffbd110950f5
2021-07-02 18:56:35 +00:00
Sunny Goyal
e6704c17f2
Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733
Change-Id: Ib647d00090d4c670ee2bbe229f05be44489fa725
2021-07-02 18:36:05 +00:00
Tracy Zhou
f3e9774ca6
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810
Change-Id: Iaea762668329b7068ed366f3588b4a679efce624
2021-07-02 18:35:47 +00:00
Sunny Goyal
6348858734
Merge "Fix some touch issues during gesture nav transition" into sc-dev
2021-07-02 18:33:34 +00:00
Tracy Zhou
fa72529b05
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev
2021-07-02 18:18:23 +00:00
Alex Chau
2407895226
Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev am: 34c449d72e am: d942860979
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15179052
Change-Id: Ic3bad54342eb7909e48209b13b1d966585366416
2021-07-02 17:46:39 +00:00
Alex Chau
d942860979
Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev am: 34c449d72e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15179052
Change-Id: Iff6bc95c4a7b761ee5433d3091d1ec22cec1b9f0
2021-07-02 17:32:45 +00:00
Alex Chau
34c449d72e
Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev
2021-07-02 17:20:30 +00:00
Alex Chau
b297c7e615
Add screen record for failing TaplTestsQuickstep
...
- For debugging failures that only happnes on cuttlefish
Bug: 191344757
Test: TaplTestsQuickstep
Change-Id: Iac16e222dc7b60f94e1eb7f305c5ccb909161783
2021-07-02 15:14:05 +01:00
Tracy Zhou
d2039614e0
Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
...
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Tracy Zhou
19655085ca
Enable live tile in 3 button mode am: 1fe5fda3d8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14254546
Change-Id: I495dbe5d3a3ee146b98a36c69b7f941a4cc6ef8a
2021-07-02 06:51:52 +00:00
Tracy Zhou
ba5a129f32
Enable live tile in 3 button mode am: d09ebe660f am: 740b2381c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133050
Change-Id: Ie928474fe22f10bd3b246679ab47ab20a7052b7d
2021-07-02 05:30:11 +00:00
Tracy Zhou
740b2381c4
Enable live tile in 3 button mode am: d09ebe660f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133050
Change-Id: I779ad9e03302864b1a2f59a8da7092917c0f72ad
2021-07-02 05:21:57 +00:00
Tracy Zhou
1fe5fda3d8
Enable live tile in 3 button mode
...
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou
d09ebe660f
Enable live tile in 3 button mode
...
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Alex Chau
43e40493fa
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca am: e526fd6a00
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I25d921c104e5285fa163124d2b0863cda5a9bc45
2021-07-01 22:49:27 +00:00
Alex Chau
35d8b03a97
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca am: 66b5af2ac2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I016cc95e7d86f145ef7dde642c811099c4049d1f
2021-07-01 22:36:55 +00:00
Alex Chau
e526fd6a00
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I4cc43374c577299c7be3d63bb8a7393a90447231
2021-07-01 22:28:30 +00:00
Alex Chau
66b5af2ac2
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: Icaebfb0b8ea2de3109030f140b3dabbc139e1aa2
2021-07-01 22:27:22 +00:00
Alex Chau
679f8bb9ca
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev
2021-07-01 22:12:54 +00:00
Tracy Zhou
1fcb289e9b
Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev am: e54f789de9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15176734
Change-Id: I7b570013c9600d32a76c72f2a0ba8847ea04a069
2021-07-01 19:45:17 +00:00
Tracy Zhou
e54f789de9
Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev
2021-07-01 19:32:39 +00:00
Jonathan Miranda
8e7c617775
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120 am: e6f0509d1d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I9b3d03c8050ac47e0368161dba58110b0e047605
2021-07-01 18:48:39 +00:00
Sunny Goyal
cac11af5a1
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1 am: 2e5176e51f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: Ie2e2042efc2048e9d2d66a5fea40b5470b771359
2021-07-01 18:48:29 +00:00
Jonathan Miranda
35bcb6f40d
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120 am: 1376feeb22
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I2af5ce38052ad6eaf8234bfff93603e52f7e0e2d
2021-07-01 18:48:18 +00:00
Sunny Goyal
835dce9cde
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1 am: ebd8b75a9e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: Ide88a388dc866aef38e2bf4d7ceb7cff179a7799
2021-07-01 18:48:04 +00:00
Jonathan Miranda
e6f0509d1d
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I38ace4adec4591e9259a8859ed547e1b951b922c
2021-07-01 18:36:20 +00:00
Jonathan Miranda
1376feeb22
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: Ib47cb13c6af50c0c9d5c6ec285beca09e88f2d41
2021-07-01 18:35:36 +00:00
Jonathan Miranda
3334c32120
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev
2021-07-01 18:34:47 +00:00
Sunny Goyal
2e5176e51f
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: I3e8d01451a9ad4b14128bf90a9d758e922d04f4e
2021-07-01 18:32:02 +00:00
Sunny Goyal
ebd8b75a9e
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: I33bdf5f8dbacef076c6441a2309c308252143370
2021-07-01 18:31:07 +00:00
Sunny Goyal
f3d3dcf4a1
Merge "Fixing some dimentions in AllSet activity" into sc-dev
2021-07-01 18:16:45 +00:00
Winson Chung
d9cff07959
Merge "Remove unused logs" into sc-v2-dev am: efa5e9f5ea am: a717b7b45a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15167125
Change-Id: I36a13d6621db04060c6d26c9bbc86a907b35f50f
2021-07-01 18:05:23 +00:00
Tracy Zhou
4986376828
Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev am: d25ee3294c am: 89f8d0763d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158868
Change-Id: I09acf90f0b002e801c9706d8cd88bf9dbf9d853d
2021-07-01 18:02:45 +00:00
Tracy Zhou
99adef95b3
Do not switch to screenshot and finish recents animation for menu options that already do so
...
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.
Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau
e0fcee01b3
Restore previous currentPage in applyLoadPlan in case task is re-ordered
...
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham
5fac02bc5e
Fix some touch issues during gesture nav transition
...
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
- Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
- Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
- Test: swipe up to go from an app to home, swipe up to all apps during the transition.
- Previously, we were getting the following sequence:
1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
- Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.
Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung
a12450e7dd
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2 am: bc5819ad4c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: Ie3e85c1f419e9faecc3a9bc73db1626001978be7
2021-07-01 17:28:10 +00:00
Winson Chung
927059c8be
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2 am: 2ae6a3e3c9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: I717210002017b6ed71bfa49a90171f4e32a7532f
2021-07-01 17:16:24 +00:00
Winson Chung
2ae6a3e3c9
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: I4183018dbe6ad644824f842cae259ab0786c9657
2021-07-01 17:15:48 +00:00
Winson Chung
a717b7b45a
Merge "Remove unused logs" into sc-v2-dev am: efa5e9f5ea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15167125
Change-Id: I12a6c3dd689fdeda918809b6848772b97bd9b376
2021-07-01 17:15:29 +00:00
Winson Chung
bc5819ad4c
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: Ic27229e49360d62d6fcd6bda498bfbb601b5e7ee
2021-07-01 17:14:55 +00:00