Commit Graph

10313 Commits

Author SHA1 Message Date
Tracy Zhou b1e003c1fb Merge "Support having dup items in folder for migration" into ub-launcher3-rvc-dev 2020-06-23 16:12:25 +00:00
Tracy Zhou 76773cd210 Support having dup items in folder for migration
Fixes: 159312066
Test: Have two dup items in a folder under one grid setting. Migrate. Make sure the folder is migrated correctly to the new grid setting.
Change-Id: Ic5aeb30a1c8acb382bccf744d7553913d8a8a320
2020-06-23 00:29:23 -07:00
TreeHugger Robot 7cb6d738c0 Merge "Eliminating messages that launcher activity is frozen" into ub-launcher3-rvc-dev 2020-06-23 06:09:26 +00:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
vadimt 839fb7b3ae Eliminating messages that launcher activity is frozen
They were ultimately caused by killing Launcher process from tests.

Now having a test info handler request to clear db.

Bug: 152629799
Change-Id: Ia81ddc3e338718c4cff08c7396b9fda1b7091024
2020-06-22 15:39:19 -07:00
Thiru Ramasamy 51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
Vadim Tryshev 21cea8e55c Merge "Changing event check implementation from logcat to TestProtocol" into ub-launcher3-rvc-dev 2020-06-22 20:42:23 +00:00
thiruram ec75cbd85a Adds additional folder label states (UNLABELED & EMPTY_LABEL)
UNLABELED -> title==null and EMPTY_LABEL -> title=="". When adding new items for the folder if the folder is in UNLABELED state, auto-labeling will be enabled.
This change also addresses auto-labeling issue due to false edit from UNLABELED to EMPTY.

Bug: 159164315

Change-Id: Ia17cd27b4afb60420dc15c544f544061fc46ad33
2020-06-22 13:24:07 -07:00
Hyunyoung Song 5c9a1ef5cd Merge "Log Launcher transitions to WW" into ub-launcher3-rvc-dev 2020-06-22 20:21:10 +00:00
Hyunyoung Song 801f81fba5 Log Launcher transitions to WW
- ONRESUME / ONSTOP
- HOME_GESTURE
- OVERVIEW_GESTURE
- QUICKSWITCH
- SWIPELEFT/SWIPERIGHT

Bug: 156875719
Bug: 148822714
Bug: 137777105

Debug log: go/launcher-log-parity

Change-Id: I64a0deab4996b5be36320fbe0339f320891c53e0
2020-06-22 12:09:06 -07:00
vadimt a17a10cddd Changing event check implementation from logcat to TestProtocol
Bug: 153670015
Change-Id: Id9fc759bd5be68758ef9cf0abbba3cd6fa452796
2020-06-22 11:04:03 -07:00
Samuel Fufa 6dac493218 Merge "Send app launch events from TaskSwitcher" into ub-launcher3-rvc-dev 2020-06-22 17:36:12 +00:00
TreeHugger Robot 845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Winson Chung c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung 4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00
Jayaprakash Sundararaj 1d96ba03ab Refactor FolderNameInfos.
Bug: 159508969

Change-Id: I984e7a4fc321392d06157c705392c1ba5672f348
2020-06-19 23:12:22 -07:00
thiruram 8bcb48cc1b Log LAUNCHER_FOLDER_AUTO_LABELING_SKIPPED events.
These events will help to understanding recall reduction is due to data coverage vs label coverage.

Bug: 159495871
Change-Id: Ia5e2cbab86f5f2072f9674fbd6abcdbc049929ee
2020-06-19 17:58:55 -07:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
Jon Miranda 36d1015997 Add depth animation when multiwindow mode changes.
This is a workaround until we can support app transitions when starting
an activity in mw mode.

Bug: 158613217
Change-Id: I843d6669722c543728ab532e1c4fbd4643f6f135
2020-06-19 16:36:57 -07:00
TreeHugger Robot f9ae1a838a Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev 2020-06-19 23:22:54 +00:00
Hyunyoung Song bb8257344c Merge "Fix a potential concurrency issue for loading CDB file Bug: 158919530" into ub-launcher3-rvc-dev 2020-06-19 21:48:30 +00:00
Samuel Fufa 56b35b9d0a Send app launch events from TaskSwitcher
Sends AppTargetEvent with action launch and container CONTAINER_OVERVIEW to AppPredictor when user launches app form recents.

Bug: 155996363
Test: Manual
Change-Id: I3eb38f5737ecaeb07e59db460e8d809416132825
2020-06-19 14:14:52 -07:00
Sunny Goyal 9d89f75ce4 Fixing fallback recents not getting proper insets on configuration change
> Using common code for Launcher and recents for insets dispatching
> Fixing recents auto closing when there is no running task

Bug: 158750568
Bug: 159133601
Change-Id: Iee25c603a77a1ac546ada1840f3afaf5797b8802
2020-06-19 11:41:53 -07:00
Vadim Tryshev 84aaecca64 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev 2020-06-19 16:37:41 +00:00
Hyunyoung Song d98d5ebedc Fix a potential concurrency issue for loading CDB file
Bug: 158919530

Change-Id: I00ddbaeebaed3aa669948cde7fbac0cf4ad86301
2020-06-19 02:09:15 -07:00
TreeHugger Robot 5c33e250fc Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev 2020-06-19 01:42:09 +00:00
TreeHugger Robot 92b0b1d0a1 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev 2020-06-19 01:28:25 +00:00
Samuel Fufa 1d08cc681c Follow up for ag/11916646
- Fixes launcher breakage

Bug: 159170242
Change-Id: Ib21bfee8d5f63d31a8807ad87ac47d600fb62e7a
2020-06-18 17:57:39 -07:00
Jon Miranda 271638574f Add spring to workspace scale when going from Hint state to Normal state.
Bug: 151768994
Change-Id: If03d39e5ef6319355a7691d60fc0152de2fc3cec
2020-06-18 17:53:07 -07:00
TreeHugger Robot c471a9a6bb Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev 2020-06-18 23:34:58 +00:00
TreeHugger Robot e49de265da Merge "Deprecates LAUNCHER_ALL_APPS_RANKED event." into ub-launcher3-rvc-dev 2020-06-18 23:28:35 +00:00
Samuel Fufa cb771349da convert HOTSEAT_MIGRATE_TO_FOLDER to DebugFlag
Bug: 159282737
Change-Id: Ided5ff36ee9c8792b9d9942814af15ac4c7ed7db
2020-06-18 15:08:19 -07:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
Samuel Fufa 44c1b5e03d Show a snackbar on predicted icon longpress
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.

Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
2020-06-18 10:57:32 -07:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00
Becky Qiu 6fb99518ef [Overview Actions] Add overview actions events.
Event IDs were generated by command line on my workstation by uieventscli.
Manually added to StatsLogManager.

Test: local
Bug: 158477117
Change-Id: Ia237d1d9b1d5a52767cac44ab0b4a6d2500b9686
2020-06-18 03:04:45 +00:00
TreeHugger Robot 1f325ab01e Merge "Don't reset RecentsView in onIdpChanged()" into ub-launcher3-rvc-dev 2020-06-17 18:15:39 +00:00
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Tony Wickham f2b8c927a9 Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev 2020-06-16 22:12:28 +00:00
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
Hyunyoung Song 730c238b8d Call displayCompletions couple frames after selectAll is called
Bug: 158710542

Change-Id: I295adce9d84bb82c4af27b7e54693ce4c64004cc
2020-06-15 13:54:54 -07:00
Tony Wickham 9459f3101f Don't reset RecentsView in onIdpChanged()
Resetting unloads visible task data and thus will leave recents
blank if overview state is enabled. Instead, unload and reload
visible task data to take new icon shape into account.

(The reason we're getting onIdpChanged() on nav bar mode change
is because the change in nav bar height causes the computed icon
size to change very slightly.)

Also fix InvariantDeviceProfile copy constructor by copying
iconBitmapSize.

Test:
- Change between 0 button and 3 button nav modes, verify recents
  doesn't appear blank
- Change icon shape in Styles and Wallpapers and go to recents,
  verify icon shape is reflected in task icons

Bug: 156354328
Change-Id: Ife29f51e85814ff483d055005fa2645135d5ec3d
2020-06-15 14:02:12 -05:00
Sunny Goyal b10e865e48 Preventing parallel motion event dispatching from view system and event proxy
1) When view system is already dispatching an event, proxy-dispatch is restricted
   to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
   takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
   proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
   dispatching only (and proxy-dispatch is already restricted to gesture only).

Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
2020-06-15 11:50:54 -07:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
TreeHugger Robot 161ed5ad9b Merge "Announce folder content size with folder title" into ub-launcher3-rvc-dev 2020-06-12 21:55:33 +00:00
Tony Wickham d2d9837b3e Merge "Skip fling anim if it is a no-op, to save a frame of aniamtion" into ub-launcher3-rvc-dev 2020-06-12 21:10:29 +00:00