Commit Graph

1454 Commits

Author SHA1 Message Date
Sebastián Franco b0f32ea815 Merge "Ensure the reorder test runs on the foldable devices" into udc-qpr-dev 2023-08-08 17:52:33 +00:00
Sebastian Franco a99e1d2a14 Ensure the reorder test runs on the foldable devices
It moves some classes form the Nexus package into the launcher package
so it can be used in both projects.

It also adds more test for foldables and test multiple
grids for each test.

Bug: 289584301
Fix: 291346193
Test: ReorderWidgets
Change-Id: I04db5f685d0344b8a3f3d42b429bbde061b3d8ea
2023-08-03 16:35:29 -07:00
Pat Manning a0e328abe7 Merge "Add test to access overview app menu." into udc-qpr-dev 2023-08-02 18:02:29 +00:00
Pat Manning ccf611234a Add test to access overview app menu.
Approved tapl DD: go/tapl-overview-task-menu-app-info

Fix: 292081139
Test: TaplTestsQuickstep.
Change-Id: Ic74267ec80b0a8c6af502a445d355f0420d8f569
2023-08-02 17:20:03 +01:00
Vadim Tryshev a1877d2888 Merge "Ignoring alpha jumps in ArrowTipView and its children." into udc-qpr-dev 2023-08-01 19:36:54 +00:00
Vadim Tryshev 1e6daed881 Merge "Detecting multiple view animation anomalies." into udc-qpr-dev 2023-08-01 17:58:12 +00:00
Vadim Tryshev 189f115e83 Detecting multiple view animation anomalies.
Now detecting all anomalies that were detected during the test. This helps to avoid rerunning the test multiple times and adding anomalies to the ignore-list one by one.

Generating a file with all detected anomalies and instructions how to suppress them.

Flag: N/A
Test: presubmit, local runs
Bug: 286251603
Change-Id: I0c34d228f91976451b518fd44873218b80178d0e
2023-07-31 18:03:48 -07:00
randypfohl c5ad40302c Temporarily disabling test
Test: ran test locally and ensured it was disabled.

Bug: 293191790
Change-Id: I966c466785aa7011d798ae13a52ddb07a93e1ee5
2023-07-31 16:32:31 -07:00
Vadim Tryshev f623f61520 Ignoring alpha jumps in ArrowTipView and its children.
I've seen an alpha jump in ArrowTipView|TextView:id/text, so disabling
the whole view sub-tree.

Bug: 292561338
Test: presubmit
Flag: N/A
Change-Id: I49e5d16d7c6e772bb848061087c56221b113d579
2023-07-28 18:08:38 -07:00
Andy Wickham fd35baa3f8 Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-28 21:57:54 +00:00
Charlie Anderson 6702ed1e19 adding popup test files and allow for selecting activity to use
Test: manual
Bug: 289228540
Flag: N/A
Change-Id: Ie78cd39d5636d8737b80a809fb22328de574f0c0
2023-07-28 10:07:00 -04:00
Vadim Tryshev 163633a916 Merge "Optimizing application of the ignore-list of nodes for AlphaJumpDetector. Instead of building the full path of each node, and then searching it in the PATHS_TO_IGNORE set, we are descending the tree of the nodes to ignore. This saves us building the whole path for each node." into udc-qpr-dev 2023-07-28 00:40:29 +00:00
Vadim Tryshev 4824afe538 Optimizing application of the ignore-list of nodes for AlphaJumpDetector.
Instead of building the full path of each node, and then searching it in the PATHS_TO_IGNORE set, we are descending the tree of the nodes to ignore. This saves us building the whole path for each node.

Now that AlphaJumpDetector has more fields specifically for alpha jump detection in AnalysisNode, I’ve introduced an abstraction of per-detector data in AnalysisNode, see the ‘detectorsData’ field. Each detector (alpha jumps, flash, position jump), will be able to add its own data to AnalysisNode without polluting it.

Flag: N/A
Test: presubmit, local runs
Bug: 286251603
Change-Id: Iac8504edfe43407a75e7fc4a39e21bfca502b090
2023-07-27 15:26:11 -07:00
Andy Wickham be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Treehugger Robot 372f88dd23 Merge "Add one flaking view to alpha-jupms ignore list" into udc-qpr-dev 2023-07-26 18:49:20 +00:00
Treehugger Robot 17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Vadim Tryshev 03bbf07522 Add one flaking view to alpha-jupms ignore list
Bug: 292561338
Test: presubmit
Flag: N/A
Change-Id: Ieaaba52e0717a87ea14bcc8a8e861a89b81f9a77
2023-07-25 11:20:14 -07:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Vadim Tryshev aa79bd9a07 Verifying that ViewCapture data is not empty
Flag: N/A
Test: presubmit
Bug: 286251603
Change-Id: I45b6f858cfa13a12203a61ee80ac2e7988360d58
2023-07-25 00:46:33 +00:00
Vadim Tryshev 55b5534467 Merge "Fix a typo" into udc-qpr-dev 2023-07-24 21:58:40 +00:00
Vadim Tryshev cb5b7335f4 Fix a typo
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2f5bfde644cf4489f71d4207c3e8eb1936f8742
2023-07-24 13:16:43 -07:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Vadim Tryshev 101ea3e4e5 Restoring starting capturing existing activity.
ag/24138143 made the rule to produce empty captures in many cases.

ag/24138143 aimed to fix a leak that was caused by a local var
alreadyOpenActivity still referring the activity when the leak check
executes.

Fixing that by moving the variable to a method startCapturingExistingActivity.

Bug: 291638593
Test: local, presubmit
Flag: N/A
Change-Id: I281202488c6c85e2e2c5b5b3300e26d808167104
2023-07-24 19:09:48 +00:00
Brandon Dayauon 6dc98ad842 Merge "Update tests for ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH" into udc-qpr-dev 2023-07-24 14:37:28 +00:00
Andy Wickham f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Brandon Dayauon df4dfdba4d Update tests for ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH
PM said we can enable ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH flags.

Since I am enabling two-line text for all apps, it's possible that the text would have other texts within the app name itself. For example, if a title of an app is long for example "Amazon Shopping" the title can now be like "Amazon\nShopping". For tests to recognize its "Amazon shopping", I am resorting to identifying the app title based on the content description.

Turn on the two feature flags in another CL

bug: 287307252
test: manual
Change-Id: I8bdc3db710514c9098ccb5d9781a100ac9b35eab
2023-07-21 20:15:19 +00:00
Jagrut Desai 615378bf05 Merge "Adding RECEIVER_EXPORTED flag to BroadcastReceiver" into udc-qpr-dev 2023-07-20 21:12:52 +00:00
Jagrut Desai d9c1092ad5 Adding RECEIVER_EXPORTED flag to BroadcastReceiver
We currently won't be able to run test locally on Android 14 devices as the flag is required for all braodcast recievers, so the change here.

Test: Presubmit
Bug: 292118103
Flag: not needed
Change-Id: I85f9d1b9717b85b30a15e825ebd500508dd3ca5d
2023-07-20 12:00:28 -07:00
Sunny Goyal 6df6cd2244 Merge "Fixing ViewCaptureRule not unregistered if activity is destroyed" into udc-qpr-dev 2023-07-20 16:36:49 +00:00
Sunny Goyal bb50f3cd8e Fixing ViewCaptureRule not unregistered if activity is destroyed
Bug: 291638593
Test: Presubmit
Flag: N/A
Change-Id: I86daf9fac210340b037d376d882ac5872c596ae4
2023-07-19 16:14:47 -07:00
Uwais Ashraf 57c60c58f5 Merge "Revert "Adding some utility test rules"" into udc-qpr-dev 2023-07-19 22:20:30 +00:00
Vinit Nayak 3d13054739 Merge "Use gesture instead of stateManager to go to AllApps" into udc-qpr-dev 2023-07-19 20:57:10 +00:00
Uwais Ashraf cc4ab7377c Revert "Adding some utility test rules"
Revert submission 23784831-launcher-test-rule

Reason for revert: Checking if these changes are the cause of a 10 min timeout in the instrumentation
Bug: 291171782
Reverted changes: /q/submissionid:23784831-launcher-test-rule

Change-Id: Id77ee089b8302992f3a5d91f35f655bb618137f0
2023-07-19 10:37:52 +00:00
Vinit Nayak 4351d50609 Use gesture instead of stateManager to go to AllApps
* Hypothesis for why ALL_APPS isn't showing is that
directly navigating to it via state manager might have
some more hiccups (historically it has), so we do it
now via swiping up on workspace

Bug: 288152874
Flag: None
Test: Passes locally
Change-Id: I8ada7d3bde88fa54c9aab84012a9b0e3e045069e
2023-07-18 15:45:42 -07:00
Jordan Silva 8bd7af2b3f Improving responsive grid xml parser
Refactors AllAppsSpecs, FolderSpecs and WorkspaceSpecs initialization to use the same code to parse the xml with different map function. This CL improves the readability of the code and remove code duplication.

Fix: 286538013
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: AllAppsSpecsTes
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: FolderSpecsTest
Test: WorkspaceSpecsTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iec5863619399efd2e80f3db46b75c4d785e1656f
2023-07-18 18:03:16 +01:00
Sunny Goyal cd5d3d0c31 Merge "Removing LauncherActivityRule as it can be flaky based on when the rule was initialized" into udc-qpr-dev 2023-07-17 16:58:20 +00:00
Sunny Goyal f6b79f7caf Removing LauncherActivityRule as it can be flaky based on when
the rule was initialized

Bug: 289161193
Test: Presubmit and PostSubmit
Flag: N/A
Change-Id: I0e1e9c6f932d2a98a2f1e47bd1665e26f2db9eb4
2023-07-14 10:29:55 -07:00
TreeHugger Robot fee828cd6c Merge "Enabling view capture analysis in Launcher tests." into udc-qpr-dev 2023-07-14 17:23:05 +00:00
Vadim Tryshev baef466f61 Enabling view capture analysis in Launcher tests.
For now, only Alpha Jumps detector is implemented. The test will fail if
an alpha jump is detected.

The ignore-list for alpha jump detection ended up being uncomfortably
long, I plan dealing with this immediately after landing this CL.

Bug: 286251603
Test: presubmit, forrest
Flag: N/A
Change-Id: I3f44b02015e2ce93eb8b4071becbc44b36416459
2023-07-13 17:34:57 -07:00
Sunny Goyal fc681dbe09 Merge "Adding some utility test rules" into udc-qpr-dev 2023-07-13 15:30:50 +00:00
Schneider Victor-tulias 19c22c20b2 Merge "Add debug tracing Launcher's lifecycle callbacks" into udc-qpr-dev 2023-07-11 22:35:53 +00:00
Andrew Cole 0b5cc64ec2 Merge "Removing screen record from test" into udc-qpr-dev 2023-07-10 20:00:55 +00:00
Sunny Goyal 2cf183d14c Adding some utility test rules
> LasyActivityRule to be used by ActivityScenario
> Utility rule to easily override feature flags

Bug: 284202543
Test: Presubmit
flag: N/A
Change-Id: I95ae19bfb1d67a55941e7b8e5c47516a351b0d24
2023-07-10 10:02:44 -07:00
Andrew Cole 0ce5977375 Removing screen record from test
The test is no longer flakey so we can remove the screen recording to save time during automated testing

Bug: b/258071914
Test: atest testUninstallFromAllApps
Change-Id: I6b044ad87b63e5035c2a88dc4f0181989e82f3b2
2023-07-06 14:25:39 -07:00
Schneider Victor-tulias 84c66b69ff Add debug tracing Launcher's lifecycle callbacks
It is possible that SimpleActivityRule is not being properly notified of Launcher's creation in Platinum tests.

Flag: not needed
Bug: 289161193
Test: AddWidgetTest
Change-Id: I09947e7202129d9335f737dcd626f706de6dbf00
2023-07-06 10:44:16 -07:00
Vinit Nayak f6f192853d Cleanup WorkProfileTest logs
Fixes: 243688989
Change-Id: Ic3f143062c1a1383d1e79959dae59c45743547e9
2023-07-05 16:27:11 -07:00
Schneider Victor-tulias 720d0cf4c4 Merge "Update TestProtocol.REQUEST_CLEAR_DATA to properly clear the workspace" into udc-qpr-dev 2023-06-30 16:54:30 +00:00
Treehugger Robot c243875235 Merge "Fix ReorderAlgorithmUnitTest not restoring numRows properly" into udc-qpr-dev 2023-06-30 02:15:34 +00:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00