Commit Graph

6937 Commits

Author SHA1 Message Date
Stefan Andonian 60e3b74522 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I291aeed8952555e9dd35b4dfe2e1c73db889351a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 18:52:00 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Tony Wickham 4f90d44377 Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev am: a329718dcf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20886425

Change-Id: I61fe680a135268379e741a171ed2d29febbeca99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:15:34 +00:00
Sebastián Franco 075bd276ca Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev am: 519714449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838734

Change-Id: Id6707d575fecfeae28b704fd8701c82f4288a9f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:14:48 +00:00
Tony Wickham a329718dcf Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev 2023-01-14 01:09:52 +00:00
Sebastián Franco 519714449f Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev 2023-01-14 00:59:47 +00:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Randy Pfohl f763efa527 Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: I7a302c76532621837b54fbf38dd153fb15f975b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 23:28:30 +00:00
Randy Pfohl dcd79bd6cd Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev 2023-01-13 23:02:41 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Johannes Gallmann f2709309bb Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: Ia1e8d8830a99268870f4c9f3cf59ca5d32a731b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 17:55:35 +00:00
Johannes Gallmann 4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
TreeHugger Robot 2618fcf11c Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ica6895eddd30abb925ce9b87322711213ae14f68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 16:01:52 +00:00
TreeHugger Robot 60c7dfec29 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev 2023-01-13 15:49:07 +00:00
TreeHugger Robot dda983334f Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I4a77261e41700023d6f3c8856db040b9369a013f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 13:46:23 +00:00
TreeHugger Robot 5f3784d147 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev 2023-01-13 13:01:03 +00:00
Vinit Nayak f47ba402c8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5798568fcfc64ef8d7ce3a5175e45f249c53e08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:14:59 +00:00
Vinit Nayak f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Jeremy Sim 2bc8635b0a Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ie382a53ed107537f52e8bc8777468f52a4288ae9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:50:52 +00:00
Jeremy Sim 9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk a39ff80885 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: If52b473eb05dca4e0b4dcbdc3c9416b4f0abb53f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:56:36 +00:00
Ats Jenk 1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk 8df2f4748a Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I01acb423b0ea3934b2e63779ba8cb3ff3a7ccf03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:37:42 +00:00
Alex Chau f4269f01d7 Revert "Add debug logs for hotseat disapperaed bug"
This reverts commit 04658bcd42.

Reason for revert: root cause found
Bug: 260135164

Change-Id: I809662780d042923de015ff4cb810b3da5169f83
2023-01-12 22:21:07 +00:00
Ats Jenk 984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
randypfohl 9c5fa66d2f Cleaning up UI jank while quick switching
Moving a few calls into the UI helper executor thread, as per the associated bug. duplicated the lines so the synchronous nature of clearing previous state wouldn't affect potential timings.

Test: local testing, rotating screen. quick switching apps.

Bug: 257470365
Change-Id: I59abad9ba51c0b19d467646752aa34ae7ef3ec1d
2023-01-12 19:06:04 +00:00
Ats Jenk ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot 318da8ce22 Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: Ib53aa807f447aeba483f6a4a10f078a5b39bf660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 17:50:42 +00:00
TreeHugger Robot 944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Tony Wickham 7d192c0e71 Remove extra overview threshold if the transient taskbar is already open
Test: Swipe to overview when taskbar is already opened vs not
Fixes: 264555943
Change-Id: Ib4c31b085ca51e50fd7442ff9a27a5f47822c242
2023-01-12 16:48:35 +00:00
Luca Zuccarini 7495d0f873 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I3629ade53ed1be9d596a158e0f71efd999428aa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 14:51:20 +00:00
Luca Zuccarini 51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Nicolo' Mazzucato 696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
2023-01-12 09:19:48 +00:00
Johannes Gallmann 031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Vinit Nayak 1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Stefan Andonian 167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Fengjiang Li e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Jagrut Desai 9ef3dff40d Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: I886944c8f9a8ad2083cd84f2cc29cf9c41497b75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 19:09:20 +00:00
Tony Huang 9898e5cc44 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: Ifbd4ea9766123d4c5943f0ea75600416a6b39312
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 04:17:34 +00:00
Jagrut Desai 50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Jeremy Sim 5f8dd20236 Fix transition animations for launch-from-staged operation
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
2023-01-10 15:44:23 -08:00
Jagrut Desai dc70ea4d65 Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev am: 4aac33824d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861033

Change-Id: I2b508ca826aa1eda8443a51bdf166871019e591c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 23:25:59 +00:00
Jagrut Desai 4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel.
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
2023-01-10 22:57:35 +00:00
Ats Jenk 774f05226b Hide DesktopTaskView background while animating
While animating DesktopTaskView to/from fullscreen, hide the background.
Background should only show up when this taskview is shown in recents.
While it is animating, we don't need to show it.

Bug: 263264985
Test: manual, trigger transient taskbar, observe that background does
not flicker

Change-Id: I76d0eb1857645b7f04a0b2e1eebe2393c252c257
2023-01-10 11:39:17 -08:00
Alex Chau a2a374bdab Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev am: 616de308b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883271

Change-Id: I0c820b11d56c43167034ff840ddb76e521f7a05a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 18:44:57 +00:00
Alex Chau 616de308b7 Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev 2023-01-10 18:34:08 +00:00