Commit Graph

17554 Commits

Author SHA1 Message Date
Catherine Liang 7e3721692c Merge "Fix Launcher preview display size" into main 2023-12-14 21:33:25 +00:00
Catherine Liang b0de412e47 Fix Launcher preview display size
When previewing the Launcher in the Wallpaper Picker for a different
display size than the current screen, the preview no longer adapts to
that screen size.

Flag: ACONFIG com.android.wallpaper.multi_crop_preview_ui_flag DEVELOPMENT
Bug: 316000567
Test: manually verified
Change-Id: Ib10f2c9acec98ed99cadd40a588e2ffdea900ba6
2023-12-14 19:08:39 +00:00
Fengjiang Li e228112c33 Merge "Cancel all apps icons preinflation when device profile has changed" into main 2023-12-14 18:16:30 +00:00
Sebastián Franco d93bb98e02 Merge "Remove ENABLE_NO_LONG_PRESS_DRAG flag." into main 2023-12-14 17:20:45 +00:00
Fengjiang Li b7a5eb9ef4 Merge "Remove duplicated widget host view reinflation on screen rotation" into main 2023-12-14 07:02:17 +00:00
Charlie Anderson 97eedb9570 Merge "fix font-scaling from clipping folder child icons" into main 2023-12-14 03:30:55 +00:00
Fengjiang Li 939ca48bae Cancel all apps icons preinflation when device profile has changed
Bug: 312816372
Test: perinflate large number of App Icons then rotate screen. Verified 1) preinflation runnable is cancelled and 2) no ViewHolder created from this cancelled runnable is added to RecyclerViewPool
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION ENABLED
Change-Id: I1a6110278e1af2b32387ab27273106d30513886f
2023-12-13 15:31:30 -08:00
Anushree Ganjam 8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Charlie Anderson 797ed83700 Merge "Add wrapper for logging backup & restore metrics from Launcher" into main 2023-12-13 19:33:26 +00:00
Brandon Dayauon 65eecc9352 Merge "Make two line text support only for ENGLISH locale" into main 2023-12-13 19:20:35 +00:00
Tracy Zhou f2643521ec Merge "Introduce taskbar_phone_size" into main 2023-12-13 18:04:04 +00:00
Jagrut Desai 113569f446 Merge "Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation" into main 2023-12-13 16:12:43 +00:00
Tracy Zhou 9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Fengjiang Li 09c3c21472 Remove duplicated widget host view reinflation on screen rotation
Don't reinflate from LauncherAppWidgetHostView#onConfigurat#onConfigurationChanged because Launcher activity will rebind app widgets on configuraiton change. This will reduce lock contention to inflate complex widget views and reduce flicker.

Bug: 285279824
Flag: None
Test: Rotate screen and verify widget are rendered correctly
Change-Id: I69abc7f1fe0ca5704ac887142c73b8d245fead4e
2023-12-12 22:41:03 -08:00
Jon Miranda 20fdc7b508 Move taskbar clean up so that it only gets called when user swipes up to go home.
This fixes the bug where the flag gets set when user taps on nav handle, which
results in the taskbar animation playing.

Flag: N/A
Test: open app
      wait for taskbar to finish stashing*
      tap on nav handle
      nothing happens (desired affect)
      * I will address tapping on taskbar while its animating in a separate change
Bug: 292108880
Change-Id: I75870050225bdd951c69224d272d0bd5a3d6d4ea
2023-12-13 02:51:28 +00:00
Federico Baron 4266fa49e2 Merge "Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures" into main 2023-12-13 01:47:21 +00:00
Jordan Silva 7808efbba1 Merge "Fix crash when restoring data from phone to tablet with responsive grid" into main 2023-12-13 00:49:26 +00:00
Brandon Dayauon 553a2c8775 Merge "Apply the expand animation on Private Space" into main 2023-12-13 00:02:56 +00:00
Brandon Dayauon cc5db6183f Merge "Include a developer option sliding flag to toggle the different amount of apps to show" into main 2023-12-13 00:01:08 +00:00
Brandon Dayauon d7f0ccf52e Merge "Move UnionDecorationHandler to Launcher" into main 2023-12-13 00:00:14 +00:00
fbaron b3b0215cb1 Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures
There are test failures when using ConstraintLayout without a known solution, see https://chat.google.com/room/AAAACwktJi8/2OogGWfbLvI. Switching back to a relativelayout to resolve those issues.

Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I004c2d77ca308d85b29217d4f1e548067126556f
2023-12-12 15:12:40 -08:00
Sebastian Franco cefdb28599 Remove ENABLE_NO_LONG_PRESS_DRAG flag.
Fix: 299748096
Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Test: atest TaplDragTest
Change-Id: I6f14f2b048e111912fa0d1b8170ca702705e00bc
2023-12-12 15:23:06 -06:00
Brian Isganitis 59c8b69ef4 Merge "Split AFVs that controller should not intercept from TYPE_ACCESSIBLE." into main 2023-12-12 20:47:46 +00:00
Charlie Anderson 861c2eed78 Merge "Adds more in depth logging of Launcher restore functionality" into main 2023-12-12 20:30:19 +00:00
Jagrut Desai 78d511614c Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ib8f64e3ae51f5468b9086808551aae826636e03c
2023-12-12 10:40:58 -08:00
Charlie Anderson c61288e271 Adds more in depth logging of Launcher restore functionality
Test: locally
Flag: N/A
Bug: 294386159
Change-Id: I810239047480090911c54dbe65a4aad8515f640c
2023-12-12 11:04:52 -05:00
Jordan Silva ce396d8abf Fix crash when restoring data from phone to tablet with responsive grid
This issue happens when restoring the data from a phone to a tablet or vice-versa. When Launcher is restoring the data, it allows the device to load a disabled or invalid grid temporarly for the migration. This leads to a crash when the responsive grid is enabled.
The hotseat spec has only WIDTH or HEIGHT specs in a certain posture. When the user restores the data from a phone to a tablet, the Launcher loads a handheld spec that doesn't have HEIGHT specs for the hotseat in landscape (spec_handheld_hotseat_[grid].xml). However, the tablet, in landscape, tries to retrieve the hotseat HEIGHT spec.

It also prevent crash when responsive grid is used with multi window mode. isVerticalBarLayout becomes false. Then, the responsive grid tries to load a hotseat spec that doesn't exist (using DimensionType.HEIGHT). Phones have hotseat specs only for DimensionType.WIDTH.

Bug: 315548992
Fix: 315069300
Fix: 315377544
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: v2/android-crystalball-eng/health/microbench/systemui/main/systemui-notification-3-jank-suite
Test: atest CtsWindowManagerDeviceDisplay:android.server.wm.display.MultiDisplaySystemDecorationTests#testSendPrimaryHomeIntentActivityOnDisplayWithDecorations -- --abi x86_64
Change-Id: Ibd6537e0528868da9a1b7672c43b5455fa6a8184
2023-12-12 10:46:22 +00:00
Jeremy Sim e73146de77 Merge "Fix clipping issue when dragging app pair icons" into main 2023-12-12 01:03:42 +00:00
Jeremy Sim 160225029d Merge "App Pairs: Launch animation" into main 2023-12-12 00:58:49 +00:00
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00
Brian Isganitis 7eae1e6124 Split AFVs that controller should not intercept from TYPE_ACCESSIBLE.
TYPE_ACCESSIBLE no longer works for certain cases (see bug). This also
simplifies TouchControllers that would otherwise add or remove from
TYPE_ACCESSIBLE (such as ALL_APPS_EDU and TASKBAR_OVERLAYS).

Fix: 315507902
Test: Manual
Flag: N/A
Change-Id: I6f5d218dab87a8bcc8e7805d0ced9a6678f09c8e
2023-12-11 21:31:38 +00:00
Sebastián Franco 9287ec0810 Merge "Simplify attemptPushInDirection" into main 2023-12-11 20:34:07 +00:00
Charlie Anderson 7bb10974d7 fix font-scaling from clipping folder child icons
Bug: 310850491
Test: verify locally and through screenshot tests
Flag: N/A

Change-Id: Iea7319e82ddffed16903e5112848cf089e5d52f2
2023-12-11 20:07:44 +00:00
Brandon Dayauon 812664df2e Make two line text support only for ENGLISH locale
bug: 313967094
Test: manual
Flag: ENABLE_TWOLINE_ALLAPPS enabled
Change-Id: I99eef31d165be8916f9e58739e405e2ffeee43c2
2023-12-11 11:50:23 -08:00
Sebastián Franco f217079aea Merge "Move onInitialBindComplete to ModelCallbacks" into main 2023-12-11 19:31:15 +00:00
Brandon Dayauon 98bf9f7532 Apply the expand animation on Private Space
- Using the refactoring that took place in ag/25414154

Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing

Flag: ACONFIG com.android.launcher3.Flags.private_space_animation DEVELOPMENT

Change-Id: Ib6229b404b48616966f3e6ab6884099b6e4b4023
2023-12-11 11:27:31 -08:00
Brandon Dayauon 96901c4541 Include a developer option sliding flag to toggle the different amount of apps to show
Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Change-Id: I78ee3a9dbc2d60f1b7acaa5834a8c656217a07d8
2023-12-11 11:27:31 -08:00
Brandon Dayauon 763e40d747 Move UnionDecorationHandler to Launcher
- Create base SectionDecorationInfo.java and RecyclerViewAnimationController.java
- SearchTransitionController now inherits from RecyclerViewAnimationController where RecyclerViewAnimationController will control
animation for private space

Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing

Flag: None
Change-Id: If34f4bb199be0e113485279931d2927cb9fad397
2023-12-11 11:27:25 -08:00
Sebastian Franco 0b461efeeb Move onInitialBindComplete to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: TaplWorkspace
Change-Id: I1a12309897a04f3ae1642fcdc9f984f7f274ba13
2023-12-11 10:07:40 -06:00
Thales Lima df643c4540 Merge changes from topic "numFolderRows" into main
* changes:
  Update dump tests
  Make numFolderRows/Columns accept more values
2023-12-11 10:54:04 +00:00
Jeremy Sim 0b070d9312 Fix clipping issue when dragging app pair icons
This CL changes AppPairIcon#getWorkspaceVisualDragBounds() to return the correct icon bounds, fixing an issue where the icon would appear clipped when being dragged.

Fixes: 312299947
Test: Icon is no longer clipped while dragging
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I103bdf53bf34d751147e1ba892f36145f04175e4
2023-12-11 17:17:00 +09:00
Jeremy Sim 23fcbf2f73 App Pairs: Launch animation
[App Pairs 7/?]

This patch implements the app pair launch animation from icon. Adds a new function, composeFadeInSplitLaunchAnimator(), in SplitAnimationController, that builds the combined launcher + shell animation.

Bug: 309618233
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I8e95f629ae2a71f1bd6cbb356f5e33233e5c2906
2023-12-11 13:09:06 +09:00
Jeremy Sim 2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash 55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
Saumya Prakash 86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Anushree Ganjam 0d86f7859f Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY
Bug: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I25675cf65f8c7a53ea37d9ba317ddc6dbb271136
2023-12-08 10:17:42 -08:00
Sebastián Franco c811263007 Merge "Moving finishBindingItems to ModelCallbacks" into main 2023-12-08 16:06:32 +00:00
Jordan Silva 558e5f8d88 Merge "Fix folder icon drawable padding for responsive grid" into main 2023-12-08 11:34:23 +00:00
Fengjiang Li 83a6a2cd42 Merge "Clear mOnInitialBindListener in Launcher#onDestroy()" into main 2023-12-08 04:05:28 +00:00