Commit Graph

1831 Commits

Author SHA1 Message Date
Shawn Lin d1567efff5 Merge "Fixed cts failure of WindowInsetsControllerTests" into tm-dev 2022-04-06 02:37:24 +00:00
Brian Isganitis 63c32cab98 Create ResourceBasedOverride for SearchSessionManager.
This override will allow Launcher3 to initialize and control a search session implementation.

Bug: 216683257
Test: Manual
Change-Id: I43d4793ef176cfd8e074961286356b96f9222ca9
2022-04-04 17:02:41 -07:00
Tracy Zhou bb75f59792 Merge "Do not append additional delimiters" into tm-dev 2022-04-01 04:26:20 +00:00
Tracy Zhou 0439fcdd5c Do not append additional delimiters
Fixes: 227665358
Test: N/A
Change-Id: I6ec0bca286c0824e474f04a61b7d855858490120
2022-03-31 17:15:46 -07:00
Vinit Nayak 26b6b577b9 Add metrics for taskbar 3 button nav
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard

Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
Merged-In: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
2022-03-31 19:36:47 +00:00
shawnlin 34aad9e022 Fixed cts failure of WindowInsetsControllerTests
If stashing taskbar is caused IME visiblity, we could just skip updating
rounded corner insets since the rounded corners will be covered by IME
during IME is showing and task bar will be restored back to unstashed
when IME is hidden.

Bug: 225765490
Test: atest WindowInsetsControllerTests
Change-Id: If8f40add0d4d9f746169d26f46f27545b4023e90
2022-03-30 18:20:32 +08:00
TreeHugger Robot 4cb55616e2 Merge "Close system windows when toggling overview" into tm-dev 2022-03-29 16:56:16 +00:00
Tony Wickham b2aa48cad6 Merge "Fix problems with taskbar floating views on rotation" into tm-dev 2022-03-29 16:36:16 +00:00
Sebastián Franco 9d5eef80cd Merge "Brighten theme-icons when in Dark mode and add dark color for taskbar" into tm-dev 2022-03-29 00:00:33 +00:00
Vinit Nayak 6be66c96ef Close system windows when toggling overview
Fix: 203835798
Test: Tap on overview with notification shade,
it closes

Change-Id: I01a5cab4fabf7950f48290418df3ae6cb270305c
2022-03-28 14:54:07 -07:00
Tony Wickham 538c9a0b52 Fix problems with taskbar floating views on rotation
- Close all views except TYPE_REBIND_SAFE
- Make All Apps TYPE_REBIND_SAFE again
- Reapply fullscreen to ensure any remaining floating views such as taskbr edu are laid out correctly upon rotation

Test: Rotating with folder and/or popup closes them; rotating with all apps stays open; rotating with all apps + popup closes popup but not all apps; rotating taskbar edu lays out correctly; opening shortcut or notification from all apps popup still closes all apps
Fixes: 220074790
Fixes: 219981733
Change-Id: I1dfea4ed0a636ab84bcc4e33304c80a689da01cd
2022-03-28 14:48:20 -07:00
Chavi Weingarten ba653b3b92 Merge "Replace consumeNextDraw with SurfaceSyncer" into tm-dev 2022-03-25 22:08:17 +00:00
Tony Wickham 59d4896635 Merge "Don't recreate taskbar on rotation" into tm-dev 2022-03-25 16:14:04 +00:00
Nicolò Mazzucato 286dd249e0 Merge "Tune fold animation on top of apps" into tm-dev 2022-03-25 09:31:10 +00:00
Vinit Nayak 7ac2116fcc Merge "Hide taskbar when launcher receives nav and keyguard showing" into tm-dev 2022-03-24 22:01:15 +00:00
Tony Wickham 3b7a391c2b Don't recreate taskbar on rotation
This was a regression due to ag/17241303, since technically the size changes when rotating (width and height swap). Now we detect that case and don't recreate, but instead propagate the new DeviceProfile via TaskbarActivityContext#updateDeviceProfile()

Test: Open an app, rotate device, ensure taskbar isn't recreated. Changing properties such as dark theme does still recreate taskbar.
Bug: 219981733
Change-Id: Ic827c8e697a284a085609ea8653d77900686306a
2022-03-24 10:35:10 -07:00
Nicolo' Mazzucato ff84d2bc66 Tune fold animation on top of apps
On top of apps, the fold animation is triggered only after a threshold. On Launcher, there is not threshold.

In this way, we don't show fold animation while apps might be handling table top/half_folded state.

+ timeout to finish the animation made shorter

Test: atest DeviceFoldStateProviderTest
Bug: 225185239
Change-Id: I5adf82e853af9a5dee5af41a853abb84c9926ccd
2022-03-24 11:31:51 +00:00
Vinit Nayak c750e3d3aa Hide taskbar when launcher receives nav and keyguard showing
* On large screen we receive notification shade expanded
signals even on keyguard.
* Add a check to not show taskbar if keyguard is showing

Fixes: 223465924
Test: Taskbar doesn't show on 3 button nav except
on bouncer, as expected.

Change-Id: I4a7ea14422eda13ae8571793ed7ba1a1964072d6
2022-03-23 14:09:25 -07:00
Sebastian Franco 5282efddc9 Brighten theme-icons when in Dark mode and add dark color for taskbar
Bug: 217247494
Test: change between dark and light mode and transition in and out of apps
Change-Id: Ia5e38d674a56eb95a48cb1e8c2688586594a69f9
2022-03-23 10:47:52 -07:00
Hongwei Wang 808d568367 Hide the Taskbar when user leaves PiP mode
This is to prevent the Taskbar from flickering when the app settles in
full-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/dIgvinb9yEB8MYfYDx0Ijy
Bug: 218450853
Test: see video
Change-Id: I9cfb0ca151dea6951561f78798bb16bafa48eba0
2022-03-22 18:45:31 -07:00
TreeHugger Robot 6c7b0f7db8 Merge "Fix issue cauing the taskbar to show in the all set page of the SUW." into tm-dev 2022-03-22 20:25:32 +00:00
Schneider Victor-tulias 44aadeaef6 Fix issue cauing the taskbar to show in the all set page of the SUW.
Some missing state handling was causing the taskbar to show in the all set page of the SUW.

Fixes: 218507703
Test: build change, flashed and factory reset device
Change-Id: If3a280ef6416f0821cf6a9b1ab0a65d58c5c8221
2022-03-22 10:50:26 -07:00
Brian Isganitis 98214d072c Merge changes from topics "presubmit-am-08ca1fad1fe94bf3ace5a708c5584d55", "presubmit-am-3c6c58a0fa374b92b1a5f8d5f5788871", "presubmit-am-6939eac1469540108813bd4ed4c60a9b" into tm-dev
* changes:
  Have taskbar all apps extend ActivityAllAppsContainerView.
  Refactor ActivityAllAppsContainerView to depend on ActivityContext.
  Refactor allapps.search package to depend on ActivityContext.
2022-03-22 16:11:35 +00:00
Vinit Nayak 68d5dd82db Merge "Use ComponentCallbacks to recreate on fold/unfold" into tm-dev 2022-03-21 19:05:52 +00:00
Alex Chau c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
Jon Miranda d17cb2722c Merge "Allow depth animation when user swipes back to home." into tm-dev 2022-03-21 15:33:08 +00:00
Kholoud Mohamed ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Brian Isganitis d478f555cb Have taskbar all apps extend ActivityAllAppsContainerView.
This step is necessary to have taskbar support search in all apps.
Search is not ready yet, so a fallback search manager is included.

Test: Manual
Bug: 216683257
Change-Id: Id118388bc4baae4b63ef205295caf46cbd541bc8
2022-03-18 15:39:54 -07:00
chaviw 29b8135260 Replace consumeNextDraw with SurfaceSyncer
Test: Builds
Bug: 200284684
Change-Id: I46e9cd89fd6b7c767bb867205400197b305e86a8
2022-03-18 16:20:42 -05:00
Jon Miranda f6780f66c3 Allow depth animation when user swipes back to home.
Bug: 221196062
Test: open app, swipe back to home, ensure blurs
Change-Id: I9faff4e41c2e8d22df72e41c7753e2090fa0973d
2022-03-18 09:58:55 -07:00
Vinit Nayak bacd5e1d21 Use ComponentCallbacks to recreate on fold/unfold
* DisplayController callbacks were sometimes being
called too soon and providing stale window bounds,
which led to the incorrect DeviceProfile being used.
Switched to ComponentCallbacks on the window to get
the most up-to-date callbacks.
* Sadly, for navigation mode changes, ComponentCallbacks
get fired too soon and have a stale navigation mode
so we continue to rely on DisplayController for that
change for now.

Fixes: 219958843
Test: Tested folding/unfolding, no taskbar appears when
it shouldn't.
Tested with changing display/font size as well as
nav mode changes

Change-Id: I1b398934c0ea49f69bad19b13977b7b0906f3190
2022-03-17 12:03:14 -07:00
Alex Chau 2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
kholoud mohamed e210b47c20 RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I095a1da30766e4b4eab33f42b034601b3322eb3d
2022-03-15 17:24:04 +00:00
Schneider Victor-tulias 0cde81a5d2 Fix failing test TaplTaskbarTest#testHideShowTaskbar
Closing the Taskbar all apps page doesn't automatically close any open popup menus. This lead to the popup menu opened in TaplTaskbarTests#testOpenMenu_FromTaskbarAllApps remaining open after going home in setUp (before running TaplTaskbarTest#testHideShowTaskbar). The the workspace is not visible to the tests while the popup menu is open, so this test would consistenly fail.

Bug: 215218813
Fixes: 224597087
Test: Ran tests locally and remotely
Change-Id: I81d8eb1e99a264611749eb3c508f707988c0fcb1
2022-03-14 22:19:12 +00:00
TreeHugger Robot 19570f9b05 Merge "Close taskbar all apps when task stack changes." into tm-dev 2022-03-11 02:18:34 +00:00
TreeHugger Robot 1b4d9b3b23 Merge "Launcher side implementation of gesture seekable back to home animation." into tm-dev 2022-03-11 02:11:03 +00:00
Shan Huang 581429b3dc Launcher side implementation of gesture seekable back to home animation.
This is a two part animation. The first part is an animation that tracks gesture location to scale and move the leaving app window. Once the gesture is committed, the second part takes over the app window and plays the rest of app close transitions in one go.

This animation is used only for apps that enable back dispatching via {@link android.view.OnBackInvokedDispatcher}. The controller registers an {@link IOnBackInvokedCallback} with WM Shell and receives back dispatches when a back navigation to launcher starts.

Apps using the legacy back dispatching will keep triggering the WALLPAPER_OPEN remote transition registered in {@link QuickstepTransitionManager}.

Bug: b/195946584
Test: m -j
Test: Swipe back to home on pre-T and T apps, at different life cycle
stages.

Change-Id: I615c5171cd875130f10346fa3ca2a8e9670176cf
2022-03-11 00:11:21 +00:00
Brian Isganitis 7910a3ca0a Close taskbar all apps when task stack changes.
Test: Manual
Fix: 223898952
Change-Id: I4c5e41227f0ee199cc08931f4532d769f376a617
2022-03-10 16:03:30 -08:00
TreeHugger Robot 6b7e469088 Merge "Add taskbar TAPL tests" into tm-dev 2022-03-11 00:00:36 +00:00
TreeHugger Robot ec8ba135be Merge "Revert "Sync hotseat/taskbar handoff"" into tm-dev 2022-03-10 22:19:16 +00:00
Jon Miranda e8b174482d Merge "Add debug logs for bad launcher state." into tm-dev 2022-03-10 22:03:37 +00:00
TreeHugger Robot 5ad574ae60 Merge "Set taskbar touchable region to empty when all apps is open." into tm-dev 2022-03-10 22:01:40 +00:00
Schneider Victor-tulias fb252e7ce1 Add taskbar TAPL tests
- Added TAPL objects to support TAPL tests for taskbar features
- Added tests for major taskbar features: hiding/showing the taskbar, opening all apps, lauching apps and app deep shortcuts from the taskbar/all apps page, launching apps and app deep shortcuts in splitscreen
- These tests should only run for large devices

Design: go/taskbar-tapl-tests
Test: ran tests locally with invalid configurations and remotely
Bug: 215218813
Change-Id: I3c28c339707467414aa47fa633f87fa0c1fdee57
2022-03-10 13:02:35 -08:00
Jon Miranda 7ebe209c21 Add debug logs for bad launcher state.
Bug:223498680
Bug:221658803

Test: manual
Change-Id: I138a7ab031269009fa8ca492cd0bd48085aa4e68
2022-03-10 20:25:38 +00:00
TreeHugger Robot 7a8b8fb2c1 Merge "Properly center all apps divider." into tm-dev 2022-03-10 20:23:52 +00:00
TreeHugger Robot 1f3cc12a76 Merge "Recreate All Apps when Taskbar is recreated." into tm-dev 2022-03-10 20:22:29 +00:00
Brian Isganitis a2f26954a0 Set taskbar touchable region to empty when all apps is open.
Fix: 223653710
Test: Manual
Change-Id: Ia78831028b67aa425d5bd5ae61ae460d3caabbb7
2022-03-10 11:21:27 -08:00
Jon Miranda 7db484396a Merge "Never look for matching view in All Apps when swiping up to go home." into tm-dev 2022-03-10 18:46:51 +00:00
Brian Isganitis cea2480cac Properly center all apps divider.
Fix: 223837782
Test: Manual on large and small screens in portrait and landscape.
Change-Id: Ie4d609ce6524cc739d00bec5a8d26ec4c4152633
2022-03-10 18:29:34 +00:00
Jon Miranda efca5c8655 Revert "Sync hotseat/taskbar handoff"
This reverts commit ede8718e63.

Reason for revert: causing ANR b/223789074

Bug: 223789074
Bug: 223443781
Bug: 202507555

Change-Id: Ibd76939a345f54e8945cdd97e652f5e06e40edcb
2022-03-10 18:27:36 +00:00