Commit Graph

14705 Commits

Author SHA1 Message Date
Sam Cackett 7ac8a04cbe Use TaskViews only for RecentsView CollectionInfo
getAccessibilityChildren includes the add desktop and clear all buttons
in the collection, so the list read outs are 2 bigger than they should
be

Fix: 411430606
Flag: EXEMPT. Bugfix
Test: Manual. Talkback
Change-Id: I3dbc4a9692396f7d8c094dd245745b878833c1a6
2025-05-13 05:45:03 -07:00
Treehugger Robot f2fff33546 Merge "Adds gpuLoadUp calls for Launcher blur preparation." into main 2025-05-05 20:45:01 -07:00
Li Lin 7c91724c2c Merge "Remove URL from image model." into main 2025-05-05 17:07:18 -07:00
Treehugger Robot 237e594dd0 Merge "Return to BackgroundAppState when tapping gesture region in desktop" into main 2025-05-05 15:31:18 -07:00
Andy Wickham 1d8676a965 Adds gpuLoadUp calls for Launcher blur preparation.
Basically the same places we were notifying expensive frames.

Test: forrest perf suites
Flag: com.android.launcher3.all_apps_blur
Bug: 410973453
Change-Id: Ifb8ee7010e0faacc9ccc21076fc8614f335e2863
2025-05-05 19:46:49 +00:00
Daniel Andersson cf29edfa2f Merge "desktop-exploded-view: Fix broken live tile when activating desk" into main 2025-05-05 12:46:01 -07:00
Fengjiang Li bccc1a8fa1 Merge "[Memory Leak] Fix leak of TIS from taskbar's pending intent" into main 2025-05-05 12:41:09 -07:00
Fengjiang Li a6c437c42f [Memory Leak] Fix leak of TIS from taskbar's pending intent
Fix: 415321479
Flag: NONE - released code
Test: manual
Change-Id: I70e2201695cb3e8501315a5ae8fd86b150d57c35
2025-05-05 09:26:55 -07:00
Schneider Victor-tulias a8053f8cba Merge "Support the gesture nav contract for recents in window" into main 2025-05-03 20:02:30 -07:00
Treehugger Robot af24c515c9 Merge "Fix taskbar visibility for desk->desk in Overview" into main 2025-05-02 22:02:38 -07:00
Treehugger Robot 51c9c19e89 Merge "Remove RecentTasksList implement of DesktopVisibilityController" into main 2025-05-02 18:26:06 -07:00
Treehugger Robot 418a8e4aa9 Merge "Update All Apps divider color." into main 2025-05-02 17:43:28 -07:00
Andy Wickham 34fba0fcb7 Merge "Ensure an opaque scrim is used for legacy all apps." into main 2025-05-02 16:39:53 -07:00
Treehugger Robot 1a597d619b Merge "Remove IME-specific touch passthrough for Taskbar" into main 2025-05-02 14:42:04 -07:00
Liran Binyamin 00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Ats Jenk e2c8c68edb Merge "Make sure animation is cancelled for existing flyout" into main 2025-05-02 14:22:24 -07:00
Andy Wickham 4efae39779 Ensure an opaque scrim is used for legacy all apps.
When there's no background panel, we should ensure an opaque
background scrim is used.

Fix: 414718408
Test: Manual with all_apps_blur and all_apps_sheet_for_handheld off.
Flag: EXEMPT bugfix
Change-Id: I1ac9f5f8fbb01f2c6a42e9f79823b5f293ebf709
2025-05-02 13:49:51 -07:00
Tony Wickham f7772b88af Return to BackgroundAppState when tapping gesture region in desktop
If the end target is null, that means the gesture did not move
enough to calculate an actual end target, and LAST_TASK is the
default for that case. We probably don't need the desktop check
specifically (could clean it up in a follow up) but since this
bug is specifically for Desktop mode I left it in for now.

Fixes: 359879541
Test: manual, tap Taskbar in Desktop and ensure no flicker
Flag: EXEMPT bugfix

Change-Id: Icc3e645819a22ed96d07a575cdccda30a5d800c1
2025-05-02 20:19:03 +00:00
Treehugger Robot 7a2d5b454f Merge "Add magnetic detach to task dismiss using MotionValue library." into main 2025-05-02 12:34:47 -07:00
Schneider Victor-Tulias 9118d87d84 Support the gesture nav contract for recents in window
- Support for the GNC allows for some additional animations and clean up. The missing clean up was causing test failures
- Also fixing broken GNC support for split apps. Swiping up from split apps caused consistent crashes, however since the current 1P swipe to home has no special animation, updating the recents window and 3P GNC to match this.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit; swipe home from 1P and 3P launcher
Change-Id: Idf24d7969e76a50ff656f6644c2b568c42e409d7
2025-05-02 15:32:51 -04:00
Treehugger Robot 21779a4192 Merge "Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused" into main 2025-05-02 11:46:48 -07:00
Suhua Lei 69ba07f2cf Fix taskbar visibility for desk->desk in Overview
Bug: 413192207
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: switch between desks in Overview
Change-Id: I49806fe2b0790b1bccbac04625d7ee553c7ab3eb
2025-05-02 11:27:48 -07:00
Daniel Andersson 05fdc49ef7 desktop-exploded-view: Fix broken live tile when activating desk
- Apply scrollOffset directly to tvs.recentsViewCroll, which already take orientationHandler into account
- Apply gridTranslationY directly to taskSecondaryTranslation, which already take orientationHandler into account
- This make sure both translations are applied after mTaskRectTransform
- Also re-calculate tvs task size after updating orientationState rotations, as the orientationHandler might be changed and affect task position
- Remove setTaskRectTranslation that is no longer used

Flag: EXEMPT bugfix
Test: manual with central/side task launching with portrait, fake landscape and 3p launcher
Bug: 410628946
Change-Id: I8ef38d193328e8a449594515403c00f517e213b3
2025-05-02 11:10:52 -07:00
Xiaoqian (Daisy) Dai 276e0be2a4 Merge "desktop-exploded-view: temporarily disable the functionality..." into main 2025-05-02 10:55:42 -07:00
Pat Manning d2f050ab26 Add magnetic detach to task dismiss using MotionValue library.
Fix: 389081766
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I77f980f9851f4b1c041cbf3bb7247b972c1730fd
2025-05-02 17:13:57 +01:00
Sunny Goyal 46b13eb184 Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused
Bug: 390572144
Flag: EXEMPTY refactor
Test: Presubmit
Change-Id: I41c5fea73452d7f4c1fd9980a89bcb7199eb19d7
2025-05-02 08:55:21 -07:00
Liran Binyamin 34024fe26a Send bubble bar distance to shell
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - send some bubbles
       - launch app
       - expand
       - swipe to home
       - fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
2025-05-02 10:54:39 -04:00
Schneider Victor-tulias 9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Treehugger Robot 5f38710c0e Merge "Only use RecentsWindowManager instances for CDs" into main 2025-05-01 22:42:17 -07:00
Ajinkya Chalke d616551419 Only use RecentsWindowManager instances for CDs
Bug: 414767197
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I8f2f143ef8ca885c089b83559899746ac594400a
2025-05-02 00:13:53 +00:00
Xiaoqian Dai b9d3a5cc44 desktop-exploded-view: temporarily disable the functionality...
... to launch an individual task window from desktop tile in Overview
when multi-desks is enabled, until the fix for b/413378320 is landed.

Note the changes in
http://ag/q/topic:%22activate-window-from-exploded-view%22 is the right
implementation, however it will only work for multi-desks with the fix
for b/413378320 is in place.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413378320
Change-Id: I72914d60fb0ec2e80af6faa7441a67e743720c38
2025-05-01 23:59:05 +00:00
Treehugger Robot c3a397b01c Merge "Skip already running check when switching in KQS" into main 2025-05-01 15:29:28 -07:00
Brian Isganitis 3b9b36255b Merge "Use LauncherPrefs for stashed handle region dark." into main 2025-05-01 13:46:44 -07:00
Schneider Victor-Tulias 3818462d0e Fix recents window activity leak
- When we clean up the recents window, the recents view gets dettached, which causes a activity leak in tests and prod through RecentsView.mOnTaskLaunchCancelledRunnable. Fixing this leak across all uses of RecentsView, rather than just for RecentsWindowManager
- Also cleaning up a potential leak in RecentsWindowManager.callbacks

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Bug: 292269949
Test: swiped up from running app, checked leak canary and heap dump; pre/post-submit tests
Change-Id: Id95b36dad6e41e5b21d1af8ede489f84ef987e50
2025-05-01 16:07:27 -04:00
Ats Jenk 506b2a8b35 Make sure animation is cancelled for existing flyout
When we show a new flyout, it is possible for the previous flyout to
still be there and animating out.
We were removing the existing flyout, but did not cancel the animation.
This meant that there could have been a hide animation running for the
previous flyout. Once that animation finished, it removed the current
flyout from the container. It was possible for the current flyout to
already be updated to the new one. In which case the animation for the
previous flyout hid the new flyout.

Bug: 414808503
Test: atest PlatformScenarioTests:BubbleBarTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I4229297fa999d815c12eefd9d583bdfc915ec00a
2025-05-01 10:52:41 -07:00
Xiaoqian (Daisy) Dai 8eda6e708f Merge "desktop-exploded-view: Implement the activate window behavior" into main 2025-05-01 10:41:06 -07:00
Tony Wickham 41b1c52c7f Remove IME-specific touch passthrough for Taskbar
It doesn't seem necessary anymore (and anyway, existing cases like
Taskbar being stashed while IME is showing handle this as well).
Removing the specific block fixes a bug where touches were going
to the underlying app even though Taskbar window is fullscreen
while editing a Folder name.

Fixes: 400859085
Test: TaskbarInsetsControllerTest
Flag: EXEMPT bugfix

Change-Id: If30acd0b3b9c3fd0b29b94ca963beb1c70162416
2025-05-01 16:43:31 +00:00
Ajinkya Chalke 011422cdb4 Skip already running check when switching in KQS
- In KQS existing code there is a check that returns early if a user is
  trying to switch to a running task. This check returns true for a task
  that is not running thus creating an issue when user tries to switch
  to that task using KQS.
- While the root cause of the issue will take time to fix, this
  temporary check ensures that we workaround it when flatenning
  heirarchy feature is enabled. This issue happens when multi-desk
  backend flag is true and flatenning flag will always be true when
  multi-desk is true (given how the features are timed for release).

Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Test: m
Bug: 414410702
Change-Id: Ia35d6706a1512efbb4feca0128a9d59cd930df2f
2025-05-01 15:22:28 +00:00
Jordan Silva de6ce21ed5 Reset IconAppChipView when DesktopTaskView is recycled
Bug: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I119599d575c82b6cce71ac3cbb4b709914f34bda
2025-05-01 03:07:55 -07:00
Treehugger Robot 675282b181 Merge "Revert^2 "Restrict nav mode UI checks within primary display"" into main 2025-04-30 20:53:19 -07:00
Andy Wickham 1e2e88a884 Update All Apps divider color.
Also update how theming is applied. We pass a ContextThemeWrapper
to relevant views to retrieve the updated colors.

Demos switching blur on and off with adb:
 - From top (QSB, handle, divider): https://drive.google.com/file/d/1FHNzp5bNbNtH8tM7rSjKELPr6hsETPST/view?usp=drive_link&resourcekey=0-JuiAUJoNh4Pe_xKa74h0-g
 - Scrolled down (header protection + private space): https://drive.google.com/file/d/1gb1GCH3tJHS7HzOjvXgrTxNQ9gfD59dw/view?usp=drive_link&resourcekey=0-AK58FpfN-sDfWhWkmqaEmA

Test: Manual
Flag: com.android.launcher3.all_apps_blur
Fix: 413143411
Change-Id: I5da3b7c38ea4f81dec1011b6cc15ad8b591c761b
2025-05-01 02:25:02 +00:00
Treehugger Robot 1ca1bf9c9d Merge "Apply fallback overview scrim, overviewactions and clearall in battery saver mode." into main 2025-04-30 19:13:54 -07:00
Li Lin d26a7d3979 Remove URL from image model.
We decided to pass image content instead in a follow up CL.

Test: manual
Bug: 414869782
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I05167f81ac7b887cb5e00915f1ffdec0bb2dc720
2025-04-30 15:09:24 -07:00
Brian Isganitis e1a3329c39 Use LauncherPrefs for stashed handle region dark.
Flag: EXEMPT refactor
Bug: 324485921
Test: go/testedequals
Change-Id: Ib69ba1595eadd318521c88069cd867988f66c4bc
2025-04-30 16:40:46 -04:00
Jagrut Desai 95ee12ff94 Merge "Auto-Stashing Functionality for Pinned Taskbar" into main 2025-04-30 13:30:06 -07:00
Willie Koomson e11651e93a Merge "Implement collectWidgetEvent in QuickstepWidgetHolderListener" into main 2025-04-30 13:01:36 -07:00
Jagrut Desai f52ffc1232 Auto-Stashing Functionality for Pinned Taskbar
This cl includes :
- Refactor to remove unpinning/pinning in desktop mode with refactor of DisplayController, TaksbarPinningController, and its tests.
- Combined the auto stashing conditions under one method shouldAllowTaskbarToAutoStash() which takes in consideration isTransientTaskbar, isInDesktop, and Always Show Taskbar option is turned on/off in desktop mode.
- enabled taksbar divider popup support in desktop mode.
- Intorduced animation for pinned taksbar when autostadhing is enabled.
- Enable to onSwipeToUnstashTaskbar for TaskbarInputStashController for pinned taksbar in desktop mode.

Test: Presubmit, Unit, Manual
Bug: 381535785
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ie5ecf3a3c72bf8dfadf2d0c908269305fe5bad0b
2025-04-30 10:39:58 -07:00
Willie Koomson 086e7b1d10 Implement collectWidgetEvent in QuickstepWidgetHolderListener
This change updates QuickstepWidgetHolderListener to implement the new
AppWidgetHostListener.collectWidgetEvent API.

Bug: 364655296
Test: Manual, interact with Launcher and check that events are logged
Flag: android.appwidget.flags.engagement_metrics

Change-Id: I9bf859f18025a49ef98e57e32e4b53e6547bd84b
2025-04-30 16:55:20 +00:00
Jordan Silva 8517ba500d Fix: Prevent app chip being destroyed for DesktopTask
DesktopTask shares the same iconView between different TaskContainers. When destroying a single Task in DesktopTask should not reset this shared IconAppChip.

Fix: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I40f144c836715290eabb9db49ed0582986a11945
2025-04-30 09:46:51 -07:00
Mykola Podolian 5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00