Commit Graph

458 Commits

Author SHA1 Message Date
TreeHugger Robot fc9ea9b0fc Merge "Speeding up TAPL by calling getVisibleStateMessage() less frequently" into ub-launcher3-rvc-dev 2020-05-04 23:18:04 +00:00
TreeHugger Robot 7bb915ba8e Merge "Remove unnecessary waitForIdle calls" into ub-launcher3-rvc-dev 2020-05-04 22:44:21 +00:00
vadimt faf4da386d Speeding up TAPL by calling getVisibleStateMessage() less frequently
The information in the message can be derived from the object dump
printed anyways.

Change-Id: I22ee136568b767c3218eaabc3920c77b3ceaa78f
2020-05-04 15:40:47 -07:00
vadimt 357e5499a2 Remove unnecessary waitForIdle calls
They were added back in times when the
code was very different, and we don't need them now.

Change-Id: Ie96b081a4f2319c7b58d22ffc410f74e9ab56d94
2020-05-04 18:57:52 +00:00
vadimt 55495201e0 Avoiding cascading "nested events checking" failure after timed-out wait
Bug: 155656943
Change-Id: I0f11552349a9f6b3b14bd1bebb37904d5dfa9c55
2020-05-04 10:52:08 -07:00
vadimt 9fd3a943ba Don't do full anomaly check after every gesture
This call is relatively expensive. Perform only cheap launcher crash
test, and do anomaly only if there are problems.

Change-Id: If45567bcedf8d177970739e9de95cbb29add744c
2020-04-30 19:31:21 -07:00
TreeHugger Robot dfd8c4806f Merge "More logging for LogEventChecker appearing to skip events" into ub-launcher3-rvc-dev 2020-04-30 20:24:21 +00:00
vadimt 232737c854 More logging for LogEventChecker appearing to skip events
Bug: 155347466
Change-Id: I6598bcf36c1f7ae76e9bb6b2eccefbd00899de2e
2020-04-30 10:19:10 -07:00
vadimt a1f0a10662 Removing tracking activity start/stop events
They were not especially useful in investigations; besides, these events
can be sent by the system asynchronously for actions that happened
before entering TAPL, causing flakes.

Change-Id: I72b5aad5521c6c0969f5b657b3db3e4d855f1d64
2020-04-29 14:23:53 -07:00
vadimt 2e6fdd7d93 Optimization: reducing number of getNavigationModeMismatchError calls
They are relatively expensive

Change-Id: I34de56884ec3f88e69c709026d3b72e62c787681
2020-04-27 13:08:50 -07:00
TreeHugger Robot 11e36db88a Merge "Cleanup code related to ag/11035582" into ub-launcher3-rvc-dev 2020-04-16 22:04:45 +00:00
TreeHugger Robot 64abef8ca1 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev 2020-04-16 21:58:47 +00:00
Vinit Nayak 916456bb5f Cleanup code related to ag/11035582
Fixes: 154235554
Change-Id: I114d1e1b9e446e15a774a5a51bdf988070091523
2020-04-16 14:16:56 -07:00
vadimt cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
Vinit Nayak 770cc42685 Revert "Cleanup code related to ag/11035582"
This reverts commit a2a1f86dff.

Reason for revert: b/154068414

Change-Id: I1db0018fa97d5a5380651cf7d04a05a0abd62857
2020-04-15 05:24:10 +00:00
Vinit Nayak a2a1f86dff Cleanup code related to ag/11035582
Bug: 153443049
Change-Id: I2a9e46fa4ffc613751c9f427ce892ddad3878b35
2020-04-14 14:02:49 -07:00
Vinit Nayak 1a09958626 Disable sensor manager for tests in platform
Bug: 153443049
Change-Id: Ieaa4b8144eba11c5d3025a1bcca42a8552d1c702
2020-04-13 15:47:02 -07:00
vadimt 8cb2f9ce08 Adding tracing for apparently skipping verifiable events
Bug: 153670015
Change-Id: I481c095f1245ba4252eb07e08b4130c857dd6e72
2020-04-09 13:02:48 -07:00
TreeHugger Robot e8fade9140 Merge "Adding diags to getWidget" into ub-launcher3-rvc-dev 2020-04-09 04:47:09 +00:00
vadimt 9915a7c60f TAPL waits for widgets recycler to become scrollable
On the Launcher side, moving setLayoutFrozen from the posted action to
avoid a possible short scrollable period just after the view is shown.

Bug: 152354290
Change-Id: I7319236d8a6e49a7e017fd54d593ee131dff10a9
2020-04-08 18:56:52 -07:00
vadimt 180c2e10fc Adding diags to getWidget
Also avoiding scrolling widgets horizontally when the gesture could
happen in the lower system gesture area.

Change-Id: I80192db7e407f8c1715aad3b96178c00b5710e71
2020-04-08 21:12:20 +00:00
Vinit Nayak b9cb1e3c8f Merge "Re-enable orientation sensor for Overview animation" into ub-launcher3-master 2020-04-02 19:02:30 +00:00
Vinit Nayak 6b7cc3fdc2 Re-enable orientation sensor for Overview animation
Slight revert of ag/10668129 with adjustment
of disabling it for tests.

Fixes: 151456795
Test: Ran the labtest command for OOP
tests for crosshatch (where this issue
was first detected)

Change-Id: I315d138c2e4a6d4068304e9b5fb2e1b7feb34e63
2020-04-02 11:07:10 -07:00
TreeHugger Robot 639aca6142 Merge "Catching StaleObjectException (and everything else) from get bounds" into ub-launcher3-master 2020-04-01 22:16:08 +00:00
TreeHugger Robot 7b4a1f5b3c Merge "Events checking for long press events" into ub-launcher3-master 2020-04-01 18:33:24 +00:00
TreeHugger Robot f1939f6f54 Merge "Including full diags from system alerts" into ub-launcher3-master 2020-04-01 18:20:32 +00:00
vadimt e277fec466 Events checking for long press events
Also fixing duplicate long press events resulting from both framework
and Launcher own detection reporting long presses.

Change-Id: Ib46de5bd60850f1c5578992c8c1172ddbc0961f3
2020-03-31 19:08:17 -07:00
vadimt 486744b173 Including full diags from system alerts
Change-Id: I779d3ccb683aea46e7e1b58ed088933d5685c183
2020-03-31 18:36:38 -07:00
vadimt bb3f515690 Catching StaleObjectException (and everything else) from get bounds
This will improve diags because fail() adds useful info to the message

Change-Id: I0a27f80c71a900078c94d9dd44d431fc206a37a0
2020-03-31 14:03:00 -07:00
vadimt 5486970e31 Improving events checks diags
Printing matching sequences and making putput more readable.

Change-Id: I3325aa2a8291096017533372f9da0f7550f39313
2020-03-30 13:21:19 -07:00
TreeHugger Robot 349e95f1e4 Merge "TAPL: Verifying activity start/stop events" into ub-launcher3-master 2020-03-28 03:45:24 +00:00
TreeHugger Robot f64cef8ee6 Merge "Adding more tracing for a widgets test flake" into ub-launcher3-master 2020-03-28 01:37:17 +00:00
vadimt 926ed41fab Adding more tracing for a widgets test flake
Bug: 152354290
Change-Id: Ie3ed8430e3f3d5c93f1bea698be46f2ddd22dea0
2020-03-27 17:40:32 -07:00
vadimt 75add7cef5 Debug tracing for "widget not present" flake
Bug: 152645831
Change-Id: I1e318650e45ab8e2a60eccef2f4f3c247b2a6b5b
2020-03-27 15:08:36 -07:00
vadimt 0dd1bd1113 TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: Ie4ea5865afd900bebbd8287dad2372c94dce8ad5
2020-03-27 10:23:33 -07:00
TreeHugger Robot e6df7da2a2 Merge "Enabling event verification for Launcher3" into ub-launcher3-master 2020-03-07 07:19:13 +00:00
vadimt 16eca5500d Enabling event verification for Launcher3
Will help investigating otherwise mysterious failures.

Change-Id: I805ed136baf6d86921fdb4782304fcdafbd3af5c
2020-03-05 19:02:18 -08:00
vadimt 3abc8511a5 Enabling widget config tests after fixing flakiness
Bug: 148867106
Change-Id: I8bbd9ef9b1ca574f79f3f76869051495b59734ce
2020-03-05 15:01:38 -08:00
Sreyas 321bfae905 OverviewActions: Creating single view instance.
Makes use of there being a single instance of OverviewActionsView
rather than each Task having it's own.

Change-Id: I881121f84de99cade3cd8f07fa8510a557b28f57
2020-03-04 11:38:59 -08:00
Vadim Tryshev 1f2182683e Merge "Not failing when getSystemAnomaly fails" into ub-launcher3-master 2020-03-02 19:41:35 +00:00
Vadim Tryshev d8995a6fda Merge "Revert "TAPL: Verifying activity start/stop events"" into ub-launcher3-master 2020-02-28 22:29:47 +00:00
Vadim Tryshev 3dd64ca3a8 Revert "TAPL: Verifying activity start/stop events"
This reverts commit 1186700c9a.

Reason for revert: Fails in the lab

Change-Id: I6715a058c76d96752b904331968b46a07ce93f85
2020-02-28 22:28:16 +00:00
Zak Cohen 23ceafe3d5 Merge "TAPL tests - make all apps in overview checks less fragile." into ub-launcher3-master 2020-02-28 21:21:36 +00:00
vadimt 18b9f396d6 Not failing when getSystemAnomaly fails
It's a supplemental method, and mysterious glitches that happen during
its work shouldn't cause the whole test to crash.

Example:
java.lang.NullPointerException: Attempt to read from field 'com.android.server.appwidget.AppWidgetServiceImpl$ProviderId com.android.server.appwidget.AppWidgetServiceImpl$Provider.id' on a null object reference
	at android.os.Parcel.createExceptionOrNull(Parcel.java:2291)
	at android.os.Parcel.createException(Parcel.java:2269)
	at android.os.Parcel.readException(Parcel.java:2252)
	at android.os.Parcel.readException(Parcel.java:2194)
	at android.accessibilityservice.IAccessibilityServiceConnection$Stub$Proxy.findAccessibilityNodeInfoByAccessibilityId(IAccessibilityServiceConnection.java:875)
	at android.view.accessibility.AccessibilityInteractionClient.findAccessibilityNodeInfoByAccessibilityId(AccessibilityInteractionClient.java:430)
	at android.view.accessibility.AccessibilityInteractionClient.getRootInActiveWindow(AccessibilityInteractionClient.java:214)
	at android.app.UiAutomation.getRootInActiveWindow(UiAutomation.java:607)
	at androidx.test.uiautomator.UiDevice.getWindowRoots(UiDevice.java:1102)
	at androidx.test.uiautomator.UiDevice.findObject(UiDevice.java:150)
	at com.android.launcher3.tapl.LauncherInstrumentation.getSystemAnomalyMessage(LauncherInstrumentation.java:334)
	at com.android.launcher3.tapl.LauncherInstrumentation.getAnomalyMessage(LauncherInstrumentation.java:359)
	at com.android.launcher3.tapl.LauncherInstrumentation.checkForAnomaly(LauncherInstrumentation.java:369)
	at com.android.launcher3.tapl.LauncherInstrumentation.lambda$eventsCheck$11(LauncherInstrumentation.java:1269)
	at com.android.launcher3.tapl.LauncherInstrumentation.lambda$eventsCheck$11$LauncherInstrumentation(Unknown Source:0)
	at com.android.launcher3.tapl.-$$Lambda$LauncherInstrumentation$3iFY1gd72Tm3mPf31PMij-eBaBk.close(Unknown Source:2)
	at com.android.launcher3.tapl.AddToHomeScreenPrompt.addAutomatically(AddToHomeScreenPrompt.java:53)
	at com.android.launcher3.ui.widget.RequestPinItemTest.runTest(RequestPinItemTest.java:163)
	at com.android.launcher3.ui.widget.RequestPinItemTest.testPinWidgetNoConfig_customPreview(RequestPinItemTest.java:95)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:148)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:142)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:923)
Caused by: android.os.RemoteException: Remote stack trace:
	at com.android.server.appwidget.AppWidgetServiceImpl$AppWidgetManagerLocal.getHostedWidgetPackages(AppWidgetServiceImpl.java:4887)
	at com.android.server.accessibility.AccessibilitySecurityPolicy.computeValidReportedPackages(AccessibilitySecurityPolicy.java:229)
	at com.android.server.accessibility.AbstractAccessibilityServiceConnection.findAccessibilityNodeInfoByAccessibilityId(AbstractAccessibilityServiceConnection.java:621)
	at android.accessibilityservice.IAccessibilityServiceConnection$Stub.onTransact(IAccessibilityServiceConnection.java:372)
	at android.os.Binder.execTransactInternal(Binder.java:1138)

Change-Id: If7ae23d07b69d524c3f300607f0866cce6405416
2020-02-28 12:08:19 -08:00
Zak Cohen dc24231e4f TAPL tests - make all apps in overview checks less fragile.
Tests that check for all apps in overview mode were only checking for
actions being enabled. This isn't sufficient logic, two button mode also
uses all apps.

Centralize the check for all apps.

Test: local tapl tests
Change-Id: If1bf98019e6f1aea8f7967883aba6780743e9d6b
2020-02-28 11:59:33 -08:00
Vadim Tryshev 64a932ed2a Merge "TAPL: Verifying activity start/stop events" into ub-launcher3-master 2020-02-28 19:22:32 +00:00
Zak Cohen eecb258cc7 Merge changes from topic "enable" into ub-launcher3-master
* changes:
  Overview Actions - Enable by default.
  TAPL test update - don't run all apps in overview tests with actions.
2020-02-27 19:48:51 +00:00
Vadim Tryshev 0e0b176361 Merge "Not showing "mismatched events" and other diags after Launcher crashes" into ub-launcher3-master 2020-02-27 19:45:39 +00:00
vadimt 1186700c9a TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: I5851aafb6d04398c5727712eaf8561916a30c4c5
2020-02-27 11:12:35 -08:00
vadimt da12b805cc Not showing "mismatched events" and other diags after Launcher crashes
Change-Id: Iee5f8813c3610314d486589bc361466a05da0ecb
2020-02-26 12:19:32 -08:00