Commit Graph

2420 Commits

Author SHA1 Message Date
Winson Chung 8822dc0018 Merging ub-launcher3-qt-r1-dev, build 5766606
Test: Manual

Bug:135926478 P2 Work Profile calendar widget not copied over correctly
Bug:135969043 P2 Easily mis trigger full gesture swipe to home when play the app with landscape mode
Bug:137196872 P1 Launcher stays visible when cancelling recents transition
Bug:138403212 P2 Send back action update to tips app
Change-Id: I2e10798216034f52374240f5fbc577cbb903250d
2019-07-31 09:38:49 -07:00
Sunny Goyal c302baced0 Notifying the geature guide app when back gesture is performed
so that user onboarding can the updated accordingly

Bug: 138403212
Change-Id: Ib4e1cde0b2c746f955d5a58251c8ab653dadbc67
2019-07-29 11:55:11 -07:00
Winson Chung fa652a8a4f Updating to use deferred cancel api
- Also updating the sysui flag to home's flags when passing some
  threshold
- Also ensure we don't allow swipe up when QS is open

Bug: 137196872
Bug: 135969043
Change-Id: I476eee7f02ae86aa795fceabb304bcaa7416ef9c
2019-07-27 10:08:52 -07:00
Adam Cohen 574d6c152c Merging ub-launcher3-qt-r1-dev, build 5758528
Test: Manual

Bug:128940249 P2 Investigate performance options for 90Hz when swiping to -1
Bug:134074554 P2 Enable test testPressHomeOnAllAppsContextMenu()
Bug:134181439 P3 Missing drag down gesture to open shade while in landscape
Bug:134981174 P1 [Google] Search bar disappears from home screen
Bug:136800511 P1 Brightness shifts when swipe up + hold to recents
Bug:137137090 P2 Improve swipe down noti shade (landscape, logging) and other swipe up home gesture logging
Bug:138025252 P4 Pixel Launcher keeps stopping when changing system language
Bug:138144992 P4 NullPointer in TouchInteractionService.dump
Bug:138227387 P1 Remove 2-button option where not appropriate
Bug:138245847 P4 On a third party wallpaper, long press not highlighting home screen folder name.
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138401738 P1 Master: java.lang.AssertionError: Navigation mode didn't change to TWO_BUTTON
Change-Id: Ib66a27de5515957a42d0791b76dfca8ed7b248d7
2019-07-26 22:08:16 +00:00
Winson Chung 1d3d19f2e1 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev 2019-07-26 16:46:35 +00:00
Winson Chung 0ef10a458d Skip tests for overlays that don't exist on device
Bug: 138401738
Bug: 138227387
Change-Id: If661fd342e1382915485bccdf6ae2c9e77a92bc4
2019-07-26 00:09:43 +00:00
vadimt f88d0b5a8a More diags in TouchInteractionService
Bug: 138251824
Change-Id: I0909a2c85b1b2bdd8b67da59c978d6a3bbb58ee5
2019-07-25 16:38:39 -07:00
TreeHugger Robot 3bbb20262b Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev 2019-07-25 23:17:21 +00:00
Winson Chung 5089140cda Fix NPE in service dump
Bug: 138144992
Change-Id: I608ea209b04fce13a63190ec424849dc909a6a9a
2019-07-25 15:22:47 -07:00
TreeHugger Robot 2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary 93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
Vadim Tryshev 2870df0776 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev 2019-07-25 19:47:42 +00:00
Tony Wickham 2b365ae7f0 Fix incorrect task index bounds
Should have been using min, not max. Added lower bound for good measure.

Bug: 138025252
Change-Id: Icd8c7d62dca7605fe63e83602e4c9fceb91f68a6
2019-07-25 12:27:29 -07:00
vadimt 7593dc995b NavigationModeSwitchRule: log exception before 'finally'
Change-Id: I158105da467e2759fec6fa5d8acd582b2e95f7c5
2019-07-25 12:16:31 -07:00
James O'Leary 74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Jon Miranda b6ce5eb1de Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev
am: 95bc50fafa

Change-Id: Ia00ea7d1298a6f46c1ff779f13a3bf015ec5cd8a
2019-07-24 19:16:18 -07:00
Tony Wickham cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Jon Miranda e734efba8d Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-24 17:15:13 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Winson Chung 3fc9a1cf69 Merging ub-launcher3-qt-r1-dev, build 5749827
Test: Manual

Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:137129923 P1 Pixel launcher is leaking memory
Bug:137161198 P1 Unable to pull notification panel down with a swipe on home screen
Bug:137253043 P1 "Pixel Launcher keeps stopping" when scrolling through recent apps
Bug:137487381 P1 Overview goes back to fullscreen when swiping up during transition
Bug:137836033 P4 Fail to stop music due to "Swipe failed to receive an event for the swipe end"
Bug:138152531 P2 [Android Q][04713598] Launcher test cases are failed
Bug:138236583 P1 Icon scale is wrong when dragging from all apps or folders
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138252347 P1 qt-r1-dev Pixel Launcher flag ENABLE_HINTS_IN_OVERVIEW is Disable by Default
Change-Id: Idd0e987d26e1ffc75cdb9f90e9c08c26bb8c6503
2019-07-23 20:54:13 -07:00
Winson Chung 0727d59576 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev 2019-07-24 00:12:28 +00:00
TreeHugger Robot 8578309f1b Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev 2019-07-24 00:01:25 +00:00
Tony Wickham fbd77c48cc Distinguish mDragHandleProgress from mMidProgress
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.

Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
2019-07-23 16:58:45 -07:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Winson Chung 48ba8c864c Fix regression in assistant window handling
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
  swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task

Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
2019-07-23 16:25:46 -07:00
Zak Cohen 87477f5996 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev 2019-07-23 22:51:28 +00:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham 3fca6aaec2 Finish recents animation when touching during animation to recents
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().

Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
2019-07-19 16:53:00 -07:00
Zak Cohen bc4d213535 TaskView - add a getter for the bitmap data.
This allows other components to get it directly from the view, rather
than retaining their own copy.

Bug: 137129923
Tested: Manual

Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
2019-07-19 15:14:53 -07:00
vadimt c8d496fe00 Fix waiting for launcher initialization
Bug: 137836033

Change-Id: Ifc8ce867abd85eaeacd09a2b39636ecc4109c046
2019-07-18 18:31:49 -07:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
Winson Chung 5841e40a95 Merging ub-launcher3-qt-r1-dev, build 5736932
Test: Manual

Bug:111935715 P2 Incorrect parent type when logging drag and drop from All Apps
Bug:131315856 P1 [PO restore] No work profile launcher shortcuts restore ~50% of the time
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:133891845 P2 TAPL: need clearer diags when a crash dialog is over Launcher or there is lock screeen
Bug:134532571 P1 Launcher flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview, but the current state is not BASE_OVERVIEW; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/overview_panel\E']
Bug:135165284 P2 [Q-Preview4] Gestural navigation animation glitch on RTL
Bug:135567630 P1 testBackground crashes in Landscape
Bug:135636137 P1 Workspace is clipped at the top when transitioning from app -> home
Bug:135687618 P4 Task shows between back and swiping up to overview
Bug:135952890 P1 Drag up on home indicator does not track finger if recently entered split screen
Bug:136033787 P0 Vzw DoU: sendexchangeemail wifi test fails with failed dismissal exception
Bug:136215685 P1 Flake: swiping up from Home to Overview in 2-button mode sometimes fails
Bug:137197916 P1 Add gesture support for 3p Launcher
Bug:137215697 P2 FloatingIcon and workspace icon visible at the same time when touch input during app to close animation
Bug:137290162 P1 Overview suggest chip showing on apps due to misconfigured flag
Bug:137316430 P1 Jank when swiping quickly back down to home when overview is peeking
Bug:64712476 P3 Import translations for dev branches
Change-Id: Ib228c0f291884050904fa069e25519755071c40a
2019-07-18 11:36:39 -07:00
Jon Miranda 11b5535556 Skip TouchInteractionService preload if restore task is pending.
Otherwise the preload may cause launcher to restore too early, resulting
in data loss.

Bug: 131315856
Change-Id: I4412c8f691286ba142e9c748a908a3ed42713a82
2019-07-17 21:24:07 -07:00
TreeHugger Robot aaf6c7ce56 Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev 2019-07-17 23:02:50 +00:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Jon Miranda bc27826478 Fix bug where icon is no present during app close animation.
* WindowTransformSwipeHandler closes all AbstractFloatingViews, including
  ListenerView, which results in FloatingIconView getting removed.
* In IconLoadResult.onIconLoaded, we remove the check for isIconLoaded since
  its not needed. This was also causing a race condition since isIconLoaded
  is not set to true until after we tell onIconLoaded to run.
* In BaseDragLayer, we have a delay before checking if the view is open and
  then closing the floating view if true. This caused issues since we reycle
  the view. Now we check if the view is open before running the delay to call
  close.

Bug: 136044361
Change-Id: I7442a589a62c3cdf90b70d146e0ecf3e4300ddf7
(cherry picked from commit 826cdcd32f)
2019-07-17 22:16:40 +00:00
Sunny Goyal e88d8acd85 Adding spring animation when swiping up to home in 3P Launcher
Bug: 137197916
Change-Id: Ic9808a30e8cd4e0b2a221c4b03bc29489038e092
2019-07-17 11:39:25 -07:00
Vinit Nayak 10d278f3d5 Merge "Reload task list when task is removed" into ub-launcher3-qt-r1-dev 2019-07-17 00:49:52 +00:00
TreeHugger Robot 401583f9b6 Merge "Getting starting point of swipe from overview to all apps via protocol" into ub-launcher3-qt-r1-dev 2019-07-17 00:24:55 +00:00
vadimt 6a75e52f85 Getting starting point of swipe from overview to all apps via protocol
Change-Id: Idf04579b67011dac45b081a81367cde2d1274117
2019-07-16 16:46:53 -07:00
Vinit Nayak 2c7917d100 Reload task list when task is removed
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.

Test: Visually inspected, recent task no longer
disappears.
Open any app, hit back, and then go to overview quickly.
App should remain in recents list.

Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
(cherry picked from commit 8651219f7e)
2019-07-16 23:24:36 +00:00
TreeHugger Robot f2de54b275 Merge "Removing tracing for fixed bugs" into ub-launcher3-qt-r1-dev 2019-07-16 23:15:07 +00:00
Sunny Goyal 365f29e577 Adding support for swipe operation when on home screen
Bug: 137197916
Change-Id: Ic85bf9767d4a9a77dafc1c60c02555f3d2a5d8a2
2019-07-16 10:51:13 -07:00
Sunny Goyal 587c3cef51 Fixing multiwindow transition when using 3P launcher
Bug: 137197916
Change-Id: I3c5cfc290972187d9d556a722afc61489d0d0629
2019-07-16 17:43:21 +00:00
TreeHugger Robot 160134e0b1 Merge "Fix overshoot velocity in 2-button landscape mode" into ub-launcher3-qt-r1-dev 2019-07-16 17:38:05 +00:00
Sunny Goyal 2e4b665933 Adding horizontal swipe support for 3p launcher
Bug: 137197916
Change-Id: I0fb5db791b3471d651db43f0e8c30b8d5baf9f27
2019-07-16 09:59:55 -07:00
TreeHugger Robot d4b839145c Merge "Don't preload overview if current home isn't gestural overview" into ub-launcher3-qt-r1-dev 2019-07-16 04:42:00 +00:00