Commit Graph

19093 Commits

Author SHA1 Message Date
Sebastian Franco 789546f528 Using the right context when in FixedLandscape
Fix: 378956881
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I57c0fb2b57828e0cb80d20417f0a45e49c78b80e
2024-12-04 23:51:34 +00:00
Shamali Patwa 2909e72d36 Merge "Update accessibility hint for widget cell that shows add button." into main 2024-12-04 20:22:26 +00:00
Treehugger Robot 14a4684992 Merge "Fix issue in scrolling in remote compose widgets" into main 2024-12-04 18:38:57 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Alex Chau d7ad4d5dee Merge "Reapply insets normalization on configuration changes" into main 2024-12-04 11:25:37 +00:00
Alex Chau ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
Pinyao Ting 1f72f9b3de Fix issue in scrolling in remote compose widgets
There was special check in LauncherAppWidgetHostView to disallow intercept touch events in launcher when the widget is scrollable, the same check needs to be implemented for remote compose widget for scrolling to work properly.

Bug: 339721781
Change-Id: I8b824f293ab287a7844f93610b8b952c4aefa3dd
Test: manual
Flag: EXEMPT bugfix
2024-12-04 00:45:48 +00:00
Treehugger Robot d0b6a849ad Merge "Make DynamicResource as dagger singleton (15/n)" into main 2024-12-03 22:14:56 +00:00
Treehugger Robot 5ef606c417 Merge "Do not let talkback read "Item added to home screen" after an app is added to home screen." into main 2024-12-03 21:43:08 +00:00
Anushree Ganjam b60be0896d Make DynamicResource as dagger singleton (15/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I8a3de783de34f79c8f8f64c5c964cc1636ace1a8
2024-12-03 12:01:45 -08:00
Alex Chau 579a785144 Reapply insets normalization on configuration changes
- When going from an app to Overview after deivce is rotated, sometimes the Configuration associated with Launcher activity have old information (dimension from preious rotation), causing LauncherRootView.onApplyWindowInsets to store wrong insets from WindowManagerProxy.normalizeWindowInsets
- The fix is when LaucnehrRootView.dispatchInsets is called, reapply insets by calling onApplyWindowInsets again to get updated normalized insets.

Fix: 323105140
Test: Launch an app, rotate to landscape, tap Recents button to go to Overview
Flag: EXEMPT BUG_FIX
Change-Id: I8e641a2702670d1364ee5a0f10a1b3c8d1a2b324
2024-12-03 19:03:28 +00:00
Brandon Dayauon f274d3ca95 Merge "Fix "disabled" at the end of talkback for workPausedCard." into main 2024-12-03 18:31:46 +00:00
Alex Chau 007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
Treehugger Robot 1733dedf85 Merge "Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count" into main 2024-12-03 18:05:10 +00:00
Brandon Dayauon a7340e8575 Merge "Add unit testing to workkUtilityView" into main 2024-12-03 15:43:48 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Kevin Lim 79fb6dfbdb Merge "[a11y] Fix talkback column and item count for AllAppsGrid" into main 2024-12-02 20:52:54 +00:00
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Brandon Dayauon fcb892328b Add unit testing to workkUtilityView
Testing inflate and visibility states (with both flag states)

bug: 361589193
Test: manually screenshot: https://screenshot.googleplex.com/45HDsyfQfNbgjiE
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I57cff03fe3b362e304f52984a2699f8d5b6e653e
2024-12-02 10:32:56 -08:00
Treehugger Robot b5bf7820e6 Merge "Adding MSDL haptics for dragging app icons in Workspace and Hotseat." into main 2024-11-29 08:14:34 +00:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Brandon Dayauon 067ed8fa6e Fix "disabled" at the end of talkback for workPausedCard.
Talk back announces "disabled" at the end because onClick() seems to unncessarily call setEnabled(false). It's not needed
and can be removed.

bug: 379804516
Test: manually with talkback
Flag: EXEMPT bug fix
Change-Id: Iebd0c0689f7a36320ec59b6898daf10988b75cf6
2024-11-27 15:53:25 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Ana Salazar Maldonado ffef53ecb6 Merge "Fix condition for showing contraste tile" into main 2024-11-27 21:16:38 +00:00
Mykola Podolian 400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
mpodolian 28907bcbd6 Set bubble bar aligned to QSB
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.

Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
2024-11-27 10:15:08 -08:00
Ana Salazar Maldonado 1e392d6679 Fix condition for showing contraste tile
Merge error caused the condition to only draw contrast tiles for empty
labels.

Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Id2d55d3bc16e76613faca07b0fd28ef01921f016
2024-11-27 10:00:58 -08:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
Ana Salazar Maldonado 9531c19ba3 Merge "Avoid drawing the contrast tile on empty text" into main 2024-11-27 02:57:30 +00:00
Kevin Lim d05a94888c [a11y] Fix talkback column and item count for AllAppsGrid
The new ItemCount API in Baklava is for AccessibilityNodeInfo, for total
items in grid. Since in AllApps grid we override and use
AccessbiilityNodeInfoForItem for the specific app within the column, we
should instead fix the column count override with the proper column counts.

Bug: b/228935017
Flag: EXEMPT a11y bug fix
Test: Manual; Before: https://recall.googleplex.com/clips/24b23bab-add8-4c13-a203-9f92144537a3
Test: Manual; After: https://recall.googleplex.com/clips/d9190fb5-c912-4dc9-8a09-868a1a1fd500
Test: Manual; Changing grid: http://recall/clips/2d513dc2-ffee-4680-95a0-ba263155d194
Change-Id: Id4a22fdbd258bca8102c16502629ea51971b139d
2024-11-26 23:50:19 +00:00
Anushree Ganjam 4c390b98f2 Merge "Create ApplicationInfoWrapper with ItemInfo.getTargetPackage() to support DeepShortcuts" into main 2024-11-26 23:08:59 +00:00
Ana Salazar Maldonado 2161355885 Avoid drawing the contrast tile on empty text
Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Ic3199d6263ac3adfd7c270de14439b0095afed1c
2024-11-26 14:52:26 -08:00
Sebastián Franco ded458db94 Merge "Add Event log for FIXED_LANDSCAPE_TOGGLE" into main 2024-11-26 19:44:45 +00:00
Holly Sun 879af5779c Do not let talkback read "Item added to home screen" after an app is added to home screen.
Bug: 379643701
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I29082c2db33e0a5d20f07e7ecc4a71448337104e
2024-11-25 21:15:53 -08:00
Anushree Ganjam 61d0c95f76 Create ApplicationInfoWrapper with ItemInfo.getTargetPackage() to support DeepShortcuts
Follow up fix for
https://googleplex-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/29586180/9/src/com/android/launcher3/popup/PopupPopulator.java#119
and crash since componentName can be null for Deep shortcuts.

Bug: 375567866
Test: Presubmit
Flag: EXEMPT Bugfix
Change-Id: I5b20248a3cc87cf044aac9848aed4cbeb6d5b092
2024-11-25 20:14:41 -08:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Sebastian Franco 8fc5f39007 Add Event log for FIXED_LANDSCAPE_TOGGLE
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I154839e78a197444ccbcbd86bba101865c6a964b
2024-11-22 15:35:35 -08:00
Ana Salazar Maldonado f18e02fa7b Merge "Avoid drawing the launcher pill outside the view bounds" into main 2024-11-22 22:13:38 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Juan Sebastian Martinez a91fbb2efd Adding MSDL haptics for dragging app icons in Workspace and Hotseat.
The feedback occurs when an icon hovers over an empty available space in
Workspace and Hotseat, as well as over other icons to create folders.
This is now compliant with the Multi-sensory Design Language spec.

Test: manual. Verified haptics while dragging icons over Workspace and
  Hotseat.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
  checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 371314631

Change-Id: I7d039ddf9d05faa39a6e6e3f9a84217d8916adc0
2024-11-22 10:31:18 -08:00
Juan Sebastian Martinez 12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Treehugger Robot 05e02fae43 Merge "Add logs for grid migration" into main 2024-11-22 15:52:00 +00:00
Treehugger Robot f2f8cd7536 Merge "Remove redundant a11y announcement upon removal of workspace item." into main 2024-11-22 15:49:35 +00:00
Pinyao Ting 604ae3283c Remove redundant a11y announcement upon removal of workspace item.
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.


Bug: 378032433
Change-Id: Iaf3b42404ecd382b1ee15f670cc4ebe0124218d2
Test: manual
Flag: EXEMPT bugfix
2024-11-22 00:34:03 +00:00
Brandon Dayauon 90ff53775a Merge "Fix keyboard staying up in AOSP launcher." into main 2024-11-21 22:06:11 +00:00
fbaron 4f1e64c8e6 Add logs for grid migration
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a it's just logs
Change-Id: Icce21f507e07adfd954fd88634bdd7f0becf4a4c
2024-11-21 13:59:39 -08:00
Juan Sebastian Martinez 86f3d35839 Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest.
The mock makes sure we don't rely on a device hardware for tests.

Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
2024-11-21 13:32:43 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Sebastian Franco cb8f82a9fd Remove Allow Rotation in foldables
Fix: 380128987
Flag: com.android.launcher3.one_grid_specs
Test: NA
Change-Id: I4bdb495b57fa7d638dde3fe47e853f3505f63628
2024-11-20 15:42:43 -08:00
Brandon Dayauon c2f4537495 Fix keyboard staying up in AOSP launcher.
The keyboard doesn't close when swiping down from A-Z list. So in Launcher when going to any state from A-Z getAPpsView().reset() gets called which eventually
calls resetSearch() where we can hideKeyboard.

bug: 379052503
Test: before in bug
after: https://drive.google.com/file/d/11oVTvkBtj9rECEtz4IVH1tURaJz6pFTO/view?usp=sharing
Flag: NONE bug fix
Change-Id: I707bf5dc2f81d5e83e869e34de674ef7fc065486
2024-11-20 14:30:41 -08:00