Commit Graph

14804 Commits

Author SHA1 Message Date
Ikram Gabiyev 749a2d2a6a Merge "Remove contentDescription attribute in filter icon" into udc-dev 2023-05-25 18:40:00 +00:00
Saumya Prakash 4ccfbf38bb Merge "Update Lottie files in gesture nav education" into udc-dev 2023-05-25 17:10:23 +00:00
Hui Kang 879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Luca Zuccarini 07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Brandon Dayauon fe3d513650 Merge "Update work tab colors and fab background color" into udc-dev 2023-05-25 03:07:59 +00:00
Ikram Gabiyev 45b33a1a55 Remove contentDescription attribute in filter icon
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
2023-05-24 14:01:04 -07:00
Jagrut Desai 990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Brandon Dayauon adcc16cf56 Update work tab colors and fab background color
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD

bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6

NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v

Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Luca Zuccarini f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Hui Kang 5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Bill Yi 754bb05feb Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-23 22:58:05 +00:00
Saumya Prakash de9f592268 Update Lottie files in gesture nav education
The existing home gesture animation had a flicker due to an incorrect
frame in the Lottie jsons. This change updates the json files for all
form factors to the corrected version.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283760250
Test: Went through the home gesture tutorial on tablet, foldable, and
mobile and verified the new animation played correctly

Change-Id: I55276ba9258e2b9908f05e0397f7c084fedf3926
2023-05-23 21:59:32 +00:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Thales Lima ac206e1daf Merge "Create TAPL test for taskbar in overview" into udc-dev 2023-05-23 18:32:34 +00:00
Luca Zuccarini a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Thales Lima 1f10e53ba2 Create TAPL test for taskbar in overview
Fix: 269985301
Test: TaplTestsQuickstep
Flag: none
Change-Id: Iea0311bcba54882f7f2cf5d35cd98a538ae85855
2023-05-23 13:22:10 +00:00
Tony Huang 2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Bill Yi 358954a957 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2ba41c3831b537e4564e3e4ddf48ec4125a1260a
2023-05-22 17:36:20 -07:00
Treehugger Robot 25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Vadim Tryshev 807d9c2c30 Merge "Revert "Re-enabling a couple of tests"" into udc-dev 2023-05-22 20:28:07 +00:00
Schneider Victor-tulias b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Schneider Victor-tulias 7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Jagrut Desai 6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Tony Huang 2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt 144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai 709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Vadim Tryshev 8d1de90744 Revert "Re-enabling a couple of tests"
This reverts commit 81b228a5fb.

Reason for revert: b/283523638

Change-Id: I2787b34e369ed2c879d80806bc30cab3dbb10c69
2023-05-19 21:17:55 +00:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Vadim Tryshev bc4813afb2 Merge "Re-enabling a couple of tests" into udc-dev 2023-05-19 17:37:16 +00:00
Luca Zuccarini 2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
Hongwei Wang 0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Randy Pfohl f6b74f1521 Merge "Updating overview colors to utilize new tokens" into udc-dev 2023-05-18 22:43:30 +00:00
Saumya Prakash 66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00
Schneider Victor-tulias 9caa0f9559 Fix redesigned gesture nav jank
- Removed the fake animated taskbar view from the redesigned tutorial flow
- Fixed the hotseat and home icon colors from the overview step

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Fixes: 281121701
Fixes: 283310758
Test: swiped up from home/overview step
Change-Id: Ie659495994f0c935c5b6c6bf1ae534ec51521726
2023-05-18 14:36:28 -07:00
Hongwei Wang 45b8d39ab8 Notify WMShell on aborting auto-enter-pip
Note that this change does not fix the bug listed here. This is to
callback WMShell when the transition is aborted and WMShell can choose
how to handle this.

Bug: 283177443
Test: adb shell dumpsys activity service SystemUIService WMShell
Test: go/winscope and check the SF/WM dump
Change-Id: I8abfc2db47d1f0bfc3d400066936bed354743420
2023-05-18 13:15:57 -07:00
Jagrut Desai 20c26a4a6c Merge "Fix TaplTestsTaskbar" into udc-dev 2023-05-18 20:11:59 +00:00
Treehugger Robot 80e9a3b64e Merge "Fix widget clipping in widget back animation" into udc-dev 2023-05-18 19:59:21 +00:00
randypfohl b8e47fe329 Updating overview colors to utilize new tokens
Test: built locally and verified colors
Flag: none
bug:275709319
Change-Id: I1abcf608e0279a70e975190ea66128563f996f3e
2023-05-18 11:15:07 -07:00
Saumya Prakash 0a6fb2c9e1 Update Lottie animations for gesture navigation tutorial to enable custom colors
This change introduces tokens for all the lottie animations in the
gesture navigation tutorial so that the colors can be changed to match
with the current design spec at http://shortn/_aig7n8W7rF

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Bug: 281764891
Test: Tried changing colors and verified that lottie animations changed
appropriately.

Change-Id: If2c820826603fb1cf424f5f0c97d83b195d26606
2023-05-18 10:47:44 -07:00
Schneider Victor-tulias 474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Vinit Nayak 6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00
Jagrut Desai b9a88db27c Merge "Fixing spacing between folder icon and folder itself" into udc-dev 2023-05-18 17:21:33 +00:00
Treehugger Robot 4b941231ce Merge "Re-enable testOverviewForTablet for persistent taskbar." into udc-dev 2023-05-17 23:33:59 +00:00
Bill Yi e3622a4b74 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-17 22:08:53 +00:00
Sihua Ma f8acb23e1f Fix widget clipping in widget back animation
Test: Manual
Fix: 280261814
Change-Id: I4db24ca624d50b1d860df428fdab9d591f35ac5e
2023-05-17 13:32:20 -07:00
Jagrut Desai 23d752779b Fix TaplTestsTaskbar
we were going to overview and clearing tasks before splitscren test are broken because of it.

Test: Presubmit
Bug: 281772186
Flag: not needed
Change-Id: I79addec3cfa0adf41581be72fed2ca3cd024a904
2023-05-17 11:51:41 -07:00
Saumya Prakash e212779ffd Merge "Display app icons in quick switch task view when there are no updates." into udc-dev 2023-05-17 17:11:49 +00:00