Commit Graph

17692 Commits

Author SHA1 Message Date
Jagrut Desai 7736ec8968 Merge "Decreasing the intensity of haptic feedback for taskbar invocation" into main 2023-11-30 19:29:45 +00:00
Tracy Zhou aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Bill Yi 62cd93cd06 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-11-30 17:46:44 +00:00
Andreas Agvard 711f104409 Merge "Use NavHandleLongPressInputConsumer regardless of flags." into main 2023-11-30 13:32:00 +00:00
Pat Manning 2a350af739 Merge "Show taskbar pinning dialog on right-click." into main 2023-11-30 10:57:41 +00:00
Pat Manning 001d1cda52 Merge "Allow right-click of taskbar icons to launch long-click menu." into main 2023-11-30 10:56:46 +00:00
Anna Zhuravleva 94228b18db Merge "Add user_type field and log it in Launcher" into main 2023-11-30 10:28:45 +00:00
Johannes Gallmann 0c3b20b585 Merge "Use Decelerate Interpolator for predictive back to home window scaling" into main 2023-11-30 08:10:04 +00:00
Johannes Gallmann c07b1c92b0 Merge "Prevent scaled window from leaving screen bounds for back to home" into main 2023-11-30 08:09:39 +00:00
Tracy Zhou 6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Winson Chung abb4483f6f Merge "Add Launcher support for left-right splits on portrait foldables" into main 2023-11-30 05:52:57 +00:00
Jagrut Desai a5ad8bed64 Decreasing the intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ic8c28b8e84bf9f388a73c518c91840d958287546
2023-11-29 19:03:33 -08:00
Jon @ 95306b1502 Merge "Allow initial call to onLauncherVisibilityChanged when using home transition listener." into main 2023-11-30 01:15:26 +00:00
Jon Miranda bd53046738 Allow initial call to onLauncherVisibilityChanged when using home transition listener.
Fixes: 308632502
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Test: HomeTransitionObserverTest
Change-Id: I8992f8f74cbfa7e98a79a136265ee6c4ad784c2c
2023-11-29 13:35:03 -08:00
Andy Wickham 3523154b07 Use NavHandleLongPressInputConsumer regardless of flags.
This way we can still log long press attempts even when the
feature flags or settings are disabled.

We always log LAUNCHER_LONG_PRESS_NAVBAR when a long press is
detected, even if nothing else happens.

Additionally, we log LAUNCHER_DEEP_PRESS_NAVBAR if the long
press was short-circuited by a deep press. In this case both
logs will appear.

If ENABLE_LPNH_DEEP_PRESS is false, it's possible that
LAUNCHER_DEEP_PRESS_NAVBAR will be logged without
LAUNCHER_LONG_PRESS_NAVBAR. This is because we log deep press
even if the feature is disabled, but it won't cause long press to
trigger immediately, so the user may release their finger before
the normal long press triggers.

Note: getLongPressRunnable will still return null if the flags or
other checks fail, so nothing will happen beyond logging.

Fix: 313477667
Fix: 310955078
Test: Manual with wwlogcat with flags in various states
Flag: NA
Change-Id: I40ceb5a22b364c2d5d6e4fdabb546b81c84354eb
2023-11-29 13:02:27 -08:00
Bill Yi b72796db31 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8827e64a1ba84eb28febabd33f591faf7113f362
2023-11-29 12:47:12 -08:00
Winson Chung 104a4c8b69 Add Launcher support for left-right splits on portrait foldables
Bug: 291018646
Test: Manual
Flag: enable_left_right_split_in_portrait

Change-Id: I92af7ffd83770f7e942c3892a12b1611ff5b50f4
Signed-off-by: Winson Chung <winsonc@google.com>
2023-11-29 20:20:14 +00:00
Alex Chau 4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Anna Zhuravleva 9c20381231 Add user_type field and log it in Launcher
Add new field user_type to decouple
work_profile and private_space users.
Deprecate is_work boolean field.

Bug: 312200869
Test: statsd_testdrive 19, output: https://paste.googleplex.com/5912695996416000
Flag: NA
Change-Id: Idc25f341b4353a85b8a93eab97c88195895baedc
2023-11-29 10:26:53 +00:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Johannes Gallmann 8c197b9328 Merge "Fix task window losing scale when going back to home" into main 2023-11-28 20:35:13 +00:00
Johannes Gallmann b4f33ab7bb Merge "Fix crash in LauncherBackAnimationController" into main 2023-11-28 20:34:10 +00:00
Schneider Victor-tulias 812bc2a9c5 Merge "Refactor LottieAnimationColorUtils to enforce proper usage" into main 2023-11-28 19:49:36 +00:00
Schneider Victor-tulias 891865dd60 Merge "Fix NPE in TaskAnimationManager" into main 2023-11-28 19:49:22 +00:00
Sunny Goyal eb67c99e5f Merge "Removing unnecessary iconFactory class when generating badged icon" into main 2023-11-28 19:02:02 +00:00
Sebastián Franco 4a708997a1 Merge "Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest" into main 2023-11-28 18:32:58 +00:00
Sergey Pinkevich d3087e3c16 Merge "Fix blinking for the active tile" into main 2023-11-28 18:31:07 +00:00
Tracy Zhou 898aec864d Merge "[taskbar/navbar unification] Do not shift back button after unlocking in phone mode" into main 2023-11-28 18:20:58 +00:00
Andy Wickham 9e6f276d41 Merge "Adds withPackageName to StatsLogger creation" into main 2023-11-28 17:15:55 +00:00
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Helen Cheuk 4a6d4994c3 Merge "Remove excess entry before putting new item" into main 2023-11-28 13:03:53 +00:00
Sergey Pinkevich 6c7ddc9b90 Fix blinking for the active tile
Call of `buildAnimationController` within `View#onApplyWindowInsets` if endTarget is not null.

Bug: 312439564
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual - took a screen recording:
Before - https://drive.google.com/file/d/1P2GsTi0xCZFjAsTQKonMMADHGkKuxMe0/view?usp=sharing
After - https://drive.google.com/file/d/1xkbFa-2Xp1OwmPrKLcqE2cYshVRXY2YV/view?usp=sharing

Change-Id: I6eb2a48bb548e20c1d36a058921ff8e1a0983cad
2023-11-28 12:24:40 +00:00
Johannes Gallmann 1de8952a30 Fix task window losing scale when going back to home
Bug: 305934426
Flag: NONE
Test: Manual, i.e. testing back to home with different devices and device orientations
Change-Id: I3eddbc918de95be713aecb469501b01e6b7b3d3b
2023-11-28 11:33:29 +01:00
Vadim Tryshev 8f2dc92364 Merge "Permanently demoting stress tests from presubmit to speed up presubmits" into main 2023-11-28 02:38:25 +00:00
Federico Baron f378be865d Merge "Fix activity leak in QuickstepLauncher" into main 2023-11-28 00:02:30 +00:00
Sunny Goyal 0069e54f1e Removing unnecessary iconFactory class when generating badged icon
Bug: 276957152
Test: Verified on device
Flag: None
Change-Id: I31ca3ef939684b16c0134d19f0add574b4b59706
2023-11-27 15:44:31 -08:00
Vadim Tryshev 5feaf596e6 Permanently demoting stress tests from presubmit to speed up presubmits
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2edf419ad556d2a4bf5c77b5c026829f9b413b9
2023-11-27 11:54:22 -08:00
fbaron c04ad685f5 Fix activity leak in QuickstepLauncher
Fix: 312397873
Test: TaplAppIconMenuTest#testLaunchMenuItem
Flag: NONE
Change-Id: I63fe5fa5b3f2d301017dc6fb375e7a56e3e5fb4d
2023-11-27 18:10:45 +00:00
helencheuk f2fc14ec4c Remove excess entry before putting new item
It is to fix gpu memory usage increase. Remove excess entry first so its max memory usage should not increase

Fix: 309182285
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: N/A
Change-Id: I40b4ec50c09001e6ee9d012bdcdd1444230daac3
2023-11-27 14:57:38 +00:00
Helen Cheuk 946a2493eb Merge "Not show hover border on select mode" into main 2023-11-27 14:21:29 +00:00
Pat Manning 0f395e8a11 Update text style for icon app chip menu.
Bug: 311657856
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ied1c5fddb94e3093729846cacfef9b257aad8df7
2023-11-25 11:24:45 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Johannes Gallmann e36c615716 Fix crash in LauncherBackAnimationController
Bug: 312949302
Flag: NONE
Test: Manual, i.e. testing quick fling back to home gesture
Change-Id: I670b2f02cab097b1d7a202a5b07fbda33d372ac8
2023-11-24 10:11:46 +01:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00