Commit Graph

16441 Commits

Author SHA1 Message Date
Liran Binyamin ac57606836 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev am: 7dd280eef3 am: d93bb84d9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024252

Change-Id: I9c50ad4479cbdf30051d24df1a71b2548591156b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 18:11:46 +00:00
Liran Binyamin d5c230d73f Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev am: 2c1e84b3a1 am: f8fcd3c9a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24012984

Change-Id: Ieb26246065d8e70d420fdbc8af9f0bea3b439f5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 18:05:45 +00:00
Mady Mellor e80734c540 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev am: db3cdd4e97 am: 1bbcc8a90d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010039

Change-Id: I77ad66e8ce94ff21b4a96f47486d70795d562c83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 16:44:29 +00:00
Mady Mellor 3aa7647db4 Handle any image / label changes for bubble updates in bubble bar am: 1812924a53 am: 36eb8b089d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010038

Change-Id: Ib9b4850d158996e5e693738913669451edadf7d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 16:44:25 +00:00
Liran Binyamin d93bb84d9d Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev am: 7dd280eef3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024252

Change-Id: I7c6a545a1fc71ccbb74d97f702a6a9bc04852ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 15:34:12 +00:00
Liran Binyamin 7dd280eef3 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev 2023-07-12 15:09:21 +00:00
Liran Binyamin f8fcd3c9a6 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev am: 2c1e84b3a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24012984

Change-Id: Id2ca1b1de161e71bea2978e3231f4f1bba2cc22a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 14:55:22 +00:00
Liran Binyamin 2c1e84b3a1 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev 2023-07-12 14:41:32 +00:00
Mady Mellor 1bbcc8a90d Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev am: db3cdd4e97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010039

Change-Id: Ic0e5a9ce061e1bc892a021c09153572e0c7b164d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 01:17:28 +00:00
Mady Mellor 36eb8b089d Handle any image / label changes for bubble updates in bubble bar am: 1812924a53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010038

Change-Id: Ib7d204f2bd06f8474613b134d25e9ff08e32c74d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 01:17:25 +00:00
Mady Mellor db3cdd4e97 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev
* changes:
  Show / hide the "update" dot on bubbles in bubble bar
  Handle any image / label changes for bubble updates in bubble bar
2023-07-12 01:00:10 +00:00
Vinit Nayak 0eca85db74 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev am: 64f3766ba7 am: d9fd3f2e58
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23986000

Change-Id: I0d8de9043cedd0468f0642a211d2d841be187346
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 00:07:34 +00:00
Vinit Nayak d9fd3f2e58 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev am: 64f3766ba7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23986000

Change-Id: I6728ffc217017fad591b0ada439b4587197d6352
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 23:28:35 +00:00
Vinit Nayak 64f3766ba7 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev 2023-07-11 23:06:47 +00:00
Mady Mellor c299ad645a Show / hide the "update" dot on bubbles in bubble bar
Updates BubbleView to include logic to render the update dot on a
bubble. This only shows for BubbleBarBubbles, not the overflow.

We only show the dot (and the badge) when:
- the bubble has new content / appropriate flags set
- AND the bubbles are expanded
  OR on the first bubble when bubbles are collapsed
- AND when the flyout is not animating (this bit doesn't exist yet)

If a bubble has a dot and is opened, the dot will animate away.
To do this, we update the flags set on a bubble.

The flag needs to be set on WMShell side as well as Launcher side.
When a bubble is shown by WMShell, it automatically updates the flag.
This CL adds code to update the flag on Launcher side when we call
into WMShell to show the bubble.

Test: manual
Bug: 269670235
Change-Id: I32f652effa9a73c567981aa5a2a5864e9c3c0c66
2023-07-11 15:09:29 -07:00
Liran Binyamin 05ef774e6e Don't show the bubble bar when it is empty
Sometimes the bubble bar shows when the launcher process starts up
even when there are no bubbles.

bubblesShowingOnHome is set to true when the launcher transitions into
Home, but that state also triggers a call to showBubbleBar() which will
eventually set the visibility on the bar.
During initialization we also call setHiddenForNoBubbles to hide the bubble
bar if it's empty, but these events happen separately so the bar may or
may not be hidden.

This change avoids calling showBubbleBar when setBubblesShowingOnHome is
called and the bar is invisible. Instead the bubble bar will become visible
once bubbles are added.

Fixes: 290608658
Test: manual
       - Toggle bubbles off and back on in settings
       - Restart launcher
       - Observe the bubble bar is not displayed
Change-Id: I30640764d7b6eae64e1c5b5c687760465bf9a7b1
2023-07-11 17:12:00 -04:00
Mady Mellor d4394e5bd5 Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev am: 3e952e034c am: ecf080eb5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010037

Change-Id: Ib2637a8fbf6303f9ce423e218048b98965190ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 21:09:16 +00:00
Liran Binyamin 1c03ed001d Pass bubble bar offsets instead of position to WMShell
This allows WMShell to calculate the position of the expanded view
correctly when the bubble bar is being expanded from stashed.

Test: See ag/24012908
Change-Id: I7b917e761c827135942d918917c920b06650f496
2023-07-11 17:08:09 -04:00
Brian Isganitis 32c8f4179f Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev am: 1a50287c08 am: 8d3ea8eeb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024243

Change-Id: Ia7a8640c6f14742160959d40547c89ed8b6369cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 21:07:22 +00:00
Mady Mellor 1812924a53 Handle any image / label changes for bubble updates in bubble bar
When we get an update to a bubble it could mean that there's a new
message OR that something about the visual representation changed.

This CL modifies BubbleBarController to handle any visual changes
that might have occurred to an updated bubble (e.g. bubble image
changed).

It does this by updating the bubbleInfo on the existing bubble.

Test: manual
Bug: 269670235
Change-Id: I03d2510aef335dafccb32d6adcd4c6adf8b3297d
2023-07-11 13:34:46 -07:00
Mady Mellor ecf080eb5c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev am: 3e952e034c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010037

Change-Id: Id9470422fa6e14e59432ef859cde823b3f588aa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 20:28:39 +00:00
Brian Isganitis 8d3ea8eeb5 Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev am: 1a50287c08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024243

Change-Id: I3a0e4e72548414078c673742ff1d3768cffc94ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 20:28:15 +00:00
Mady Mellor 3e952e034c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev 2023-07-11 20:24:14 +00:00
Brian Isganitis f54c6fa4b4 Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""
This reverts commit 853a5b9e0c.

Fixes SecondaryDisplayLauncher class by using lambda instead of method
reference for #getAllAppsItemLongClickListener. This change is necessary
because mDragLayer is late-init.

Test: Home Settings > Developer Options > Launch Secondary Display
Bug: 289261756
Flag: No
Change-Id: I7b83f81651dde360edea6ee7bea6cc82441e6bef
2023-07-11 13:21:47 -04:00
David Saff 69e4f72c4b Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev am: aaf3094540 am: 20d1f741b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24017969

Change-Id: Icf176421f6f3ec05924ac3514c19499ab9c74c9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 13:48:39 +00:00
David Saff 20d1f741b9 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev am: aaf3094540
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24017969

Change-Id: I1048ccfe13a8b888d5c3dd6384cb801623e1c7e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 13:12:21 +00:00
David Saff aaf3094540 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev 2023-07-11 12:32:36 +00:00
David Saff 853a5b9e0c Revert "Provide AllApps item OnLongClickListener through ActivityContext."
This reverts commit 0acab2532d.

Reason for revert: b/290403189

Change-Id: Ie3f67f78a8ffce8c2d5a92f65a7e74d788c82a81
2023-07-11 10:45:33 +00:00
Mady Mellor 4e0ec1e458 Unify calls to sysuiProxy#showBubble into one method
This will make it easier to note that a bubble has been "visited"
so that we can hide the update dot (coming in future CL).

Test: manual
Bug: 269670235
Change-Id: Ie2dbbc478198ece65c05927295d3c3031a7be82e
2023-07-10 13:38:15 -07:00
Vinit Nayak f6c2e87747 Dismiss split select when tapping on home button
Bug: 276361926
Test: Initate split, dismiss whenever home is pressed,
doesn't dismiss when all apps dragged down
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Idc95123e27963c3913d04c6eb27f0e4c9b1eb401
2023-07-10 11:06:42 -07:00
Tracy Zhou 13ca2d1263 Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev am: 10b5a3903a am: 35fd1517bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23996760

Change-Id: Ia14fe62163dc5021c0449df591d21d3d2a91242e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 18:06:19 +00:00
Tracy Zhou 35fd1517bc Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev am: 10b5a3903a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23996760

Change-Id: Iceb6e903bd2c83a87b8ebe5289ed4fbfcb324fc6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 17:48:09 +00:00
Tracy Zhou 10b5a3903a Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev 2023-07-10 17:31:55 +00:00
Liran Binyamin a38a5c193e Merge "Pass the bubble bar screen coordinates to WMShell" into udc-qpr-dev am: 57d68b4834 am: 6964b6633b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23984264

Change-Id: I01904e826cf28953a7b431d73bf9226891899fa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 16:51:50 +00:00
Liran Binyamin 6964b6633b Merge "Pass the bubble bar screen coordinates to WMShell" into udc-qpr-dev am: 57d68b4834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23984264

Change-Id: I34a294754edc7c9b8c90a7efb1193b6f29117146
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 16:23:53 +00:00
Liran Binyamin 57d68b4834 Merge "Pass the bubble bar screen coordinates to WMShell" into udc-qpr-dev 2023-07-10 15:44:35 +00:00
Tracy Zhou da6a625f46 Fix icon not showing in staged split from keyboard shortcut
Bug: 246661484
Test: https://screenshot.googleplex.com/8X6ggCoYPD8rzSp
Change-Id: I0fa592b1a027769fd09a6de803ea44f5ae915f43
2023-07-08 13:59:12 -07:00
Bill Yi 0e7e197e96 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-07-08 17:48:48 +00:00
Bill Yi 4a8967ee5d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-07-08 17:47:14 +00:00
Brian Isganitis f49b1b1664 Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev am: ea206bbad5 am: 0ea37669bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836392

Change-Id: Ib263ebca69bcab7e6940d5a5ed486b150ba6639e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 21:09:30 +00:00
Winson Chung cb98339501 Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd am: a8e08175ad am: 55eedd4e5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: If404ec948a6fff8ac68098054bfe0fe0a3ebd763
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:28:58 +00:00
Winson Chung 1913610652 Ignore recents transition if there are no closing tasks am: 6f7e15ff64 am: b06c5f7a2b am: 216d00531d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: I0e42233fa908a30c2d25e8811578ecc6866c81a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:28:00 +00:00
Brian Isganitis 0ea37669bd Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev am: ea206bbad5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836392

Change-Id: I4ccee814359e38aae2b552bec4cfbe21b988327a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:27:19 +00:00
Winson Chung 51c94c622e Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd am: 273703131a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Id2e78875d607f8deb1511a235d761f662eafbdd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:01:47 +00:00
Winson Chung 55eedd4e5c Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd am: a8e08175ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Id330daa9c44cad3ef1733ba2319a8b69260ef99b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:01:36 +00:00
Winson Chung c0cb49ddfe Ignore recents transition if there are no closing tasks am: 6f7e15ff64 am: bf087d6065
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: Ie570a261b0e9128480403520a7d27a9a75ccd0fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:01:36 +00:00
Winson Chung 216d00531d Ignore recents transition if there are no closing tasks am: 6f7e15ff64 am: b06c5f7a2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: I69a9a85e57bc1282179f979b073e0e3dab8d59c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:01:25 +00:00
Brian Isganitis ea206bbad5 Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev 2023-07-07 19:43:01 +00:00
Winson Chung 273703131a Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: I74c4feb37cc95819bbf3e6792a73a19c30882570
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:19:44 +00:00
Winson Chung bf087d6065 Ignore recents transition if there are no closing tasks am: 6f7e15ff64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: I6308efc06ae3f5283f48b64c504e2638b6482435
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:19:32 +00:00