Commit Graph

10274 Commits

Author SHA1 Message Date
TreeHugger Robot 45c58fd466 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede am: 6d7db81e74 am: 5ed4ac94b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I551675593fb9d55358f18d2fd9bc32a42be81b6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 18:01:41 +00:00
TreeHugger Robot 5ed4ac94b9 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede am: 6d7db81e74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I9fa56bb4e2060b00919c1014ecae2a5472f578d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 17:35:10 +00:00
TreeHugger Robot 6d7db81e74 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I03703262518cf2fd060bf4d3b0a89337e9a92b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 16:43:22 +00:00
Alex Chau 302d750758 Merge "Update overview actions alignment" into tm-dev am: a80efcee9f am: c7fee694e7 am: 9f1635718c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: Ic93b6737cd0843629f81d4cf33bdfd6504f7329a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 13:41:28 +00:00
Alex Chau 9f1635718c Merge "Update overview actions alignment" into tm-dev am: a80efcee9f am: c7fee694e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: I128b4f0f8e8990fed7df5957485089271e298807
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 13:20:27 +00:00
Alex Chau 2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
Alex Chau c7fee694e7 Merge "Update overview actions alignment" into tm-dev am: a80efcee9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: Ie7496af60cde34345324140511a7b2f7b255f10f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 12:47:17 +00:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Jerry Chang b9354f676e Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: 448ae578f9 am: 1833317d5d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: Ie08dae193987636b0095cb197893e09b845eedd8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 04:35:49 +00:00
Jerry Chang 1833317d5d Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: 448ae578f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: Ia8b5e52d278d8ac280d5827dba3c64dcdbe93220
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 04:12:22 +00:00
Jerry Chang 448ae578f9 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I523efffd571c815efe94836f3560d3b1c60788b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 03:50:22 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Tracy Zhou b2151475b6 Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e am: 9660c41b4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3b09f7af5b4be06dfa305d0585b9a5d73d377f85
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 19:33:02 +00:00
Tracy Zhou 9660c41b4c Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3db055b4066d721eccc9ca6cdc70d25aec0b3574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:25:22 +00:00
Tracy Zhou 7148e74f1e Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: Ic6378b71451cafcf02ece812c93a240123cd2c03
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 17:53:25 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
TreeHugger Robot e58c73ffea Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286 am: 16a13ec3e6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I78b6b7d97fab1810140b2bc09f585566feb47c2a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:32:31 +00:00
TreeHugger Robot 16a13ec3e6 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I10c86da47d157bb99d3422719f2f9c8acf8fc568
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:39 +00:00
TreeHugger Robot 14615df286 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I86545cb56dac22db803cacfdc893f82efcecefd5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 15:36:46 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
TreeHugger Robot f07608957b Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48 am: 4ebc61e76a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: Ied4008303bbd0e5f726cb6dd49cfe58159af933c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 04:17:49 +00:00
TreeHugger Robot 4ebc61e76a Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I5a02a4c0d0d22655559100c95998ceec0f7a752b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:56:23 +00:00
TreeHugger Robot 9c3bd94b48 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I3083e1b4d5e9556b0152b8229658575e403ca76a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:24:58 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham bb6926f8c6 Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f am: 96c5c67dca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Ia3625ff9b17b348790926c217d48f48782ab2a6a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 02:00:52 +00:00
Tony Wickham 96c5c67dca Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I0471cb6feb14e517dea2ca0a07445335ecee45a5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:47:33 +00:00
Tony Wickham cc10db044f Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Id798f042e7cc39d76fb3e4ce8c7ffbf2a54184fd
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:18:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00
Tony Wickham b64eecba3a Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: 9de10ff889 am: b0b89c7f00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I7c922df6ae38c31ec507591420c2115884d3745c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 00:14:54 +00:00
Tony Wickham b0b89c7f00 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: 9de10ff889
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I56e8a873e333b1470eddddb73157ace4eb531bb7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:43:01 +00:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial.
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
2022-04-22 16:37:49 -07:00
Tony Wickham 9de10ff889 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I6c01f58f282234ce2e85a582a25a442ba7c7d9d2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:19:24 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere d17d701859 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: 78194ca6ad am: eef266fe39
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: Ie4fefefa49c0ff23c0e09933c0db403eedba06de
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:43:48 +00:00
Sunny Goyal 01d3f8ef47 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: d99aee90ef am: 8fbfd8ecf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I165aa0431d79c61668f2fd4f194e57ba862095b7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:43:37 +00:00
Santiago Etchebehere eef266fe39 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: 78194ca6ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I2d68fd2a3348c2ca7bede5a189e93c14b34b8826
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:20:47 +00:00
Sunny Goyal 8fbfd8ecf8 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: d99aee90ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I7ca9e432376e4533a1643187c51ab3545f25c465
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:20:32 +00:00
Santiago Etchebehere 78194ca6ad Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I7e56d7a2f10052f9cb0a3ef6e83e33aa4024f493
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:11:04 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal d99aee90ef Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Id8a4e2f0a5b45267b8386f22b15639f232e93460
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:03:22 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
2022-04-22 21:02:22 +00:00
Jeremy Sim ef914fe5b1 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: cca5e510fd am: fb8907517c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: Ib3686882f4d2e43bdf7100d162506410d154b67b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:44:54 +00:00
TreeHugger Robot a36b69f84c Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: e17589f4b8 am: f06f6e7f1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I63d97dc762d22f52868d4aefd88d095f2e94925d
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:44:22 +00:00
Tony Wickham da6d914e7c Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 44e65099c2 am: cf6b7e2dd9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I7470fbc1ad42ae90aa6e426914c3640834d33cc2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:43:56 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim fb8907517c Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: cca5e510fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: Ie12e347f3d58730d4a0ae5ed9c4c92fbfcace800
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:21:14 +00:00
TreeHugger Robot f06f6e7f1d Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: e17589f4b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: Ib73e94fdb7f113ba0838b857817648520d91bb02
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:20:50 +00:00
Tony Wickham cf6b7e2dd9 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 44e65099c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: If17f49f0227f14bdbbd72a8c7480b7a27eacc73a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:20:01 +00:00