Commit Graph

7378 Commits

Author SHA1 Message Date
Johannes Gallmann 72313feac1 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev am: 83683829f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21750179

Change-Id: Iebc90a935e9bbdd865f2fd03b531e5f5bcfefa66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 19:54:47 +00:00
Johannes Gallmann 83683829f7 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev 2023-03-06 18:55:49 +00:00
Hyunyoung Song a10811b4fe Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev am: eeee84efb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21447384

Change-Id: I97443edd17e2c0d4982a9a63bdd61c78c1b9e4e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 18:39:09 +00:00
Hyunyoung Song eeee84efb6 Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev 2023-03-06 18:23:32 +00:00
Hongwei Wang 5f57433ebc Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev am: 1897e4f40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21613694

Change-Id: I03d3746ad0795a87307676fe2ee2d7c18454bcc7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 17:50:09 +00:00
Hongwei Wang 1897e4f40f Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev 2023-03-06 17:13:56 +00:00
TreeHugger Robot 3dda7ab75f Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev am: a176ad060f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778039

Change-Id: I1d7772bfe999a4b9967b1656b99023c94eecdb17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:22 +00:00
Jeremy Sim 2a81b79a3c Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev am: ad9bdcfd2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21221178

Change-Id: I14e25affb3d204cd2fcf0f693fd53ce502e576f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:09 +00:00
Sunny Goyal 5a4ff1a073 Merge "Simplifying code around multiple translation components" into tm-qpr-dev am: 33c3e77411
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593003

Change-Id: Id4e43cb78aa1aaeca74c0c3ee449e9bda91924aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:44:31 +00:00
TreeHugger Robot f5153d5de2 Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev am: 3dd1440520
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592805

Change-Id: Ic8972961193226ab1cb1a0a31bd6ff9e12f980c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:40:43 +00:00
Brian Isganitis 0c15dabc48 Merge changes from topic "running-in-test-camel" into tm-qpr-dev am: d2d2913812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725479

Change-Id: Iad48010b9309567049338220a2300cf85f7567c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:39 +00:00
Brian Isganitis 3450bbf901 Make isTooltipEnabled a getter due to its mutable dependencies. am: aa08af872b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21652556

Change-Id: I85a188279b8461af0ac98763e9711252669b08e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:33 +00:00
Vinit Nayak f24a4d5208 Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev am: f51426a6ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21701337

Change-Id: I6f299319cac89a12e66c054d9baa39e1107c7651
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:02 +00:00
Brian Isganitis f5dc57a910 Merge "Treat setup wizard default home as null." into tm-qpr-dev am: 5248b02080
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21690746

Change-Id: I51f0ca59c02cba6b44c38971be924dd9b0bb28f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:33:34 +00:00
TreeHugger Robot a176ad060f Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev 2023-03-04 01:46:17 +00:00
Jeremy Sim ad9bdcfd2d Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev 2023-03-04 01:10:47 +00:00
Sunny Goyal 33c3e77411 Merge "Simplifying code around multiple translation components" into tm-qpr-dev 2023-03-04 00:59:54 +00:00
TreeHugger Robot 3dd1440520 Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev 2023-03-04 00:18:16 +00:00
Brian Isganitis d2d2913812 Merge changes from topic "running-in-test-camel" into tm-qpr-dev
* changes:
  Expose IS_RUNNING_IN_TEST_HARNESS as static method.
  Make isTooltipEnabled a getter due to its mutable dependencies.
2023-03-03 23:15:38 +00:00
Jon Miranda 8f2b50fdeb Sync overview scroll so that it ends before/at same time as taskbar animation
Fixes: 267355260
Test: open overview, scroll to 'Clear all button', tap on blank space
Change-Id: Ia58683f7b167ff42443dda3d39368bf6aaa366e0
2023-03-03 13:34:55 -08:00
Vinit Nayak f51426a6ee Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev 2023-03-03 21:33:52 +00:00
Brian Isganitis 5248b02080 Merge "Treat setup wizard default home as null." into tm-qpr-dev 2023-03-03 21:11:18 +00:00
Vinit Nayak fc155dd5b0 Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev am: 750009face
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21460191

Change-Id: I5ee197302979a7ee12198d783a6ab703fe9acde1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:43:10 +00:00
Ats Jenk 7e7f2ff07e Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev am: 37d6a2be10
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21656508

Change-Id: I40adcf60f0628e8cf4e0c0d1198da7ad7ce975fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:41:48 +00:00
Schneider Victor-tulias 424d95ed87 Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev am: 860b30e7ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527494

Change-Id: I49eefbde68bdd93aac103bdc5f6d2094036bf391
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:39:11 +00:00
Vinit Nayak 750009face Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev 2023-03-03 19:37:04 +00:00
Ats Jenk 37d6a2be10 Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev 2023-03-03 19:32:13 +00:00
Schneider Victor-tulias 860b30e7ac Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev 2023-03-03 18:14:44 +00:00
Nick Chameyev fcf5d393eb Merge "Do not use private APIs in unfold module" into tm-qpr-dev am: c7ab991818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21523105

Change-Id: Ida34210a83f096beb2c2bb9346dbe864ac09d2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 17:26:01 +00:00
Johannes Gallmann f54b88d2d6 Add onEndCallback to ContainerAnimationRunner
Bug: 247121782
Test: Manual, i.e. tested that callback is invoked after launch animation
Change-Id: Ie52ffa1b76de01943dd16346560768b3ecced118
2023-03-03 16:55:07 +01:00
Nick Chameyev c7ab991818 Merge "Do not use private APIs in unfold module" into tm-qpr-dev 2023-03-03 13:22:03 +00:00
Vinit Nayak 26c893603f Add null check for recents when tapping on Taskbar icons
Fixes: 270669636
Test: Couldn't repro, but visually we have checks for
recentsView != null && OTHER_CONDITION, but in the else
case we don't check if recentsView being null is the reason
the if-block didn't get triggered

Change-Id: I72e7480bac56c7e7b7edb73edac4309e9923d302
2023-03-02 18:18:11 -08:00
Ats Jenk e086649965 Merge "Support large desktop tile in grid only overview" into tm-qpr-dev am: 8e20d62034
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21611657

Change-Id: I79ec0ad431543b9bbc86fc1c1b159a6925c969c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 01:27:42 +00:00
Jeremy Sim 03815e6c79 Create TAPL test suite for splitscreen
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.

testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.

Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Brian Isganitis fdd044e16e Expose IS_RUNNING_IN_TEST_HARNESS as static method.
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.

Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions

Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
2023-03-03 00:17:33 +00:00
Ats Jenk 55cb5fca91 Hide desktop tile when choosing apps for split
Bug: 269660657
Test: open overview, click on split screen action, observe desktop tile
  is hidden
Test: on home screen, long press on app icon and choose split screen,
  observe overview opens with desktop tile hidden

Change-Id: I60c06a8e2ef8fc13e741f8845254d22e9e430bb6
2023-03-02 15:14:34 -08:00
Schneider Victor-tulias 3146c5f6b4 Translate the TutorialStepIndicator to prevent overlapping skip and done buttons
On large fonts and display sizes, the TutorialStepIndicator can overlap the skip and/or done buttons. Adding some additional translation to account for this.

Fixes: 269588989
Test: tried the tutorial on the largest and default font and display sizes on a phone
Change-Id: I45a276bba3e9cb10336c6f3aa363b7a5c7a73543
2023-03-02 15:13:21 -08:00
Ats Jenk 8e20d62034 Merge "Support large desktop tile in grid only overview" into tm-qpr-dev 2023-03-02 22:45:38 +00:00
Sunny Goyal 82dfc15037 Simplifying code around multiple translation components
Bug: 270759683
Test: Verified on device
Change-Id: I6c758c715828ae25e0e3c60b793cf85d70cb2487
2023-03-02 12:22:03 -08:00
Luca Zuccarini f295e3a85a Hide the splash icon when launching with no view and no item.
This is achieved by instead creating an empty item info that only
specifies the splash type to be solid color.

Bug: 269343536
Test: manual
Change-Id: Ibf5c8f1c949e26af207b8c6e382f71677b9acc2d
2023-03-02 18:19:38 +00:00
Pat Manning 322c54f1b1 Merge "Add modal action for grid only overview." into tm-qpr-dev am: c6c33dd115
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21674620

Change-Id: I9a15d97ba4d64ea4d30ee299dca3b3c7a563c823
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 17:24:23 +00:00
Pat Manning c6c33dd115 Merge "Add modal action for grid only overview." into tm-qpr-dev 2023-03-02 17:06:51 +00:00
TreeHugger Robot 28e92a0831 Merge "Prevent QSB from being a part of the icon reveal animation." into tm-qpr-dev am: 7f8f573f46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21689401

Change-Id: I89da04d7bbebef7aa33085de85e6acbfe6427b3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 17:06:20 +00:00
Sunny Goyal 5d41fbc53a Merge "Restarting launcher if a flag changes" into tm-qpr-dev am: f4bead71ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118642

Change-Id: If745a819e7d647cc969b42b16cbcf40e9a108b31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 17:06:07 +00:00
Ats Jenk 45e0a90013 Support large desktop tile in grid only overview
Based on UX specs, desktop tile should be using the large size and be
pinned ot the right in overview.
Updates to ensure the desktop tile is using the focused tile size when
grid only overview is enabled.

Test: enable grid only overview, have some fullscreen tasks in overview
  and some desktop tasks, open overview from home, observe desktop tile
  peeks from right
Test: same setup as before, open a fullscreen app, open overview,
  observe desktop tile peeks in from right
Test: same setup as before, go to desktop, open overview, observe
  desktop tile is focused
Test: turn off grid only overview, repeat the same test case

Bug: 271131878

Change-Id: Ic804428dca415f08a26c47e1d6b9b3a94fcfbfdf
2023-03-02 09:04:37 -08:00
TreeHugger Robot 7f8f573f46 Merge "Prevent QSB from being a part of the icon reveal animation." into tm-qpr-dev 2023-03-02 16:29:05 +00:00
Sunny Goyal f4bead71ea Merge "Restarting launcher if a flag changes" into tm-qpr-dev 2023-03-02 16:23:45 +00:00
Treehugger Robot 2b22bb33ff Merge "Fix NPE in FallbackSwipeHandler when getRunningTask() returns null" am: 78e1964a05 am: d693b1406a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2361489

Change-Id: Iff1c7f7e931932e3da697b8057cbc57fc8c78aff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 12:51:22 +00:00
Treehugger Robot d693b1406a Merge "Fix NPE in FallbackSwipeHandler when getRunningTask() returns null" am: 78e1964a05
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2361489

Change-Id: Ifc0ab83af62d3672da6221635b75a333de2b9965
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 12:17:49 +00:00
Pat Manning b4f3807df2 Add modal action for grid only overview.
This is an issue for tablets on landscape.

Fix: 271314156
Test: manual.
Change-Id: I5c3c1a9ff4b193439bdcc72f17b20bc8da4d16f5
2023-03-02 10:43:55 +00:00