Commit Graph

19528 Commits

Author SHA1 Message Date
Ana Salazar Maldonado 71c38ab75c Add Widget Resize Frame actions
Demos:
http://screencast/cast/NTE1NDE3NzM0MzgxNTY4MHwxYzQ2MDVlOC1mOQ
http://screencast/cast/NTcwNTM3ODE5MTkwMDY3Mnw5MDBiNzAzMS03MA

Bug: 374248904
Test: manual - activate talkback, add new widget
Flag: EXEMPT bug fix
Change-Id: I80ab0da75ec054709a28f41d9ceabce9e94866d9
2025-03-11 12:39:12 -07:00
Treehugger Robot b43cae24a4 Merge "Fix home screen page description when removing an existing page." into main 2025-02-28 21:26:35 -08:00
Mykola Podolian b0fe82378a Merge changes from topic "bubblebar_drop_target" into main
* changes:
  Removed fly-back animation after a taskbar item drop on the bubble bar
  Added BubbleBarLocation drop target.
2025-02-28 18:02:48 -08:00
Treehugger Robot 55dd78123c Merge "Taskbar on home should open all apps that support drag to workspace" into main 2025-02-28 17:04:20 -08:00
Treehugger Robot dad3394772 Merge "Fix LauncherPrefs crash by allowing sub-types of Set" into main 2025-02-28 16:49:02 -08:00
Brian Isganitis fbe72436c8 Merge "Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE." into main 2025-02-28 14:58:30 -08:00
Charlie Anderson 4e4ad89696 Fix LauncherPrefs crash by allowing sub-types of Set
Bug: 396616795
Test: LauncherPrefsTest
Flag: EXEMPT bugfix
Change-Id: Id380a6e4bb5eb809978070ff1b523c9e98e6b869
2025-02-28 21:57:43 +00:00
Toni Barzic 26ad16592a Taskbar on home should open all apps that support drag to workspace
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
      drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
2025-02-28 21:31:46 +00:00
Treehugger Robot d300486e66 Merge "Adding option to skip animations for testing" into main 2025-02-28 13:10:53 -08:00
Brian Isganitis 8bab8eb171 Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE.
The invisible proxy view was preventing anything below it from being
accessible.

Flag: EXEMPT bugfix
Fix: 377526512
Test: #14 in bug.
Change-Id: I9d4596ebbbc4317a9ff7ded37b43b5fa1885e6ea
2025-02-27 19:41:48 -05:00
Treehugger Robot 1e8125c76b Merge "Merging some notification dots implementation" into main 2025-02-27 16:08:10 -08:00
Treehugger Robot 029b6016d2 Merge "Fixing widgets broken during reconfiguration" into main 2025-02-27 15:59:30 -08:00
Jagrut Desai 2ac4d9c794 Merge "Update Taskbar Icon content description to include state description" into main 2025-02-27 15:47:09 -08:00
mpodolian c666b9587b Added BubbleBarLocation drop target.
A drop target for the BubbleBarLocation has been added. This
implementation enables the Launcher process to handle application
drag-and-drop actions onto the bubble bar.

Known issues:
1) Upon dropping, the dragged icon animates back to its original taskbar
position from the top-left corner.
2) The expanded view drop target is not presented.
3) When an icon is dropped on the opposite side of the bubble bar, the
resulting location does not change, even though the drop target is
correctly displayed.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Navigate to the overview screen, drag a taskbar icon to
the left or right side, targeting the bubble bar drop zone. Verify the
drop target's appearance. Then, drop the icon and observe that a new
application bubble is added.

Change-Id: I0f64a664620959f2503ac3fd711476b354a09348
2025-02-27 14:32:32 -08:00
Treehugger Robot 8459313c57 Merge "Converting LauncherBindableItemsContainer to kotlin" into main 2025-02-27 14:07:03 -08:00
Treehugger Robot a708bee45b Merge "Fix jumpcuts in folder background color when opening/closing" into main 2025-02-27 14:01:50 -08:00
Alex Chau ee1bae7d72 Merge "Multi property refactor" into main 2025-02-27 13:41:07 -08:00
Treehugger Robot 9a5cd11da5 Merge "Move MainThreadInitializedObject to Launcher3 Go." into main 2025-02-27 13:03:12 -08:00
Sunny Goyal fc2735ed96 Fixing widgets broken during reconfiguration
Async widget inflation may complete after the updates have been deferred,
leading the widget to a broken state.
Reapply widget if its root content changed while deferred

Bug: 375442765
Bug: 327696338
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I78d0f4ce92ee9bd2ee001de3a0e181f2e727218c
2025-02-27 12:36:15 -08:00
Shamali P 94e276c1c5 Fix home screen page description when removing an existing page.
When we remove an in-between or last empty page, we manually set the
current page but don't update the description that's set on the
accessibility view. Due to which, when talkback focuses on it, it sees
the stale page count in the description.

This fix ensures to keep the state updated during removal.

Bug: 390360063
Fix: 390360063
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: Idd9a54d3a1ee43e56f51db78e614776eca6a12f7
2025-02-27 12:16:23 -08:00
Charlie Anderson 4ac496c510 Merge "Make Folder preview items appear as square grid instead of circle" into main 2025-02-27 11:49:43 -08:00
Sihua Ma 4160ad3967 Fix jumpcuts in folder background color when opening/closing
Background drawable is not associated with any folder view, and as a
result invalidating the drawable doesn't cause it to be redrawn on the
screen

Fix: 392617057
Bug: 399674389
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I6d2bd97f66b53cdbeb4a715e53ff89b3450546f0
2025-02-27 18:48:51 +00:00
Sunny Goyal d237c9587b Converting LauncherBindableItemsContainer to kotlin
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I4d2fa18b6b275742d84de16ed604987c2deee6e8
2025-02-27 10:34:37 -08:00
Jagrut Desai 536097dec2 Update Taskbar Icon content description to include state description
This cl inlcudes: while user is in desktop mode, we will add state description(active, minimized) of each app icon to it's content description.

Test: Manual
Bug: 397555157
Flag: EXEMPT bugfix
Change-Id: Iaec18e7099108e8b076b76c637a41e29ed837265
2025-02-27 09:58:31 -08:00
Charlie Anderson 39f902cd84 Make Folder preview items appear as square grid instead of circle
- Eventually we should remove circular geometry from ClippedFolderIconLayoutRule altogether

Bug: 392610664
Test: changing shapes with different size folders
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I15c854c19186a3e4262e8d2b40960f3519ec2729
2025-02-27 09:09:10 -08:00
Sunny Goyal 39063bf167 Merging some notification dots implementation
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie02311afba85f06fbafd265a5015cd23bd356a36
2025-02-27 08:50:26 -08:00
Sunny Goyal d8e5ddb4cd Removing unnecessary isBindingItems method from ActivityContext
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I06fd1dcc81da5e5502a9fb0751c2701b26fd4621
2025-02-27 08:49:33 -08:00
Alex Chau 3c3d636dc9 Multi property refactor
- Introduced MultiPropertyDelegate to delegate Kotlin var to MultipPropertyFactory, allowing easy creation of var for MultiPropertyFactory
- Introduced KFloatProperty to map any Kotlin var to a FloatProperty, which simplify the code to creaet FloatProperty a lot
- Combined the above to refactor usage of MultipPropertyFactory, use var to simplfiy things, and expose them as FloatProperty directly when needed

Fix: 399635468
Test: Smoke test main flow of enter Overview, task launching etc.
Test: presubmit
Flag: EXEMPT REFACTOR
Change-Id: Ie7dd8b69da7e3bda9026a0ef7b0377c26a78a332
2025-02-27 16:01:32 +00:00
Anushree Ganjam e6065f5a94 Move MainThreadInitializedObject to Launcher3 Go.
Move SandboxContext to a separate class.
Remove all MainThreadInitializedObject references in Launcher3 and tests.
Remove ObjectSandbox interface and make RoboApplication extend
SandboxContext

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I1a8af5e6ae59df44d8ad6732b4d6e949ac402d6c
2025-02-26 16:49:08 -08:00
Treehugger Robot a2af6e4daa Merge "Removing unnecessary ActivityContextDelegate" into main 2025-02-26 13:04:00 -08:00
Sunny Goyal e9355c622d Removing unnecessary ActivityContextDelegate
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ib95b26de000a2fe8204fdbc46c8a9da4f65c7eab
2025-02-26 10:52:10 -08:00
Treehugger Robot d668dd6e30 Merge "Visual updates for PageDotIndicators" into main 2025-02-25 22:33:46 -08:00
Stefan Andonian ae8ab4c403 Visual updates for PageDotIndicators
TODOs have been added for verifying and updating the Outline, right to left mode,
and the entry animation. This CL is complex, and those have been left out on purpose.

Bug: 394355070
Test: Verified this behavior looks good in LTR on the workspace.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I8f0192f461d344360572411e1a62921fd65ba600
2025-02-25 20:26:00 -08:00
Charlie Anderson dfb45d9c03 Simplify ShapesProvider and use constants
Bug: 398689048
Bug: 372884380
Test: presubmit and locally
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: I102265ef4b25d84bb7a0b1f9642a9c19a7200e22
2025-02-25 20:17:54 -08:00
Sunny Goyal 998cf2cb7e Adding option to skip animations for testing
Bug: 398894260
Flag: EXEMPT test
Test: atest GridPreviewTest
Change-Id: I9c3a7f6d8dfd63eac46038cc5d769def0392c194
2025-02-25 19:22:12 +00:00
Will Osborn 8bc3268ec4 Merge "DisplayController refactoring for multiple displays" into main 2025-02-25 08:16:52 -08:00
Alex Chau 45c1192fdf Merge "Handle AddDesktopButton's visibility in different launcher states" into main 2025-02-25 03:39:39 -08:00
Will Osborn c47d03f1f9 DisplayController refactoring for multiple displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: I18c196c977b3731aa09d2cc93ab6341b8f1636c6
2025-02-25 11:29:02 +00:00
Sukesh Ram 3242782931 Merge "[CD Taskbar] Remove legacy all apps button (secondary display)" into main 2025-02-24 23:38:34 -08:00
Treehugger Robot 1799b85186 Merge "Fix grid previewing so it matches the applied layout" into main 2025-02-24 17:00:15 -08:00
Jagrut Desai 269fb15e97 Merge "Desktop Mode Taskbar Recreate Animation" into main 2025-02-24 16:00:48 -08:00
Sukesh Ram dc0a634362 [CD Taskbar] Remove legacy all apps button (secondary display)
Remove legacy all apps UI from secondary display. This is a quick temporary fix just to remove the legacy all apps button for aesthetic purposes without breaking secondary display launcher. The button will appear invisible. A more robust removal will be done when secondary launcher is eradicated completely.

Bug: 398196983
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ic5bc44efd479f7298e346d9d45fbb6f24dfad5d3
2025-02-24 15:26:56 -08:00
minch b10cedd21c Handle AddDesktopButton's visibility in different launcher states
Introduce [ADD_DESK_BUTTON] in LauncherState and change the button's
visibility across different launcher states. E.g., the button
shouldn't be visible in the quick switch.

Bug: 389209338
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: 1. Swipe up from home, the button shown util in overview.
      2. Swipe up from the fullscreen app, the button is invisible
         util release the finger.
      3. The button is invisible in quick switch.
      4. All the above tested with NexusLauncher and Nova launcher,
         which is a 3rd launcher.
      5. Tested with gesture and 3-finger swipe on the touchpad.
      6. Both the ClearAllButton and AddDesktopButton are not
         visibile when in select mode.
Change-Id: I54e11d4d03401be68b5b67a6f591edd737c9ea30
2025-02-24 21:33:36 +00:00
Jagrut Desai cf05d3ec0e Merge "Fix Taskbar Edu accessibility anmimation" into main 2025-02-24 13:27:53 -08:00
Jagrut Desai 8b2e5eff9b Desktop Mode Taskbar Recreate Animation
This Cl includes
       - addition of entry/exit callback methods in DesktopVisibilityController.
       - taskbar manager now listens to desktop mode changes.
       - TaskbarBackrgroundRedererer can now individually animation backgrounds for transient and persistent taskbars
       - new channel for taskbar icon alpha added to TaskbarViewController
       - new animated float to handle background alpha while we are recreating taskbar with animation.

Solution:

we use the callabck we get from DekstopVisibilty for entry/exit to first change logic of when we are considered inDesktopMode. Upon entry/exit we notify display controller for info change.
we also at notify taskbar manager who is now a listener to the desktop mode change and start the recreate process. TaskbarManager first animates existing taskbar out of user view and then follows the original recreate flow.

Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib827564cacd194f499e7d9b1965e2bb13e3548ab
2025-02-24 11:59:53 -08:00
Federico Baron 45fe4733fb Fix grid previewing so it matches the applied layout
Bug: 392019771
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: tested manually
Change-Id: If0fdd130d4278222b0b6ec2787aa7d6d56fc4b2f
2025-02-24 11:54:26 -08:00
Sunny Goyal b1fab90e26 Enforcing grid customization permission in manifest instead of code
Bug: 389173244
Test: Updated tests
Flag: EXEMPT manifest change
Change-Id: I0fee57f935156da6b2b5a612259db2c4b3605846
2025-02-24 10:40:43 -08:00
Charlie Anderson d4d526c3b5 Merge "Simplify some package update logic around restoring archived/unarchived shortcuts" into main 2025-02-24 09:58:35 -08:00
Treehugger Robot 332c329276 Merge "Fixing model thread priority getting set to background while loading" into main 2025-02-24 09:40:53 -08:00
Jagrut Desai e49214080f Fix Taskbar Edu accessibility anmimation
This cl include: Allows user to click on lottie animation views to play and pause animations. If user have choosen to remove animations we will honor it and not play the animation from begaining.

Test: Manual, Presubmit
Bug: 378980835
Flag: EXEMPT bugfix
Change-Id: Ieaaf771bc307837f042f6e59d8f02fefb2e8286a
2025-02-24 09:36:22 -08:00