7953f25c3c
Merge "Add spring animation when stashing transient taskbar." into tm-qpr-dev am: ba85154590 am: 9c0ad5f746
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22178236
Change-Id: Ibec649f0c7d6181ac52e2067898fe4b0b82f01a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-22 03:46:12 +00:00
ba85154590
Merge "Add spring animation when stashing transient taskbar." into tm-qpr-dev
2023-03-22 02:34:46 +00:00
e71032e2cf
Merge "Fix bug where Taskbar was not auto-hiding after splitscreen launch from icon menu" into tm-qpr-dev am: 3c8def9f88 am: ce97be3d12
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22077752
Change-Id: I38ab3fedc4a6cbb164a8b0f8e5a8be8f1c4a4aea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-22 00:15:48 +00:00
3c8def9f88
Merge "Fix bug where Taskbar was not auto-hiding after splitscreen launch from icon menu" into tm-qpr-dev
2023-03-21 23:34:34 +00:00
8eed87ac89
Fix bug where Taskbar was not auto-hiding after splitscreen launch from icon menu
...
This patch fixes a bug where the transient Taskbar was not hiding properly after splitscreen was initiated. When the user is inside an app and launches splitscreen by longpressing on a Taskbar icon and selecting the split button, the transient Taskbar should hide right away. This is an equivalent action to dragging the Taskbar icon up to create a split, and should hide the Taskbar so that other UI elements (like system-level toasts and error messages) can be seen.
The bug occurred because updateAndAnimateTransientTaskbar() is not being called in this specific code path to stash the Taskbar.
Fixed by adding a new call to updateAndAnimateTransientTaskbar upon clicking the splitscreen menu button.
Fixes: 272292897
Test: Manual
Change-Id: I64a9acfc41ddcaba4d9f43eb216458de44b4c9a4
2023-03-21 14:35:36 -07:00
3344ec7004
Add spring animation when stashing transient taskbar.
...
Bug: 273961611
Change-Id: I35a658a5e30a155094a48effdefc3895f45e0483
Flag: ENABLE_TRANSIENT_TASKBAR
Test: stash transient taskbar
2023-03-21 10:25:48 -07:00
7b410f24b4
Do not perform invisible transitions while the screen is off.
...
This change caches whether launcher was active at the time of the screen
off, and assumes this last state when the screen is actually off.
While trying to understand the code, I renamed a couple class-internal
methods and flags, plus added comments. If they are not accurate, its
due to a misunderstanding on my part, and I will gladly revisit and
check whether all the assumptions I made still hold.
Bug: 261418621
Test: manually
Change-Id: I2ad25caf478100781a063c356c5fd2d20d3e1917
2023-03-21 10:27:13 +00:00
7654a32a29
Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev am: 201a8f5ea3 am: c9905fed66
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778876
Change-Id: I56f40e88f58630b919fc1231fc1b230074c186bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 18:22:53 +00:00
201a8f5ea3
Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev
2023-03-14 17:16:43 +00:00
31dded9c2a
Ensure taskbar background always transparent in notification tray. am: 84261f9d9b am: 16fdd8b4f0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593273
Change-Id: I24d71d5ef12be305576149fd30666d951c033481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-09 00:46:58 +00:00
84261f9d9b
Ensure taskbar background always transparent in notification tray.
...
Persistent, taskbar can be in light or dark modes. Since notification
tray has its own background color, we should hide ours to avoid clashing
with it.
Test: Manual
Fix: 270758899
Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517
2023-03-08 23:51:34 +00:00
d1b7b5141f
Merge "Log when taskbar is in task switcher container." into tm-qpr-dev am: ba5b25c198 am: cba28f0b3f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21780681
Change-Id: Iac3de6884edf1a160da9baeb33929fcdd92eaf3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-08 19:45:04 +00:00
c762ef68d4
Log when taskbar is in task switcher container.
...
Test: wwdebug & wwlogcat
Bug: 261177876
Change-Id: Id4eda7ee7e4e2c1aa60e07d5b65410b3847d9ac6
2023-03-07 03:29:21 +00:00
cdc13fc4e8
Log when FLAG_STASHED_IN_APP_AUTO changes.
...
Bug: 261177876
Test: wwdebug & wwlogcat
Change-Id: If2d2a3d38f3128a60d551bca9f4cdf64f2bcb032
2023-03-07 03:12:45 +00:00
8ecb5eeb62
Merge changes from topic "running-in-test-camel" into tm-qpr-dev am: d2d2913812 am: 0c15dabc48
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725479
Change-Id: I3d02a42c2d0bdebc2487def8696d9a489aca7311
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-07 00:08:07 +00:00
6820cf8677
Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev am: f51426a6ee am: f24a4d5208
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21701337
Change-Id: Iec21590a5cda006eefdaafc8c39811dd4ce53b32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-07 00:07:53 +00:00
be2db5bd3d
Merge "Do not use private APIs in unfold module" into tm-qpr-dev am: c7ab991818 am: fcf5d393eb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21523105
Change-Id: I80ef77898fe2ffc728cdaa2473252ca032880da3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-07 00:05:17 +00:00
d2d2913812
Merge changes from topic "running-in-test-camel" into tm-qpr-dev
...
* changes:
Expose IS_RUNNING_IN_TEST_HARNESS as static method.
Make isTooltipEnabled a getter due to its mutable dependencies.
2023-03-03 23:15:38 +00:00
f51426a6ee
Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev
2023-03-03 21:33:52 +00:00
c7ab991818
Merge "Do not use private APIs in unfold module" into tm-qpr-dev
2023-03-03 13:22:03 +00:00
26c893603f
Add null check for recents when tapping on Taskbar icons
...
Fixes: 270669636
Test: Couldn't repro, but visually we have checks for
recentsView != null && OTHER_CONDITION, but in the else
case we don't check if recentsView being null is the reason
the if-block didn't get triggered
Change-Id: I72e7480bac56c7e7b7edb73edac4309e9923d302
2023-03-02 18:18:11 -08:00
fdd044e16e
Expose IS_RUNNING_IN_TEST_HARNESS as static method.
...
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.
Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions
Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
2023-03-03 00:17:33 +00:00
86e4f02035
Merge "Fix bug with Taskbar not differentiating between user profiles" into tm-qpr-dev am: 24b1890c4b am: 0027186ea2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21566360
Change-Id: Ic90db4ff687565109c3644cede0f7c50f9f66f4a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-02 04:10:00 +00:00
e35d112693
Fix bug with Taskbar not differentiating between user profiles
...
This patch fixes a bug where Taskbar would not differentiate between user profiles when selecting an app to launch from Overview.
The bug occurred because findLastActiveTaskAndRunCallback(), which checks for already-running tasks when launching an app from the Taskbar, only checks for a ComponentName match and not a userId match.
Fixed by making the findLastActiveTaskAndRunCallback() also check for a userId match.
Fixes: 270456926
Test: Manual
Change-Id: I43ff06083a5dce775fdbd0b0ed951beaae34c0ab
2023-03-01 10:57:41 -08:00
8e17afacdd
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67 am: 06ed4db282
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212
Change-Id: I4f8fab35c7c4c1de91927fc01a3b8a90d8d4aacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 03:51:29 +00:00
54c262cd67
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev
2023-02-22 02:15:46 +00:00
a09599d97f
Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f am: f94e71eca0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940
Change-Id: I622200bd7dca3086433170dc680ccc9aa2bc0e8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 22:47:21 +00:00
dd2311e7f7
Do not use private APIs in unfold module
...
Removes usages of the private/hidden APIs
in unfold module so it could be easily
reused in 1p/3p apps.
Bug: 258828766
Test: manual fold/unfold with a full screen
app and in split screen
Change-Id: I79618af5f1e4bd7da66b840e321403bb33cf7e95
2023-02-21 18:26:46 +00:00
c97bb4600f
Move split functions from RecentsView to SplitSelectStateController
...
* Moving things out of RecentsView to avoid
dependency on a non-testable class
* Also helping prevent bloating RecentsView.java
Bug: 266482558
Test: Single Chrome instance in recents. Initiate split
with Chrome from workspace, tap on Chrome again in Taskbar,
ensure no crash.
Change-Id: I99ec704479ffaa860f4d80c2cb9f54182f31f41a
2023-02-17 17:28:08 -08:00
ddb909603a
Remove setImeIsVisible/setTouchesEnabled as its already handled by insets.
...
Bug: 260101467
Test: manual
Change-Id: Iba22a6db61abd4be0b2a15b2e4099d9bc03ddbc9
2023-02-18 00:27:03 +00:00
2f0b433e57
Merge "Making taskbar to stay stashed if user launches app for split screen view from all apps view" into tm-qpr-dev am: 4ffc71262d am: f13a3413a8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20840305
Change-Id: If38a667631f3e68316b510a2d26af32b2d8d870a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-16 00:42:07 +00:00
4ffc71262d
Merge "Making taskbar to stay stashed if user launches app for split screen view from all apps view" into tm-qpr-dev
2023-02-15 23:03:19 +00:00
79855e7cb8
Merge "Add the KeyboardQuickSwitchView (2/2)" into tm-qpr-dev am: 25656568e3 am: 74ffb0ba89
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087436
Change-Id: Ie6f0b30af20e5905fc10105bbf2fcf8a0db028b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 06:15:48 +00:00
de7ceba80b
Add the KeyboardQuickSwitchView (2/2)
...
Adding KeyboardQuickSwitchView and associated flows.
Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
d5b9cdc6fa
Merge "Update region sampling to account for window visibility" into tm-qpr-dev am: c5180384d5 am: 30616e83d9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21384584
Change-Id: If15c741da1eae2b399b3a41ea406d5fa7c56cf7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-14 06:28:41 +00:00
95de6078b0
Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev am: b41d15b5f6 am: 3e815cbbb9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21344502
Change-Id: I195b250bec9a965d916659d8c3490e62bde5065b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-14 05:41:35 +00:00
c5180384d5
Merge "Update region sampling to account for window visibility" into tm-qpr-dev
2023-02-14 04:48:02 +00:00
b41d15b5f6
Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev
2023-02-14 04:45:24 +00:00
fc97f74e82
Have Taskbar report left/right gesture insets
...
Fixes: 231648761
Test: output from adb shell dumpsys activity service
TouchInteractionService, specifically TaskbarInsetsController
Change-Id: I8ed7fefb482bd4f73d2b2026ccb4ac369b6321ab
2023-02-14 04:43:01 +00:00
c3a8254e65
Merge "Reapply previous states when recreating the task bar" into tm-qpr-dev am: a097a960c8 am: f51df33fc8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21383817
Change-Id: Ia95dbef74947a2530b8b8f7ceaa371dc2c804acd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-14 01:50:02 +00:00
8bce18a562
Update region sampling to account for window visibility
...
- Similar to the nav bar, we should also disable region sampling then
the window is no longer visible (ie. when in immersive mode) otherwise
we fall back into gpu composition which consumes more battery
Fixes: 268280575
Test: Enter immersive mode and verify region sampling is disabled
Change-Id: I99bf8986c6f22fd8d480d255d10cfcd39cfb79e3
2023-02-11 01:02:35 +00:00
8fe24e0893
Reapply previous states when recreating the task bar
...
- When the taskbar is recreated (ie. from a display config change),
the previous states sent from SysUI need to be reapplied to the
new controllers
Fixes: 267664948
Test: Wipe device, in SUW accessibility settings change the display
density and verify it properly tints the back button
Change-Id: I837a67ced2941d4545359b8231026044b5479767
2023-02-11 00:25:01 +00:00
ef03a14980
Making taskbar to stay stashed if user launches app for split screen view from all apps view
...
Test: Visual
Fix: 263058045
Change-Id: Idcbc4ce90e8d4ff1084780bf331f2cea8b9335ca
2023-02-08 21:53:37 +00:00
01b66f98ca
Merge "Don't applyState if taskbar is already destroyed" into tm-qpr-dev am: 632e9a84c4 am: 25dd967b05
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21238187
Change-Id: I9a1f6a9556aa8bf321d0527fc90c1e6f9c5c5fd1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-03 18:43:21 +00:00
632e9a84c4
Merge "Don't applyState if taskbar is already destroyed" into tm-qpr-dev
2023-02-03 17:55:30 +00:00
3c76c2212a
Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev am: 5903751ee3 am: 82382fc784
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21225224
Change-Id: Iec7cd640cb84417f231dd440490a6d1c78b38465
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-03 02:29:15 +00:00
5903751ee3
Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev
2023-02-03 01:34:05 +00:00
9fb8883017
Don't applyState if taskbar is already destroyed
...
Test: Open overview while unfolded, then fold; ensure hotseat remains
visible
Fixes: 260135164
Change-Id: I788a9a682a7d5fabbea7c478231fc7abe92e95b9
2023-02-03 01:00:21 +00:00
2b25ded506
Update notification dot renderer when we update the taskbar icon size.
...
Test: swipe to home with an app that has a notification dot
observe no jump in dot size
Bug: 264709741
Change-Id: I5d56fe57e74ed7b094477ecd8727152f3f522042
2023-02-02 23:10:42 +00:00
5bce035bb7
Merge changes I865871e5,Ie655de7a into tm-qpr-dev am: 6e21d310c1 am: 21c3aab5b3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074655
Change-Id: I5485085b18ffb98354d05ead2f3c9fc802ac4d1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-01-31 19:29:11 +00:00
Jon Miranda
Jeremy Sim
Mike Schneider
Brian Isganitis
Vinit Nayak
Nick Chameyev
TreeHugger Robot
Jagrut Desai
Schneider Victor-tulias
Winson Chung
Tony Wickham