Commit Graph

12151 Commits

Author SHA1 Message Date
Alex Chau f35a887446 Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev 2021-06-30 10:24:11 +00:00
Hyunyoung Song 6eee4e4f3d Merge "Rebind recycler views if launcher activity restarted" into sc-dev am: 77c532d799
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15136464

Change-Id: Iaa257f243aac6c2378a89102ab9bbae2d412d500
2021-06-30 04:20:04 +00:00
Hyunyoung Song 77c532d799 Merge "Rebind recycler views if launcher activity restarted" into sc-dev 2021-06-30 04:00:23 +00:00
Jonathan Miranda 2178eedc6a Merge "Set elevation of popup and arrow to match. This ensures no shadow overlap." into sc-dev am: 26a485bb2a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147164

Change-Id: I71252441a356c0119eeb94bdef36ab14d370b2a2
2021-06-30 03:08:23 +00:00
Jonathan Miranda 26a485bb2a Merge "Set elevation of popup and arrow to match. This ensures no shadow overlap." into sc-dev 2021-06-30 02:56:18 +00:00
Brian Isganitis 0aa22aaea1 Merge "Intercept touch events for launcher preview root view" into sc-v2-dev 2021-06-29 23:58:17 +00:00
Steven Ng 755c2c54c7 Merge "Use category icon for pending conversation widgets" into sc-dev am: d35dcdec05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142493

Change-Id: Id2b6a1429d1b8f84e901fffc0e669c357888d9be
2021-06-29 23:16:56 +00:00
Jonathan Miranda 576e567f0f Merge "Fix bug where status bar was not set properly." into sc-dev am: 1b6a8b2255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15146553

Change-Id: I1e4b057e8a5f75c823eb15a5539c3130ddb06183
2021-06-29 23:16:50 +00:00
Steven Ng d35dcdec05 Merge "Use category icon for pending conversation widgets" into sc-dev 2021-06-29 23:15:04 +00:00
Jonathan Miranda 1b6a8b2255 Merge "Fix bug where status bar was not set properly." into sc-dev 2021-06-29 23:03:15 +00:00
Jon Miranda fa73c02172 Set elevation of popup and arrow to match. This ensures no shadow overlap.
Bug: 191823198
Test: long press app where arrow is on top and bottom in:
      workspace, all apps, and search UI

Change-Id: Icc4ac259607175d5e12447a844ba166ba28b74af
2021-06-29 15:49:46 -07:00
Hyunyoung Song 0b9537e6fc Rebind recycler views if launcher activity restarted
Bug: 185038312
Test: manual
TL;DR;;
What was attempted but was too much refactoring of the code.

Failed attempt #1: try re triggering the search.
This was not trivial as SearchSession object is yet created.

Failed attempt #2: Restoring AdapterItems in AlphabeticalAppsList
This meant AdapterItems class and also it's children
had to extend Parceleable object.

Ultimate fix:
Original issue of dupe view id among slice and work recyclerview
should be fixed. And restoring should just work.

Change-Id: I1bddd6aa5bc736ade3b02f69aa947d64cfa467d6
2021-06-29 14:52:57 -07:00
Jon Miranda 401b921c19 Fix bug where status bar was not set properly.
- Need to check both alpha of the view, and alpha of the background color.

Bug: 187467559
Test: check status bar colors when using:
      - on white wallpaper,
      - on black wallpaper,
      - on wallpaper with white text
      - on wallpaper with dark text

Change-Id: Ie6f34d34dfa9dea716f95bd6a95125fbd650fc29
2021-06-29 14:23:55 -07:00
Yogisha Dixit ffd5acea77 Merge "Show resize frame when widget is added." into sc-dev am: 419ee4599e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13956205

Change-Id: I318890ec7296fdd9f2176cf19e77898ed5acbf0e
2021-06-29 21:21:45 +00:00
Yogisha Dixit 419ee4599e Merge "Show resize frame when widget is added." into sc-dev 2021-06-29 21:07:34 +00:00
Brian Isganitis 3b39f3164b Intercept touch events for launcher preview root view
This change prevents any accidental touches on any widgets in the
preview.

Test: Tapping on launcher preview in wallpaper app should never activate
a widget.
Bug: 191623924

Change-Id: I98d462eca699cf368dcd5894f15584f280932ccc
2021-06-29 16:07:16 -04:00
Samuel Fufa 42064e0d30 Merge "Update snackbar color" into sc-dev am: 48ec126d8b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15129885

Change-Id: Ib158406b7300fe1dcb77279cba80d764bc294e29
2021-06-29 19:05:06 +00:00
Alex Chau ba61b98fca Snap to relative position to snappd task when dismissing
- Calculate the diff to snapped page scroll and apply in onLayout, so tasks won't jump after dismiss when not in snapped position
- In grid, always keep the relateive snapped page unchanged to avoid jump

Bug: 188793333
Test: manual
Change-Id: Id11c2d700dc55440de39cc7409d06a712cedc9bc
2021-06-29 19:54:21 +01:00
Samuel Fufa 48ec126d8b Merge "Update snackbar color" into sc-dev 2021-06-29 18:48:38 +00:00
Alina Zaidi dd0b46e6db Merge "Make sure search recycler view is bound to fast scroller if user is in search mode at the time of attachment of work/personal recycler view." into sc-dev am: 7ed32025f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142492

Change-Id: I19abded4e3e36cf1adf9ba9185b7debb543fd54d
2021-06-29 18:30:16 +00:00
Alina Zaidi 7ed32025f1 Merge "Make sure search recycler view is bound to fast scroller if user is in search mode at the time of attachment of work/personal recycler view." into sc-dev 2021-06-29 18:13:23 +00:00
Yogisha Dixit 037a5362d8 Show resize frame when widget is added.
I referenced the code in Workspace.java that updates the widget view's
layout params before showing the resize frame.

Test: manual, AddWidgetTest and AddConfigWidgetTest tapl tests
Bug: 183437963
Change-Id: I6655917878fa22d6084b4bf39fc0661e7278d6f9
2021-06-29 18:25:38 +01:00
Steven Ng 12f7a59e5c Use category icon for pending conversation widgets
Fix: 192333050
Test: Manual
Change-Id: Ie3895cd4747f1bec1c8ca9af82347bb0eafa7415
2021-06-29 18:04:09 +01:00
Alina Zaidi 57973c328a Make sure search recycler view is bound to fast scroller if user is
in search mode at the time of attachment of work/personal recycler view.

Bug: 191980945
Test: Tested manually.
1) Open widget picker, scroll.
2) Enable dark mode, scroll.
3) Type search query, scroll.
4) Disable dark mode, scroll.
5) Have work profile in phone and repeat the above with work tab open
and search.

Change-Id: I106717091a88868c4bbe3fad0dd71c8344e9c8ed
2021-06-29 16:32:32 +01:00
Steven Ng 4edea3a6a6 Set the widgets pickers' width to at most 80% of screen width on
large screen devices

Test: Phone: Open the full widgets picker and observe the width of
      the widgets picker fills the device screen width.
      Large screen devices: Open the bottom widgets picker and observe
      the width of the widgets picker only takes at most 80% of the
      devices' screen width.
      Same behavior is observed for bottom widgets picker.
Bug: 186425352
Change-Id: I801b73ea031a290fb6a7295dca826ac91841877e
2021-06-29 16:24:34 +01:00
Steven Ng 190471ff2d Merge "Set the widget preview title a11y text to "{widget name} widget"" into sc-dev am: 9bb83f65cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15127003

Change-Id: I6962b6c720359677764bdbde507b2a6aaae801f1
2021-06-29 14:41:27 +00:00
Steven Ng 9bb83f65cb Merge "Set the widget preview title a11y text to "{widget name} widget"" into sc-dev 2021-06-29 14:25:13 +00:00
Steven Ng 85486d1c2c Set the widget preview title a11y text to "{widget name} widget"
Fix: 187376680
Test: Manual
Change-Id: I211d8e2b437091808d1f5a764075af4c3832ef48
2021-06-29 12:12:43 +01:00
Steven Ng b14a7a2d16 Merge "Extract common measurement in widgets pickers to its base class" into sc-dev am: 9f2674b6a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15114084

Change-Id: If0e29d3c3d9461b0c222fb9ca826f253733cf0a1
2021-06-29 11:02:12 +00:00
Steven Ng 9f2674b6a9 Merge "Extract common measurement in widgets pickers to its base class" into sc-dev 2021-06-29 10:45:58 +00:00
Yogisha Dixit 57a6f10e40 Merge "Don't show resize handle if widget cannot be resized." into sc-dev am: 9b8932f579
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15114085

Change-Id: Iff6ecb28dfb972b347faab76c757c8c3ec955d87
2021-06-29 10:13:54 +00:00
Yogisha Dixit 9b8932f579 Merge "Don't show resize handle if widget cannot be resized." into sc-dev 2021-06-29 09:59:40 +00:00
Yogisha Dixit ad68318048 Don't show resize handle if widget cannot be resized.
Test: manual
Bug: 190015493
Change-Id: Ibb0cc347103b8d01d30a19925f929617426e4889
2021-06-29 09:08:09 +01:00
Jonathan Miranda ec5beb8332 Merge "Ensure iconScale never exceeds 1." into sc-dev am: fab44042cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133276

Change-Id: I4adff0a4fb256e13fdbfc3056f09bb43dea01461
2021-06-29 02:23:26 +00:00
Jonathan Miranda fab44042cb Merge "Ensure iconScale never exceeds 1." into sc-dev 2021-06-29 02:12:56 +00:00
Hyunyoung Song fcac0c503f Merge "RecyclerView Scrollbar is easier to target" into sc-dev am: 40c4d5fc4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15115886

Change-Id: Ie360a92fb6669cf86ef4b9a7e64562af08f77f79
2021-06-29 00:09:08 +00:00
Hyunyoung Song 40c4d5fc4a Merge "RecyclerView Scrollbar is easier to target" into sc-dev 2021-06-29 00:08:52 +00:00
Sunny Goyal 925311975e Merge "Remove expensive logging." into sc-dev am: 2d6d8f890a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15112728

Change-Id: I0432590d39862c7efd312b760c64e4632fe170fc
2021-06-29 00:08:40 +00:00
Hyunyoung Song 587ab6b6bc Merge "Don't use ProxyActivity when launching from SearchActionItemInfo intent" into sc-dev am: c2e05c1df5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15105731

Change-Id: I55f81d6765381dd306e0cc56a13abb0c1a72aa36
2021-06-29 00:08:04 +00:00
Sunny Goyal 2d6d8f890a Merge "Remove expensive logging." into sc-dev 2021-06-29 00:05:12 +00:00
Hyunyoung Song c2e05c1df5 Merge "Don't use ProxyActivity when launching from SearchActionItemInfo intent" into sc-dev 2021-06-28 23:58:46 +00:00
Jon Miranda ab3c681df8 Ensure iconScale never exceeds 1.
The rest of the scaled values should scale accordingly.

Bug: 190777089
Test: manual
Change-Id: I97f1724b7e96eea3ad81c295a98ccb71da756abb
2021-06-28 16:55:10 -07:00
Samuel Fufa f6b7b17fa3 Update snackbar color
Bug: 184369338
Test: local
Change-Id: Id43b0957693d94236a3b6771b9ed881222c0e2b2
2021-06-28 15:28:52 -05:00
Steven Ng 17afc8d2fd Merge "Refine all apps tabs alignment & remove ripple effect from tabs" into sc-dev am: c9d5391bf2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15079828

Change-Id: Idaf1c4715bf938d92102e9b9e121e637ee5d34af
2021-06-28 16:57:18 +00:00
Steven Ng c9d5391bf2 Merge "Refine all apps tabs alignment & remove ripple effect from tabs" into sc-dev 2021-06-28 16:38:50 +00:00
Steven Ng fbe1836627 Extract common measurement in widgets pickers to its base class
Bug: 191644950
Test: 1. Open the full widget picker. Observe the clock widgets'
         previews are shown properly. Then, rotate the screen and
         observe the clock widgets' previews are shown properly.
      2. Open the bottom widgets picker for clock. Observe the
         clock widgets' previews are shown properly. Then, rotate
         the screen and observe the clock widgets' previews are shown
         properly.
      3. Repeat 1, 2 after changing the system navigation from button
         to gesture.
Change-Id: I564fc2ce0baf3103ae77499380ad69ec38ac6930
2021-06-28 14:55:27 +01:00
Hyunyoung Song 878dedfb84 Don't use ProxyActivity when launching from SearchActionItemInfo intent
Bug: 188490184
Test: Manual
Change-Id: I9b1b17dfb7e896025a01245414cdab11cf3125cb
2021-06-28 06:34:48 -07:00
Hyunyoung Song 58f49418ff RecyclerView Scrollbar is easier to target
Bug: 191666122
Test: manual

TL;DR;;
1) Allow some x offset when determining touch points are hitting the track
2) reduce the timeout to consider dragging state

Change-Id: Iebcbbbd1e50b602119795c57fc04c4c2a5ccdde5
2021-06-27 22:57:55 -07:00
Steven Ng a3df3b8bf2 Merge "Fix rounded corners for shortcut & generated preview shadow box" into sc-dev am: bf60673bbb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15098570

Change-Id: Ia04afd31b5f225fd0020c50f19b55125f6a8bdef
2021-06-26 22:47:47 +00:00
Steven Ng 3bf38cb556 Merge "Refine widgets removal logging" into sc-dev am: 57072af106
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15106953

Change-Id: I39f50ba31e70131c9709096a822f7894a245db44
2021-06-26 22:47:42 +00:00