There are bugs in the accounting for the margins if we manipulate the
view directly, causing the wrong top to be reported and the view to be
shifted when we call scrollToPosition. Item decorations ensure that the
layout system for the recycler view always has the right details about
the spacing.
Fix: 191642682
Test: verified locally
Change-Id: Ie80563757079e885c8178883ab16e314d01c5b32
Test: Drop Gmail widget to home screen and configure it. Then, drop
the widget to a home screen that doesn't have sufficient space
to accommodate it. The gmail widget can't be dropped to that
home page and is returned to its original position.
Fix: 190582606
Change-Id: I177c09562d059b658e835cbb7fdde0d7bc6565d2
This reverts commit 96cc3c533c.
Reason for revert: Causes back to close sub-settings (b/191257243).
Change-Id: I3aa01bed1d73874176fc2568bac4ca714e9f2df7
Bug: 188565060
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)
Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
open popup, click on notification
checked RTL
Change-Id: I92672f94233d986ae5b5c54979980967308cb156
This allows for smooth animations as the items will have their full
height resolved
Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
This reverts commit 71cefb593f.
Reason for revert: The default padding is added by the framework not the launcher. We really need to subtract padding from the size.
Bug: 190498032
Change-Id: If7f164da34aec3d8e022ef2c752b72292cca0489
Fix 2 bugs in this CL
1. Before this CL, getBoundsForViewInDragLayer returns absolute bounds
for widgets. What we want is the bounds of a widget when it is
visible in the drag layer. ViewGroupFocusHelper#viewToRect has
taken PagedView into account. This makes it a prefect candidate to
calculate relative bounds of a widget.
2. requestLayout at the end of endDrag is problematic due to the drop
animation. If the drop animation is still in progress when onLayout
is called, the bounds of the widget isn't final. Since the color of
app widget right before is already the final color. We don't really
need to update the color extraction.
Test: Set the wallpaper and clock widget according to the bug. Then,
reboot the device. The clock widget color shown right after
reboot is the expected color. Long pressing the widget doesn't
cause a color change.
Fix: 191114337
Change-Id: I466c8102dba0e5b207b3768e0935472cbd523235
Test: Set the grid to 4x5 (without padding) and verify the min / max
size sent to Conversation widget is expected.
Bug: 190498032
Change-Id: I8ef6e5d897ebd0e2ea9af4497b00059c8dfad70a
BuildCompat.isAtLeastS() in Launcher dependency only checks if the
code name is "S". In the recent version of Android, the code name has
changed to "REL".
Test: Open Widgets picker, expand Conversations and observe a preview
layout is shown.
Fix: 191239040, 191216821
Change-Id: I6a6e647d4cb327d251bde3484ea2d2e79c0f86f5
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown
Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y
Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
InvariantDeviceProfile.supportedProfiles can be modified in respect to
configuration changes. This CL ensures the list was cloned before access
to prevent ConcurrentModificationException
Bug: 191231591
Test: manual
Change-Id: I123458dcfe99af4babca2cf73733e3d2af0fad3c
Sunny Goyal
Brian Isganitis
Stevie Kideckel
Steven Ng
Jonathan Miranda
Samuel Fufa
TreeHugger Robot
Yogisha Dixit
Thiru Ramasamy
Schneider Victor-tulias
Pinyao Ting
Hyunyoung Song