Commit Graph

11710 Commits

Author SHA1 Message Date
Bill Lin 51b35256d2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev
* changes:
  2/ Notify adjust touch slop when one handed mode activated
  1/ Provides feasibility to adjust touch slop in TouchController
2021-06-04 00:16:12 +00:00
Brian Isganitis 6afcfd7cbd Show toolbar back button on subsettings pages
Test: Back button displayed and functional on subsettings
Bug: 187732263
Change-Id: I6a3679de3a00480f5a0861f966d178be25f001d4
2021-06-03 17:04:33 -04:00
Brian Isganitis ed49a7187d Pad bottom of settings list view with bottom system insets
This change allows for a transparent navigation bar in the settings Material next redesign.

Test: Bottom of settings not cut off by bottom navigation bar
Bug: 187732263
Change-Id: I237011003ca0c3760c0fbdbb2865ef90c19d7b81
2021-06-03 17:02:05 -04:00
Jonathan Miranda 3ed65ede16 Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev 2021-06-03 20:23:18 +00:00
Bill Lin a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin 945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00
Jon Miranda 4981118478 Only inset widgets if workspaceTopPadding is greater than the widget padding.
This prevents widget from becoming too close to status bar.

Bug: 189724771
Test: manual
Change-Id: I86f83b6a35bd2802bdbdf175340a379b498f481d
2021-06-03 09:54:45 -07:00
Stevie Kideckel f15214597e Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev 2021-06-03 14:15:00 +00:00
Stevie Kideckel 5cc44eb73e Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev 2021-06-03 11:00:32 +00:00
Stevie Kideckel eb367e471b Scroll to the selected widget picker row after headers are clicked
This keeps the row in view. Currently, this will scroll the row to the
centre-bottom of the screen due to the top padding being double counted,
but that will remedied in a future CL.

This also resolves the issue where the last row's widgets aren't visible
by handling that case specially

Fix: 188665456
Bug: 183378651
Test: verified locally
Change-Id: I9acb9087a8cdaf130ac5955c810c96462b368f36
2021-06-03 09:48:21 +00:00
Stevie Kideckel abd33b38e2 Use the LayoutManager as the source of truth for visible positions
During animations, the view group child may not correspond to the
visible views that appear at the top.

The previous logic is kept in the case that the layout manager returns
null for any reason, which can happen before layout has occurred for the
position.

Fix: 189588014
Test: verified locally
Change-Id: Ie8b5dcef50287e9e90a21f86e30a1ebcbbcba30f
2021-06-03 09:36:22 +00:00
Alina Zaidi 8796707172 Update scrim in widget pickers.
Also adjust padding in pin widget bottom sheet.

Test: Tested manually
Bug: 189802334
Change-Id: Ic25547ab1519139afdbf07aaefeb9168cf3501ff
2021-06-02 20:39:28 +01:00
TreeHugger Robot f5af5ce11f Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev 2021-06-01 23:39:39 +00:00
Wale Ogunwale 0e25d2eba8 Revert "Add haptic feedback to Launcher recent apps scrolling"
This reverts commit b1ef5e5c55.

Reason for revert: b/182382085#comment4

Change-Id: I001944da64dc05324b14cc9dd3db5921faf8806c
Bug: 182382085
2021-06-01 22:10:18 +00:00
Steven Ng c58b204926 Merge "Show app widget resize frame after launcher state change" into sc-dev 2021-06-01 21:11:01 +00:00
Steven Ng a45ea6cf33 Merge "Fix add extra empty screen logic" into sc-dev 2021-06-01 21:04:55 +00:00
TreeHugger Robot b13200c6b1 Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev 2021-06-01 21:02:29 +00:00
TreeHugger Robot 9ccd3c5e12 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev 2021-06-01 21:00:19 +00:00
Brian Isganitis d9463fbfdd Merge "Create settings activity layout with explicit toolbar" into sc-dev 2021-06-01 20:15:15 +00:00
Sunny Goyal 4c29af3a6d Fixing deadlock when surface creation is waiting on surface destroy
Bug: 189049869
Test: Manual
Change-Id: I0f92d3666dab81bc381163d93530119d45c4fdbd
2021-06-01 12:36:38 -07:00
Jonathan Miranda d8035e1821 Merge "Turn off app close flag, Revert back to R implementation." into sc-dev 2021-06-01 18:18:38 +00:00
Jonathan Miranda dfde41cf1e Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev 2021-06-01 18:17:17 +00:00
Alina Zaidi 8a8c36cca9 Merge "Add more education tips for widgets. (2/3)" into sc-dev 2021-06-01 17:34:18 +00:00
TreeHugger Robot 04ef35f854 Merge "Further adjust work profile tabs paddings in the widgets picker" into sc-dev 2021-06-01 13:13:03 +00:00
Alina Zaidi f2c79dea0d Add more education tips for widgets. (2/3)
Show education dialog on WidgetsFullSheet.
-Have a button in widget education dialog to intent into PixelTips apps.
-Make sure arrow tip view shows after dismissing education dialog on
WidgetsFullSheet if there is a widget to show it on.
-Update colors and layout for arrow tips.

Test: Tested manually
Bug: 185354491
Change-Id: I5cbdd02fc4f19a49a42dac4451b071e3d604747f
2021-06-01 13:58:18 +01:00
Steven Ng 7e3d96c620 Show app widget resize frame after launcher state change
When this bug occurs, the resize frame coordinate is incorrect because
the launcher state animation has not finished when the drag view
finishes animating back to its original position.

Test: Quickly long press and release a widget from the home screen.
      Observe the resize frame is correctly shown around the widget.

Bug: 186370472
Change-Id: I6bfba2e85e3354a215c26203dd22df13db3b8b83
2021-06-01 12:20:32 +01:00
Steven Ng a0d49dcfb4 Further adjust work profile tabs paddings in the widgets picker
Test: Open widgets picker and observe tabs paddings are correctly set.
Bug: 188872382
Change-Id: Ib6a735bf2b0710f86b8641533cadb27116049341
2021-06-01 11:40:36 +01:00
Steven Ng 755723403b Merge "Don't dismiss keyboard after clicking X button on the widgets search bar" into sc-dev 2021-06-01 10:05:26 +00:00
Sunny Goyal 8a7f973264 Merge "Enabling themed icon feature" into sc-dev 2021-05-28 18:53:40 +00:00
Jon Miranda de907805d1 Change folderFillColor to colorBackgroundFloating.
There seems to be some nuance that prevents me from defining it once in
the base theme, so just updated all of them individually to prevent
any edge case from slipping through.

Bug: 188095988
Test: manual
Change-Id: I1dea639f174fa4ec09bda93a6e2017993b2007a5
2021-05-28 01:21:21 +00:00
Brian Isganitis 08fdf4d269 Create settings activity layout with explicit toolbar
This layout will be overridden to have a collapsible toolbar on API 31.

Test: Settings layout unchanged
Bug: 187732263
Change-Id: I0c098dd0a09a1787a10035a3d3f35ecf461cfc20
2021-05-27 18:41:18 -04:00
Brian Isganitis 8d6ca68786 Merge "Give each preference screen its own activity and toolbar title" into sc-dev 2021-05-27 22:29:28 +00:00
Jon Miranda 62769f10d7 Turn off app close flag, Revert back to R implementation.
Need more time to experiment with interpolated + springs based approach,
will aim for QPR instead.

Bug: 189120868
Bug: 173107751
Test: manual
Change-Id: I5698bd61c92b4fa719d82f2553125fc7f65b5969
2021-05-27 15:14:52 -07:00
Brian Isganitis 890d8d5a91 Give each preference screen its own activity and toolbar title
This change is in preparation for each preference screen having its own collapsible toolbar with its specific title.

Test: Subsettings open with activity transition and title changes
Bug: 187732263
Change-Id: Iac44d688539195ddb6c2aca0a96d737ce7727071
2021-05-27 16:08:22 -04:00
Steven Ng 7a36ad396e Don't dismiss keyboard after clicking X button on the widgets search bar
Test: Enter some queries in the widgets search bar. Click X button. The
      keyboard is still opened after the search queries has been erased.
Bug: 189454318
Change-Id: Icb0501cf36cbf1517e2da24044da44101fa86ed9
2021-05-27 18:42:31 +01:00
Pierre Barbier de Reuille 0bb96c9168 Merge "Update the computation of the widget span from size" into sc-dev 2021-05-27 12:11:27 +00:00
Samuel Fufa bd883ea788 Merge "Remove AllApps prediction edu" into sc-dev 2021-05-27 11:02:49 +00:00
Tony Wickham f8d731a808 Cleanup state properly when interacting during gesture nav transition
When the transition is canceled (e.g. when touching the nav bar during the transition), do the following:
- Abort the RecentsView scroll including the edge effects to ensure we get onSettledOnEndTarget() immediately.
- Jump to the current gesture end target state instead of the default rest state.

Test: Swipe up and to the left and hold to go to overview from an app, then swipe up to home during the transition; ensure that the touch down goes to overview rather than home, and subsequently that the swipe is respected and goes to home
Fixes: 189142339
Change-Id: Ie1d7dd05f45ab48968df7fdfd69fa1e1dda36d06
2021-05-26 15:28:38 -07:00
TreeHugger Robot a07c2efdf6 Merge "Enable unpausing apps from the workspace." into sc-dev 2021-05-26 22:24:40 +00:00
Stevie Kideckel d9abe11b92 Merge "Add the DefaultItemAnimator, without change animations" into sc-dev 2021-05-26 22:21:03 +00:00
Pierre Barbier de Reuille 295a402908 Update the computation of the widget span from size
The new computation takes into account the new cell layout border
spacing.

Change-Id: Ic20e0906bbbaaf1e53475585e2a6ca31c277e09b
Bug: 187461595
Test: Manual testing, varying the sizes in a widget
2021-05-26 22:44:58 +01:00
TreeHugger Robot 96793bdfe1 Merge "Adjust the widgets fitting algorithm to mitigate over packing issue" into sc-dev 2021-05-26 21:06:57 +00:00
Sunny Goyal e85dc514cd Enabling themed icon feature
Bug: 183641907
Test: Manual
Change-Id: I79643803bb50ab2f4b40122258cd1c8bf89b90ad
2021-05-26 12:40:35 -07:00
Steven Ng b7773f93cf Adjust the widgets fitting algorithm to mitigate over packing issue
If we are fitting more than one widgets / shortcuts on the same row,
we will only allow the total width to be n - 1 cells, where n is the
grid width in cells.

Test: Run WidgetsTableUtils robolectric test.
Bug: 189103942
Change-Id: I2f23cb08fe95d68562188cc7b1852d99d7093dc0
2021-05-26 19:27:46 +01:00
TreeHugger Robot b1858afaf2 Merge "Add haptic feedback to Launcher recent apps scrolling" into sc-dev 2021-05-26 18:05:33 +00:00
Stevie Kideckel 47f935dbbe Add the DefaultItemAnimator, without change animations
Change animations cause the addition of another view to be able to
crossfade/interpolate the two. Disabling change animations prevents us
losing the focus when a header row changes due to expanding or
collapsing.

Test: verified locally
Bug: 183378651
Change-Id: I07837b41748b5206936321c08d376069fa81b363
2021-05-26 17:08:18 +00:00
Lais Andrade b1ef5e5c55 Add haptic feedback to Launcher recent apps scrolling
Add light LOW_TICK effects when the scrolling on RecentsView
snaps to a page, and a stronger TICK effect when the edges
absorb the scroll (by scrolling fast towards one of the edges).

Fix: 182382085
Test: manual
Change-Id: Ifb917ae499f73607707773f9870eb39cd6fe16ef
2021-05-26 13:37:30 +01:00
Stevie Kideckel fa7c98ee45 Merge "Remove intrinsic padding from widget previews" into sc-dev 2021-05-26 09:27:11 +00:00
TreeHugger Robot 694b667138 Merge "Update Gesture nav tutorial." into sc-dev 2021-05-26 09:20:18 +00:00
Samuel Fufa 53ec9a4e06 Merge "[Search] Resolve afterimage when closing allapps" into sc-dev 2021-05-26 00:42:58 +00:00