Commit Graph

12754 Commits

Author SHA1 Message Date
Vinit Nayak 524d6b83e9 Merge "Shows AppPairs in previous tasks" into sc-v2-dev 2021-11-10 16:33:50 +00:00
TreeHugger Robot 31bd663332 Merge "Fix wrong getIconBounds method inside BubbleTextView" into sc-v2-dev 2021-11-10 09:44:26 +00:00
Vinit Nayak 4d57e7091f Shows AppPairs in previous tasks
Fixes: 203006080
Change-Id: I63912a61e7617ec41f229c19cc267dc5a1857bae
2021-11-09 13:47:18 -08:00
Hyunyoung Song c2f024beb6 Fix wrong getIconBounds method inside BubbleTextView
Bug: 205065809
Test: screenshot on the bug

TL;DR;; created two variants depending on the layout direction

Change-Id: I9c5e74409c701b1f219ca450de0dca2291507045
2021-11-09 11:39:21 -08:00
Alex Chau ac038434f0 Remove gap between screenIds when restoring from single display device
- In RestoreDbTask.sanitizeDb, add extra step to fill all screenIds gaps so that no empty pages are left in between
  e.g. [0, 3, 4, 6, 7] -> [0, 1, 2, 3, 4]

Fix: 201085524
Test: RestoreDbTaskTest
Change-Id: If0b577bf789347cc490ada0b22f2cd39ee1a33bb
2021-11-09 17:01:01 +00:00
TreeHugger Robot 68953fc693 Merge "Add popup menu and click handling to taskbar." into sc-v2-dev 2021-11-05 23:22:59 +00:00
Jonathan Miranda 58763e47d6 Merge "Testing to see if waiting for transition to end will fix flaky tests" into sc-v2-dev 2021-11-05 22:53:17 +00:00
Schneider Victor-tulias 2bfbf3bffa Add popup menu and click handling to taskbar.
- Added popup menu support to taskbar icons
- Added item click handling for taskbar icon popup menu items

Bug: 198438631
Test: long pressed taskbar icons, pressed popup menu items, dragged taskbar icons to start multi-window mode
Change-Id: Ibc59c1eada50a877a863c075fbfd3e4accaae008
2021-11-05 13:07:09 -07:00
Jon Miranda a234a8ea85 Testing to see if waiting for transition to end will fix flaky tests
Test: presubmit
Bug: 202735477
Change-Id: Icf62003b9f422cf0e327365260c36f6d57b71aef
2021-11-05 12:31:15 -07:00
vadimt 41f99abeb5 Allowing OOP tests to enable home screen rotation.
Bug: 202567877
Test: local runs
Change-Id: Ifb711a3071a26e2d8e690e0378b6e74146ac722c
(cherry picked from commit 462fe7c007)
2021-11-05 18:19:01 +00:00
Greg Kaiser 5b4145e34b Merge "Revert "launcher: use a different task menu for foldables"" into sc-v2-dev 2021-11-05 16:19:43 +00:00
Greg Kaiser 24898d3be0 Revert "launcher: use a different task menu for foldables"
This reverts commit 10eb3cd98b.

Reason for revert: Root cause of P0 b/205278434
Bug: 205278434
Bug: 193432925
Test: Local reverted and now launcher works on wembley

Change-Id: I3605c01066a3ce383d45e0a938f1e00b3c7f7bb9
Merged-In: I5ee18d3ee1b671fcaedda633e7a268addd5c5c15
2021-11-05 16:19:05 +00:00
Alex Chau 67ddd0fefd Merge "Update overview clear all button to be larger" into sc-v2-dev 2021-11-05 11:49:56 +00:00
Thales Lima ed7a7b23d4 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-05 10:13:38 +00:00
Samuel Fufa 4112ae6a5b Merge "[Search] Show search suggestions with in Recyclerview" into sc-v2-dev 2021-11-04 21:00:15 +00:00
TreeHugger Robot 4c96d446a5 Merge "Update all home screen widgets size upon workspace inset change" into sc-v2-dev 2021-11-04 17:39:06 +00:00
Thales Lima 10eb3cd98b launcher: use a different task menu for foldables
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.

This creates a working menu, the correct style will come in later CLs.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Icb068954e1e20a52d80c16c52d8e38ce9a181a8b
Merged-In: Icb068954e1e20a52d80c16c52d8e38ce9a181a8b
2021-11-04 16:40:37 +00:00
Alex Chau 56bd257478 Update overview clear all button to be larger
- Tuned the size and corner radius
- Tuned the margin from screen edge
- Tuned the vertical position

Bug: 204153113
Test: manual
Change-Id: Ibf3df599b31c7ecc2c9c951fc89e7e09c90253ef
2021-11-04 16:02:17 +00:00
Steven Ng 91b46d1ba3 Update all home screen widgets size upon workspace inset change
Test: Add a clock widget to the home screen. Then, change the navigation
      gesture. Go to home screen to confirm the clock widget is rendered
      as expected in the portrait. Then, rotate the device to landscape.
      Confirmed the clock widget is rendered correctly in the landscape.
Fix: 202837404
Change-Id: I93b70c53f10c8150131b183defc8baf01e5924a8
2021-11-04 12:00:03 +00:00
Winson Chung 3b5dddbce1 Merge "Add some logging for taskbar recreation" into sc-v2-dev 2021-11-03 23:41:07 +00:00
Winson Chung 067faf3bbe Add some logging for taskbar recreation
Bug: 201305599
Test: Manual
Change-Id: I437fe3226657ebe7b5507146fbe5e7f32e2e2fce
2021-11-03 11:17:44 -07:00
sfufa@google.com 6cf7b319ac [Search] Show search suggestions with in Recyclerview
This change removes usage of FloatingHeaderView to display suggested web results to using RecyclerView.

Bug: 204116666
Test: Manual [apk attached to BR]
Change-Id: I7f8f1a5630f3cc2b29e7276636eaf45cda148566
2021-11-03 10:27:04 -07:00
Benno Lin 8f083ccce3 Merge "Update TAPL to operate on folder icons." into sc-v2-dev 2021-11-03 02:14:46 +00:00
Zak Cohen 427113fa58 Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev 2021-11-02 23:33:31 +00:00
Zak Cohen 21f6189cd5 Add temporary logging to try and debug: b/202414125
Bug: 202414125
Test: Local
Change-Id: I641f9877972f3f584e5fc618d89c65c52f0d1da0
2021-11-02 14:17:15 -07:00
Alex Chau 27794e8fa3 Merge "Add logging of draw / DeviceProfile params for a crash" into sc-v2-dev 2021-11-02 18:26:58 +00:00
Alina Zaidi 6180273e1f Merge "Use equals() to compare UserHandle when building LauncherAtom#ItemInfo." into sc-v2-dev 2021-11-02 16:27:56 +00:00
Alina Zaidi 08c3e8f526 Use equals() to compare UserHandle when building LauncherAtom#ItemInfo.
Bug: 204756057
Test: Manually verified correct behave through logs
Change-Id: Ic314e38978893984bac89988bfc3229a21d0214e
2021-11-02 14:10:37 +00:00
Alex Chau 05659a3d10 Add logging of draw / DeviceProfile params for a crash
Bug: 203530620
Test: manual
Change-Id: I376157ee3f688b16a05b59a0093f06519533f6c7
2021-11-02 13:11:05 +00:00
Jonathan Miranda 9b85616119 Merge "Remove PROTOTYPE_APP_CLOSE feature flag and associated code." into sc-v2-dev 2021-11-01 18:35:44 +00:00
Jon Miranda 029a644a6e Remove PROTOTYPE_APP_CLOSE feature flag and associated code.
Flag was never enabled, safe to remove.

Bug: 200999899
Test: manual
Change-Id: Ie2646d8c4b9a1c40fac1bfd7dadf4ec714171aec
2021-10-29 16:07:29 -07:00
TreeHugger Robot 01f8b561b3 Merge "Fixing the possibility of opening multiple WidgetsFullSheet" into sc-v2-dev 2021-10-28 16:20:05 +00:00
Alex Chau 0cc439ab18 Merge "Partially restoring reverted logging" into sc-v2-dev 2021-10-28 11:10:17 +00:00
TreeHugger Robot 0c689ef773 Merge "Clean up IllegalStateException for page pairing" into sc-v2-dev 2021-10-27 11:21:46 +00:00
Vadim Tryshev 8629be753f Partially restoring reverted logging
ag/15858126 slowed down everything so
that the flake stopped to repro.

Attempting to reintroduce a more
lightweight logging hoping that the flake will
keep reproing.

Test: presubmit
Bug: 195031154

Change-Id: Ib533c22253e367cced1680a6f4d6736087f0837a
2021-10-26 20:00:55 +00:00
Pinyao Ting 35c5755b71 Fix the fallback logic for shortcut icons when icons are missing
The icons of shortcuts in general are not persisted in backup payload
and thus are not available on the new device, apps are reposponsible for
republishing those shortcuts on the new device, with the only exception
being pinned shortcuts, whose icons are stored in launcher.db as a
fallback when icons are not avaialble in the shortcut themselves.

A previous CL unexpected excluded deep shortcuts from loading their
fallback icons in launcher.db, causes pinned shortcut to fallback
further to default droid icons, this CL restores the original behavior.

Bug: 202346722
Test: manual
Change-Id: Ie09becd3a0dc1ca1e7c2573fe1b68b61a58c2091
2021-10-26 18:02:08 +00:00
Sebastian Franco 97503ab4fb Fixing the possibility of opening multiple WidgetsFullSheet
The error is that you can open multiple times the view for
selecting widgets for the Home Screen (i.e. WidgetsFullSheet.java)
but only when using a keyboard by using the command ctrl+w
creating a new instance every time you use it. To fix this
I added a singleton pattern so that only one instance of
WidgetsFullSheet.java can be open at any given point.

Test: Manually Tested
Fix: 196704061
Change-Id: I7a364ee5e746e77455da326a21aff6830ac18e8c
2021-10-26 11:26:21 -05:00
TreeHugger Robot 8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Sebastian Franco 63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Alex Chau 53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alex Chau 920be89b26 Clean up IllegalStateException for page pairing
Fix: 198820019
Test: manual
Change-Id: Ic691f781b20d664c57a26370aae479ab68508303
2021-10-25 15:20:16 +01:00
Benno Lin 5261776d3a Update TAPL to operate on folder icons.
The change updates features listed as follow:

1. Create a new class for folder icon.
2. Implement function to drag a icon to the other.
   (create a folder)
3. Find folders in a workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragToFolder
Change-Id: I3044025f8297f6e442446d70238f4b56f38a798a
2021-10-25 11:08:44 +00:00
TreeHugger Robot d4df41b78f Merge "Bugfix where the widget handles appear even when you can't resize it." into sc-v2-dev 2021-10-21 20:46:37 +00:00
Sunny Goyal 486adb03a0 Fixing wrong text spacing bounds
Bug: 203740844
Test: Manual
Change-Id: I68fcab489643acf80759f90736f806ae2852e648
2021-10-21 11:30:18 -07:00
Sebastian Franco 4067f5d4ae Bugfix where the widget handles appear even when you can't resize it.
To fix it I added the following logic condition: if the minimum size of
the widget (`mMinVSpan` vertically) is equal to the maximum size of the
widget (`mMaxVSpan` vertically), then you can't change the size and the
handles shouldn't appear, I did this for both the horizontal handles as
well as the vertical handles.

Fix: 202004006
Change-Id: Ide05231f5712a736129ac6cb2fee358f7c70e371
Test: Manully veryfied.
2021-10-21 17:32:31 +00:00
TreeHugger Robot ea38519fa4 Merge "Fix bug with resize frame in Launcher3." into sc-v2-dev 2021-10-20 20:50:17 +00:00
Schneider Victor-tulias e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Yogisha Dixit 7b1d25b251 Fix bug with resize frame in Launcher3.
Also updated the tests to check that the resize frame is shown.

Bug: 192655785
Test: AddWidgetTest, AddConfigWidgetTest, manual
Change-Id: Id348f39cec1bebc8ec9ea9f3068f4bda2159eac4
2021-10-20 19:03:14 +01:00
Pat Manning 3c647ff30a Merge "Add new quickstep test for many tasks open at once." into sc-v2-dev 2021-10-20 15:20:26 +00:00
Pat Manning ccec1de6ae Add new quickstep test for many tasks open at once.
This test is needed for testing overview-grid-related functionality.
- Opening non-focused tasks
- Dismissing a non-focused task from the grid
- Grid rows rebalancing after dismissal, which only happens when enough
apps are open to be off-screen.
- Grid tasks do not scroll after dismissal.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ic907db4643cdc2eb9e4610dab917347e234e470c
2021-10-20 14:40:32 +01:00