Commit Graph

14710 Commits

Author SHA1 Message Date
Tony Wickham 6ecdbc69b2 Merge "Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar" into tm-qpr-dev am: 788f8e09fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20666524

Change-Id: Id1c71be116afa8bb77bb2213064939ea34f86d1c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 16:39:43 +00:00
Tony Wickham 788f8e09fe Merge "Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar" into tm-qpr-dev 2022-12-08 16:21:43 +00:00
Tony Wickham 5de5ac9008 Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar
This avoids us trying to read FORCE_PERSISTENT_TASKBAR feature flag
which apparently crashes tests due to permission issues. Going forward,
when we support persistent taskbar better, we should update the tests
and this check as commented in the code.

Test: com.google.android.apps.nexuslauncher.TaplTestsNexus#testSearchNoInputs
Fixes: 261604544
Change-Id: I35c20825e8171766834f0f32be4f3818d02ab1df
2022-12-08 16:19:16 +00:00
Schneider Victor-tulias d132ad4393 Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: Icfdd29ce44e4ff73bfb79b3150addca41b7517cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:25:37 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00
TreeHugger Robot 4c44df1edb Merge "Simiplifying the Parner override definition so that it can be used for multiple overrides" into tm-qpr-dev am: 117865726f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470533

Change-Id: I351d81002525189f3877fefeb75a5190482ad3df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 06:49:56 +00:00
Sunny Goyal 3e58eea9da Simiplifying the Parner override definition so that it can be used
for multiple overrides

Bug: 257555083
Test: Presubmit
Change-Id: I14eb98edb19ccf109222d6806e27de707e485457
2022-12-07 23:35:18 +00:00
TreeHugger Robot d1409f220b Merge "Remove feature flags and use search config flags." into tm-qpr-dev am: 1c744c996c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20624019

Change-Id: I9bf3371ca4eb65c5dcec19466644fe8d1a9fbca4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 23:30:48 +00:00
TreeHugger Robot 1c744c996c Merge "Remove feature flags and use search config flags." into tm-qpr-dev 2022-12-07 22:58:39 +00:00
TreeHugger Robot ededf539ff Merge "Support right click to bring up app menu and actions" into tm-qpr-dev am: 13b432cd9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613963

Change-Id: I2ef2a21fd627033e74532bfc0aa7c7d8878d4e27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:29:25 +00:00
TreeHugger Robot 13b432cd9d Merge "Support right click to bring up app menu and actions" into tm-qpr-dev 2022-12-07 20:00:33 +00:00
Schneider Victor-tulias f0de6cc2ca Revert "Cancel gestures on launcher destroy"
Revert "Refactor SchedulerCallback implementation"

Revert submission 20555112-launcher-destroy-gestures

Reason for revert: causes test failures
Reverted Changes:
Ib43cdd597:Refactor SchedulerCallback implementation
Ia8e936e26:Cancel gestures on launcher destroy

Change-Id: I2199e39237b7c9fe25784b46e16960cd5f17c46c
2022-12-07 19:46:00 +00:00
Andy Wickham 83a06d68f7 Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev am: abb18ea62a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20518558

Change-Id: I07c5849c0371dd6e25ea435c810f25422bce4784
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:25:16 +00:00
Andy Wickham abb18ea62a Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev 2022-12-07 19:08:53 +00:00
Jon Miranda 2645897b6e Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev am: 6ba531d1aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590318

Change-Id: Ice4e6728e8912bc9a2aa753944170765779dfee5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 17:55:09 +00:00
TreeHugger Robot 0a456b59ef Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev am: 5e0d7ae019
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20640160

Change-Id: I6efba3ac4543bd9b1f289de1f349edeaffdef3c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 17:54:48 +00:00
Jon Miranda 6ba531d1aa Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev 2022-12-07 17:33:53 +00:00
TreeHugger Robot 5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Fengjiang Li 9f90efb39e Support right click to bring up app menu and actions
Test: https://b.corp.google.com/action/issues/250092449/attachments/40159735?download=true
Change-Id: I159005cc982478896d442bb2675ccb1bb7f0322e
2022-12-07 08:48:16 -08:00
Andy Wickham 493831af1a Fixes for floating search bar (e.g. background protection).
- Adds background protection for the search bar
 - Views animating based on keyboard now support manual swipes.

Bug: 213954333
Bug: 259004115
Bug: 251460671
Test: Manual
Change-Id: I055766126fb46a8e8b48907e442c9e54aaa4badf
2022-12-06 17:59:53 -08:00
Alex Chau 5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Holly Sun 581aa03806 Remove feature flags and use search config flags.
Bug: 210661150
Test: manual
Change-Id: I6aa176895f80f31840570ce2c0ecbfbfb11079a1
2022-12-06 11:31:31 -08:00
Sebastián Franco a3ac407d85 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev am: 9adbab96b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646376

Change-Id: Icf0e9ddf86799e6fcffa74f47473013925af6a99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 17:48:51 +00:00
Sebastián Franco 9adbab96b7 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev 2022-12-06 17:17:26 +00:00
Tony Wickham c9740c89aa Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: Ia758acdad42c8f95b9ee52d37d0bf7a3f2c63e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 06:29:09 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot f77ad4afd4 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: I5907940eac2de90c913e1d8ed965b35f013815f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:13:20 +00:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
TreeHugger Robot a44e9370f0 Merge "Make grid size migration less confusing for users." into tm-qpr-dev am: 33c348f573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388826

Change-Id: Ia19f19c57fa662098336bd05b1d34753c460cd97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 18:48:11 +00:00
TreeHugger Robot 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sihua Ma 57489b5c3a Merge "Replace title of system services with more specific ones" into tm-qpr-dev am: 7b467addea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20592089

Change-Id: If38ca63ad1328d7b3ea25b6c33661c7d26c904d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 06:48:40 +00:00
Sihua Ma 7b467addea Merge "Replace title of system services with more specific ones" into tm-qpr-dev 2022-12-03 06:26:18 +00:00
Sebastián Franco e8786a176d Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev am: fba141a3dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20611319

Change-Id: Idb38e0a166a18455a2bed40822c0ed8547359b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:43 +00:00
Becky Qiu aa60e3218d Merge "[Toast] Add a new type for AppSearch latency logging." into tm-qpr-dev am: c99da62f6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20614451

Change-Id: I0d4128b310b3db6726c3b8bef6df5235a0ab26d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:30 +00:00
Sebastián Franco c35f52236a Merge "Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0" into tm-qpr-dev am: 9f775cab1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20610916

Change-Id: I636ec04af1eaac8be8793a05e8a44f0bd213afac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:13 +00:00
Sebastián Franco fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00
Becky Qiu c99da62f6f Merge "[Toast] Add a new type for AppSearch latency logging." into tm-qpr-dev 2022-12-03 01:23:33 +00:00
Sebastián Franco 9f775cab1a Merge "Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0" into tm-qpr-dev 2022-12-03 01:18:02 +00:00
Sebastian Franco 5bf936ac16 Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0
Bug: 260984829
Test: atest HomeScreenEditStateImageTest
Change-Id: I4aba76de512aedf5b4c921593fe43099700eb773
2022-12-02 14:05:24 -08:00
Brian Isganitis 658905ee9f Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev am: a5953002d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20579485

Change-Id: I2b9f37784bf89d7249d239b1575c00124c838ac1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 21:53:45 +00:00
Sebastian Franco 2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
Brian Isganitis a5953002d4 Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev 2022-12-02 21:10:55 +00:00
Jon Miranda 9c053594e9 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev am: 01e90b7787
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613321

Change-Id: Id47761c23154fe04e0cb1a5c1e7807ad02c22f1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 19:29:06 +00:00
Jon Miranda 01e90b7787 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev 2022-12-02 18:58:08 +00:00
TreeHugger Robot d48a078c78 Merge "Removing SearchActionItemInfo" into tm-qpr-dev am: cfa199537b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20537169

Change-Id: I8345c99ddf6fd22802f0c4ca0ed8ca56ee263f2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 17:45:52 +00:00
Anushree Ganjam 70460864a4 Merge "Use CopyOnWriteArrayList to avoid ConcurrentModificationException." into tm-qpr-dev am: d7898e6083
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613560

Change-Id: I7be74d469dd98bbe8dede91158cfe44e6cb56252
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 17:44:57 +00:00