6eb5e0892b
Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967
Change-Id: Ic4f1ca2b27cd408963ff33ad7972ec4d1fef5a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-18 09:53:20 +00:00
3c898a7550
Merge "Preload overview after unfold" into udc-qpr-dev
2023-09-18 08:37:56 +00:00
a6f66eeba7
Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312
Change-Id: Ib31bfdd11c5f1c62b1ffcfe24bcdd81fd4903633
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-15 17:24:13 +00:00
8ad9393213
Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev
2023-09-15 17:20:43 +00:00
9b3598f154
Provide bgExecutor for RotationButtonController
...
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread
Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
2023-09-15 10:46:00 -04:00
f6264d2387
Preload overview after unfold
...
Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).
With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.
Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85c9
2023-09-15 11:38:46 +00:00
f3a2082285
Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997
Change-Id: I06df48dda4c77024b9b35127a8eeda9b42080607
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-14 16:51:15 +00:00
15b81093d7
Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev
2023-09-14 16:26:34 +00:00
09b354b232
Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823
Change-Id: I628cb28daa134c58b10a8db6f84f4004ed1ddbf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-14 16:00:42 +00:00
28498d5f6f
Print out debug logging in bug report if not running test.
...
Bug: 300101221
Test: local
Flag: not needed, logging only.
Change-Id: If016d6fe35a1c43e1a1f311d696b9f2ca0f36f6a
2023-09-13 17:24:51 -07:00
a101ac696f
Ensure PauseUIUpdate always ends up getting set to false
...
when result was null but getTaskbarUIController() is not null, we don't setPauseUIUpdate to false. This CL ensure we always end up setting pauseUIUpdate to false so that the hotseat suggested apps show up.
Fix: 295892343
Flag: no flag
Test: verify hotseat icons don't disappear
Change-Id: Id872f3174df276cb7a4ed7f6672523d0851a11dd
2023-09-13 16:56:02 -07:00
a1e8f327ff
Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295
Change-Id: I0066e91a986878debb75663fa68d4f5408af8898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-11 22:57:58 +00:00
733d440ac1
Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev
2023-09-11 21:52:08 +00:00
6472119d4b
Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar
...
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
2023-09-11 09:39:23 -07:00
ad147bbc0d
Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404
Change-Id: I543b44b24c93508776bcc4a7c24a8142a70d698c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-11 16:29:01 +00:00
9e6a845ca4
Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev
2023-09-11 15:30:05 +00:00
294a40b1be
Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784
Change-Id: I87cd79905c5febcd0391d75b9756522ad3d1ba34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-08 16:44:53 +00:00
3289e4fa35
Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev
2023-09-07 23:43:42 +00:00
a62d85752e
Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979
Change-Id: Iae9abea705e1f379cb605ed286de6ee4e6df8168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-07 22:54:25 +00:00
503f04f86d
Register OnAttachStateChangeListener before attaching to container.
...
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).
Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
2023-09-07 19:15:10 +00:00
b33d906d87
Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468
Change-Id: Ifd6ac159f610f6a9a3a0f409778a6084f411949f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-05 18:09:33 +00:00
31679166a7
Merge "Add nullable annotation" into udc-qpr-dev
2023-09-05 16:50:38 +00:00
785a7511b6
Add error handling to prevent IllegalArgumentException
...
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.
Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Merged-In: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
2023-09-05 13:58:42 +00:00
a2c965726e
Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620
Change-Id: I76dcb5ab590f458fdebb2b171e3faf58d7d919f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-02 00:48:43 +00:00
aee84be4b6
Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979
Change-Id: I790f16e73181bd299e9e229401015784588bd245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-02 00:48:15 +00:00
15b0c9ea54
Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev
2023-09-01 23:49:30 +00:00
a6f089c5fc
Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev
2023-09-01 23:46:02 +00:00
0eb2b24d68
Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246
Change-Id: I59ba22e210e592dff73e0a1ac73b6fba4762e610
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-09-01 23:05:41 +00:00
2677e04510
Merge "Update TaskView corner radius dynamically" into udc-qpr-dev
2023-09-01 22:41:18 +00:00
3ca10a1325
Ensure Gesture Nav Edu animation scales to fit different screen sizes
...
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.
Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
2023-08-31 23:08:54 +00:00
5d20ad6500
Update TaskView corner radius dynamically
...
Previously we set the corner radius just once when TaskView is
constructed, but this doesn't work when reusing the TaskView on a
different display that has a different corner radius.
Flag: none
Test: FullScreenDrawParamsTest
Test: kill launcher, open Overview on one display, then switch to
another display with different corner radii and ensure task radii
have updated while quick switching
Fixes: 293224095
Change-Id: I5f0697a4697400ec0e003c116774d74a945ee59e
2023-08-31 22:41:53 +00:00
75d8994e6f
Add nullable annotation
...
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.
bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
2023-08-31 13:59:13 -07:00
e5b09cd7f1
Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev am: dbd47e9f75
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24587641
Change-Id: I350f08b5d09a9f7c17a93529b0a9bfd033e2a04c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-30 23:27:09 +00:00
dbd47e9f75
Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev
2023-08-30 23:06:15 +00:00
976876ec5b
Add tests for LPH override for 3 button mode Taskbar.
...
Override == Launcher handles via AssistUtils instead of SysUI.
Bug: 297561673
Test: TaskbarNavButtonControllerTest + bug bash session
Change-Id: I079d4b9045d6f7d94d74e91bcabbbc182de6e17d
2023-08-30 14:45:18 -07:00
c4cc4b13b1
Remove extraneous transition from Overview to Home screen
...
Previously, users used to be able to swipe down near the
bottom of the screen to leave overview. This was causing the taskbar to
animate to home while still in overview (and causing jank). Since this isn't expected behavior for
how to leave overview, this change removes that method.
Flag: N/A
Fix: 284416178
Test: Completed multiple transitions (ex. Overview to home) with 3
button nav and gesture nav. Ensured swiping down from below the recents
task does not go to the home screen while not affecting other
transitions.
Change-Id: I8cdfde71117dd947174d9c3c3a7f834fbeaddcca
2023-08-30 21:24:45 +00:00
0c93438614
Merge "Fixes search feature invocation issue" into udc-qpr-dev am: 7d793ecdda
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24586848
Change-Id: I9cbd977cd6091f5259fc137541ab9e11f00e5def
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-30 20:10:22 +00:00
0b8c5fa5c7
Fixes search feature invocation issue
...
Fixes: 297866704
Flag: N/A
Test: Manual
Change-Id: I9647504e6c6999ce7aa17ab4acfc65d522dcd2af
2023-08-30 20:16:11 +02:00
f98e3a2bdd
Fixes broken callbacks in RecentsAnimationCallbacks
...
finishRecentsAnimation calls cleanup immediately which removes all the
callbacks. This prevents any callback previousy added from getting
the cancelled callback.
Bug: 298069218
Test: Verified locally
Flag: N/A
Change-Id: I54b9a4529870d771f2eff8fd7cb6f2f376f9e112
2023-08-29 16:16:48 -07:00
53ce6a6656
Merge "Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user" into udc-qpr-dev am: 1757f1b2c0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24575470
Change-Id: I10e3b27190f0770d0bb641137879971514447718
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-29 05:47:00 +00:00
1757f1b2c0
Merge "Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user" into udc-qpr-dev
2023-08-29 05:02:42 +00:00
cde39e3cfd
Merge "Add logs around hotseat suggested apps" into udc-qpr-dev am: 41d269a43b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24529027
Change-Id: If446b69e23e9c7e22e5193c2890eb0fa84de3a38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-28 23:36:32 +00:00
41d269a43b
Merge "Add logs around hotseat suggested apps" into udc-qpr-dev
2023-08-28 23:09:44 +00:00
db248cf94f
Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user
...
* Previously the CUJ was ending after only the launcher side
animation was completing, before we actually made the
call into shell to launch the tasks
Test: Compiles (no baseline to test metrics/latency off of)
Bug: 285578568
Change-Id: I958e4a5265cb2fd81f2358343846385058b4465a
2023-08-28 19:03:39 +00:00
a5e28a3af2
Merge "Specify stage and bounds for desktop split." into udc-qpr-dev am: 8020100928
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24376138
Change-Id: I38e200140074f2f2ee3dd4ffa5068babb1886e96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-25 21:50:24 +00:00
a8c9d7161f
Rename AssistUtilsBase -> AssistUtils am: b2ac210120
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24555400
Change-Id: Idde965260aef41cd3fe662557051ccc92418e8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-25 21:49:54 +00:00
8020100928
Merge "Specify stage and bounds for desktop split." into udc-qpr-dev
2023-08-25 20:50:59 +00:00
b2ac210120
Rename AssistUtilsBase -> AssistUtils
...
Bug: n/a
Test: n/a
Flag: n/a
Change-Id: Ia227b180732d0acfdc4b648885d5ce208d86ee49
2023-08-25 12:12:17 -07:00
dc1b080293
Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev am: dddd60e84f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24446027
Change-Id: If09506013aaf6cfe5249c7948216c6f675cb859d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-25 15:34:29 +00:00
dddd60e84f
Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev
2023-08-25 15:07:56 +00:00
Nicolò Mazzucato
Vinit Nayak
Federico Baron
Becky Qiu
Jagrut Desai
Schneider Victor-tulias
Andy Wickham
Brian Isganitis
Brandon Dayauon
Saumya Prakash
Sunny Goyal
Tony Wickham
Andreas Agvard
Treehugger Robot
Matt Sziklay