Commit Graph

12143 Commits

Author SHA1 Message Date
Winson Chung 6d1dcc2b4e Fix regression in ending recents transition while locked
- Prior to ag/28807475 we would not finish the recents transition
  when ending to home while the device is locked, so we need to
  continue to skip that now.

Flag: EXEMPT bugfix
Bug: 361950809
Bug: 359608026
Test: Lock the device, open camera and swipe up
Change-Id: I66ba065ebd0084ecd51ea803e88e31bf8acbfdcb
2024-08-25 20:45:03 +00:00
Tracy Zhou ee87fb8940 Merge "notifyTaskbarStatus in taskbar phone mode" into main 2024-08-20 22:38:06 +00:00
Mady Mellor c15fe691e7 Merge changes I964d213d,I95085fd1 into main
* changes:
  Make an input consumer for bubble bar
  Include bubbles in the dragged items of taskbar UI controller
2024-08-20 21:34:54 +00:00
Tracy Zhou a54e490eb1 notifyTaskbarStatus in taskbar phone mode
This fixes notification shade not being able to swipe up to the edge during animation because it listens to the task bar visibility signal

Fixes: 352365691
Test: https://b.corp.google.com/issues/352365691#comment28
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I10d6f49d087dd85b3a8bc5894f76f5d46ba4a865
2024-08-20 20:39:41 +00:00
Winson Chung ab06202228 Merge "1/ Remove unused legacy recents paths" into main 2024-08-20 20:02:50 +00:00
Treehugger Robot d064e58ff0 Merge "Handle multithreading in ActiveGestureLog" into main 2024-08-20 17:07:35 +00:00
Treehugger Robot 5f6f4b4342 Merge "Remove manual call to stash takbar from within onTaskbarIconLaunched." into main 2024-08-20 15:51:18 +00:00
Schneider Victor-tulias cb8b3f27d2 Handle multithreading in ActiveGestureLog
ArrayList.add is not thread-safe. Attempting rapid calls across threads is the only way for it to throw ArrayIndexOutOfBoundsException.

Flag: EXEMPT bug fix
Fixes: 360619084
Test: checked TIS logs
Change-Id: I66e5f2e13d5237717abcf42e56efa2942f317676
2024-08-20 11:10:09 -04:00
Liran Binyamin 873fbaaebf Merge "Check bubble count for initial state animation" into main 2024-08-20 14:08:14 +00:00
Treehugger Robot eda0a92d52 Merge "Read task size info from RecentsView directly" into main 2024-08-20 11:46:03 +00:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Jeremy Sim bfb29a2e3f Merge "Add a contentDescription to splitscreen's first staged task" into main 2024-08-20 05:05:50 +00:00
Jeremy Sim 2e59268f3b Add a contentDescription to splitscreen's first staged task
Currently, when we stage the first app in a split, the floatingTaskView has no contentDescription and is announced by screen readers as "unlabeled".

This CL allows FloatingTaskView to copy a contentDescription from the underlying task or ItemInfo when it is created.

Also changes SplitConfigurationOptions#itemInfo to a private field with a public getter for mockito compatibility.

Fixes: 319783133
Test: Confirmed with TalkBack on Overview, contextual and Intent splits
Flag: EXEMPT bugfix
Change-Id: Ia5a95e403bfe8623e17d2ceac9073ef15c7bb476
2024-08-20 03:19:58 +00:00
Jon Miranda 173c218366 Remove manual call to stash takbar from within onTaskbarIconLaunched.
Taskbar does not know if the icon clicked will result in a translucent
activity. After this change, taskbar app stashing logic is now the same
between taskbar and home launches.

We should still stash after split screen, because in the case of
translucent activity the background becomes opaque.

Fixes: 354627538
Test: Pause app in hotseat, go to overview, launch paused app
      note that taskbar does not go away
Flag: EXEMPT bugfix
Change-Id: I3d3ed7a6ca10090c7207b45d0b272dc4fc928e32
2024-08-19 16:41:36 -07:00
Mady Mellor 788a6ebb74 Make an input consumer for bubble bar
Instead of unstashing bubble bar in TaskbarUnstashInputConsumer
handle it in its own input consumer instead. This is a nicer
separation of concerns and simplifies the logic in both places.

Additionally, this fixes issues where swiping up the bubble bar
handle might initiate / be handled by gesture nav (or all apps) when
really any events originating on bubble UI should be managed by
bubbles instead.

Adds some mostly mock'd tests to check that the static method used
to indicate if bubbles should take the event or not works correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - test swipe up on bubble bar handle in an app
             - test swipe up on bubble bar on home - it should
               open & all apps / launcher transition shouldn't happen
             - longpress to drag bubbles around on home and overview,
               try the collapsed bar & individual bubbles in the
               expanded bar
             - test dragging on the bubble bar after it's revealed
               in an app
Test: atest BubbleBarInputConsumerTest
Bug: 345488529
Change-Id: I964d213d71de15e4350cff5202dfb9343de1af14
2024-08-19 15:26:37 -07:00
Winson Chung 69062b75b6 1/ Remove unused legacy recents paths
- We no longer support the legacy recents animation cancel path
  (it was already a no-op)
- Use the shell recents transition path instead of the legacy recents
  animation for remaining use cases

Flag: EXEMPT cleaning up unused code
Bug: 359608026
Test: Test both kb shortcut and desktop split invocation paths
Change-Id: I2726d52b3b4f3533afc4286b155c71eadcb57909
2024-08-19 20:28:51 +00:00
Alex Chau d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Mady Mellor d22a0b84cb Include bubbles in the dragged items of taskbar UI controller
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - test dragging bubbles with the other CL
Bug: 345488529
Change-Id: I95085fd18f2710cd36a2d47640641da047aa48c7
2024-08-19 09:52:57 -07:00
Winson Chung cafe06f63d Merge "Detach the nav bar from the app when going home" into main 2024-08-16 22:42:44 +00:00
Mykola Podolian 3bae9ff981 Merge "Fixed issue when hotseat icons are not touchable" into main 2024-08-16 22:26:56 +00:00
mpodolian 9367722dbc Fixed issue when hotseat icons are not touchable
The issue existed because of taskbar insets where set to the full height
of bubble and task bars. Added check that only adds bars touch area if
the user is currently not on the launcher home screen. Commented failing
tests.

Bug: 358301278
Bug: 359277238
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual.
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hcgYuHUJwfbhlvPRsvdWYf
The touch area is within the red rectangle.

Change-Id: I3c2ad3633a049972b93fe5c5e45efd557c220e1f
2024-08-16 13:00:03 -07:00
Luca Zuccarini 0ad76ac07d Merge "Move some Shell utils to the Shared package." into main 2024-08-16 16:32:37 +00:00
Pat Manning 0c6e17020d Merge "Show and hide taskbar tooltips immediately." into main 2024-08-16 14:45:10 +00:00
Winson Chung 5db6d3dd8e Detach the nav bar from the app when going home
- Nothing currently detaches the nav bar from the app until the recents
  animation completes if onAnimationStart() happens after the end
  target is set

Flag: EXEMPT bugfix
Fixes: 343457097
Test: Artificially introduce delayed onRecentsAnimationStart and verify
      detachNavFromApp is called
Change-Id: I1ec0d8821d61f9fad9a811d6a12ce21e8417252f
2024-08-16 00:27:31 +00:00
Pat Manning b488c88fa3 Show and hide taskbar tooltips immediately.
Fix: 356352494
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ie7dc1f341cf059bb38f61fa185152cb2555e36b1
2024-08-15 17:59:59 +01:00
Treehugger Robot 1d94ee8627 Merge "If we're adding / removing a bubble, don't forget to add the overflow" into main 2024-08-15 16:49:46 +00:00
Treehugger Robot 3ed6885901 Merge "Fix launch animation issue for Desktop tile" into main 2024-08-15 12:17:58 +00:00
Liran Binyamin 246837aa59 Merge "Don't reset alpha after dragging to dismiss" into main 2024-08-15 08:03:13 +00:00
Tracy Zhou 9944b989d6 Merge "Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions" into main 2024-08-15 04:56:41 +00:00
Treehugger Robot 9df623644a Merge "Register the bubble listener after everything has been initialized" into main 2024-08-15 01:51:24 +00:00
Tracy Zhou a51ee6a4dc Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions
Somehow deviceProfile.isGestureMode doesn't have the right signal for tests.

We need to look into why dp doesn't have the right signal for isGestureMode in tests. Temporary fix here to unblock pushing the flag to staging

Bug: 359196354
Test: https://android-build.corp.google.com/builds/abtd/run/L05600030005823769
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie6451812cf4b0c3f034cabdfd4cec726322af0bc
2024-08-15 01:49:40 +00:00
Mady Mellor a7f2d83b61 If we're adding / removing a bubble, don't forget to add the overflow
One case I missed was a bubble being added/removed AND the overflow
showing... this isn't the nicest, but when the add/remove animation
is done, animate the overflow in.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 358304168
Test: manual - don't have the overflow showing, add a 6th bubble,
               observe that the overflow appears
Change-Id: I1a9cec3970f5535e935f3404fa6dbd6de2f69fa5
2024-08-14 16:23:07 -07:00
Mady Mellor 173ac574d8 Register the bubble listener after everything has been initialized
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in bubble bar, switch between transient
               taskbar and pinned taskbar repeatedly.
Bug: 359096619
Change-Id: I02beacff64b12380ee6d134b7dcc64cfd27e4b0b
2024-08-14 15:22:21 -07:00
Alex Chau 4bb08df3dc Fix launch animation issue for Desktop tile
- See http://go/b320307512_problems for details
- Adding the following to DesktopTaskView's launch animation
  - Problem 1: Animate away DesktopTaskView's background according to fullscreenProgress, instead of a jump cut
  - Problem 2: Animate Overview's background to transparent to reveal the wallpaper behind
  - Problem 3: Animate wallpaper's zoom back to 1
- Problem 4: Apply TaskRectTransltion in TaskViewSimualtor for DesktopTaksView as well, which is used to account for TaskView not in center.
- Problem 4: Also applied RecentsView zoom in animation when TaskView is not in center, to make the whole DesktopTaskView container (backgroundView) moves as a whole. This requires calculating a new pivot before applying the zoom.
- Problem 5: When swipe down or quick switch from home into Desktop, run DesktopRecentsTransitionController without animation to put everything in the end state immediately to avoid animating again
- Problem 6: For swipe down animation, we now let createAdjacentPageAnimForTaskLaunch handle the wallpaper zoom and splash alpha, instead of doubling the effort. In case of Desktop, wallpaper depth be aniamted to 0 (no zoom/blur)
- Problem 6: Bring Desktop live tile to front during swipe down to avoid wallpaper blur applying to the desktop
- Problem 7 and 8: Crop out desktop window outside full screen bound. This is done by calulating intersection between full screen Rect and desktop window's Rect
- Problem 8: Make swipe down to use thumbnailBounds instead of bounds of the first snapshotView, this fixes all situations that first snapshotView's height is different from TaskView (e.g. vertical split, DesktopTaskView)
- Problem 9: Desktop remote target's alpha should remain 1

Bug: 320307512
Test: TaplTestsOverviewDesktop, motion fixes are tested manually
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Iae6e594424dfc89851b4f7179b0fb5b5ac5e7f46
Signed-off-by: Alex Chau <alexchau@google.com>
2024-08-14 17:31:59 +01:00
Liran Binyamin afdad57bdf Don't reset alpha after dragging to dismiss
After dragging the bubble bar to dismiss, don't reset its alpha
value.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359804931
Test: manual
      - Create a bubble in the bubble bar
      - Drag bubble bar to dismiss
      - Create another bubble
      - Observe the new bubble does not flicker
Change-Id: I8d56f71d38ec33acda8efade50735b59254d77d4
2024-08-14 08:08:40 -04:00
Liran Binyamin 229696a0e4 Check bubble count for initial state animation
With optional overflow, we need to check for actual bubble count
before animating the bubble bar to its initial state.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359403793
Test: manual
       - create first bubble on home
       - observe bubble bar animates correctly to initial state
       - add second bubble
       - observe bubble bar bounces correctly and does not slide
         in from the bottom of the screen
Change-Id: I53a34bc00b24e8a6504bcca0532054755554b9ac
2024-08-14 03:47:35 -04:00
Saumya Prakash eb950c1f44 Disable split screen option in app menu in Desktop Mode
The split screen app shortcut is not intended to work in Desktop Mode.
This change removes it from Taskbar and all apps in this mode to avoid
a crash.

Fix: 346333758
Test: Launch the app menu for different apps in Desktop mode and in
normal mode. Check that the split option only shows up in normal mode.
Flag: EXEMPT bugfix

Change-Id: I6e2535b41a490ad3eb5c0ebd924c49eaf5028669
2024-08-13 22:22:19 +00:00
Vinay Joglekar cd53b74000 Merge "Announce “Desktop” when focusing on the desktop mode in Overview" into main 2024-08-13 16:24:27 +00:00
vinayjoglekar 95e590229a Announce “Desktop” when focusing on the desktop mode in Overview
https://drive.google.com/file/d/1MNUyDtRhyU8tKRZ5JONLAeUBQ_8Vrids/view?usp=drive_link

Test: NA
BUG: 329375034
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I36460002be94697746fb085e4aeca9a6ac804002
2024-08-13 13:16:10 +00:00
Helen Cheuk 801f86ecac Merge "[Contextual Edu] Enable updating Edu data in Launcher" into main 2024-08-13 12:52:02 +00:00
Kai Li d5b25b8e8e Merge "Add a parameter to requestAssistDataForTask to allow fetching the structure." into main 2024-08-13 11:46:15 +00:00
Uwais Ashraf d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Tracy Zhou c632ae351d Disable 2-finger swipe from home to pull down notifications
Bug: 356804470
Test: manual
Flag: EXEMPT bugfix
Change-Id: I612e3c7ac7cd0db2fe2dbb142f0271c07ffdda3b
2024-08-12 21:28:17 -07:00
Treehugger Robot e3165184f6 Merge "Revert "Synchronize the app launch and taskbar stash animations."" into main 2024-08-13 02:19:52 +00:00
Jon Miranda 50a7279ae6 Revert "Synchronize the app launch and taskbar stash animations."
This reverts commit cde962dcb7.

Fixes: 355666644
Reason for revert: Memory leak b/355666644

Change-Id: I2eee00d2d8d65e1e1805ad76fafc7caab8626715
2024-08-13 00:41:01 +00:00
Ben Lin d924a99dd6 Merge "Check for leftTopTask and rightBottomTask in KQS." into main 2024-08-12 22:24:45 +00:00
Ben Lin fd9056cab4 Check for leftTopTask and rightBottomTask in KQS.
KQS currently always take the GroupTask's taskId1 and taskId2 as
leftTop/rightBottom, in that order. However, sometimes it is possible
that the order is flipped; RecentTasksController#getRecentTasks return a
list of tasks base on recency, and it is possible that when it
initializes a new GroupTask, it put leftBottom as task2 and vice versa,
completely dependent on how they are processed. This CL uses
GroupTask#mSplitBounds as the source of truth to see

1) Which leftTop/rightBottom to draw for the thumbnail and
2) Which task is leftTop, which task is rightBottom, for re-launching

Bug: 328691131
Test: Manually; using KQS, no longer see the app in the wrong places
Flag: EXEMPT bugfix
Change-Id: I14b3becb05359a917372ec2d7d80d32190f0f96b
2024-08-12 13:33:35 -07:00
Uwais Ashraf 60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Vinay Joglekar fee62395a2 Merge "Update desktop icon/app Chip with the new icon" into main 2024-08-12 09:03:14 +00:00
Liran Binyamin de9b1df642 Merge "Remove BubbleBarView.mIsAnimatingNewBubble" into main 2024-08-11 08:25:29 +00:00