Commit Graph

14732 Commits

Author SHA1 Message Date
Merissa Mitchell 6ce6bd6328 Merge "[Pip2] Use PipFlags#isPip2ExperimentEnabled in Launcher" into main 2025-05-07 14:12:10 -07:00
Matthew Mourgos c67c038ec3 Merge "Fix freeform tasks not animating on overview button press." into main 2025-05-07 13:20:05 -07:00
Treehugger Robot 879abdab2a Merge "Fix quick switch state during battery saver" into main 2025-05-07 13:10:55 -07:00
Treehugger Robot adde4dd42a Merge "External displays should always be in 3-button nav mode" into main 2025-05-07 12:15:46 -07:00
Thu-Huong Vu 486436b704 Merge "[Growth] Add nudge proto." into main 2025-05-07 11:36:13 -07:00
Treehugger Robot 7d0ea7ed6b Merge "Enable overview for connected display as developer option" into main 2025-05-07 11:15:20 -07:00
vinayjoglekar ea75586c0a Fix quick switch state during battery saver
During quick switch we will always need to have background Transparent for consistency.
Previous implementation of Quick switch state was inconsistent. Hence making quick switch state return always transparent.

Bug: 416217645
Test: Quick switch between apps.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I561dd6509bbadbbdc751308740d8152bcb0c4032
2025-05-07 18:26:23 +01:00
Will Osborn f0ed143ab7 External displays should always be in 3-button nav mode
Also changed TouchInteractionService gestureNavMode to be per-display

Bug: 415269541
Flag: EXEMPT bugfix
Test: local + presubmit

Change-Id: I0da978e6fcb29f743b41f1c75c6d0efd8e7231a8
2025-05-07 16:25:49 +00:00
Treehugger Robot 2e6fc30b12 Merge "Use supplied context instead of system for taskbar" into main 2025-05-07 09:09:26 -07:00
Pierre Barbier de Reuille 296a74b880 Enable overview for connected display as developer option
Bug: 407954908
Test: manual
Flag: EXEMPT (flag infra)
Change-Id: Iebc0f1be080026097e3fb450cc9f74d6bba8f834
2025-05-07 08:42:25 -07:00
Steven Ng c488852c2c Merge "Don't show phantom animation when switching app in connected display oveview" into main 2025-05-07 02:53:52 -07:00
Treehugger Robot 9d6ecdda8e Merge "Cleanup flag" into main 2025-05-07 02:22:31 -07:00
Treehugger Robot 344bee4ae0 Merge "Moving PredictionHelper to kotlin" into main 2025-05-06 19:45:06 -07:00
Thu-Huong Vu 3c8c04c1b1 [Growth] Add nudge proto.
Keep these file in synch with the nudge proto definition in //depot/google3/java/com/google/android/desktop/growth/proto.

Bug: 416054612
Test: EXEMPT add in the follow up CL
Flag: EXEMPT add separately

Change-Id: I5fe6ae7b3cb285bd1c07fd4ff54b273799ec0d98
2025-05-06 17:06:06 -07:00
Ajinkya Chalke 5212ce06f9 Use supplied context instead of system for taskbar
- Use supplied TaskbarActivityContext to evaluate padding in dp instead
  of Resources.getSystem that doesn't seem to provide accurate
  measurement when launcher is initialising.

Fix: 414343355
Test: m
Flag: EXEMPT minor refactor
Change-Id: Ia64a7280ba60534fc949269c5886e9b32a917e03
2025-05-06 23:28:29 +00:00
Merissa Mitchell bea2e7ca6c [Pip2] Use PipFlags#isPip2ExperimentEnabled in Launcher
instead of checking Flags#enablePip2 directly

Bug: 409622499
Test: m
Flag: com.android.wm.shell.enable_pip2
Change-Id: I4892d6590403202737e40d21c6d215c1adc7b47e
2025-05-06 15:42:12 -07:00
Vinit Nayak 208b999445 Merge "Disable taskbar nav buttons when split layout animations are running" into main 2025-05-06 12:25:24 -07:00
Steven Ng 3f9fa4e2db Don't show phantom animation when switching app in connected display oveview
In TaskViewUtils, the StateManager#movetoRestState method is invoked after the recents animation finishes and before the launcher state is reapplied. The issue leading to a phantom transition is that moveToRestState initiates an animation due to RecentsWindowManager#shouldAnimateStateChange always returns true.
Connected display overview is similar to 3P recents. And thus, we follow RecentsActivity#shouldAnimateStateChange to always return false.

Test: manually click on a overview tile in the connected display. No phantom animation is observed after switching to the app.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 415245440
Change-Id: I3c9600cae6ce9058749365734f433f5e3cdb9445
2025-05-06 17:56:01 +00:00
Sunny Goyal 02a41c7e5c Moving PredictionHelper to kotlin
Bug: 390572144
Flag: EXEMPT refactor
Test: atest PredictionHelperTest
Change-Id: If94ae62d7e1412e6760423cf8ab43acba236c3e9
2025-05-06 10:49:30 -07:00
Sunny Goyal 53cc9a7806 Merge "Moving predicted items to ItemIdMap instead of extraItems" into main 2025-05-06 10:29:39 -07:00
Matthew Mourgos 26ca4a18b1 Fix freeform tasks not animating on overview button press.
When the home screen is shown behind desktop mode, pressing the overview button to start a transition should still animate tasks shown on top of home screen. To ensure that freeform tasks are animated, the home screen should not be considered visible when performing transitions in this case. Therefore, make getVisibleLauncher() return null, so that switchToRecentsIfVisible() doesn't animate launcher to overview without animating the freeform tasks at the same time.

Bug: 375644149
Flag: com.android.window.flags.show_home_behind_desktop
Test: Open a window, press overview button. With no windows open, press
overview button.

Change-Id: I9b1d72e35071c5b446b98a8e6c6695ff5c666222
2025-05-06 08:17:48 -07:00
Sam Cackett 4fe1a9861b Cleanup flag
Remove com.android.launcher3
 .enable_show_enabled_shortcuts_in_accessibility_menu flag and
 references from the codebase

Fix: 415679751
Flag: EXEMPT. Cleanup
Test: OverviewMenuImageTest
Change-Id: I3a7b58b7c3fe4c6c3a5750fd1e851909630e80ff
2025-05-06 12:23:54 +01:00
Steven Ng a5bc3c5677 Merge "Use grantManageKeyGesturesToRecents flag for granting recents key gesture events" into main 2025-05-06 04:22:26 -07:00
Treehugger Robot d7802c985c Merge "Limit LauncherTaskbarUIController to primary" into main 2025-05-06 02:55:48 -07:00
Treehugger Robot f2fff33546 Merge "Adds gpuLoadUp calls for Launcher blur preparation." into main 2025-05-05 20:45:01 -07:00
Li Lin 7c91724c2c Merge "Remove URL from image model." into main 2025-05-05 17:07:18 -07:00
Sunny Goyal aef6c7932e Moving predicted items to ItemIdMap instead of extraItems
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s

Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
2025-05-05 15:52:37 -07:00
Treehugger Robot 237e594dd0 Merge "Return to BackgroundAppState when tapping gesture region in desktop" into main 2025-05-05 15:31:18 -07:00
Vinit Nayak e184a22786 Disable taskbar nav buttons when split layout animations are running
* There are race conditions and weird breakages when
we try to go to home/recents while split apps are being
animated so we disable for now.

Test: Manual
Bug: 391894192
Flag: EXEMPT bugfix
Change-Id: I0350a5124d72fab9d98f81d6ab5369bd790c16b1
2025-05-05 17:23:31 -04:00
Andy Wickham 1d8676a965 Adds gpuLoadUp calls for Launcher blur preparation.
Basically the same places we were notifying expensive frames.

Test: forrest perf suites
Flag: com.android.launcher3.all_apps_blur
Bug: 410973453
Change-Id: Ifb8ee7010e0faacc9ccc21076fc8614f335e2863
2025-05-05 19:46:49 +00:00
Daniel Andersson cf29edfa2f Merge "desktop-exploded-view: Fix broken live tile when activating desk" into main 2025-05-05 12:46:01 -07:00
Fengjiang Li bccc1a8fa1 Merge "[Memory Leak] Fix leak of TIS from taskbar's pending intent" into main 2025-05-05 12:41:09 -07:00
Fengjiang Li a6c437c42f [Memory Leak] Fix leak of TIS from taskbar's pending intent
Fix: 415321479
Flag: NONE - released code
Test: manual
Change-Id: I70e2201695cb3e8501315a5ae8fd86b150d57c35
2025-05-05 09:26:55 -07:00
Schneider Victor-tulias a8053f8cba Merge "Support the gesture nav contract for recents in window" into main 2025-05-03 20:02:30 -07:00
Treehugger Robot af24c515c9 Merge "Fix taskbar visibility for desk->desk in Overview" into main 2025-05-02 22:02:38 -07:00
Treehugger Robot 51c9c19e89 Merge "Remove RecentTasksList implement of DesktopVisibilityController" into main 2025-05-02 18:26:06 -07:00
Treehugger Robot 418a8e4aa9 Merge "Update All Apps divider color." into main 2025-05-02 17:43:28 -07:00
Andy Wickham 34fba0fcb7 Merge "Ensure an opaque scrim is used for legacy all apps." into main 2025-05-02 16:39:53 -07:00
Treehugger Robot 1a597d619b Merge "Remove IME-specific touch passthrough for Taskbar" into main 2025-05-02 14:42:04 -07:00
Liran Binyamin 00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Ats Jenk e2c8c68edb Merge "Make sure animation is cancelled for existing flyout" into main 2025-05-02 14:22:24 -07:00
Andy Wickham 4efae39779 Ensure an opaque scrim is used for legacy all apps.
When there's no background panel, we should ensure an opaque
background scrim is used.

Fix: 414718408
Test: Manual with all_apps_blur and all_apps_sheet_for_handheld off.
Flag: EXEMPT bugfix
Change-Id: I1ac9f5f8fbb01f2c6a42e9f79823b5f293ebf709
2025-05-02 13:49:51 -07:00
Tony Wickham f7772b88af Return to BackgroundAppState when tapping gesture region in desktop
If the end target is null, that means the gesture did not move
enough to calculate an actual end target, and LAST_TASK is the
default for that case. We probably don't need the desktop check
specifically (could clean it up in a follow up) but since this
bug is specifically for Desktop mode I left it in for now.

Fixes: 359879541
Test: manual, tap Taskbar in Desktop and ensure no flicker
Flag: EXEMPT bugfix

Change-Id: Icc3e645819a22ed96d07a575cdccda30a5d800c1
2025-05-02 20:19:03 +00:00
Treehugger Robot 7a2d5b454f Merge "Add magnetic detach to task dismiss using MotionValue library." into main 2025-05-02 12:34:47 -07:00
Schneider Victor-Tulias 9118d87d84 Support the gesture nav contract for recents in window
- Support for the GNC allows for some additional animations and clean up. The missing clean up was causing test failures
- Also fixing broken GNC support for split apps. Swiping up from split apps caused consistent crashes, however since the current 1P swipe to home has no special animation, updating the recents window and 3P GNC to match this.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit; swipe home from 1P and 3P launcher
Change-Id: Idf24d7969e76a50ff656f6644c2b568c42e409d7
2025-05-02 15:32:51 -04:00
Treehugger Robot 21779a4192 Merge "Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused" into main 2025-05-02 11:46:48 -07:00
Suhua Lei 69ba07f2cf Fix taskbar visibility for desk->desk in Overview
Bug: 413192207
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: switch between desks in Overview
Change-Id: I49806fe2b0790b1bccbac04625d7ee553c7ab3eb
2025-05-02 11:27:48 -07:00
Daniel Andersson 05fdc49ef7 desktop-exploded-view: Fix broken live tile when activating desk
- Apply scrollOffset directly to tvs.recentsViewCroll, which already take orientationHandler into account
- Apply gridTranslationY directly to taskSecondaryTranslation, which already take orientationHandler into account
- This make sure both translations are applied after mTaskRectTransform
- Also re-calculate tvs task size after updating orientationState rotations, as the orientationHandler might be changed and affect task position
- Remove setTaskRectTranslation that is no longer used

Flag: EXEMPT bugfix
Test: manual with central/side task launching with portrait, fake landscape and 3p launcher
Bug: 410628946
Change-Id: I8ef38d193328e8a449594515403c00f517e213b3
2025-05-02 11:10:52 -07:00
Xiaoqian (Daisy) Dai 276e0be2a4 Merge "desktop-exploded-view: temporarily disable the functionality..." into main 2025-05-02 10:55:42 -07:00
Pat Manning d2f050ab26 Add magnetic detach to task dismiss using MotionValue library.
Fix: 389081766
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I77f980f9851f4b1c041cbf3bb7247b972c1730fd
2025-05-02 17:13:57 +01:00