Commit Graph

1182 Commits

Author SHA1 Message Date
Treehugger Robot 5684d23331 Merge "Don't expect another task to become focused when dismissing Desktop task" into main 2025-01-21 20:33:31 -08:00
Vinit Nayak e7753eb796 Merge "Remove and cleanup AppPairs flag" into main 2025-01-21 12:20:55 -08:00
Alex Chau 341330bacd Don't expect another task to become focused when dismissing Desktop task
- Don't consider Dekstop task as focused in TAPL
- Renamed variables in dismissTasks_whenDesktopTask_IsInTheCenter as there isn't always a focused task

Fix: 391354508
Test: TaplTestsOverviewDesktop#dismissTasks_whenDesktopTask_IsInTheCenter
Flag: EXEMPT BUG_FIX
Change-Id: Iadc0cf81f37d537837e565e233d11c4148cf3045
2025-01-21 17:58:58 +00:00
Liran Binyamin e96bd71f50 Merge "Pass the user id for intent app bubbles" into main 2025-01-17 12:29:50 -08:00
Vinit Nayak 3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Liran Binyamin 96dc022401 Pass the user id for intent app bubbles
When creating a new app bubble by long pressing on launcher icons,
pass the user id to wm shell so the bubble is created for the correct
user context.

Bug: 361173339
Flag: com.android.wm.shell.enable_bubble_anything
Test: atest BubbleAnythingTest
Test: manual
       - create work profile
       - long press on a work profile app icon -> Bubble
       - observe new bubble opens in the work profile context
Change-Id: Idb980bc6f74e85e85a9777f0d39e772b84feeb9c
2025-01-15 21:35:54 -05:00
Uwais Ashraf 5b13bb4adb Cleanup enableUseTopVisibleActivityForExcludeFromRecentTask flag
Fix: 342627272
Flag: com.android.launcher3.enable_use_top_visible_activity_for_exclude_from_recent_task
Test: TaplTestsQuickstep
Change-Id: I3217869ec6f9c623c55c2504607b386020da7292
2025-01-15 04:07:56 -08:00
Schneider Victor-Tulias 878b2af8ea Update recents states sent to tests by RecentsWindowManager
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 382527932
Test: Tapl tests
Change-Id: I1e802e6787570e781d59e61cf03ce62c8a1edb47
2025-01-07 10:41:17 -05:00
Sunny Goyal a39a09ba6a Replacing custom parcelables with platform types for test APIs
Bug: 377772352
Flag: EXEMPT test only
Test: Presubmit
Change-Id: Ie464c67adf6502aee1fe65ef643e1a67260b820f
2024-12-26 17:19:15 -08:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Treehugger Robot 8a0d3fd363 Merge "Test KQS gets dismissed in certain situations" into main 2024-11-13 23:26:46 +00:00
Toni Barzic 121f6880dd Test KQS gets dismissed in certain situations
Adds tests that verify the KQS gets properly dismissed when user swipes
home while Keyboard Quick Switch UI is shown.

Bug: None

Test: atest TaplTestsKeyboardQuickSwitch
Flag: EXEMPT tests
Change-Id: I6da053f297eedb297c0d40a7414883fbd69b94e5
2024-11-13 21:28:21 +00:00
Shamali P 290fa07cc0 Update tapl test to consider the show all button
TAPL tests seem to be using system image with old PCC app and enables
airplane mode. So, it is likely filters won't load doesn't show, but
tried to create a cuttlefish image to test cover both cases, so that
if it shows, test knows how to handle it.

tapl demo:
http://screencast/cast/NTQ5ODkyNjUxNjkyODUxMnxlZmMyNzNjZS1hYQ

Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I19b121e3ce27221cb5195a2e55f686635d775590
2024-11-12 22:33:39 +00:00
Jordan Silva f048c99de4 Add OverviewDesktop test to verify carousel behavior on swipe up
This CL updates a test to verify the behaviour while swiping up from a fullscreen app to Overview and checking if that TaskView is between DesktopTasks (right side) and Grid Tasks (left side).
The test adds the following validations:
- Launches adjacent task while DesktopTask is at the center of the screen
- Swipe up from a fullscreen app to Overview to validate whether the task is between other tasks and desktop tasks.
- Fling back to DesktopTask to dismiss the adjacent focused task

Fix: 353948167
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Iaa15d4061c3b6ba8fc0d03416b4721cdf3f047c3
2024-11-06 13:58:41 +00:00
Sam Cackett 1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
Sunny Goyal 43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Jagrut Desai 85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Sukesh Ram e297bc0c0e Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 326908466
Test: Manual
Change-Id: I01dadc884929a8946f408997ddbcbd0ac4c820ec
2024-09-26 19:44:55 +00:00
Schneider Victor-tulias b3983db5e4 Merge "Update goToOverviewUnchecked to account for desktop task visiblity" into main 2024-09-24 19:31:43 +00:00
Schneider Victor-Tulias 38deee2508 Update goToOverviewUnchecked to account for desktop task visiblity
Flag: com.android.launcher3.enable_desktop_task_alpha_animation
Fixes: 367646122
Test: SwitchToOverviewFromDesktopTest#switchToOverview
Change-Id: I600dfcd8507d2e24f5bfccf78164b6eec3ec80b1
2024-09-24 10:47:38 -04:00
Vaibhav Devmurari 21f06911aa Fix NumberFormatException in LauncherTests
If the key event flags contain 0x80000000 then it causes number
format exception during parsing to Integer

Bug: 358569822
Test: atest NexusLauncherTests
Flag: EXEMPT TEST_ONLY
Change-Id: I6371ab7b9d5d5e356d7199830543177daeda3eea
2024-09-19 13:17:50 +00:00
Treehugger Robot d60904d573 Merge "Add perfetto traces to LauncherInstrumentation" into main 2024-09-17 17:12:21 +00:00
Treehugger Robot 545440327d Merge "Update out-of-date TODO comment" into main 2024-09-17 16:25:49 +00:00
Schneider Victor-Tulias 0a815eae39 Update out-of-date TODO comment
These TODO comments will be adressed by b/342627272, so b/326565120 should be closed.

Flag: EXEMPT comment update
Bug: 326565120
Bug: 342627272
Test: none needed, comment update
Change-Id: I75637e1494a1abba5c542a292a8a1e8881cbedfc
2024-09-17 10:13:16 -04:00
Nicolo' Mazzucato 2e3d304273 Add perfetto traces to LauncherInstrumentation
This will help understanding what's taking time in those tests, and optimize the runtime to add more perfromance tests to presubmits.

Bug: 332823157
Test: perfetto trace
Flag: NONE adding traces
Change-Id: I806c2cd103ff58a4467e48b3da5e95f7f51743f3
2024-09-17 08:06:38 +00:00
Mykola Podolian 5feb4a969a Merge "Fix falling tapl tests" into main 2024-09-09 17:19:12 +00:00
Nick Chameyev 02cc26f055 Merge "Capture Launcher icon positions by reusing UiObject2" into main 2024-09-09 10:43:10 +00:00
mpodolian 39383dd5b3 Fix falling tapl tests
Fix the root cause of falling tests.

Bug: 359277238
Flag: TEST_ONLY
Test: TaplTestsQuickstep,TaplTestPersistentTaskbar
Change-Id: I1e3138e26d0ab253dff7a64cbb3253c220a7db1a
2024-09-07 09:13:53 -07:00
Nick Chameyev 11c0ebcd57 Capture Launcher icon positions by reusing UiObject2
Reuse the same UiObject2/HomeAppIcon objects
when capturing Launcher icon positions.

When invoking 'launcher.workspace.allWorkspaceIcons'
we wait for the animation to finish which makes
the test fail as we expect to capture icon positions
midway through the animation.

Test: atest LauncherFoldAnimationTest
Bug: 315163608
Bug: 296991492
Flag: EXEMPT bugfix
Change-Id: I668d15165e4c777b3be24d66ad3f7888eaca2fea
2024-09-06 14:13:36 +00:00
vinayjoglekar 3359fa7f32 Fix talkback in split mode
1. Announce description of both snapshot in GroupedTaskView.
2. Announce them in correct order.

After setting right content description for both the apps in split mode, announcement order was reverse. Seems that order of the node tree which android sees was wrong. Also order did not change even in RTL mode.

see here https://paste.googleplex.com/6492038621298688.

The correct order is manually set using addChildrenForAccessibility in GroupedTaskView. (similarly being used in RecentsView since we use reverse order for overview). Also considered RTL.
See order after fix here
https://paste.googleplex.com/6492038621298688

https://drive.google.com/file/d/1BA1YKkcNsovEu4us9cvq5xOdXviTR1OV/view?usp=drive_link

Other alternatives tried were fixing order using android:accessibilityTraversalAfter and android:accessibilityTraversalBefore, both in layout and programatically which doesn't seem to work.

Test: Manual - Using Node tree debugging of talkback developer options.(Print and filter by tag TreeDebug)
BUG: 330424779
Flag: EXEMPT bugfix
Change-Id: If3c360277bd951d2d2b223bab7844e078e9c7d27
2024-09-03 15:22:30 +01:00
Alex Chau fdbfd3410b Clean-up debug logs
Fix: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ie66a34134881e4333f610d8979b2ac443d54a1cb
2024-08-20 19:01:19 +01:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Alex Chau d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Alex Chau 1ceac5ddfe Implement e2e test for desktop windowing
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct

Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit

TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem

Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
2024-08-08 10:37:40 +01:00
Treehugger Robot 6a8f5ecced Merge "Revert "Add debug logs to BaseOverview#isActionsViewVisible"" into main 2024-07-30 17:07:14 +00:00
Schneider Victor-tulias 533e1d2753 Revert "Add debug logs to BaseOverview#isActionsViewVisible"
This reverts commit 11eaec69f4.

Reason for revert: debug logs no longer needed

Change-Id: If0b2f33c63c86483e4d28df79086e80103fdb001
2024-07-30 14:44:46 +00:00
Tracy Zhou 8a4213b786 Fix tapl test failures from enabling task bar on the phones
https://android-build.corp.google.com/test_investigate/?invocationId=I33800010300127205&testResultId=TR49729385401905444

Bug: 355971327
Test: run tapl tests
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Iab463b0a439efd3e707384ca4c6588a1de28d7b9
2024-07-28 10:18:19 -07:00
Johannes Gallmann 35f77be929 Merge "Fix onUserInteraction not called with 3-button-nav and enableOnBackInvokedCallback=true" into main 2024-07-19 09:46:51 +00:00
Andrew Cole 940917b92e Merge "Test Week - Deleting NexusTestInformationHandler" into main 2024-07-17 22:33:47 +00:00
Treehugger Robot 5d4587f04d Merge "Update comment to remove todo" into main 2024-07-17 20:28:05 +00:00
Winson Chung abdbc75801 Update comment to remove todo
Fixes: 197326121
Flag: EXEMPT bugfix
Test: N/a
Change-Id: I66c07a29dda128e14a0e6ff1755546bbda48ba55
2024-07-17 18:50:44 +00:00
Jagrut Desai 6276f1797b Remove getWorkspaceIconsPositions()
This cl addresses
	- removing of getWorkspaceIconsPositions()
	- addition of getWorkspaceIconPosition()

getWorkspaceIconsPositions() was not reliable as it was getting any icon selector and not actually waiting for the icon of intereset.
now we wait for specific icon of interest and tests are change accordingly.

Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY

Change-Id: Ia65b9d51520763a7fbbb8d5cd3bc129496e443cc
2024-07-16 13:48:27 -07:00
Andrew Cole d798e6d1f9 Test Week - Deleting NexusTestInformationHandler
NexusTestInformationHandler only relied on one boolean switch that is not currently used so I am deleting it.

Bug: 353303621
Test: TAPL
Flag: TEST_ONLY
Change-Id: I6181d47561b318d1eb1bd632d4ae042e126cfdb9
2024-07-15 11:57:47 -07:00
Johannes Gallmann 82f7b5ad44 Fix onUserInteraction not called with 3-button-nav and enableOnBackInvokedCallback=true
We should ignore KeyEvents with the FLAG_CANCELED flag in log analysis for Launcher tests as these KeyEvents should not have any effect.

Bug: 346943119
Flag: com.android.window.flags.predictive_back_system_anims
Test: atest BackNavigationTests
Test: atest OnBackInvokedCallbackGestureTest
Test: Manual, i.e. verifying in a test app that onUserInteraction is called when pressing back key in 3-button-nav and when enableOnBackInvokedCallback=true
Change-Id: Icff47009757c49cdd8998244dd3e9459cc6ee085
2024-07-11 08:25:13 +00:00
Anushree Ganjam c8ecd62615 Merge "Use BySelector to search for text in search results." into main 2024-06-14 01:46:13 +00:00
Anushree Ganjam 4d404d9f8b Use BySelector to search for text in search results.
Verify the text after it's collected. I ran the test 20 times and
couldn't find the stale object exception being thrown.

Bug: 340341450
Bug: 339737008
Test: Manual
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile

Change-Id: Ib153205db36cdd8b5fba4734b8b68930857659ff
2024-06-13 15:56:25 -07:00
Jagrut Desai b09b1a73a2 Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon" into main 2024-06-13 18:38:05 +00:00
Jagrut Desai 1c794082a7 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: I69d64ac8a0a496c947acf7fdce142a37005aeedc
2024-06-13 09:30:55 -07:00