Commit Graph

704 Commits

Author SHA1 Message Date
Alex Chau 9c85596111 Support both grid and large tile with gridOnlyOverivew
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid

TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size

TaskView
- Removed no longer used nonGridPivotTranslationX

RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize

Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
2025-01-13 13:31:29 +00:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
Brandon Dayauon df14fffa54 Add elevation to workFAB to create a shadow
Unable to use md.sys.elevation.level3 but codesearched and
looked it up that this is equivalent to 6dp.

bug: 375597648
Test:
before: https://drive.google.com/file/d/1fp2l5p4wW2Gf3duC2qQ_brQ-xY0bTnOF/view?usp=sharing
after: https://drive.google.com/file/d/19xSAnWJURuwrjhMiywfjNT2vD0G2GoFP/view?usp=sharing
Flag: NONE adding elevation
Change-Id: I484609b4dc817b6d76701f60da51c3ec89bc8755
2024-11-12 15:33:10 -08:00
Matthew Mourgos ba81c0f345 Merge "Add focus ring to widgets header" into main 2024-11-08 21:44:05 +00:00
Matthew Mourgos 7820eab80c Add focus ring to widgets header
Change the widgets header drawable to be a selector with the
state_focused property in addition to the state_expanded property. The
focused items are drawn with a focus ring with no ripple, while the
unfocused items have a ripple.

Bug: 365120324
Test: focus traversal through left widget picker pane
Flag: EXEMPT bug fix
Change-Id: I710cb9e2d727a061e0c19df15526e8c832f6366b
2024-11-07 12:56:16 -08:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Brandon Dayauon a7123472ce Remove layoutTransitions for current FAB and use custom animation.
Have background contain left and right padding of 16dp.
That way upon collapse, its easier to animate so that every other view's space but the icon is removed.
Spec when expanded/collapsed: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2839-365095&node-type=text&m=dev

bug: 361589193
Test: manually - video:https://drive.google.com/file/d/1K7HCpayZBa_oo9p3XV10QQX4miTy_d3q/view?usp=sharing
withRTL: https://drive.google.com/file/d/1NfUEyEvzjfQamujv4EqLNBqB47mPNG1Y/view?usp=sharing
Flag: NONE just changing expandedFAB to use custom animations from layoutTransition

Change-Id: I7948633850a1010175eb4f0248daff22cf2f2c87
2024-10-29 09:50:13 -07:00
Brian Isganitis 27e05992f6 Update recent indicators to match spec.
Does not implement any animations.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Fix: 356394053
Test: go/testedequals
Change-Id: If8e319b605beedd0e9b14dc37da1b5ffa12f3c9f
2024-10-21 15:04:03 -04:00
Liam, Lee Pong Lam d4488bfd72 Implement focus state on personal/work tab button
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Charlie Anderson 0c54dbd4a5 Slightly lower icon shadow insets to avoid accidental shrinking or padding
Bug: 350758155
Test: locally
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I5d0396c3e4710873ff797a35b97fad7e79a14495
2024-08-27 22:41:42 +00:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Uwais Ashraf 37752f5e19 Merge changes I31d9a51e,I1bc14be7 into main
* changes:
  Prevent requestLayout() when updating drawables that don't change size
  Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Uwais Ashraf f1c14902ca Fix splash icon size to 52dp
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
Shuming Hao f1d0df2867 Remove unused resources for split screen handle
Bug: 338079912
Test: Manually
Flag: EXEMPT cleanup
Change-Id: I09c02de82186f2080ce10ee75ecb75f9d7f8859a
2024-08-19 09:54:25 -07:00
Charlie Anderson 99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Brandon Dayauon 085ee66233 Remove padding on background and icon.
This padding causes the x to look pointy.

bug:342246204
Test:
before padding:https://screenshot.googleplex.com/GU8ZKEcGPH7DaAD
after padding: https://screenshot.googleplex.com/aRGtiKMQ8jyMWsw
Flag: NONE Padding change

Change-Id: I910914b742bfbb5bf0122ebb1b950ce95c43e9ed
2024-07-22 11:26:11 -07:00
Saumya Prakash f3e12f2b31 Merge "Change Pinned taskbar corners to be fixed." into main 2024-06-13 20:17:37 +00:00
Saumya Prakash f9c602d1d9 Change Pinned taskbar corners to be fixed.
Based on new UX guidelines, the corners for the pinned taskbar should be 16 dp.

Fix: 337872323
Test: Put device in 3 button mode and pinned taskbar and observe
sharper, fixed corners. Transient taskbar remains unchanged.
Flag: EXEMPT bugfix

Change-Id: I2130e91dcdc0afb007fde93438f3fa603bc15af8
2024-06-11 22:18:09 +00:00
Shamali P 3dabf391f2 Scale down the widget previews on similar scale as the spring load scale
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.

Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.

Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
2024-05-29 22:38:22 +00:00
Pierre Barbier de Reuille 2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Pierre Barbier de Reuille f60dd5471c Update desktop mode to identify minimized tasks
When a task is minimised, it becomes invisible but is still running.
WMShell now signals to the launcher when a task's visibility changes.
The task bar takes the visibility into account to know if a running task
is, in fact, minimised.

Test: atest NexusLauncherTests:DesktopTaskbarRunningAppsControllerTest
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 333872717
Change-Id: Iaff6b1240d354bb3c4de8e4884948acf9bf40112
2024-05-23 20:59:16 +01:00
Brandon Dayauon ae0e957eea Update private space divider thickness and padding per spec.
Thickness (height) is 2dp.
Padding above and below the divider is 32dp.

bug: 340307977
test manually:
before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing
after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing
after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing
Flag: None

Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
2024-05-20 16:24:14 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00
Oli Thompson 3ea1acb8ca Show edu card when managed profile removed
Reset the work edu card bit so the edu card shows if the managed profile is removed

Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG

Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
2024-05-15 14:19:03 +00:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Brandon Dayauon a1b3c39bbd Update private space corners to 28dp
bug: 339876216
Test: manually
Flag: None
Change-Id: I1ce8ac2f128de3a614c74db0db59ce451dc7ed6e
2024-05-10 12:41:22 -07:00
Willie Koomson 1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Willie Koomson 61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Gustav Sennton 52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Treehugger Robot aab3693c61 Merge "Increasing Header height to 72dp." into main 2024-04-25 21:00:44 +00:00
Shamali P d4997cf063 Align the margins between handle, text, and container with main picker.
Also aligns style to match main picker which doesn't set header style.

Requested by Jane / UX.

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I15fb82e807fdaa55bbfaaf73872273d1d6e84f97
2024-04-24 19:15:11 +00:00
Shamali P 9478a40898 Update the app-specific picker to have a container like the main picker
This is to ensure widgets are displayed with same container across the
two pickers.

* http://screencast/cast/NDYxNjMzNDExNjY1MTAwOHwwMTBlYzkwZC0wNg
* http://screencast/cast/NjY1NzAyNzY5NzgwMzI2NHwyYTg3ZWIzNS0wNw
* http://screencast/cast/NTYyMzcwMTc4NDQ5NDA4MHw3Y2JlZDEwZS04Mw

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I42b743b99cf6f47b7bade57de01b130df78ac1e9
2024-04-24 19:14:50 +00:00
Himanshu Gupta 6d40d42976 Increasing Header height to 72dp.
As per UX spec, the header height needs to
be 72 dp, with the settings gear, unlock button
in middle occupying 48dp, leaving 12dp padding
above and below the latter in header.

Before: https://photos.app.goo.gl/j4vtTQXWy93DRwGA6
After: https://photos.app.goo.gl/7SxLdCQh7KJzYYLx5

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I7c8115bf3c9b5832a2abcc4a710a2ccf78784c2b
2024-04-24 14:58:59 +01:00
Himanshu Gupta faafb3a19a Fix horizontal spacing in PS Header
1. Removes padding between settings cog and lock button,
as the insets already provide the required padding.
2. Reduces the lock button margin from left to accomodate
the inbuilt inset in the button.

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I077097c7beb2cc8fe14f4367c66ca4e1ad4270d0
2024-04-23 15:28:01 +01:00
Shamali Patwa a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00
Brandon Dayauon baf5f6ec3d Polish workFAB with updated spec.
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
2024-04-18 14:40:42 -07:00
Willie Koomson dcc2d82d4e Scroll to show WidgetCell when it is tapped.
Scroll to show WidgetCell when it is tapped in a widget sheet.
Otherwise, the add button may show/hide without the user seeing
it if the bottom is clipped.

Bug: 329861721
Test: manual- tap WidgetCell when top or bottom is scrolled out of view
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD

Change-Id: Ie21730c193e845cb1c1fa447b7c0a7e719984a8f
2024-04-15 22:32:48 +00:00
Saumya Prakash 5bb103246b Merge "Adjust where the back button is rendered for new SUW requirements." into main 2024-04-11 19:05:52 +00:00
Saumya Prakash da26e19dd8 Adjust where the back button is rendered for new SUW requirements.
Large screen devices in landscape mode and devices that have mostly a
square aspect ratio are undergoing a redesign in Setup wizard that makes
most screens two-pane. As part of this redesign, the back button is
aligned in this change. This change doesn't use a flag because the Setup
Wizard change is not flagged.

Fixes: 323778778
Fixes: 328017929
Test: Run Setup Wizard and see if the back button aligns with the Skip
button in two pane screens.
Flag: N/A

Change-Id: I22680f40c0ddf7cd03ab1da69406eb14184b0174
2024-04-11 16:53:41 +00:00
Vinit Nayak cdaabc6199 Add placeholder divider view when starting split tasks
* This prevents launcher underneath from peaking through
while the split apps are loading

Bug: 299640096
Test: Launched from recents, home and all apps
Doesn't seem to affect small screen since recents scrolls
away and the scrim is only left

Change-Id: I32e394a0bc361489473ee657161c8f3bcbf1e422
2024-04-11 05:09:49 +00:00
Zak Cohen ea3fe15fa8 Merge "Widget Picker - Always center add widget button text vertically" into main 2024-04-04 22:19:21 +00:00
Hyunyoung Song d0eb878d90 Merge "Add 16dp between nav bar and container by setting extra padding to the recyclerView." into main 2024-04-04 18:33:52 +00:00
Zak Cohen d00650bec3 Widget Picker - Always center add widget button text vertically
https://screenshot.googleplex.com/6aLoQSeADh2Ds6V

Bug: 331493703
Test: screenshot tests
Flag: NA layout bug fix
Change-Id: I6399474c42d3cd8ee172bbbbc0789044aac8cbe0
2024-04-04 10:01:18 -07:00